workable 2.0.0rc1 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d886522592c7473bc8fb058f56ea68a8b2d79585
-  data.tar.gz: c019b51b0a908a38ac418fd2ea8003f98c5e9ca5
+  metadata.gz: 1918a3c5a23e3c42973eed949f0b0cc3ba83c613
+  data.tar.gz: 307220a59d69533df3446a11c216f72a8748be8a
 SHA512:
-  metadata.gz: 43d116e2475036166516674d0efff67bb5f8e13bd3f05bb0c63373ae91398df068d6190ac99f19f9bc662cd0d86755c7d3fbc752cafff4e177adbe9d888c1e4f
-  data.tar.gz: d9007195f31b8075e86a63a07bd3836a75ae2d6d1cc06e0ceccc9661212630f49e7a0f7e3c1d444f027f1824e7567afb7efada341279759fc405d7d77cb37de8
+  metadata.gz: 2fd937d0071f53b9c2df9735cd376d774abe397d2565ee0a12e13cb89c2b0fbeb77e7d2f802e83be0aa69d25bcc775ca964df002982f697b2e538ed99f8288f6
+  data.tar.gz: 80671b951b7f0a01bb0c00fd5bff54fa2e209358c4dbeb2b6ea06ea0946829ba63cdebc3319d56a1bf2daa2016133befdfc53b1d58d6caaae936e5dd0dad12e7

data/.travis.yml

@@ -3,12 +3,11 @@ sudo: false
 cache: bundler
 
 rvm:
-  - 1.9.3
-  - 2.0.0
   - 2.1
   - 2.2
-  - jruby
+  - jruby-head
   - rbx-2
+  - ruby-head
 
 notifications:
   email: false

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 2.0.0
+
+Date: 2015-11-14
+
+**Breaking change - Ruby >= 2.1 required**
+
 ## 2.0.0rc1
 
 Date: 2015-11-02

data/Gemfile

@@ -1,6 +1,2 @@
 source 'https://rubygems.org'
-
-# ruby=ruby-2.2.2
-
-# Specify your gem's dependencies in workable-client.gemspec
 gemspec

data/README.md

@@ -6,7 +6,7 @@
 [![Gem Version](https://badge.fury.io/rb/workable.svg)](http://badge.fury.io/rb/workable)
 [![Dependency Status](https://gemnasium.com/emq/workable.svg)](https://gemnasium.com/emq/workable)
 
-Dead-simple Ruby API client for [workable.com][1]. No extra runtime dependencies. Ruby >= 1.9.3.
+Dead-simple Ruby API client for [workable.com][1]. No extra runtime dependencies.
 
 Uses v3 API provided by workable.
 

data/lib/workable/client.rb

@@ -133,7 +133,7 @@ module Workable
 
     # build the url to api
     def api_url
-      'https://www.workable.com/spi/v%s/accounts/%s' % [Workable::API_VERSION, subdomain]
+      @_api_url ||= 'https://www.workable.com/spi/v%s/accounts/%s' % [Workable::API_VERSION, subdomain]
     end
 
     # do the get request to api
@@ -157,7 +157,9 @@ module Workable
       http.use_ssl = true
 
       request = type.new(uri.request_uri, headers)
+
       yield request if block_given?
+
       response = http.request(request)
 
       parse!(response)
@@ -166,9 +168,9 @@ module Workable
     # parse the api response
     def parse!(response)
       case response.code.to_i
-      when 204, 205  # handled no response
+      when 204, 205
         nil
-      when 200...300 # handled with response
+      when 200...300
         JSON.parse(response.body)
       when 401
         fail Errors::NotAuthorized, JSON.parse(response.body)['error']
@@ -217,11 +219,11 @@ module Workable
       response = get_request(url, params)
 
       Collection.new(
-        @transform_to.apply(transform_mapping, response[root_key]),
-        method(__callee__),
-        transform_mapping,
-        root_key,
-        response['paging'])
+        data: @transform_to.apply(transform_mapping, response[root_key]),
+        next_page_method: method(__callee__),
+        transform_mapping: transform_mapping,
+        root_key: root_key,
+        paging: response['paging'])
     end
 
     def configuration_error(message)

data/lib/workable/collection.rb

@@ -5,14 +5,14 @@ module Workable
 
     attr_reader :data
 
-    def initialize(data, next_page_method, transform_mapping, root_key, paging = nil)
+    def initialize(data:, next_page_method:, transform_mapping:, root_key:, paging: nil)
       @data = data
 
       if paging
-        @next_page = paging['next']
-        @next_page_method = next_page_method
+        @next_page         = paging['next']
+        @next_page_method  = next_page_method
         @transform_mapping = transform_mapping
-        @root_key = root_key
+        @root_key          = root_key
       end
     end
 

data/lib/workable/errors.rb

@@ -1,11 +1,11 @@
 module Workable
   module Errors
-    class WorkableError < StandardError; end
+    class WorkableError        < StandardError; end
     class InvalidConfiguration < WorkableError; end
-    class NotAuthorized < WorkableError; end
-    class InvalidResponse < WorkableError; end
-    class NotFound < WorkableError; end
-    class AlreadyExists < WorkableError; end
-    class RequestToLong < WorkableError; end
+    class NotAuthorized        < WorkableError; end
+    class InvalidResponse      < WorkableError; end
+    class NotFound             < WorkableError; end
+    class AlreadyExists        < WorkableError; end
+    class RequestToLong        < WorkableError; end
   end
 end

data/lib/workable/version.rb

@@ -1,3 +1,3 @@
 module Workable
-  VERSION = '2.0.0rc1'
+  VERSION = '2.0.0'
 end

data/spec/lib/workable/collection_spec.rb

@@ -2,7 +2,12 @@ require 'spec_helper'
 
 describe Workable::Collection do
   describe 'delegation' do
-    let(:collection){ described_class.new([1, 2, 3], double, :job, 'jobs') }
+    let(:collection){ described_class.new(
+      data: [1, 2, 3],
+      next_page_method: double,
+      transform_mapping: :job,
+      root_key: 'jobs')
+    }
 
     it 'delegates size to `data`' do
       expect(collection.size).to eq(3)
@@ -27,7 +32,13 @@ describe Workable::Collection do
 
   describe '#fetch_next_page' do
     let(:next_method){ double }
-    let(:collection){ described_class.new([], next_method, :job, 'jobs', paging) }
+    let(:collection){ described_class.new(
+      data: [],
+      next_page_method: next_method,
+      transform_mapping: :job,
+      root_key: 'jobs',
+      paging: paging)
+    }
 
     context 'when next page is available' do
       let(:paging){ { 'next' => 'http://example.com?limit=2&since_id=3' } }

data/workable.gemspec

@@ -17,12 +17,12 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '>= 1.9.3'
+  spec.required_ruby_version = '>= 2.1.0'
 
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.1.0'
   spec.add_development_dependency 'webmock', '~> 1.20.4'
-  spec.add_development_dependency 'coveralls', '~> 0.7.2'
+  spec.add_development_dependency 'coveralls', '~> 0.8.9'
   spec.add_development_dependency 'guard', '~> 2.12'
   spec.add_development_dependency 'guard-rspec', '~> 4.5'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: workable
 version: !ruby/object:Gem::Version
-  version: 2.0.0rc1
+  version: 2.0.0
 platform: ruby
 authors:
 - Rafał Wojsznis
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-02 00:00:00.000000000 Z
+date: 2015-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -59,14 +59,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.2
+        version: 0.8.9
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.2
+        version: 0.8.9
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
@@ -147,12 +147,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: 2.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.4.6