wor-push-notifications-aws 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3b8ea9f5f5acde332401fc297c566f3f5daec527
-  data.tar.gz: 7ac5140ce68d400bea02c177db0b93ca61086928
+  metadata.gz: 2579fa5d87164c198bdd3cb86e90d814ad261ff3
+  data.tar.gz: 432f4ce9d4b23d10837dd296035a6a8ce7e01de3
 SHA512:
-  metadata.gz: 1138461202f9f5c86bd61bd1ce8a71fbb284f2afee1f6f3a0324ebacd0d3fdf4b3101b8d0d2d039e07869894d844232ce75dcfd8e45dcfbe8e8d233a66d73871
-  data.tar.gz: 692de303da017b9df4fab6fc4df5b9db35113282c8f99c04fe0ea9b5f9eba65daf42360996f34d11fa143918899123214c12d29c956f0820d6383a6587b798cd
+  metadata.gz: 9d5ced70039d2f3bd7e25a4fd871e35eb80dadb47bd46bf29793ddcb4289618568531fb8f5a81bd98b559f7ada580c7b19cb01faaf1d1136467a64eea2cf0234
+  data.tar.gz: de0b2b76ad7aac52e7e268fc029035cf66a22c685ad86dc636dcd1acccbd79280754e4796c0d91a619922560bca0ac5048ca8cccf1cb2b149f6dfe21278e6a3e

data/.codeclimate.yml

@@ -2,3 +2,8 @@ engines:
   rubocop:
     enabled: true
     channel: rubocop-0-48
+
+ratings:
+   paths:
+   - "lib/**/*"
+   - "spec/**/*"

data/lib/wor/push/notifications/aws.rb

@@ -86,7 +86,7 @@ module Wor
         end
 
         def self.add_token(user, device_token, device_type)
-          PushNotifications.add_token(user, device_token, device_type)
+          PushNotifications.add_token(user, device_token, device_type.to_sym)
         end
 
         def self.delete_token(user, device_token)

data/lib/wor/push/notifications/aws/exceptions.rb

@@ -0,0 +1,11 @@
+module Wor
+  module Push
+    module Notifications
+      module Aws
+        module Exceptions
+          class ModelWithoutDeviceTokensAttribute < StandardError; end
+        end
+      end
+    end
+  end
+end

data/lib/wor/push/notifications/aws/push_notifications.rb

@@ -1,7 +1,7 @@
 require 'wor/push/notifications/aws/android_push_json_builder'
 require 'wor/push/notifications/aws/ios_push_json_builder'
-require 'wor/push/notifications/aws/services/sns_client'
 require 'wor/push/notifications/aws/validators/push_notifications_validator'
+require 'aws-sdk-rails'
 
 module Wor
   module Push
@@ -62,7 +62,9 @@ module Wor
             end
 
             def sns
-              @sns_client ||= SnsClient.new(Wor::Push::Notifications::Aws.aws_region)
+              @sns_client ||= ::Aws::SNS::Client.new(
+                region: Wor::Push::Notifications::Aws.aws_region
+              )
             end
 
             def app_arn(device_type)

data/lib/wor/push/notifications/aws/validators/push_notifications_validator.rb

@@ -10,27 +10,36 @@ module Wor
           end
 
           def validate_add_token
+            validate_model_existance
             validate_existence_of_attributes_in_model
             validate_parameters
           end
 
           def validate_delete_token
+            validate_model_existance
             validate_existence_of_attributes_in_model
           end
 
           def validate_send_message(message_content)
+            validate_model_existance
             validate_existence_of_attributes_in_model
             validate_message_content(message_content)
           end
 
           private
 
+          def validate_model_existance
+            raise ArgumentError, message_for_nil_model if @model.nil?
+          end
+
           def validate_existence_of_attributes_in_model
-            raise message_for_missing_attribute unless @model.has_attribute?(:device_tokens)
+            return if @model.has_attribute?(:device_tokens)
+            raise Wor::Push::Notifications::Aws::Exceptions::ModelWithoutDeviceTokensAttribute,
+                  message_for_missing_attribute_in_model
           end
 
           def validate_message_content(message_content)
-            raise message_for_invalid_message_content if message_content[:message].blank?
+            raise ArgumentError, message_content_error_message if message_content[:message].blank?
           end
 
           def validate_parameters
@@ -38,20 +47,24 @@ module Wor
             raise ArgumentError, message_for_nil_device_token if @device_token.blank?
           end
 
-          def message_for_missing_attribute
-            'Missing attribute device_tokens for model. Have you run the gem migration?'
-          end
-
           def message_for_invalid_device_type
             "Invalid device_type. It has to be one of the types configured \
              #{Wor::Push::Notifications::Aws.device_types}."
           end
 
+          def message_for_missing_attribute_in_model
+            'Missing attribute device_tokens for model. Have you run the gem migration?'
+          end
+
           def message_for_nil_device_token
             'device_token cannot be nil.'
           end
 
-          def message_for_invalid_message_content
+          def message_for_nil_model
+            'your entity instance cannot be nil.'
+          end
+
+          def message_content_error_message
             "the message_content must have a 'message' field"
           end
 

data/lib/wor/push/notifications/aws/version.rb

@@ -2,7 +2,7 @@ module Wor
   module Push
     module Notifications
       module Aws
-        VERSION = '0.1.0'.freeze
+        VERSION = '0.1.1'.freeze
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: wor-push-notifications-aws
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Leandro Masello
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-26 00:00:00.000000000 Z
+date: 2017-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -67,9 +67,9 @@ files:
 - lib/generators/wor/push/notifications/aws/install_generator.rb
 - lib/wor/push/notifications/aws.rb
 - lib/wor/push/notifications/aws/android_push_json_builder.rb
+- lib/wor/push/notifications/aws/exceptions.rb
 - lib/wor/push/notifications/aws/ios_push_json_builder.rb
 - lib/wor/push/notifications/aws/push_notifications.rb
-- lib/wor/push/notifications/aws/services/sns_client.rb
 - lib/wor/push/notifications/aws/validators/push_notifications_validator.rb
 - lib/wor/push/notifications/aws/version.rb
 - wor-push-notifications-aws.gemspec

data/lib/wor/push/notifications/aws/services/sns_client.rb

@@ -1,15 +0,0 @@
-require 'aws-sdk-rails'
-
-module Wor
-  module Push
-    module Notifications
-      module Aws
-        class SnsClient
-          def initialize(region)
-            Aws::SNS::Client.new(region: region)
-          end
-        end
-      end
-    end
-  end
-end