woothee 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 27a8d0b1a8d5a09b9528c9cf9d7257a117c7c2c1
-  data.tar.gz: 5c277d4b25b6e834f06feae8feccf67183ef4c50
+  metadata.gz: c014eaeb7dddd4ad586f76066fdadb6c0585cdef
+  data.tar.gz: 61bb29e14c857fe716a04144ce0bb53b061b48d7
 SHA512:
-  metadata.gz: d72ebc71e88a85f2a73bcb813bed6b62a38c30ca7eedff4442ca5251b350481dd7fadc3f82e962aa6a608852c089ea14db22a9fabeda9cdb1d00ee4034ca54f1
-  data.tar.gz: a035060f6c2b6d2660a906732f317fd8d7c5fdda9c54cd8c60e6c99f0a3ab123b0fc6fcb606d7b2567aad3e3674ba90d489f85d1957349b2679e8ed19b867ba7
+  metadata.gz: ef8c6a020c0712bbb2b3560a01458cc40ddd0b2d2ea2aacc9f5073e4e95986f3a7efc9215d06df09cd78397004635802b7a7612c7457ff4b8baae5b0b1db0d12
+  data.tar.gz: 3cc4730be55cde4d26c537bf75c81d9751bfb6b82e8de1d5b3645212bacd4adac7feae84e5530d14db6e843107782fd3056426ddb89658661c817691b7526593

data/lib/woothee/version.rb

@@ -1,3 +1,3 @@
 module Woothee
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

data/lib/woothee.rb

@@ -16,7 +16,7 @@ module Woothee
  end
 
   def self.is_crawler(useragent)
-    useragent.length > 0 and useragent != '-' and try_crawler(useragent, {})
+    !!useragent && useragent.length > 0 and useragent != '-' and try_crawler(useragent, {})
   end
 
   def self.exec_parse(useragent)

data/spec/02_run_testsets_spec.rb

@@ -26,12 +26,19 @@ describe Woothee do
   TARGETS.each do |filename,groupname|
     YAML.load_file(TESTSET_DIR + filename).each do |e|
       r = Woothee.parse(e['target'])
-      [:name, :category, :os, :version, :vendor, :os_version].each do |attribute|
-        it groupname + ("test(%s): %s" % [attribute, e['target']]) do
-          if [:name, :category].include?(attribute) or ([:os, :version, :vendor, :os_version].include?(attribute) and e.has_key?(attribute.to_s))
-            expect(r[attribute].to_s).to eql(e[attribute.to_s])
+      context groupname do
+        [:name, :category, :os, :version, :vendor, :os_version].each do |attribute|
+          it  ("test(%s): %s" % [attribute, e['target']]) do
+            if [:name, :category].include?(attribute) or ([:os, :version, :vendor, :os_version].include?(attribute) and e.has_key?(attribute.to_s))
+              expect(r[attribute].to_s).to eql(e[attribute.to_s])
+            end
           end
         end
+
+        it "test(is_crawler): #{e['target']}" do
+          is_major_crawler = e['category'] == 'crawler' && e['name'] != 'misc crawler'
+          expect(Woothee.is_crawler(e['target'])).to eq(is_major_crawler)
+        end
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: woothee
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - TAGOMORI Satoshi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-01 00:00:00.000000000 Z
+date: 2015-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake