wkhtmltopdf_runner 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 49ed7f230cca92d8a57989e9b8a98a1174c1bf10b74e6b0c368bdae58c688a28
-  data.tar.gz: d7e0488870d44bd5b764060c9aa136be90af123c363b94b5fa1ea2b4ee1bd5df
+  metadata.gz: 564d5b04ff0472a8426dbd6f038ecb624e5e47a520f07200e404177931998066
+  data.tar.gz: ebc0c7fe8a93bbaa1cd7ba6f68a82c404b25d0b93a6e2cb58bfdd5dfbfb60a81
 SHA512:
-  metadata.gz: a51dae3be442ffd8076379513b91062793b784b729851d9ce296af2a12a80e7637632f55eea3f719fae3f6c7a1b990f6f0d9dd6fd2d914c9efa9a72dc19302af
-  data.tar.gz: 7302a141785e7634ee599c981ac58626cc719e52a54f1614f9ceeba7221037113623917b4d739c6fb8dc055b3a0728fb55f0674007dee58b870f6c49247462d2
+  metadata.gz: c0d7b2e1f5da37b02406e2e479955703c9434bd3e510b9c2296b215a9b31e5d67e68149a21e05525e94d509c60699fc94fe255417b52f9ebc9704c9634d7bd3b
+  data.tar.gz: 69e40aa96ab5f2c1fd2073b1496ab7214b56c12acd44c16fe07149b4dff6c163092b8b1212177e0bec9f6957c36cb3dd2e59ed3ea5bb29dd437aafbb6bb62144

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    wkhtmltopdf_runner (0.3.0)
+    wkhtmltopdf_runner (0.4.0)
 
 GEM
   remote: https://rubygems.org/

data/lib/wkhtmltopdf_runner/cmd.rb

@@ -17,13 +17,13 @@ module WkhtmltopdfRunner
       validate!
       debug_command!
 
-      err = Open3.popen3(*command) do |_stdin, _stdout, stderr|
-        stderr.read
+      err, exit_status = Open3.popen3(*command) do |_stdin, _stdout, stderr, wait_thr|
+        [stderr.read, wait_thr.value]
       end
 
-      unless err&.strip&.empty?
+      unless exit_status.success?
         raise WkhtmltopdfRunner::Error,
-          "Error generating PDF. Command Error:\n#{err}"
+          "Failed to generate PDF. Status: #{exit_status.exitstatus} Error:\n#{err&.strip}"
       end
 
       true

data/lib/wkhtmltopdf_runner/runner.rb

@@ -12,7 +12,10 @@ module WkhtmltopdfRunner
         run(url, pdf_file, options)
         pdf_file.rewind
 
-        return yield(pdf_file) if block_given?
+        if block_given?
+          yield(pdf_file)
+          return true
+        end
 
         pdf_file.read
       end
@@ -24,9 +27,9 @@ module WkhtmltopdfRunner
 
     def pdf_from_string(string, options = {}, &block)
       Tempfile.open(['file-', '.html']) do |html_file|
-        html_file.binmode
         html_file.write(string)
         html_file.rewind
+
         pdf_from_file(html_file, options, &block)
       end
     end

data/lib/wkhtmltopdf_runner/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module WkhtmltopdfRunner
-  VERSION = '0.3.0'
+  VERSION = '0.4.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: wkhtmltopdf_runner
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Justas Palumickas