wkhtmltopdf_runner 0.3.0 → 0.4.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 49ed7f230cca92d8a57989e9b8a98a1174c1bf10b74e6b0c368bdae58c688a28
4
- data.tar.gz: d7e0488870d44bd5b764060c9aa136be90af123c363b94b5fa1ea2b4ee1bd5df
3
+ metadata.gz: 564d5b04ff0472a8426dbd6f038ecb624e5e47a520f07200e404177931998066
4
+ data.tar.gz: ebc0c7fe8a93bbaa1cd7ba6f68a82c404b25d0b93a6e2cb58bfdd5dfbfb60a81
5
5
  SHA512:
6
- metadata.gz: a51dae3be442ffd8076379513b91062793b784b729851d9ce296af2a12a80e7637632f55eea3f719fae3f6c7a1b990f6f0d9dd6fd2d914c9efa9a72dc19302af
7
- data.tar.gz: 7302a141785e7634ee599c981ac58626cc719e52a54f1614f9ceeba7221037113623917b4d739c6fb8dc055b3a0728fb55f0674007dee58b870f6c49247462d2
6
+ metadata.gz: c0d7b2e1f5da37b02406e2e479955703c9434bd3e510b9c2296b215a9b31e5d67e68149a21e05525e94d509c60699fc94fe255417b52f9ebc9704c9634d7bd3b
7
+ data.tar.gz: 69e40aa96ab5f2c1fd2073b1496ab7214b56c12acd44c16fe07149b4dff6c163092b8b1212177e0bec9f6957c36cb3dd2e59ed3ea5bb29dd437aafbb6bb62144
data/Gemfile.lock CHANGED
@@ -1,7 +1,7 @@
1
1
  PATH
2
2
  remote: .
3
3
  specs:
4
- wkhtmltopdf_runner (0.3.0)
4
+ wkhtmltopdf_runner (0.4.0)
5
5
 
6
6
  GEM
7
7
  remote: https://rubygems.org/
@@ -17,13 +17,13 @@ module WkhtmltopdfRunner
17
17
  validate!
18
18
  debug_command!
19
19
 
20
- err = Open3.popen3(*command) do |_stdin, _stdout, stderr|
21
- stderr.read
20
+ err, exit_status = Open3.popen3(*command) do |_stdin, _stdout, stderr, wait_thr|
21
+ [stderr.read, wait_thr.value]
22
22
  end
23
23
 
24
- unless err&.strip&.empty?
24
+ unless exit_status.success?
25
25
  raise WkhtmltopdfRunner::Error,
26
- "Error generating PDF. Command Error:\n#{err}"
26
+ "Failed to generate PDF. Status: #{exit_status.exitstatus} Error:\n#{err&.strip}"
27
27
  end
28
28
 
29
29
  true
@@ -12,7 +12,10 @@ module WkhtmltopdfRunner
12
12
  run(url, pdf_file, options)
13
13
  pdf_file.rewind
14
14
 
15
- return yield(pdf_file) if block_given?
15
+ if block_given?
16
+ yield(pdf_file)
17
+ return true
18
+ end
16
19
 
17
20
  pdf_file.read
18
21
  end
@@ -24,9 +27,9 @@ module WkhtmltopdfRunner
24
27
 
25
28
  def pdf_from_string(string, options = {}, &block)
26
29
  Tempfile.open(['file-', '.html']) do |html_file|
27
- html_file.binmode
28
30
  html_file.write(string)
29
31
  html_file.rewind
32
+
30
33
  pdf_from_file(html_file, options, &block)
31
34
  end
32
35
  end
@@ -1,5 +1,5 @@
1
1
  # frozen_string_literal: true
2
2
 
3
3
  module WkhtmltopdfRunner
4
- VERSION = '0.3.0'
4
+ VERSION = '0.4.0'
5
5
  end
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: wkhtmltopdf_runner
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.3.0
4
+ version: 0.4.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Justas Palumickas