wkhtmltopdf_runner 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 25395e8c97bcf92fbfb3c1900aeebc29fde134bd284ea20ac8d0a6001392a7b3
-  data.tar.gz: b2854859d2dcb315f891ab90d9e890d2233c44ac55c2eb36450b334dd0df5508
+  metadata.gz: 1895a36bbd4b903055cf6d21f42106e5bfa00c1a8d875631e6b9979d0b88d356
+  data.tar.gz: 61d6d422e25f4aac27115720fb6a62960dcafe932dc6c013bc77f6bf677b93d4
 SHA512:
-  metadata.gz: b0bc3de109daf0557bb5d52fb075d024bfcca427b29f4f85077b82dab1b55d3cc710c7eb118bb9a7189be192277d9ea826a0f5fb637d6e20d29b85427416647b
-  data.tar.gz: c62ce9a592e75d480fc466a25a777582b728835e91c5a32478539136ef15312c85609d30919416abeb4245dfb9294653764e6cead326e73abfd27e62caf8e600
+  metadata.gz: c066432c2090eebff947c79dcc658532ccc111a1ee496dc8934b7e61c964ed54b9e68327fbd1d1ed0dd1a5ecb1942b4f3bb5d1d3045ded705cad6787e84679d3
+  data.tar.gz: 8279ec00819efdae52cab34c3894d5fd0209b73fc0b440a9f296821e8753e16e68f5908e58ffa7403916801c3b40ce1727df34103fa2c0bec9fbb6dd7f3274bc

data/.rubocop.yml

@@ -1,3 +1,5 @@
+require: rubocop-rspec
+
 AllCops:
   TargetRubyVersion: 2.3
   Exclude:

data/Gemfile

@@ -5,6 +5,11 @@ source 'https://rubygems.org'
 group :development do
   gem 'pry'
   gem 'rubocop', require: false
+  gem 'rubocop-rspec', require: false
+end
+
+group :development, :test do
+  gem 'simplecov'
 end
 
 # Specify your gem's dependencies in wkhtmltopdf_runner.gemspec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    wkhtmltopdf_runner (0.1.0)
+    wkhtmltopdf_runner (0.2.0)
 
 GEM
   remote: https://rubygems.org/
@@ -9,17 +9,20 @@ GEM
     ast (2.4.0)
     coderay (1.1.2)
     diff-lcs (1.3)
+    docile (1.3.1)
     jaro_winkler (1.5.2)
+    json (2.2.0)
     method_source (0.9.2)
-    parallel (1.13.0)
+    parallel (1.14.0)
     parser (2.6.0.0)
       ast (~> 2.4.0)
     powerpack (0.1.2)
     pry (0.12.2)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
+    psych (3.1.0)
     rainbow (3.0.0)
-    rake (10.5.0)
+    rake (12.3.2)
     rspec (3.8.0)
       rspec-core (~> 3.8.0)
       rspec-expectations (~> 3.8.0)
@@ -33,15 +36,23 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.8.0)
     rspec-support (3.8.0)
-    rubocop (0.64.0)
+    rubocop (0.65.0)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
       parser (>= 2.5, != 2.5.1.1)
       powerpack (~> 0.1)
+      psych (>= 3.1.0)
       rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (~> 1.4.0)
+    rubocop-rspec (1.32.0)
+      rubocop (>= 0.60.0)
     ruby-progressbar (1.10.0)
+    simplecov (0.16.1)
+      docile (~> 1.1)
+      json (>= 1.8, < 3)
+      simplecov-html (~> 0.10.0)
+    simplecov-html (0.10.2)
     unicode-display_width (1.4.1)
     wkhtmltopdf-binary-edge (0.12.5.0)
 
@@ -51,9 +62,11 @@ PLATFORMS
 DEPENDENCIES
   bundler (~> 2.0)
   pry
-  rake (~> 10.0)
-  rspec (~> 3.0)
+  rake (~> 12.3)
+  rspec (~> 3.8)
   rubocop
+  rubocop-rspec
+  simplecov
   wkhtmltopdf-binary-edge (~> 0.12.5)
   wkhtmltopdf_runner!
 

data/lib/wkhtmltopdf_runner/cmd.rb

@@ -10,7 +10,7 @@ module WkhtmltopdfRunner
       @url = url
       @file = file
       @config = config
-      @options = options.reverse_merge(config.options)
+      @options = config.options.merge(options)
     end
 
     def run

data/lib/wkhtmltopdf_runner/configuration.rb

@@ -4,19 +4,25 @@ require 'logger'
 
 module WkhtmltopdfRunner
   class Configuration
-    attr_writer :logger, :options
-    attr_accessor :debug, :binary_path
+    attr_writer :logger, :options, :debug
+    attr_accessor :binary_path
 
     def logger
-      @logger ||= begin
-        return Rails.logger if defined?(Rails)
+      return @logger if defined?(@logger)
+      return Rails.logger if defined?(Rails)
 
-        Logger.new(STDOUT)
-      end
+      Logger.new(STDOUT)
     end
 
     def options
       @options || {}
     end
+
+    def debug
+      return @debug if defined?(@debug)
+      return true if defined?(Rails) && Rails.env.development?
+
+      false
+    end
   end
 end

data/lib/wkhtmltopdf_runner/path.rb

@@ -2,6 +2,10 @@
 
 module WkhtmltopdfRunner
   class Path
+    def self.get(path = nil)
+      new(path).call
+    end
+
     EXE_NAME = 'wkhtmltopdf'
 
     def initialize(path = nil)
@@ -9,7 +13,9 @@ module WkhtmltopdfRunner
     end
 
     def call
-      @path || find_wkhtmltopdf_binary_path
+      return @path if WkhtmltopdfRunner::Utils.present?(@path)
+
+      find_wkhtmltopdf_binary_path
     end
 
     private
@@ -25,21 +31,25 @@ module WkhtmltopdfRunner
         `which #{EXE_NAME}`.chomp
       end
 
-      WkhtmltopdfRunner::Utils.present?(detected_path) && detected_path
+      WkhtmltopdfRunner::Utils.presence(detected_path)
     rescue StandardError
       nil
     end
 
     def path_from_env
+      env_paths
+        .map { |l| File.expand_path(File.join(l, EXE_NAME)) }
+        .detect { |location| File.exist?(location) }
+    end
+
+    def env_paths
       possible_locations = [
-        ENV['PATH'].split(':'),
+        ENV['PATH'].split(File::PATH_SEPARATOR),
         %w[/usr/bin /usr/local/bin]
       ]
 
       possible_locations << %w[~/bin] if ENV.key?('HOME')
-      possible_locations
-        .flatten.map { |l| File.expand_path(File.join(l, EXE_NAME)) }
-        .detect { |location| File.exist?(location) }
+      possible_locations.flatten.uniq
     end
   end
 end

data/lib/wkhtmltopdf_runner/runner.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'wkhtmltopdf_runner/configuration'
+require 'tempfile'
 
 module WkhtmltopdfRunner
   class Runner

data/lib/wkhtmltopdf_runner/utils.rb

@@ -28,5 +28,9 @@ module WkhtmltopdfRunner
     def self.present?(obj)
       !blank?(obj)
     end
+
+    def self.presence(obj)
+      obj if present?(obj)
+    end
   end
 end

data/lib/wkhtmltopdf_runner/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module WkhtmltopdfRunner
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

data/wkhtmltopdf_runner.gemspec

@@ -36,7 +36,7 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = '>= 2.3.0'
 
   spec.add_development_dependency 'bundler', '~> 2.0'
-  spec.add_development_dependency 'rake', '~> 10.0'
-  spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'rake', '~> 12.3'
+  spec.add_development_dependency 'rspec', '~> 3.8'
   spec.add_development_dependency 'wkhtmltopdf-binary-edge', '~> 0.12.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: wkhtmltopdf_runner
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Justas Palumickas
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-02-19 00:00:00.000000000 Z
+date: 2019-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -30,28 +30,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3.8'
 - !ruby/object:Gem::Dependency
   name: wkhtmltopdf-binary-edge
   requirement: !ruby/object:Gem::Requirement