with_advisory_lock 3.1.0 → 3.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d83c8384aa5b5b063851f1bcef61584c552c6845
-  data.tar.gz: 2ff00f6afba93642d8d2bcb0c6ae639dec2ff913
+  metadata.gz: 21f4b6ac2afa73ae66983bce969dc1786aab95a7
+  data.tar.gz: 8b4874809c6356b53d775764f0f7228658bfa9c4
 SHA512:
-  metadata.gz: 2b1529ea567b8f99008590582827e0b7b4a5c03af8fa779253f68c40aac1c9eaaa0cea4537f1007027c3148422af3ca59579416443443328aa27775560deda22
-  data.tar.gz: 06f6b2a54dc18806663041c0954a5d222ed533023e8e01a5c61a21e078836cc9e4fd00a822b35f825da1e144cdedeaf8ee396e2224ff83db413ae792288ad83a
+  metadata.gz: cd2e76cc799d22fb4b1f67456eb282797337d9580b143d4cb38c26b0f24e45b7bfa8de19c2ab17f5a730bbcd7623654dd1703c43e5deaed9a05d6c3cf0ecebc8
+  data.tar.gz: 9bdbcafdb615da0af5671191f233b2c458ff1bfe1d63cf0bfff26da4d627070a985b9dc242da14c3a3a1ac511fedbbdb394b62a60172f3f4b430c66f5e24108f

data/.travis.install-mysql-5.7.sh

@@ -0,0 +1,11 @@
+#!/usr/bin/env bash
+if [[ "${MYSQL_VERSION}" == "5.7" ]]; then
+  sudo service mysql stop || echo "mysql not stopped"
+  sudo stop mysql-5.6 || echo "mysql-5.6 not stopped"
+  echo mysql-apt-config mysql-apt-config/select-server select mysql-5.7 | sudo debconf-set-selections
+  wget http://dev.mysql.com/get/mysql-apt-config_0.7.3-1_all.deb
+  sudo dpkg --install mysql-apt-config_0.7.3-1_all.deb
+  sudo apt-get update -q
+  sudo apt-get install -q -y --allow-unauthenticated -o Dpkg::Options::=--force-confnew mysql-server
+  sudo mysql_upgrade
+fi

data/.travis.yml

@@ -1,17 +1,22 @@
 language: ruby
 
+dist: trusty
+sudo: required
+
 rvm:
   - 2.4.0
   - 2.3.3
   - 2.2.6
 
 gemfile:
+  - gemfiles/activerecord_5.1.gemfile
   - gemfiles/activerecord_5.0.gemfile
   - gemfiles/activerecord_4.2.gemfile
 
 env:
   - DB=postgresql
   - DB=mysql
+  - DB=mysql MYSQL_VERSION=5.7
   - DB=sqlite
 
 before_install:
@@ -20,6 +25,7 @@ before_install:
 script: WITH_ADVISORY_LOCK_PREFIX=$TRAVIS_JOB_ID bundle exec rake --trace
 
 before_script:
+  - bash .travis.install-mysql-5.7.sh
   - mysql -e 'create database with_advisory_lock_test'
   - psql -c 'create database with_advisory_lock_test' -U postgres
 

data/Appraisals

@@ -5,3 +5,7 @@ end
 appraise "activerecord-5.0" do
   gem "activerecord", "~> 5.0.0"
 end
+
+appraise "activerecord-5.1" do
+  gem "activerecord", "~> 5.1.0"
+end

data/README.md

@@ -5,10 +5,8 @@ Adds advisory locking (mutexes) to ActiveRecord 4.2 and 5.0, with ruby 2.4, 2.3
 or [PostgreSQL](http://www.postgresql.org/docs/9.3/static/functions-admin.html#FUNCTIONS-ADVISORY-LOCKS).
 SQLite resorts to file locking.
 
-[![Build Status](https://api.travis-ci.org/mceachen/with_advisory_lock.png?branch=master)](https://travis-ci.org/mceachen/with_advisory_lock)
-[![Gem Version](https://badge.fury.io/rb/with_advisory_lock.png)](http://rubygems.org/gems/with_advisory_lock)
-[![Code Climate](https://codeclimate.com/github/mceachen/with_advisory_lock.png)](https://codeclimate.com/github/mceachen/with_advisory_lock)
-[![Dependency Status](https://gemnasium.com/mceachen/with_advisory_lock.png)](https://gemnasium.com/mceachen/with_advisory_lock)
+[![Build Status](https://api.travis-ci.org/ClosureTree/with_advisory_lock.svg?branch=master)](http://travis-ci.org/ClosureTree/with_advisory_lock)
+[![Gem Version](https://badge.fury.io/rb/with_advisory_lock.svg)](https://badge.fury.io/rb/with_advisory_lock)
 
 ## What's an "Advisory Lock"?
 
@@ -114,7 +112,7 @@ most commonly used lock.**
 
 ### Table-level locks
 
-Provided through something like the [monogamy](https://github.com/mceachen/monogamy)
+Provided through something like the [monogamy](https://github.com/ClosureTree/monogamy)
 gem, these prevent concurrent access to **any instance of a model**. Their coarseness means they
 aren't going to be commonly applicable, and they can be a source of
 [deadlocks](http://en.wikipedia.org/wiki/Deadlock).
@@ -136,12 +134,12 @@ lock again, and the block given will be yielded to.
 
 ### Is clustered MySQL supported?
 
-[No.](https://github.com/mceachen/with_advisory_lock/issues/16)
+[No.](https://github.com/ClosureTree/with_advisory_lock/issues/16)
 
 ### There are many ```lock-*``` files in my project directory after test runs
 
 This is expected if you aren't using MySQL or Postgresql for your tests.
-See [issue 3](https://github.com/mceachen/with_advisory_lock/issues/3).
+See [issue 3](https://github.com/ClosureTree/with_advisory_lock/issues/3).
 
 SQLite doesn't have advisory locks, so we resort to file locking, which will only work
 if the ```FLOCK_DIR``` is set consistently for all ruby processes.
@@ -160,9 +158,13 @@ end
 
 ## Changelog
 
+### 3.1.1
+
+* [Joel Turkel](https://github.com/jturkel) added `require 'active_support'` (it was required, but relied on downstream gems to pull in active_support before pulling in with_advisory_lock). Thanks!
+
 ### 3.1.0
 
-* [Jason Weathered](https://github.com/jasoncodes) Added new shared and transaction-level lock options ([Pull request 21](https://github.com/mceachen/with_advisory_lock/pull/21)). Thanks!
+* [Jason Weathered](https://github.com/jasoncodes) Added new shared and transaction-level lock options ([Pull request 21](https://github.com/ClosureTree/with_advisory_lock/pull/21)). Thanks!
 * Added ActiveRecord 5.0 to build matrix. Dropped 3.2, 4.0, and 4.1 (which no longer get security updates: http://rubyonrails.org/security/)
 * Replaced ruby 1.9 and 2.0 (both EOL) with ruby 2.2 and 2.3 (see https://www.ruby-lang.org/en/downloads/)
 
@@ -185,7 +187,7 @@ end
 * Lock timeouts of 0 now attempt the lock once, as per suggested by 
   [Jon Leighton](https://github.com/jonleighton) and implemented by 
   [Abdelkader Boudih](https://github.com/seuros). Thanks to both of you!
-* [Pull request 11](https://github.com/mceachen/with_advisory_lock/pull/11) 
+* [Pull request 11](https://github.com/ClosureTree/with_advisory_lock/pull/11) 
   fixed a downstream issue with jruby support! Thanks, [Aaron Todd](https://github.com/ozzyaaron)!
 * Added Travis tests for jruby
 * Dropped support for Rails 3.0, 3.1, and Ruby 1.8.7, as they are no longer
@@ -207,9 +209,9 @@ end
 
 ### 0.0.9
 
-* Merged in Postgis Adapter Support to address [issue 7](https://github.com/mceachen/with_advisory_lock/issues/7)
+* Merged in Postgis Adapter Support to address [issue 7](https://github.com/ClosureTree/with_advisory_lock/issues/7)
   Thanks for the pull request, [Abdelkader Boudih](https://github.com/seuros)!
-* The database switching code had to be duplicated by [Closure Tree](https://github.com/mceachen/closure_tree),
+* The database switching code had to be duplicated by [Closure Tree](https://github.com/ClosureTree/closure_tree),
   so I extracted a new ```WithAdvisoryLock::DatabaseAdapterSupport``` one-trick pony.
 * Builds were failing on Travis, so I introduced a global lock prefix that can be set with the
   ```WITH_ADVISORY_LOCK_PREFIX``` environment variable. I'm not going to advertise this feature yet.
@@ -217,13 +219,13 @@ end
 
 ### 0.0.8
 
-* Addressed [issue 5](https://github.com/mceachen/with_advisory_lock/issues/5) by
+* Addressed [issue 5](https://github.com/ClosureTree/with_advisory_lock/issues/5) by
   using a deterministic hash for Postgresql + MRI >= 1.9.
   Thanks for the pull request, [Joel Turkel](https://github.com/jturkel)!
-* Addressed [issue 2](https://github.com/mceachen/with_advisory_lock/issues/2) by
+* Addressed [issue 2](https://github.com/ClosureTree/with_advisory_lock/issues/2) by
   using a cache-busting query for MySQL and Postgres to deal with AR value caching bug.
   Thanks for the pull request, [Jaime Giraldo](https://github.com/sposmen)!
-* Addressed [issue 4](https://github.com/mceachen/with_advisory_lock/issues/4) by
+* Addressed [issue 4](https://github.com/ClosureTree/with_advisory_lock/issues/4) by
   adding support for ```em-postgresql-adapter```.
   Thanks, [lestercsp](https://github.com/lestercsp)!
 

data/gemfiles/activerecord_5.1.gemfile

@@ -0,0 +1,19 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activerecord", "~> 5.1.0"
+
+platforms :ruby do
+  gem "mysql2", "~> 0.3.10"
+  gem "pg", "< 0.19"
+  gem "sqlite3"
+end
+
+platforms :jruby do
+  gem "activerecord-jdbcmysql-adapter"
+  gem "activerecord-jdbcpostgresql-adapter"
+  gem "activerecord-jdbcsqlite3-adapter"
+end
+
+gemspec path: "../"

data/lib/with_advisory_lock.rb

@@ -1,4 +1,5 @@
 require 'with_advisory_lock/version'
+require 'active_support'
 
 module WithAdvisoryLock
   extend ActiveSupport::Autoload

data/lib/with_advisory_lock/version.rb

@@ -1,3 +1,3 @@
 module WithAdvisoryLock
-  VERSION = Gem::Version.new('3.1.0')
+  VERSION = Gem::Version.new('3.1.1')
 end

data/test/lock_test.rb

@@ -11,7 +11,7 @@ describe 'class methods' do
     it 'returns the name of the last lock acquired' do
       Tag.with_advisory_lock(lock_name) do
         # The lock name may have a prefix if WITH_ADVISORY_LOCK_PREFIX env is set
-        Tag.current_advisory_lock.must_match /#{lock_name}/
+        Tag.current_advisory_lock.must_match(/#{lock_name}/)
       end
     end
   end

data/test/options_test.rb

@@ -7,14 +7,14 @@ describe 'options parsing' do
 
   specify 'defaults (empty hash)' do
     impl = parse_options({})
-    impl.timeout_seconds.must_equal nil
+    impl.timeout_seconds.must_be_nil
     impl.shared.must_equal false
     impl.transaction.must_equal false
   end
 
   specify 'nil sets timeout to nil' do
     impl = parse_options(nil)
-    impl.timeout_seconds.must_equal nil
+    impl.timeout_seconds.must_be_nil
     impl.shared.must_equal false
     impl.transaction.must_equal false
   end
@@ -41,14 +41,14 @@ describe 'options parsing' do
 
   specify 'hash with shared option sets shared to true' do
     impl = parse_options(shared: true)
-    impl.timeout_seconds.must_equal nil
+    impl.timeout_seconds.must_be_nil
     impl.shared.must_equal true
     impl.transaction.must_equal false
   end
 
   specify 'hash with transaction option set transaction to true' do
     impl = parse_options(transaction: true)
-    impl.timeout_seconds.must_equal nil
+    impl.timeout_seconds.must_be_nil
     impl.shared.must_equal false
     impl.transaction.must_equal true
   end

data/test/shared_test.rb

@@ -57,7 +57,7 @@ describe 'shared locks' do
 
     it 'raises an error when attempting to use a shared lock' do
       one = SharedTestWorker.new(true)
-      one.locked?.must_equal nil
+      one.locked?.must_be_nil
       exception = proc {
         one.cleanup!
       }.must_raise ArgumentError

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: with_advisory_lock
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.1.1
 platform: ruby
 authors:
 - Matthew McEachen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-17 00:00:00.000000000 Z
+date: 2017-08-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -130,6 +130,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".travis.install-mysql-5.7.sh"
 - ".travis.yml"
 - Appraisals
 - Gemfile
@@ -138,6 +139,7 @@ files:
 - Rakefile
 - gemfiles/activerecord_4.2.gemfile
 - gemfiles/activerecord_5.0.gemfile
+- gemfiles/activerecord_5.1.gemfile
 - lib/with_advisory_lock.rb
 - lib/with_advisory_lock/base.rb
 - lib/with_advisory_lock/concern.rb
@@ -180,7 +182,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Advisory locking for ActiveRecord