with-version 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a78fa4c49e7ff1cc9d33f1a9344cbe9d7ce95224693b4bf9b4e3d41ea436a40a
-  data.tar.gz: 65d8a5357cef1b1a69aeff518f1ca1d0e35d55920166bc2ae5b6f2484982d283
+  metadata.gz: 8d66a01b9e2d6ababc8eecc53a40726fad9431f4e240476a5b930e7c708890b9
+  data.tar.gz: 3bea1d04c1a8e13297500f5c5f04cd5ffc133002b7108fd6633476e11f5e7a9d
 SHA512:
-  metadata.gz: 6b153188b7ad108b454044f7a8717420788d61e382c8feee963361525d0933316a19793357bfbb3d5d2c99ac5f82d6f6185cb6035cda2f4a09f48dfef7543f94
-  data.tar.gz: 1f42d854e9183a0cec864e5e48e1aa8de205646bce8ef792ceed275b13396e251e8c12c755b4c9e070cc450073892d6a33f7a200a9bf43c6357a9518fe1be66c
+  metadata.gz: a27a350a265ac8f94d6f2262bc4e73f7b3d40f997fcc6227165fb029bf496eac429c2464a339dc49d7432acbf5e99e6bd453e1ed43f81b3b7a1c49f9b0519cf3
+  data.tar.gz: 3bd7fa7bb9e06f0404a169e9ba779ade96443659d4d2e8b222617e1443a43c0c00a6ee0230e9af526e547fab2abcfdf1cc7324d739ed0765d138f2ade6d85c29

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+### 0.2.0 (7/16/2020)
+
+* Include pre-release Ruby versions in `with_minimum_ruby` - [@dblock](https://github.com/dblock).
+
 ### 0.1.0 (1/13/2020)
 
 * Initial public release - [@dblock](https://github.com/dblock).

data/Gemfile.lock

@@ -1,32 +1,32 @@
 PATH
   remote: .
   specs:
-    with-version (0.1.0)
+    with-version (0.2.0)
 
 GEM
   remote: http://rubygems.org/
   specs:
-    ast (2.4.0)
-    diff-lcs (1.3)
+    ast (2.4.1)
+    diff-lcs (1.4.4)
     jaro_winkler (1.5.4)
-    parallel (1.19.1)
-    parser (2.7.0.2)
-      ast (~> 2.4.0)
+    parallel (1.19.2)
+    parser (2.7.1.4)
+      ast (~> 2.4.1)
     rainbow (3.0.0)
     rake (13.0.1)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
       rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.1)
-      rspec-support (~> 3.9.1)
-    rspec-expectations (3.9.0)
+    rspec-core (3.9.2)
+      rspec-support (~> 3.9.3)
+    rspec-expectations (3.9.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-mocks (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
-    rspec-support (3.9.2)
+    rspec-support (3.9.3)
     rubocop (0.79.0)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
@@ -35,7 +35,7 @@ GEM
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 1.7)
     ruby-progressbar (1.10.1)
-    unicode-display_width (1.6.0)
+    unicode-display_width (1.6.1)
 
 PLATFORMS
   ruby

data/README.md

@@ -27,7 +27,7 @@ class Example
 end
 ```
 
-```ruby 
+```ruby
 # Ruby 2.3.0
 undefined method `dig' for #<Example:0x00007fca9388a8a0> (NoMethodError)
 ```
@@ -37,6 +37,24 @@ undefined method `dig' for # (NoMethodError)
 Digging x, y ...
 ```
 
+It will automatically handle pre-release versions differently from when using `Gem::Version`, which is something developers often don't consider.
+
+```ruby
+Gem::Version.new('2.4.0.pre') >= Gem::Version.new('2.4.0') # false
+```
+
+```ruby
+require 'with-version'
+
+class Example
+  include With::Version::Ruby
+
+  with_minimum_ruby '2.4.0' do
+    # also true if RUBY_VERSION = 2.4.0.pre
+  end
+end
+```
+
 ## Contributing
 
 You're encouraged to contribute to this gem. See [CONTRIBUTING](CONTRIBUTING.md) for details.

data/lib/with-version/ruby.rb

@@ -11,7 +11,7 @@ module With
 
       module ClassMethods
         def with_minimum_ruby(version)
-          if With::Version::Ruby::Version.new(RUBY_VERSION) >= With::Version::Ruby::Version.new(version)
+          if With::Version::Ruby::Version.new(RUBY_VERSION).release >= With::Version::Ruby::Version.new(version)
             yield
           end
         end

data/lib/with-version/ruby/version.rb

@@ -23,6 +23,7 @@ module With
         attr_accessor :segments
 
         def initialize(version)
+          @version = version
           @segments = split_to_segments(version)
         end
 
@@ -51,6 +52,20 @@ module With
           0
         end
 
+        def prerelease?
+          !!(@version =~ /[a-zA-Z]/)
+        end
+
+        def release
+          if prerelease?
+            segments = @segments.dup
+            segments.pop while segments.any? { |s| String === s }
+            self.class.new segments.join('.')
+          else
+            self
+          end
+        end
+
         private
 
         def split_to_segments(version)

data/lib/with-version/version.rb

@@ -2,6 +2,6 @@
 
 module With
   module Version
-    VERSION = '0.1.0'
+    VERSION = '0.2.0'
   end
 end

data/spec/with-version/ruby_spec.rb

@@ -41,4 +41,19 @@ describe With::Version::Ruby do
       expect(@versions.sort).to eq([PREV_VERSION, RUBY_VERSION])
     end
   end
+
+  RELEASE_VERSION = Gem::Version.new(RUBY_VERSION).release.to_s
+  PRE_RELEASE_VERSION = Gem::Version.new(RELEASE_VERSION + '.pre1').to_s
+
+  context PRE_RELEASE_VERSION do
+    it 'includes includes pre-release' do
+      extend With::Version::Ruby::ClassMethods
+      stub_const('RUBY_VERSION', PRE_RELEASE_VERSION)
+      version_included = nil
+      with_minimum_ruby(RELEASE_VERSION) do
+        version_included = RUBY_VERSION
+      end
+      expect(version_included).to eq PRE_RELEASE_VERSION
+    end
+  end
 end

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: with-version
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Daniel Doubrovkine
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-01-13 00:00:00.000000000 Z
+date: 2020-07-16 00:00:00.000000000 Z
 dependencies: []
-description: 
+description:
 email: dblock@dblock.org
 executables: []
 extensions: []
@@ -36,7 +36,7 @@ homepage: http://github.com/dblock/with-version
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -51,8 +51,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-rubygems_version: 3.0.6
-signing_key: 
+rubygems_version: 3.1.3
+signing_key:
 specification_version: 4
 summary: Syntax sugar for version checks.
 test_files: []