wirecard_sepa 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 04e43db72ba035b59d9e26101b5c84664fdd745f
-  data.tar.gz: 2e174adf77802fce273870d8f72a57b7a1cf9cf7
+  metadata.gz: aaa93141c612cc1f432a50fe6cab5c7f031bb9f6
+  data.tar.gz: 4016372fc3adbf2c6811a98d3f989e66d02b572c
 SHA512:
-  metadata.gz: 449083675e209e5aa7956326e0a448a7fb41e444c9ce6b86f18ffaf6dd29cdc0e67862940e6f92e2ef00b7039270004f9a0e71db0d824a525146ade84d7cd8d9
-  data.tar.gz: 2edcc3b230df93a2cf7e740e70a72a17c180beab3897c7fdda76536d94e4cce13004e819968d1bc1b8ea7f7980a5b3c915d349587f537c080b22ba2492949bfc
+  metadata.gz: 9eefb21db2e5e4ba84f62823217b76cef25bf913f063eeea0b06e6a259840704ce250ab16a8ee835706be967cc9b05b78aafa2b00bc92df78cedff45d8ca512c
+  data.tar.gz: 58c5db146fea9374f7222c6022744440deac8f56c5f594e7f1ce1984d71e25ad7d016f42f25c320299c0a7117240e90f6dd5e7e77622f4a800b94fd1657d69e4

data/CHANGELOG.md

@@ -0,0 +1,5 @@
+## [0.0.3] - 2015-06-15
+### Changed
+- Added Changelog
+- Added Specs for init/processing recurring payments
+

data/README.md

@@ -5,10 +5,10 @@
 A WORK IN PROGRESS PROJECT
 
 ## TODOS
-1. Error Handling
-1. Maybe cache template files (are they loaded from disk each request?)
-1. Docs for usage in README.md
-1. Check Recurring Request/Response
+- [ ] Error Handling
+- [ ] Maybe cache template files (are they loaded from disk each request?)
+- [ ] Docs for usage in README.md
+- [ ] Check Recurring Request/Response
 
 ## Contributing
 1. Fork it ( https://github.com/betterplace/wirecard_sepa/fork )

data/lib/wirecard_sepa/direct_debit/response.rb

@@ -30,31 +30,41 @@ module WirecardSepa
       end
 
       def transaction_id
-        xml_doc.at_css('transaction-id').text
+        value_at 'transaction-id'
       end
 
       def transaction_state
-        xml_doc.at_css('transaction-state').text
+        value_at 'transaction-state'
       end
 
       def status_code
-        xml_doc.at_css('status')[:code]
+        value_at 'status', attribute: :code
       end
 
       def status_description
-        xml_doc.at_css('status')[:description]
+        value_at 'status', attribute: :description
       end
 
       def due_date
-        xml_doc.at_css('due-date').text
+        value_at 'due-date'
       end
 
       def provider_transaction_reference_id
-        xml_doc.at_css('provider-transaction-reference-id').text
+        value_at 'provider-transaction-reference-id'
       end
 
       private
 
+      # Returns the text of a node with the given position. If
+      # an additional attribute is given, this attribute is returned
+      # instead.
+      # This method provides mainly nil-safeness.
+      def value_at(position, attribute: nil)
+        node = xml_doc.at_css(position)
+        node or return
+        attribute ? node[attribute] : node.text
+      end
+
       def xml_doc
         @xml_doc ||= Nokogiri::XML xml
       end

data/lib/wirecard_sepa/version.rb

@@ -1,3 +1,3 @@
 module WirecardSepa
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/spec/lib/wirecard_sepa/direct_debit/response_spec.rb

@@ -6,6 +6,7 @@ describe WirecardSepa::DirectDebit::Response do
 
   let(:success_response) { described_class.new success_xml }
   let(:failure_response) { described_class.new failure_xml }
+  let(:empty_response) { described_class.new '<xml/>' }
 
   describe '.for_request(request)' do
     let(:request) { double('Fake Typhoeus request', body: '</xml>') }
@@ -31,15 +32,41 @@ describe WirecardSepa::DirectDebit::Response do
       it('params[:due_date]')           { expect(params[:due_date]).to eq '2013-10-03' }
       it('params[:reference_id]')       { expect(params[:reference_id]).to eq '33F7A4D125' }
     end
+
+    context 'for a failed response' do
+      let(:params) { failure_response.params }
+
+      it('params[:transaction_id]')     { expect(params[:transaction_id]).to eq '4185215e-250f-11e3-8d4b-005056a97162' }
+      it('params[:transaction_state]')  { expect(params[:transaction_state]).to eq 'failed' }
+      it('params[:status_code]')        { expect(params[:status_code]).to eq '400.1007' }
+      it('params[:status_description]') { expect(params[:status_description]).to eq 'The account holder information has not been provided. Please check your input and try again. ' }
+      it('params[:due_date]')           { expect(params[:due_date]).to be_nil }
+      it('params[:reference_id]')       { expect(params[:reference_id]).to be_nil }
+    end
+
+    context 'for a failed, empty response' do
+      let(:params) { empty_response.params }
+
+      it('params[:transaction_id]')     { expect(params[:transaction_id]).to be_nil }
+      it('params[:transaction_state]')  { expect(params[:transaction_state]).to be_nil }
+      it('params[:status_code]')        { expect(params[:status_code]).to be_nil }
+      it('params[:status_description]') { expect(params[:status_description]).to be_nil }
+      it('params[:due_date]')           { expect(params[:due_date]).to be_nil }
+      it('params[:reference_id]')       { expect(params[:reference_id]).to be_nil }
+    end
   end
 
   describe '#success?' do
     it 'returns true for a succesful response' do
-      expect(success_response.success?).to eq true
+      expect(success_response).to be_success
     end
 
     it 'returns false for a failure response' do
-      expect(failure_response.success?).to eq false
+      expect(failure_response).not_to be_success
+    end
+
+    it 'returns false for a malformed, empty response' do
+      expect(empty_response).not_to be_success
     end
   end
 end

data/spec/lib/wirecard_sepa/gateway_spec.rb

@@ -1,65 +1,61 @@
 require 'spec_helper'
 
+# TODOs
+# [] Record response from wirecard w/ VCR
 describe WirecardSepa::Gateway do
   let(:gateway) { described_class.new(sandbox_gateway_config) }
+  let(:debit_params) do
+    {
+      requested_amount: '12.12',
+      account_holder_first_name: 'John',
+      account_holder_last_name: 'Doe',
+      bank_account_iban: 'DE42512308000000060004',
+      bank_account_bic: 'WIREDEMMXXX',
+      mandate_id: '1235678',
+      mandate_signed_date: '2013-09-24',
+    }
+  end
+  let(:recurring_init_params) do
+    {
+      requested_amount: '15.00',
+      account_holder_first_name: 'Bob',
+      account_holder_last_name: 'Hawk',
+      bank_account_iban: 'DE42512308000000060004',
+      bank_account_bic: 'WIREDEMMXXX',
+      mandate_id: '2356789',
+      mandate_signed_date: '2013-08-11',
+    }
+  end
 
   describe '#debit(params)' do
-    let(:params) do
-      {
-        requested_amount: '12.12',
-        account_holder_first_name: 'John',
-        account_holder_last_name: 'Doe',
-        bank_account_iban: 'DE42512308000000060004',
-        bank_account_bic: 'WIREDEMMXXX',
-        mandate_id: '1235678',
-        mandate_signed_date: '2013-09-24',
-      }
-    end
-
     it 'posts the correct XML' do
       # TODO: Record response from wirecard
-      response = gateway.debit(params)
-      # FIXME: For some reason wirecard always returns the following error:
-      # "The Request Identifier has not been provided.  Please check your input and try again."
-      # Status-Code: 400.1010
-      # expect(response).to be_success
-      expect(response.request.headers['Content-Type']).to eq 'application/xml;charset=UTF-8'
+      response = gateway.debit(debit_params)
+      expect(response).to be_success
+      expect(response.params).to_not be_empty
+      expect(response.transaction_id).to_not be_empty
     end
   end
 
   describe '#recurring_init(params)' do
-    let(:params) do
-      {
-        requested_amount: '15.00',
-        account_holder_first_name: 'Bob',
-        account_holder_last_name: 'Hawk',
-        bank_account_iban: 'DE11512308000000060002',
-        bank_account_bic: 'WIREDEMMXXX',
-        mandate_id: '2356789',
-        mandate_signed_date: '2013-08-11',
-      }
-    end
-
     it 'posts the correct XML' do
-      response = gateway.recurring_init(params)
-      # FIXME: For some reason wirecard always returns the following error:
-      # "The Request Identifier has not been provided. Please check your input and try again."
-      # Status-Code: 400.1010
-      # expect(response).to be_success
+      # TODO: Record response from wirecard
+      response = gateway.recurring_init(recurring_init_params)
+      expect(response).to be_success
+      expect(response.params).to_not be_empty
+      expect(response.transaction_id).to_not be_empty
     end
   end
 
   describe '#recurring_process(params)' do
-    let(:params) do
-      { parent_transaction_id: 'e6604f91-663c-11e3-a07b-18037336c0b3' }
-    end
+    let(:init_response) { gateway.recurring_init(recurring_init_params) }
+    let(:parent_transaction_id) { init_response.transaction_id }
 
     it 'posts the correct XML' do
-      response = gateway.recurring_process(params)
-      # FIXME: For some reason wirecard always returns the following error:
-      # "The Request Identifier has not been provided. Please check your input and try again."
-      # Status-Code: 400.1010
-      # expect(response).to be_success
+      response = gateway.recurring_process({ parent_transaction_id: parent_transaction_id })
+      expect(response).to be_success
+      expect(response.params).to_not be_empty
+      expect(response.transaction_id).to_not be_empty
     end
   end
 end

data/spec/spec_helper.rb

@@ -18,7 +18,7 @@ def sandbox_gateway_config
     http_auth_username:  '70000-APITEST-AP',
     http_auth_password:  'qD2wzQ_hrc!8',
     merchant_account_id: '4c901196-eff7-411e-82a3-5ef6b6860d64',
-    creditor_id:         'abcdef',
+    creditor_id:         'DE00000000000000000000',
   })
 end
 

data/wirecard_sepa.gemspec

@@ -18,8 +18,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^spec/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "typhoeus"
-  spec.add_dependency "nokogiri"
+  spec.add_dependency "typhoeus", "~> 0.7"
+  spec.add_dependency "nokogiri", "~> 1.6"
 
   spec.add_development_dependency "bundler", "~> 1.7"
   spec.add_development_dependency "rake", "~> 10.4"

metadata

@@ -1,43 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: wirecard_sepa
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - betterplace developers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-11 00:00:00.000000000 Z
+date: 2015-06-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: typhoeus
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.7'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.6'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -118,6 +118,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md