wire_transfer 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5ef8d0d72b82534d64e3ecba6d564e5155050670
-  data.tar.gz: 50a021fcdc17ec6d70160598d0dc66d4966b5a8a
+  metadata.gz: 8046416c65495ffd67af77961a3f740533a27234
+  data.tar.gz: c81c34b96a40afe2fe8ee62ec1f5ad8aa2e69b39
 SHA512:
-  metadata.gz: 5ba473c99aebbef74626c0bf48b362a5e78ab6635c41ff816cb5874a0072d22c7573fb7add7bba67decde33f0236a8105ed11c77b10c667ba6f71b13e703a502
-  data.tar.gz: cad4d76c830a3cf9e5416c234cd3c4ef6d126ad3ffbc422488bffb0e91c4da26630d8532ced500561fdc568a523dc1dfe7f9237510c855f1a7d199c1351288f7
+  metadata.gz: fdff5475f902727ff58931a2dca779567fd98b4d198a8d73d07b3f98a2fd7e7c9aabe953193244479975811d998f61456227365249cbf80c701bd18d19d91c77
+  data.tar.gz: f417ac92da07ef8671309f480a4127feb75c993b4d331bd10e333af2a75e9cd3babaf9b2fd03dcd144bc45e4549f5e5176aaf8555de368ea5f51579a1742e9d2

data/lib/wire_transfer.rb

@@ -11,8 +11,12 @@ require "wire_transfer/helper"
 require "wire_transfer/invalid_number_error"
 
 module WireTransfer
-  def self.generate_structured_communication(reference)
-    StructuredCommunication.compute(reference)
+  def self.generate_structured_communication(number)
+    StructuredCommunication.new(number)
+  end
+
+  def self.parse_structured_communication(string)
+    StructuredCommunication.from_string(string)
   end
 end
 

data/lib/wire_transfer/structured_communication.rb

@@ -1,40 +1,33 @@
 module WireTransfer
   class StructuredCommunication
-    def initialize number
-      @number = number.to_s
-      raise InvalidNumberError unless @number.match(/\A\d{12}\z/)
-    end
+    ALLOWED_NUMBERS = 0..9999999999
 
-    # Take a reference number and pad it with a certain amount of zeros
-    # to make a total of 10 characters. Then it computes and appends 2 control characters.
-    def self.compute(reference)
-      padded_reference = pad_reference_with_zeros(reference)
-      new(append_control_characters(padded_reference))
-    end
-
-    # Take a communication number and format it as it appears on a wire transfer.
-    def to_s
-      communication_number = @number.insert 3, "/"
-      communication_number = communication_number.insert 8, "/"
-      "+++#{communication_number}+++"
+    def initialize number
+      @number = number
+      raise InvalidNumberError unless ALLOWED_NUMBERS.include?(@number)
     end
 
-    protected
+    def self.from_string(string)
+      string = string.gsub(/[^\d]/, '')
+      raise InvalidNumberError unless string.size == 12
+      number             = string[0..9]
+      control_characters = string[10..11]
 
-    def self.pad_reference_with_zeros(reference)
-      reference.to_s.ljust(10, "0")
+      structured_communication = new(number.to_i)
+      raise InvalidNumberError unless structured_communication.control_characters == control_characters
+      structured_communication
     end
 
-    def self.append_control_characters(padded_reference)
-      padded_reference + compute_control_characters(padded_reference)
+    def padded_number
+      @number.to_s.rjust(10, "0")
     end
 
     # Take the remainder of the euclidian division from the padded
     # reference by 97 (modulo 97) and pad it with zeros if necessary
     # unless this remainder is equal to 0, in that case,
     # the control characters are replaced by 97.
-    def self.compute_control_characters(padded_reference)
-      remainder = padded_reference.to_i % 97
+    def control_characters
+      remainder = padded_number.to_i % 97
 
       if remainder > 0
         remainder.to_s.rjust(2, "0")
@@ -42,5 +35,20 @@ module WireTransfer
         "97"
       end
     end
+
+    def checksummed_padded_number
+      padded_number + control_characters
+    end
+
+    # Take a communication number and format it as it appears on a wire transfer.
+    def to_s
+      communication_number = checksummed_padded_number.insert 3, "/"
+      communication_number = communication_number.insert 8, "/"
+      "+++#{communication_number}+++"
+    end
+
+    def to_i
+      @number
+    end
   end
 end

data/lib/wire_transfer/version.rb

@@ -1,3 +1,3 @@
 module WireTransfer
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: wire_transfer
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Romain Gérard