win32-file-stat 1.4.2 → 1.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f4a8344517f65f38afc25399ed53ba90e4042790
-  data.tar.gz: 082ee54ef5f8683133ac1a6debd4100aa689dbd2
+  metadata.gz: ee8c0c3a76c7fcc22794899ff2cb0e0f455ba6e0
+  data.tar.gz: 73fbaca95c61912ef6e62f7baa2bf26c3a6f9f66
 SHA512:
-  metadata.gz: c739e1e16beb1130f1cba2c27dcb94e53758a6df15dc9bf8eea30789da0626ae1cec9a9481bd811437603583353974df7bb18b792e7e09ad5160c33d218c801f
-  data.tar.gz: 73012b9bd897383edf5208ebd42b163350f7bdef8acc9c44ff9eac56eb041d99754e92a2e55ea5156a08e1c771a5694ad3faff4e1e2f3f52940c473620e850d5
+  metadata.gz: 7cd9985c5a62e7d71e99f586dfe2f18dc1f49fedc4c808db474fa2f5f0b790870612d1f114450de484e93bdeda2b34e1c1339efe2773cc4401a7f3ef6fe56680
+  data.tar.gz: 0db9479f32582058da50eaff0afff77226f9fa51e7a520aeb2dd0b9e5f2ee63c260f9d3ae0cf1f96cb8bf9cf421b57d5857c44ffbcf0677ce3d8b4dc95e7990a

data/CHANGES

@@ -1,10 +1,14 @@
+== 1.4.3 - 8-May-2014
+* The #writable? method now ignores the readonly attribute if it's a directory.
+* Replaced File.exists? with File.exist? to avoid warnings in Ruby 2.1.x.
+
 == 1.4.2 - 28-Apr-2014
 * Allow the File::Stat.new method to accept objects that respond to to_str
   or to_path to mimic MRI.
 
 == 1.4.1 - 12-Feb-2014
-* The #writable and #writable_real methods now always return false if the file
-  has been marked readonly.
+* The #writable? and #writable_real? methods now always return false if the
+  file has been marked readonly.
 * Fixed an rdev test and added a writable test.
 
 == 1.4.0 - 16-Dec-2013

data/Rakefile

@@ -19,7 +19,7 @@ namespace :gem do
   desc "Install the win32-file-stat gem"
   task :install => [:create] do
     file = Dir["win32-file-stat*.gem"].first
-    sh "gem install #{file}"
+    sh "gem install -l #{file}"
   end
 end
 

data/lib/win32/file/stat.rb

@@ -55,7 +55,7 @@ class File::Stat
   attr_reader :dev_major, :dev_minor, :rdev_major, :rdev_minor
 
   # The version of the win32-file-stat library
-  WIN32_FILE_STAT_VERSION = '1.4.2'
+  WIN32_FILE_STAT_VERSION = '1.4.3'
 
   # Creates and returns a File::Stat object, which encapsulate common status
   # information for File objects on MS Windows sytems. The information is
@@ -173,7 +173,13 @@ class File::Stat
       @readable = access_check(path, GENERIC_READ)
       @readable_real = @readable
 
-      @writable = access_check(path, GENERIC_WRITE) && !@readonly
+      # The MSDN docs say that the readonly attribute is honored for directories
+      if @directory
+        @writable = access_check(path, GENERIC_WRITE)
+      else
+        @writable = access_check(path, GENERIC_WRITE) && !@readonly
+      end
+
       @writable_real = @writable
 
       @world_readable = access_check_world(path, FILE_READ_DATA)

data/test/test_file_stat.rb

@@ -54,7 +54,7 @@ class TC_Win32_File_Stat < Test::Unit::TestCase
   end
 
   test "version is set to expected value" do
-    assert_equal('1.4.2', File::Stat::WIN32_FILE_STAT_VERSION)
+    assert_equal('1.4.3', File::Stat::WIN32_FILE_STAT_VERSION)
   end
 
   test "constructor does not modify argument" do
@@ -460,7 +460,7 @@ class TC_Win32_File_Stat < Test::Unit::TestCase
 
   # Not sure how to test properly in a generic way, but works on my local network
   test "rdev works on unc path" do
-    omit_unless(Etc.getlogin == "djberge" && File.exists?("//scipio/users"))
+    omit_unless(Etc.getlogin == "djberge" && File.exist?("//scipio/users"))
     assert_true(File::Stat.new("//scipio/users").rdev > 1000)
   end
 
@@ -604,6 +604,15 @@ class TC_Win32_File_Stat < Test::Unit::TestCase
     assert_false(File::Stat.new(@@sys_file).writable?)
   end
 
+  test "writable? returns expected result for system directory" do
+    dir = "C:/Program Files"
+    if @@elevated
+      assert_true(File::Stat.new(dir).writable?)
+    else
+      assert_false(File::Stat.new(dir).writable?)
+    end
+  end
+
   test "a file marked as readonly is not considered writable" do
     File.chmod(0644, @@txt_file)
     assert_true(File::Stat.new(@@txt_file).writable?)
@@ -638,7 +647,7 @@ class TC_Win32_File_Stat < Test::Unit::TestCase
 
   def teardown
     SetFileAttributes(@@txt_file, @attr) # Set file back to normal
-    File.delete(@temp) if File.exists?(@temp)
+    File.delete(@temp) if File.exist?(@temp)
     @dir  = nil
     @stat = nil
     @attr = nil
@@ -646,8 +655,8 @@ class TC_Win32_File_Stat < Test::Unit::TestCase
   end
 
   def self.shutdown
-    File.delete(@@txt_file) if File.exists?(@@txt_file)
-    File.delete(@@exe_file) if File.exists?(@@exe_file)
+    File.delete(@@txt_file) if File.exist?(@@txt_file)
+    File.delete(@@exe_file) if File.exist?(@@exe_file)
 
     @@block_dev = nil
     @@txt_file  = nil

data/win32-file-stat.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name      = 'win32-file-stat'
-  spec.version   = '1.4.2'
+  spec.version   = '1.4.3'
   spec.authors   = ['Daniel J. Berger', 'Park Heesob']
   spec.license   = 'Artistic 2.0'
   spec.email     = 'djberg96@gmail.com'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: win32-file-stat
 version: !ruby/object:Gem::Version
-  version: 1.4.2
+  version: 1.4.3
 platform: ruby
 authors:
 - Daniel J. Berger
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-28 00:00:00.000000000 Z
+date: 2014-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ffi