will_paypal 0.1.1 → 0.1.2

data/.gitignore

@@ -1,3 +1,5 @@
 pkg
 doc
-Manifest
+Manifest
+.rvmrc
+Gemfile.lock

data/Rakefile

@@ -1,3 +1,4 @@
+require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 
 desc "Run specs"

data/lib/will_paypal.rb

@@ -28,9 +28,9 @@ class WillPaypal
     data.merge!(self.config[:params])
     query = []
     data.each do |key, value|
-      query << "#{key.to_s.upcase}=#{URI.escape(value.to_s)}"
+      query << "#{key.to_s.upcase}=#{CGI.escape(value.to_s)}"
     end
-    query.join("&")
+    query.sort.join("&")
   end
 
   def hash_from_query_string(query_string)

data/spec/will_paypal_spec.rb

@@ -24,6 +24,16 @@ describe "WillPaypal" do
     end
   end
 
+  describe "Converting query strings back and forth" do
+    let(:paypal) { WillPaypal.new }
+    it 'should succeed' do
+      hash = {'NAME' => 'Barnes & Noble', 'TITLE' => 'Barnes and Noble'}
+      convertible = paypal.hash_from_query_string(paypal.query_string_for(hash))
+      convertible['NAME'].should eql(hash['NAME'])
+      convertible['TITLE'].should eql(hash['TITLE'])
+    end
+  end
+
   describe "Request to Paypal" do
 
     describe "Query String" do
@@ -88,7 +98,7 @@ describe "WillPaypal" do
         http_response = double("response")
         http_response.should_receive(:code)
         http_response.should_receive(:body)
-        http.should_receive(:request_post).with("/nvp", "USER=team_1220115929_biz_api1.example.com&SIGNATURE=&VERSION=72.0&PWD=").and_return(http_response)
+        http.should_receive(:request_post).with("/nvp", "PWD=&SIGNATURE=&USER=team_1220115929_biz_api1.example.com&VERSION=72.0").and_return(http_response)
         http.should_receive(:use_ssl=).with(true)
         http.should_receive(:verify_mode=).with(OpenSSL::SSL::VERIFY_PEER)
         http.should_receive(:ca_path=).with('/etc/ssl/certs')
@@ -111,7 +121,7 @@ describe "WillPaypal" do
         http_response.should_receive(:code)
         http_response.should_receive(:body)
         http.should_receive(:use_ssl=).with(true)
-        http.should_receive(:request_post).with("/nvp", "USER=team_1220115929_biz_api1.example.com&SIGNATURE=&VERSION=72.0&PWD=").and_return(http_response)
+        http.should_receive(:request_post).with("/nvp", "PWD=&SIGNATURE=&USER=team_1220115929_biz_api1.example.com&VERSION=72.0").and_return(http_response)
         http.should_receive(:verify_mode=).with(OpenSSL::SSL::VERIFY_NONE)
         paypal.call_paypal({})
       end

data/will_paypal.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{will_paypal}
-  s.version = "0.1.1"
+  s.version = "0.1.2"
   s.platform    = Gem::Platform::RUBY
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=

metadata

@@ -1,13 +1,8 @@
 --- !ruby/object:Gem::Specification 
 name: will_paypal
 version: !ruby/object:Gem::Version 
-  hash: 25
   prerelease: 
-  segments: 
-  - 0
-  - 1
-  - 1
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors: 
 - Michael Bumann - Railslove
@@ -16,7 +11,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-05-19 00:00:00 +02:00
+date: 2012-01-13 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -27,11 +22,6 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 23
-        segments: 
-        - 2
-        - 6
-        - 0
         version: 2.6.0
   type: :development
   version_requirements: *id001
@@ -43,9 +33,6 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
         version: "0"
   type: :development
   version_requirements: *id002
@@ -62,15 +49,12 @@ extra_rdoc_files:
 - README.rdoc
 files: 
 - .gitignore
-- .rvmrc
 - Gemfile
-- Gemfile.lock
 - README.rdoc
 - Rakefile
 - lib/will_paypal.rb
 - spec/spec_helper.rb
 - spec/will_paypal_spec.rb
-- will_paypal-0.1.0.gem
 - will_paypal.gemspec
 has_rdoc: true
 homepage: https://github.com/railslove/Will-Paypal
@@ -91,24 +75,17 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 11
-      segments: 
-      - 1
-      - 2
       version: "1.2"
 requirements: []
 
 rubyforge_project: will_paypal
-rubygems_version: 1.5.0
+rubygems_version: 1.6.2
 signing_key: 
 specification_version: 3
 summary: Paypal NVP API Class.

data/.rvmrc

@@ -1 +0,0 @@
-rvm use --create ree@nvp

data/Gemfile.lock

@@ -1,26 +0,0 @@
-PATH
-  remote: .
-  specs:
-    will_paypal (0.1.0)
-
-GEM
-  remote: http://rubygems.org/
-  specs:
-    diff-lcs (1.1.2)
-    fakeweb (1.3.0)
-    rspec (2.6.0)
-      rspec-core (~> 2.6.0)
-      rspec-expectations (~> 2.6.0)
-      rspec-mocks (~> 2.6.0)
-    rspec-core (2.6.0)
-    rspec-expectations (2.6.0)
-      diff-lcs (~> 1.1.2)
-    rspec-mocks (2.6.0)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  fakeweb
-  rspec (~> 2.6.0)
-  will_paypal!