wikidatum 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 78bb68e7872a77e0dc21f9904d0fd8306b4d4caa23329824d87257a91e503925
-  data.tar.gz: 84765a7d5f3cee85b0c6ad68953f1d6e9718d068037247f8e8e7e1c4b651c51b
+  metadata.gz: d2ee435a3831b816e6e64465040a5197de654450551812b835b28329be9c287d
+  data.tar.gz: d23fb1902df5465b123fc0bcea0c7594fb64a6e918604a9f1bb1f4e4eadf6eff
 SHA512:
-  metadata.gz: 24dd512b025f3e618b46ba9b5cc280c2ef500909b7f68c666f29914b5a64e1da63729ded4e321e37461f68f6fdc1f429ec87a71684b773eacb5f25f56ee5c212
-  data.tar.gz: e43e1b92d171667ce5af5028c56b7d5c28971ef3c3aed93f55a919088e6a990796889eb32293563191d857cf547ca685b6d571bc629a199cbbb6ab332283a731
+  metadata.gz: ccd8210a5120fbbfb35ed03899938bf4ca4e5302bc93e3e53652180b86b221a3ec23afe57db78777ffcda5971150f7c0ed6af89cde7b294fe21d716491653c49
+  data.tar.gz: cb4e092b80c6ab871c1dd7f5bd46f700029eab7438c7a4063a2aee42b389c0e86ec0e387fc15fa996037d2478f494ac46572879078930c41c18ae6b7e4073e00

data/CHANGELOG.md

@@ -4,11 +4,23 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
+## Unreleased
+
+## 0.3.1 - 2022-12-28
+### Added
+
+- Add an error message when attempting to make a bot edit without authentication, as this will always trigger a 403 error from the REST API.
+
+### Fixed
+
+- Fix the creation of WikibaseItem statements, the format used in the previous release was incorrect.
+
 ## 0.3.0 - 2022-12-27
 ### Added
 
 - Add `allow_ip_edits` argument on `Wikidatum::Client.new`. This protects users from making IP address-exposing edits if they haven't explicitly opted-in to doing that. The argument defaults to false.
 - Add code to raise errors when various types of invalid input are passed to `Wikidatum::Client#add_statement`.
+- Start testing the gem on Ruby 3.2.
 
 ### Fixed
 

data/lib/wikidatum/client.rb

@@ -245,7 +245,15 @@ module Wikidatum
         }
       end
 
-      body = { statement: statement_hash.merge({ qualifiers: qualifiers, references: references, rank: rank.to_s, type: 'statement' }) }
+      body = {
+        statement: statement_hash.merge(
+          {
+            qualifiers: qualifiers,
+            references: references,
+            rank: rank.to_s
+          }
+        )
+      }
 
       response = post_request("/entities/items/#{id}/statements", body, tags: tags, comment: comment)
 
@@ -292,6 +300,13 @@ module Wikidatum
       @allow_ip_edits
     end
 
+    # Is the current instance of Client editing as a bot?
+    #
+    # @return [Boolean]
+    def bot?
+      @bot
+    end
+
     private
 
     # For now this just returns the `@wikibase_url`, but in the future the API
@@ -426,13 +441,15 @@ module Wikidatum
     # Check if authentication has been provided, and then check if IP edits
     # are allowed. If neither condition returns true, raise an error.
     #
+    # Also check if the user is performing IP edits as a bot, which will
+    # always return a 403 error from the REST API, and return a specific
+    # error message if so.
+    #
     # @return [void]
-    # @raise [DisallowedIpEditError]
+    # @raise [DisallowedIpEditError, DisallowedBotEditError]
     def ensure_edit_permitted!
-      return if authenticated?
-      return if allow_ip_edits?
-
-      raise DisallowedIpEditError
+      raise DisallowedIpEditError if !authenticated? && !allow_ip_edits?
+      raise DisallowedBotEditError if !authenticated? && bot?
     end
   end
 end

data/lib/wikidatum/data_type/wikibase_item.rb

@@ -57,8 +57,6 @@ class Wikidatum::DataType::WikibaseItem
 
   # @!visibility private
   def marshal_dump
-    {
-      id: @id
-    }
+    @id
   end
 end

data/lib/wikidatum/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Wikidatum
-  VERSION = '0.3.0'
+  VERSION = '0.3.1'
 end

data/lib/wikidatum.rb

@@ -24,6 +24,15 @@ module Wikidatum
     end
   end
 
+  # If the Wikidatum::Client is set to mark their edits as belonging to a bot,
+  # they must be authenticated as a bot user. We will disallow these edits
+  # as long as they're not authenticated as a specific user.
+  class DisallowedBotEditError < Error
+    def message
+      'No authentication provided, but attempted to edit as a bot. You cannot make edits as a bot unless you have authenticated as a user with the Bot flag.'
+    end
+  end
+
   # rubocop:disable Naming/ConstantName
 
   # These language codes are not enforced, you can pass whatever language code

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: wikidatum
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Connor Shea