wicked_pdf 1.0.5 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 47fe2d6d38cc265b92a54aaba23756bd4ecfcf30
-  data.tar.gz: 914991dd1656d0fb326ebf2e38a8f013ce8357b4
+  metadata.gz: c95f5e0cfe79095b9afde68450e7c5a4ffa8e003
+  data.tar.gz: 778a71b7ca2186a1dbd2bc3082f2687880143252
 SHA512:
-  metadata.gz: 166e1621757930e9ac10846569c28cc6e215eb4e81f2a8280789f9b2ffa8ba4d4a7fc53140f898dcb591c0890561e25e5f996af5c1f70a0ff81e4625a565ab7b
-  data.tar.gz: 58c3dfe3876a9941da002de9aca24283a217ebbc1da024f1caef83c92a9c1be845186382a2e7955d539c3e1bde73486219dd66eab26bf16d61be3c053365f119
+  metadata.gz: 76fe365657188e7e7b37ab1bdfec591d4908309e0322b38817ebe4f678aac81b4301ce65d2ff4c4cb6ab1fbb8b6cba12a389763980431534493dff446b76ef40
+  data.tar.gz: 3b5be736f73b1a217725cb1e0bcb21b40daae9f721f57f284590dc593930e5312fef134093414b4f7c9166798ca3f50f52da8b29c244c75fcb9816b18e95b4b7

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## [1.0.6] - 2016-04-04
+### Changed
+- Revert shellescaping of options. The fix was causing more issues than it solved (like "[page] of [topage]" being escaped, and thus not parsed by `wkhtmltopdf`). See #514 for details.
+
 ## [1.0.5] - 2016-03-28
 ### Changed
 - Numerous RuboCop style violation fixes, spelling errors, and test-setup issues from [indyrb.org](http://indyrb.org/) hack night. Thank you all for your contributions!
@@ -65,7 +69,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 - Asset helpers no longer add a file extension if it already is specified with one
 
 # Compare Releases
-- [1.0.5...HEAD](https://github.com/mileszs/wicked_pdf/compare/1.0.5...HEAD)
+- [1.0.6...HEAD](https://github.com/mileszs/wicked_pdf/compare/1.0.6...HEAD)
+- [1.0.5...1.0.6](https://github.com/mileszs/wicked_pdf/compare/1.0.5...1.0.6)
 - [1.0.4...1.0.5](https://github.com/mileszs/wicked_pdf/compare/1.0.4...1.0.5)
 - [1.0.3...1.0.4](https://github.com/mileszs/wicked_pdf/compare/1.0.3...1.0.4)
 - [1.0.2...1.0.3](https://github.com/mileszs/wicked_pdf/compare/1.0.2...1.0.3)

data/lib/wicked_pdf.rb

@@ -4,7 +4,6 @@
 require 'logger'
 require 'digest/md5'
 require 'rbconfig'
-require 'shellwords'
 
 if (RbConfig::CONFIG['target_os'] =~ /mswin|mingw/) && (RUBY_VERSION < '1.9')
   require 'win32/open3'
@@ -162,12 +161,12 @@ class WickedPdf
       return value.collect { |v| make_option(name, v, type) }
     end
     if type == :name_value
-      parts = value.to_s.split(' ').map { |part| part.shellescape }
+      parts = value.to_s.split(' ')
       ["--#{name.tr('_', '-')}", *parts]
     elsif type == :boolean
       ["--#{name.tr('_', '-')}"]
     else
-      ["--#{name.tr('_', '-')}", value.to_s.shellescape]
+      ["--#{name.tr('_', '-')}", value.to_s]
     end
   end
 

data/lib/wicked_pdf/version.rb

@@ -1,3 +1,3 @@
 class WickedPdf
-  VERSION = '1.0.5'.freeze
+  VERSION = '1.0.6'.freeze
 end

data/test/unit/wicked_pdf_test.rb

@@ -218,9 +218,4 @@ class WickedPdfTest < ActiveSupport::TestCase
     cover_option = @wp.get_valid_option('cover')
     assert_equal @wp.get_parsed_options(options), "--disable-javascript --header-center 3 #{cover_option} http://example.org"
   end
-
-  test 'options are shellescaped' do
-    options = { :header => { :left => "That's crazy" } }
-    assert_equal "--header-left That\\'s\\ crazy", @wp.get_parsed_options(options)
-  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: wicked_pdf
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.6
 platform: ruby
 authors:
 - Miles Z. Sterrett
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-28 00:00:00.000000000 Z
+date: 2016-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails