wicked_pdf 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dd7dae1230ac2e120e6ca1cb235a8f21465df966
-  data.tar.gz: c66399843e25433bc83ac7970ff392f2a217bf95
+  metadata.gz: 9ab8593ac44c5682cf136c152de88154d721bb05
+  data.tar.gz: a999e4080b0f2a76c4488058e4ccf24e69cb9d1d
 SHA512:
-  metadata.gz: 86a57ed7f58c19916f48c8cfc98074c5e6cb3ca060c1563abbb2c62e2c0eecefeaba635502ece68c870be7b4049422ef7fd326d59507a6a8709d3938def96491
-  data.tar.gz: e97feccdf135d2e74d2d14e9ba1e944c130ed631c27a2f18c46e5be1f6804ac439e75755a0a3ddeffffe877d33547c07c76f13980b5b42d0eda45f243f98e399
+  metadata.gz: 1dc2bb0b82be7d2071dd92648cee85e6ab8f539cce32b3eb92d78ab4758926e156aead56847d6a2663ea9909f79d3f53c37f6b63bf3b01d0d2343efd37b3d3c6
+  data.tar.gz: 1595873318fa389a248d5d85203a9fc397a3670d36c3ac73032362bb06f5c38f5c9dbbe78bd5e3c11c233fcfb1ad06b530dbc8ef2bdbe29582b20308605e8158

data/.rubocop.yml

@@ -0,0 +1,9 @@
+inherit_from: .rubocop_todo.yml
+
+AllCops:
+  Exclude:
+    - 'test/dummy/**/*'
+
+# I'd like wicked_pdf to keep Ruby 1.8 compatibility for now
+Style/HashSyntax:
+  EnforcedStyle: hash_rockets

data/.rubocop_todo.yml

@@ -0,0 +1,67 @@
+# This configuration was generated by `rubocop --auto-gen-config`
+# on 2015-11-08 18:41:57 -0500 using RuboCop version 0.32.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+Lint/AmbiguousRegexpLiteral:
+  Enabled: false
+
+# Offense count: 2
+Lint/HandleExceptions:
+  Enabled: false
+
+# Offense count: 9
+Metrics/AbcSize:
+  Max: 45
+
+# Offense count: 2
+Metrics/BlockNesting:
+  Max: 4
+
+# Offense count: 2
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 279
+
+# Offense count: 5
+Metrics/CyclomaticComplexity:
+  Max: 9
+
+# Offense count: 92
+# Configuration parameters: AllowURI, URISchemes.
+Metrics/LineLength:
+  Max: 563
+
+# Offense count: 14
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 30
+
+# Offense count: 4
+Metrics/PerceivedComplexity:
+  Max: 12
+
+# Offense count: 5
+Style/AccessorMethodName:
+  Enabled: false
+
+# Offense count: 1
+Style/CaseEquality:
+  Enabled: false
+
+# Offense count: 1
+Style/ClassVars:
+  Enabled: false
+
+# Offense count: 15
+Style/Documentation:
+  Enabled: false
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
+Style/RegexpLiteral:
+  Enabled: false

data/.travis.yml

@@ -42,6 +42,10 @@ matrix:
     - rvm: 2.2.0
       gemfile: gemfiles/rails_edge.gemfile
   allow_failures:
+    - rvm: 1.9.2
+      gemfile: gemfiles/3.1.gemfile
+    - rvm: 1.9.2
+      gemfile: gemfiles/3.2.gemfile
     - rvm: 1.9.3
       gemfile: gemfiles/rails_edge.gemfile
     - rvm: 2.0.0

data/CHANGLOG.md

@@ -0,0 +1,42 @@
+# Change Log
+All notable changes to this project will be documented in this file.
+This project adheres to [Semantic Versioning](http://semver.org/).
+
+## [1.0.0] - 2015-11-03
+### Changed
+- Accepted that `WickedPDF` cannot guarantee backwards compatibility with older versions of `wkthmltopdf`, and decided to publish a new version with the MAJOR number incremented, signaling that this may have breaking changes for some people, but providing a path forward for progress. This release number also signals that this is a mature (and relatively stable) project, and should be deemed ready for production (since it has been used in production since ~2009, and downloaded over a *million* times on [RubyGems.org](https://rubygems.org/gems/wicked_pdf)).
+- Stopped attempting to track with version number of `wkhtmltopdf` binary releases (`wkhtmltopdf` v9.x == `WickedPDF` v9.x)
+- Adopted [Semantic Versioning](http://semver.org/) for release numbering
+- Added a CHANGELOG (based on [keepachangelog.com](http://keepachangelog.com/))
+- Misc code tweaks as suggested by [RuboCop](https://github.com/bbatsov/rubocop)
+
+### Added
+- Check version of `wkhtmltopdf` before deciding to pass arguments with or without dashes
+- New arguments and options for the table of contents supported in newer versions of wkhtmltopf: `text_size_shrink`, `level_indentation`, `disable_dotted_lines`, `disable_toc_links`, `xsl_style_sheet`
+- Merge in global options to `pdf_from_html_file` and `pdf_from_string`
+- Add ability to generate pdf from a web resource: `pdf_from_url(url)`
+
+### Removed
+- Explicit dependency on [Rails](https://github.com/rails/rails), since parts of this library may be used without it.
+- Comment out the `:exe_path` option in the generated initalizer by default (since many systems won't have `wkthmltopdf` installed in that specific location)
+
+### Fixed
+- Issues with `file://` paths on Windows-based systems
+- Issues with parsed options/argument ordering on versions of `wkthmltopdf` > 0.9
+- Issues with middleware headers when running Rails app mounted in a subdirectory
+- Issues with options that have a `key: 'value'` syntax when passed to `wkthmltopdf`
+- Issue with `:temp_path` option being deleted from original options hash
+- Issue with header/footer `:content` being deleted after the first page
+- Issues with options being modified during processing (including global config options)
+- Issues with asset helpers recognizing assets specified without a protocol
+- Issues with `url()` references and embedded `data:base64` assests in stylesheets rendered with `wicked_pdf_stylesheet_link_tag`
+- Asset helpers no longer add a file extension if it already is specified with one
+
+# Compare Releases
+- [1.0.0...Unreleased](https://github.com/mileszs/wicked_pdf/compare/f0b49fa...HEAD)
+- [1.0.0...1.0.1](https://github.com/mileszs/wicked_pdf/compare/24303d0...f0b49fa)
+- [0.11.0...1.0.0](https://github.com/mileszs/wicked_pdf/compare/968ae69...24303d0)
+- [0.10.2...0.11.0](https://github.com/mileszs/wicked_pdf/compare/076f043...968ae69)
+- [0.10.1...0.10.2](https://github.com/mileszs/wicked_pdf/compare/a920bc9...076f043)
+- [0.10.0...0.10.1](https://github.com/mileszs/wicked_pdf/compare/df67c30...a920bc9)
+- [0.9.10...0.10.0](https://github.com/mileszs/wicked_pdf/compare/9daecee...df67c30)

data/README.md

@@ -329,9 +329,11 @@ You may have noticed: this plugin is heavily inspired by the PrinceXML plugin [p
 
 1. Fork it
 2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request
+3. Run the test suite and check the output (`rake`)
+4. Add tests for your feature or fix (please)
+5. Commit your changes (`git commit -am 'Add some feature'`)
+6. Push to the branch (`git push origin my-new-feature`)
+7. Create new Pull Request
 
 ### Awesome Peoples
 

data/Rakefile

@@ -5,7 +5,7 @@ require 'rails/version'
 require 'bundler/gem_tasks'
 
 desc 'Default: run unit tests.'
-task :default => :setup_and_run_tests
+task :default => [:setup_and_run_tests, :rubocop]
 
 desc 'Test the wicked_pdf plugin.'
 Rake::TestTask.new(:test) do |t|
@@ -15,6 +15,13 @@ Rake::TestTask.new(:test) do |t|
   t.verbose = true
 end
 
+desc 'Run RuboCop'
+task :rubocop do
+  return unless RUBY_VERSION > '1.9.2'
+  require 'rubocop/rake_task'
+  RuboCop::RakeTask.new
+end
+
 desc 'Setup and run all tests'
 task :setup_and_run_tests do
   unless File.exist?('test/dummy/config/environment.rb')
@@ -27,12 +34,7 @@ desc 'Generate dummy application for test cases'
 task :dummy_generate do
   Rake::Task[:dummy_remove].invoke
   puts 'Creating dummy application to run tests'
-
-  prefix = ''
-  if Rails::VERSION::MAJOR != 2
-    prefix = 'new '
-  end
-
+  prefix = (Rails::VERSION::MAJOR == 2) ? '' : 'new '
   system("rails #{prefix}test/dummy")
   FileUtils.rm_r Dir.glob('test/dummy/test/*')
 end

data/lib/wicked_pdf.rb

@@ -50,9 +50,8 @@ class WickedPdf
 
   def pdf_from_string(string, options = {})
     options = options.dup
-    # merge in global config options
-    options.merge!(WickedPdf.config) {|key, option, config| option}
-    string_file = WickedPdfTempfile.new("wicked_pdf.html", options[:temp_path])
+    options.merge!(WickedPdf.config) { |_key, option, _config| option }
+    string_file = WickedPdfTempfile.new('wicked_pdf.html', options[:temp_path])
     string_file.binmode
     string_file.write(string)
     string_file.close
@@ -67,8 +66,8 @@ class WickedPdf
 
   def pdf_from_url(url, options = {})
     # merge in global config options
-    options.merge!(WickedPdf.config) {|key, option, config| option}
-    generated_pdf_file = WickedPdfTempfile.new("wicked_pdf_generated_file.pdf", options[:temp_path])
+    options.merge!(WickedPdf.config) { |_key, option, _config| option }
+    generated_pdf_file = WickedPdfTempfile.new('wicked_pdf_generated_file.pdf', options[:temp_path])
     command = [@exe_path]
     command << '-q' unless on_windows? # suppress errors on stdout
     command += parse_options(options)
@@ -77,10 +76,11 @@ class WickedPdf
 
     print_command(command.inspect) if in_development_mode?
 
-    err = Open3.popen3(*command) do |stdin, stdout, stderr|
+    err = Open3.popen3(*command) do |_stdin, _stdout, stderr|
       stderr.read
     end
-    if return_file = options.delete(:return_file)
+    if options[:return_file]
+      return_file = options.delete(:return_file)
       return generated_pdf_file
     end
     generated_pdf_file.rewind
@@ -114,7 +114,7 @@ class WickedPdf
   end
 
   def retreive_binary_version
-    stdin, stdout, stderr = Open3.popen3(@exe_path + ' -V')
+    _stdin, stdout, _stderr = Open3.popen3(@exe_path + ' -V')
     @binary_version = parse_version(stdout.gets(nil))
   rescue StandardError
   end
@@ -186,7 +186,7 @@ class WickedPdf
       if options[o].blank?
         []
       else
-        make_option("#{prefix.blank? ? '' : prefix + '-'}#{o.to_s}",
+        make_option("#{prefix.blank? ? '' : prefix + '-'}#{o}",
                     options[o],
                     type)
       end
@@ -196,22 +196,21 @@ class WickedPdf
   def parse_header_footer(options)
     r = []
     [:header, :footer].collect do |hf|
-      unless options[hf].blank?
-        opt_hf = options[hf]
-        r += make_options(opt_hf, [:center, :font_name, :left, :right], "#{hf.to_s}")
-        r += make_options(opt_hf, [:font_size, :spacing], "#{hf.to_s}", :numeric)
-        r += make_options(opt_hf, [:line], "#{hf.to_s}", :boolean)
-        if options[hf] && options[hf][:content]
-          @hf_tempfiles = [] unless defined?(@hf_tempfiles)
-          @hf_tempfiles.push(tf = WickedPdfTempfile.new("wicked_#{hf}_pdf.html"))
-          tf.write options[hf][:content]
-          tf.flush
-          options[hf][:html] = {}
-          options[hf][:html][:url] = "file:///#{tf.path}"
-        end
-        unless opt_hf[:html].blank?
-          r += make_option("#{hf.to_s}-html", opt_hf[:html][:url]) unless opt_hf[:html][:url].blank?
-        end
+      next if options[hf].blank?
+      opt_hf = options[hf]
+      r += make_options(opt_hf, [:center, :font_name, :left, :right], "#{hf}")
+      r += make_options(opt_hf, [:font_size, :spacing], "#{hf}", :numeric)
+      r += make_options(opt_hf, [:line], "#{hf}", :boolean)
+      if options[hf] && options[hf][:content]
+        @hf_tempfiles = [] unless defined?(@hf_tempfiles)
+        @hf_tempfiles.push(tf = WickedPdfTempfile.new("wicked_#{hf}_pdf.html"))
+        tf.write options[hf][:content]
+        tf.flush
+        options[hf][:html] = {}
+        options[hf][:html][:url] = "file:///#{tf.path}"
+      end
+      unless opt_hf[:html].blank?
+        r += make_option("#{hf}-html", opt_hf[:html][:url]) unless opt_hf[:html][:url].blank?
       end
     end unless options.blank?
     r

data/lib/wicked_pdf/middleware.rb

@@ -1,6 +1,5 @@
 class WickedPdf
   class Middleware
-
     def initialize(app, options = {}, conditions = {})
       @app        = app
       @options    = (WickedPdf.config || {}).merge(options)
@@ -89,6 +88,5 @@ class WickedPdf
     def concat(accepts, type)
       (accepts || '').split(',').unshift(type).compact.join(',')
     end
-
   end
 end

data/lib/wicked_pdf/pdf_helper.rb

@@ -43,15 +43,13 @@ module PdfHelper
 
   def set_basic_auth(options = {})
     options[:basic_auth] ||= WickedPdf.config.fetch(:basic_auth) { false }
-    if options[:basic_auth] && request.env['HTTP_AUTHORIZATION']
-      request.env['HTTP_AUTHORIZATION'].split(' ').last
-    end
+    return unless options[:basic_auth] && request.env['HTTP_AUTHORIZATION']
+    request.env['HTTP_AUTHORIZATION'].split(' ').last
   end
 
   def clean_temp_files
-    if defined?(@hf_tempfiles)
-      @hf_tempfiles.each { |tf| tf.close! }
-    end
+    return unless defined?(@hf_tempfiles)
+    @hf_tempfiles.each(&:close!)
   end
 
   def make_pdf(options = {})
@@ -66,8 +64,8 @@ module PdfHelper
 
   def make_and_send_pdf(pdf_name, options = {})
     options[:wkhtmltopdf] ||= nil
-    options[:layout]      ||= false
-    options[:template]    ||= File.join(controller_path, action_name)
+    options[:layout] ||= false
+    options[:template] ||= File.join(controller_path, action_name)
     options[:disposition] ||= 'inline'
     if options[:show_as_html]
       render_opts = { :template => options[:template], :layout => options[:layout], :formats => options[:formats], :handlers => options[:handlers], :content_type => 'text/html' }
@@ -85,17 +83,16 @@ module PdfHelper
   # to temp files and return a new options hash including the URLs to these files.
   def prerender_header_and_footer(options)
     [:header, :footer].each do |hf|
-      if options[hf] && options[hf][:html] && options[hf][:html][:template]
-        @hf_tempfiles = [] unless defined?(@hf_tempfiles)
-        @hf_tempfiles.push(tf = WickedPdfTempfile.new("wicked_#{hf}_pdf.html"))
-        options[hf][:html][:layout] ||=  options[:layout]
-        render_opts = { :template => options[hf][:html][:template], :layout => options[hf][:html][:layout], :formats => options[hf][:html][:formats], :handlers => options[hf][:html][:handlers] }
-        render_opts.merge!(:locals => options[hf][:html][:locals]) if options[hf][:html][:locals]
-        render_opts.merge!(:file => options[hf][:html][:file]) if options[:file]
-        tf.write render_to_string(render_opts)
-        tf.flush
-        options[hf][:html][:url] = "file:///#{tf.path}"
-      end
+      next unless options[hf] && options[hf][:html] && options[hf][:html][:template]
+      @hf_tempfiles = [] unless defined?(@hf_tempfiles)
+      @hf_tempfiles.push(tf = WickedPdfTempfile.new("wicked_#{hf}_pdf.html"))
+      options[hf][:html][:layout] ||= options[:layout]
+      render_opts = { :template => options[hf][:html][:template], :layout => options[hf][:html][:layout], :formats => options[hf][:html][:formats], :handlers => options[hf][:html][:handlers] }
+      render_opts.merge!(:locals => options[hf][:html][:locals]) if options[hf][:html][:locals]
+      render_opts.merge!(:file => options[hf][:html][:file]) if options[:file]
+      tf.write render_to_string(render_opts)
+      tf.flush
+      options[hf][:html][:url] = "file:///#{tf.path}"
     end
     options
   end

data/lib/wicked_pdf/railtie.rb

@@ -1,12 +1,13 @@
 require 'wicked_pdf/pdf_helper'
 require 'wicked_pdf/wicked_pdf_helper'
+require 'wicked_pdf/wicked_pdf_helper/assets'
 
 if defined?(Rails)
 
   if Rails::VERSION::MAJOR == 3
 
     class WickedRailtie < Rails::Railtie
-      initializer 'wicked_pdf.register' do |app|
+      initializer 'wicked_pdf.register' do |_app|
         ActionController::Base.send :include, PdfHelper
         if Rails::VERSION::MINOR > 0 && Rails.configuration.assets.enabled
           ActionView::Base.send :include, WickedPdfHelper::Assets
@@ -28,7 +29,7 @@ if defined?(Rails)
   else
 
     class WickedRailtie < Rails::Railtie
-      initializer 'wicked_pdf.register' do |app|
+      initializer 'wicked_pdf.register' do |_app|
         ActionController::Base.send :include, PdfHelper
         ActionView::Base.send :include, WickedPdfHelper::Assets
       end

data/lib/wicked_pdf/tempfile.rb

@@ -3,7 +3,7 @@ require 'tempfile'
 class WickedPdfTempfile < Tempfile
   # ensures the Tempfile's filename always keeps its extension
   def initialize(filename, temp_dir = nil)
-    temp_dir  ||= Dir.tmpdir
+    temp_dir ||= Dir.tmpdir
     extension = File.extname(filename)
     basename  = File.basename(filename, extension)
     super([basename, extension], temp_dir)

data/lib/wicked_pdf/version.rb

@@ -1,3 +1,3 @@
 class WickedPdf
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

data/lib/wicked_pdf/wicked_pdf_helper.rb

@@ -1,20 +1,18 @@
-require 'open-uri'
-
 module WickedPdfHelper
   def self.root_path
     String === Rails.root ? Pathname.new(Rails.root) : Rails.root
   end
 
   def self.add_extension(filename, extension)
-    (filename.to_s.split(".").include?(extension) ? filename : "#{filename}.#{extension}")
+    filename.to_s.split('.').include?(extension) ? filename : "#{filename}.#{extension}"
   end
 
   def wicked_pdf_stylesheet_link_tag(*sources)
     css_dir = WickedPdfHelper.root_path.join('public', 'stylesheets')
-    css_text = sources.collect { |source|
+    css_text = sources.collect do |source|
       source = WickedPdfHelper.add_extension(source, 'css')
       "<style type='text/css'>#{File.read(css_dir.join(source))}</style>"
-    }.join("\n")
+    end.join("\n")
     css_text.respond_to?(:html_safe) ? css_text.html_safe : css_text
   end
 
@@ -32,108 +30,4 @@ module WickedPdfHelper
     js_text = sources.collect { |source| wicked_pdf_javascript_src_tag(source, {}) }.join("\n")
     js_text.respond_to?(:html_safe) ? js_text.html_safe : js_text
   end
-
-  module Assets
-    ASSET_URL_REGEX = /url\(['"]?([^'"]+?)['"]?\)/
-
-    def wicked_pdf_stylesheet_link_tag(*sources)
-      stylesheet_contents = sources.collect do |source|
-        source = WickedPdfHelper.add_extension(source, 'css')
-        "<style type='text/css'>#{read_asset(source)}</style>"
-      end.join("\n")
-
-      stylesheet_contents.gsub(ASSET_URL_REGEX) do
-        if Regexp.last_match[1].starts_with?('data:')
-          "url(#{Regexp.last_match[1]})"
-        else
-          "url(#{wicked_pdf_asset_path(Regexp.last_match[1])})"
-        end
-      end.html_safe
-    end
-
-    def wicked_pdf_image_tag(img, options = {})
-      image_tag wicked_pdf_asset_path(img), options
-    end
-
-    def wicked_pdf_javascript_src_tag(jsfile, options = {})
-      jsfile = WickedPdfHelper.add_extension(jsfile, 'js')
-      javascript_include_tag wicked_pdf_asset_path(jsfile), options
-    end
-
-    def wicked_pdf_javascript_include_tag(*sources)
-      sources.collect { |source|
-        source = WickedPdfHelper.add_extension(source, 'js')
-        "<script type='text/javascript'>#{read_asset(source)}</script>"
-      }.join("\n").html_safe
-    end
-
-    def wicked_pdf_asset_path(asset)
-      if (pathname = asset_pathname(asset).to_s) =~ URI_REGEXP
-        pathname
-      else
-        "file:///#{pathname}"
-      end
-    end
-
-    private
-
-    # borrowed from actionpack/lib/action_view/helpers/asset_url_helper.rb
-    URI_REGEXP = %r{^[-a-z]+://|^(?:cid|data):|^//}
-
-    def asset_pathname(source)
-      if precompiled_asset?(source)
-        if (pathname = set_protocol(asset_path(source))) =~ URI_REGEXP
-          # asset_path returns an absolute URL using asset_host if asset_host is set
-          pathname
-        else
-          File.join(Rails.public_path, asset_path(source).sub(/\A#{Rails.application.config.action_controller.relative_url_root}/, ''))
-        end
-      else
-        Rails.application.assets.find_asset(source).pathname
-      end
-    end
-
-    # will prepend a http or default_protocol to a protocol relative URL
-    # or when no protcol is set.
-    def set_protocol(source)
-      protocol = WickedPdf.config[:default_protocol] || 'http'
-      if source[0, 2] == '//'
-        source = [protocol, ':', source].join
-      elsif source[0] != '/' && !source[0, 8].include?('://')
-        source = [protocol, '://', source].join
-      end
-      source
-    end
-
-    def precompiled_asset?(source)
-      Rails.configuration.assets.compile == false || source.to_s[0] == '/'
-    end
-
-    def read_asset(source)
-      if precompiled_asset?(source)
-        if set_protocol(asset_path(source)) =~ URI_REGEXP
-          read_from_uri(source)
-        else
-          IO.read(asset_pathname(source))
-        end
-      else
-        Rails.application.assets.find_asset(source).to_s
-      end
-    end
-
-    def read_from_uri(source)
-      encoding = ':UTF-8' if RUBY_VERSION > '1.8'
-      asset = open(asset_pathname(source), "r#{encoding}") { |f| f.read }
-      asset = gzip(asset) if WickedPdf.config[:expect_gzipped_remote_assets]
-      asset
-    end
-
-    def gzip(asset)
-      stringified_asset = StringIO.new(asset)
-      gzipper = Zlib::GzipReader.new(stringified_asset)
-      gzipped_asset = gzipper.read
-    rescue Zlib::GzipFile::Error
-    end
-
-  end
 end

data/lib/wicked_pdf/wicked_pdf_helper/assets.rb

@@ -0,0 +1,120 @@
+require 'open-uri'
+
+module WickedPdfHelper
+  module Assets
+    ASSET_URL_REGEX = /url\(['"]?([^'"]+?)['"]?\)/
+
+    def wicked_pdf_asset_base64(path)
+      asset = Rails.application.assets.find_asset(path)
+      throw "Could not find asset '#{path}'" if asset.nil?
+      base64 = Base64.encode64(asset.to_s).gsub(/\s+/, '')
+      "data:#{asset.content_type};base64,#{Rack::Utils.escape(base64)}"
+    end
+
+    def wicked_pdf_stylesheet_link_tag(*sources)
+      stylesheet_contents = sources.collect do |source|
+        source = WickedPdfHelper.add_extension(source, 'css')
+        "<style type='text/css'>#{read_asset(source)}</style>"
+      end.join("\n")
+
+      stylesheet_contents.gsub(ASSET_URL_REGEX) do
+        if Regexp.last_match[1].starts_with?('data:')
+          "url(#{Regexp.last_match[1]})"
+        else
+          asset = Regexp.last_match[1]
+          if asset_exists?(asset)
+            "url(#{wicked_pdf_asset_path(asset)})"
+          end
+        end
+      end.html_safe
+    end
+
+    def wicked_pdf_image_tag(img, options = {})
+      image_tag wicked_pdf_asset_path(img), options
+    end
+
+    def wicked_pdf_javascript_src_tag(jsfile, options = {})
+      jsfile = WickedPdfHelper.add_extension(jsfile, 'js')
+      javascript_include_tag wicked_pdf_asset_path(jsfile), options
+    end
+
+    def wicked_pdf_javascript_include_tag(*sources)
+      sources.collect do |source|
+        source = WickedPdfHelper.add_extension(source, 'js')
+        "<script type='text/javascript'>#{read_asset(source)}</script>"
+      end.join("\n").html_safe
+    end
+
+    def wicked_pdf_asset_path(asset)
+      if (pathname = asset_pathname(asset).to_s) =~ URI_REGEXP
+        pathname
+      else
+        "file:///#{pathname}"
+      end
+    end
+
+    private
+
+    # borrowed from actionpack/lib/action_view/helpers/asset_url_helper.rb
+    URI_REGEXP = %r{^[-a-z]+://|^(?:cid|data):|^//}
+
+    def asset_pathname(source)
+      if precompiled_asset?(source)
+        if (pathname = set_protocol(asset_path(source))) =~ URI_REGEXP
+          # asset_path returns an absolute URL using asset_host if asset_host is set
+          pathname
+        else
+          File.join(Rails.public_path, asset_path(source).sub(/\A#{Rails.application.config.action_controller.relative_url_root}/, ''))
+        end
+      else
+        Rails.application.assets.find_asset(source).pathname
+      end
+    end
+
+    # will prepend a http or default_protocol to a protocol relative URL
+    # or when no protcol is set.
+    def set_protocol(source)
+      protocol = WickedPdf.config[:default_protocol] || 'http'
+      if source[0, 2] == '//'
+        source = [protocol, ':', source].join
+      elsif source[0] != '/' && !source[0, 8].include?('://')
+        source = [protocol, '://', source].join
+      end
+      source
+    end
+
+    def precompiled_asset?(source)
+      Rails.configuration.assets.compile == false || source.to_s[0] == '/'
+    end
+
+    def read_asset(source)
+      if precompiled_asset?(source)
+        if set_protocol(asset_path(source)) =~ URI_REGEXP
+          read_from_uri(source)
+        elsif asset_exists?(source)
+          IO.read(asset_pathname(source))
+        end
+      else
+        Rails.application.assets.find_asset(source).to_s
+      end
+    end
+
+    def read_from_uri(source)
+      encoding = ':UTF-8' if RUBY_VERSION > '1.8'
+      asset = open(asset_pathname(source), "r#{encoding}") { |f| f.read }
+      asset = gzip(asset) if WickedPdf.config[:expect_gzipped_remote_assets]
+      asset
+    end
+
+    def gzip(asset)
+      stringified_asset = StringIO.new(asset)
+      gzipper = Zlib::GzipReader.new(stringified_asset)
+      gzipper.read
+    rescue Zlib::GzipFile::Error
+    end
+
+    def asset_exists?(source)
+      Rails.application.assets.find_asset(source).present?
+    end
+  end
+end

data/test/functional/wicked_pdf_helper_assets_test.rb

@@ -2,10 +2,16 @@ require 'test_helper'
 require 'action_view/test_case'
 
 class WickedPdfHelperAssetsTest < ActionView::TestCase
-
   include WickedPdfHelper::Assets
 
   if Rails::VERSION::MAJOR > 3 || (Rails::VERSION::MAJOR == 3 && Rails::VERSION::MINOR > 0)
+    test 'wicked_pdf_asset_base64 returns a base64 encoded asset' do
+      source = File.new('test/fixtures/wicked.css', 'r')
+      destination = Rails.root.join('app', 'assets', 'stylesheets', 'wicked.css')
+      File.open(destination, 'w') { |f| f.write(source) }
+      assert_match /data:text\/css;base64,.+/, wicked_pdf_asset_base64('wicked.css')
+    end
+
     test 'wicked_pdf_asset_path should return a url when assets are served by an asset server' do
       expects(:asset_pathname => 'http://assets.domain.com/dummy.png')
       assert_equal 'http://assets.domain.com/dummy.png', wicked_pdf_asset_path('dummy.png')

data/test/unit/wicked_pdf_test.rb

@@ -95,18 +95,18 @@ class WickedPdfTest < ActiveSupport::TestCase
 
     [:header, :footer].each do |hf|
       [:center, :font_name, :left, :right].each do |o|
-        assert_equal "--#{hf.to_s}-#{o.to_s.gsub('_', '-')} header_footer",
+        assert_equal "--#{hf}-#{o.to_s.gsub('_', '-')} header_footer",
                      wp.get_parsed_options(hf => { o => 'header_footer' }).strip
       end
 
       [:font_size, :spacing].each do |o|
-        assert_equal "--#{hf.to_s}-#{o.to_s.gsub('_', '-')} 12",
+        assert_equal "--#{hf}-#{o.to_s.gsub('_', '-')} 12",
                      wp.get_parsed_options(hf => { o => '12' }).strip
       end
 
-      assert_equal "--#{hf.to_s}-line",
+      assert_equal "--#{hf}-line",
                    wp.get_parsed_options(hf => { :line => true }).strip
-      assert_equal "--#{hf.to_s}-html http://www.abc.com",
+      assert_equal "--#{hf}-html http://www.abc.com",
                    wp.get_parsed_options(hf => { :html => { :url => 'http://www.abc.com' } }).strip
     end
   end
@@ -120,7 +120,8 @@ class WickedPdfTest < ActiveSupport::TestCase
                    wp.get_parsed_options(:toc => { o => 'toc' }).strip
     end
 
-    [:depth, :header_fs, :l1_font_size, :l2_font_size, :l3_font_size, :l4_font_size,
+    [
+      :depth, :header_fs, :l1_font_size, :l2_font_size, :l3_font_size, :l4_font_size,
       :l5_font_size, :l6_font_size, :l7_font_size, :l1_indentation, :l2_indentation,
       :l3_indentation, :l4_indentation, :l5_indentation, :l6_indentation, :l7_indentation
     ].each do |o|
@@ -145,7 +146,7 @@ class WickedPdfTest < ActiveSupport::TestCase
     wp = WickedPdf.new
 
     [:top, :bottom, :left, :right].each do |o|
-      assert_equal "--margin-#{o.to_s} 12", wp.get_parsed_options(:margin => { o => '12' }).strip
+      assert_equal "--margin-#{o} 12", wp.get_parsed_options(:margin => { o => '12' }).strip
     end
   end
 
@@ -155,14 +156,15 @@ class WickedPdfTest < ActiveSupport::TestCase
 
     pathname = Rails.root.join('app', 'views', 'pdf', 'file.html')
     assert_equal "#{cover_option} http://example.org", wp.get_parsed_options(:cover => 'http://example.org').strip, 'URL'
-    assert_equal "#{cover_option} #{pathname.to_s}", wp.get_parsed_options(:cover => pathname).strip, 'Pathname'
+    assert_equal "#{cover_option} #{pathname}", wp.get_parsed_options(:cover => pathname).strip, 'Pathname'
     assert_match /#{cover_option} .+wicked_cover_pdf.+\.html/, wp.get_parsed_options(:cover => '<html><body>HELLO</body></html>').strip, 'HTML'
   end
 
   test 'should parse other options' do
     wp = WickedPdf.new
 
-    [:orientation, :page_size, :proxy, :username, :password, :dpi,
+    [
+      :orientation, :page_size, :proxy, :username, :password, :dpi,
       :encoding, :user_style_sheet
     ].each do |o|
       assert_equal "--#{o.to_s.gsub('_', '-')} opts", wp.get_parsed_options(o => 'opts').strip
@@ -179,7 +181,8 @@ class WickedPdfTest < ActiveSupport::TestCase
       assert_equal "--#{o.to_s.gsub('_', '-')} 5", wp.get_parsed_options(o => 5).strip
     end
 
-    [:book, :default_header, :disable_javascript, :grayscale, :lowquality,
+    [
+      :book, :default_header, :disable_javascript, :grayscale, :lowquality,
       :enable_plugins, :disable_internal_links, :disable_external_links,
       :print_media_type, :disable_smart_shrinking, :use_xserver, :no_background
     ].each do |o|

data/wicked_pdf.gemspec

@@ -21,6 +21,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rails'
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rubocop' if RUBY_VERSION > '1.9.2'
   spec.add_development_dependency 'sqlite3'
   spec.add_development_dependency 'mocha'
   spec.add_development_dependency 'test-unit'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: wicked_pdf
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Miles Z. Sterrett
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-04 00:00:00.000000000 Z
+date: 2015-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -52,6 +52,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -104,7 +118,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
+- CHANGLOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -128,6 +145,7 @@ files:
 - lib/wicked_pdf/tempfile.rb
 - lib/wicked_pdf/version.rb
 - lib/wicked_pdf/wicked_pdf_helper.rb
+- lib/wicked_pdf/wicked_pdf_helper/assets.rb
 - test/fixtures/document_with_long_line.html
 - test/fixtures/wicked.css
 - test/functional/pdf_helper_test.rb