whyvalidationssuckin96 1.6.1 → 1.6.2

data/VERSION

@@ -1 +1 @@
-1.6.1
+1.6.2

data/lib/whyvalidationssuckin96/macros/validates_date.rb

@@ -1,5 +1,6 @@
 require 'whyvalidationssuckin96/skippable_validation'
 require 'whyvalidationssuckin96/attribute_based_validation'
+require 'date'
 
 module WhyValidationsSuckIn96
 

data/lib/whyvalidationssuckin96/validation_support.rb

@@ -88,7 +88,7 @@ module WhyValidationsSuckIn96
         if defined?(@run_with_generic_callbacks)
           @run_with_generic_callbacks
         else
-          @run_with_generic_callbacks = public_instance_methods.include?('run_callbacks')
+          @run_with_generic_callbacks = !public_instance_methods.grep(/run_callbacks/).empty?
         end
       end
 

data/lib/whyvalidationssuckin96/vendor/rfc822.rb

@@ -1,7 +1,8 @@
+# encoding: binary
 #
 # RFC822 Email Address Regex
 # --------------------------
-# 
+#
 # Originally written by Cal Henderson
 # c.f. http://iamcal.com/publish/articles/php/parsing_email/
 #
@@ -9,7 +10,7 @@
 #
 # Licensed under a Creative Commons Attribution-ShareAlike 2.5 License
 # http://creativecommons.org/licenses/by-sa/2.5/
-# 
+#
 module WhyValidationsSuckIn96
   module RFC822
     EmailAddress = begin

data/test/macros/validates_acceptance_test.rb

@@ -3,7 +3,7 @@ require 'teststrap'
 context "validates acceptance" do
   
   should "add a validation macro" do
-    WhyValidationsSuckIn96::ValidationBuilder.instance_methods
+    WhyValidationsSuckIn96::ValidationBuilder.instance_methods.map {|im| im.to_s}
   end.includes('validates_acceptance_of')
   
   context "with some default options" do

data/test/macros/validates_associated_test.rb

@@ -3,7 +3,7 @@ require 'teststrap'
 context "validates associated" do
   
   should "add a validation macro" do
-    WhyValidationsSuckIn96::ValidationBuilder.instance_methods
+    WhyValidationsSuckIn96::ValidationBuilder.instance_methods.map {|im| im.to_s}
   end.includes('validates_associated')
   
   context "with some default options" do

data/test/macros/validates_confirmation_test.rb

@@ -3,7 +3,7 @@ require 'teststrap'
 context "validates confirmation" do
   
   should "add a validation macro" do
-    WhyValidationsSuckIn96::ValidationBuilder.instance_methods
+    WhyValidationsSuckIn96::ValidationBuilder.instance_methods.map {|im| im.to_s}
   end.includes('validates_confirmation_of')
   
   context "with some default options" do

data/test/macros/validates_date_test.rb

@@ -3,7 +3,7 @@ require 'teststrap'
 context "validates date" do
 
   should "add a validation macro" do
-    WhyValidationsSuckIn96::ValidationBuilder.instance_methods
+    WhyValidationsSuckIn96::ValidationBuilder.instance_methods.map {|im| im.to_s}
   end.includes('validates_as_date')
 
   context "with some default options" do

data/test/macros/validates_email_test.rb

@@ -3,7 +3,7 @@ require 'teststrap'
 context "validates email" do
   
   should "add a validation macro" do
-    WhyValidationsSuckIn96::ValidationBuilder.instance_methods
+    WhyValidationsSuckIn96::ValidationBuilder.instance_methods.map {|im| im.to_s}
   end.includes('validates_as_email')
   
   context "with some default options" do

data/test/macros/validates_exclusion_test.rb

@@ -3,7 +3,7 @@ require 'teststrap'
 context "validates exclusion" do
 
   should "add a validation macro" do
-    WhyValidationsSuckIn96::ValidationBuilder.instance_methods
+    WhyValidationsSuckIn96::ValidationBuilder.instance_methods.map {|im| im.to_s}
   end.includes('validates_exclusion_of')
 
   should "raise if an :in option is not given" do

data/test/macros/validates_format_test.rb

@@ -3,7 +3,7 @@ require 'teststrap'
 context "validates format" do
   
   should "add a validation macro" do
-    WhyValidationsSuckIn96::ValidationBuilder.instance_methods
+    WhyValidationsSuckIn96::ValidationBuilder.instance_methods.map {|im| im.to_s}
   end.includes('validates_format_of')
   
   should "raise if a :with option is not given" do

data/test/macros/validates_inclusion_test.rb

@@ -3,7 +3,7 @@ require 'teststrap'
 context "validates inclusion" do
 
   should "add a validation macro" do
-    WhyValidationsSuckIn96::ValidationBuilder.instance_methods
+    WhyValidationsSuckIn96::ValidationBuilder.instance_methods.map {|im| im.to_s}
   end.includes('validates_inclusion_of')
 
   should "raise if an :in option is not given" do

data/test/macros/validates_length_test.rb

@@ -3,7 +3,7 @@ require 'teststrap'
 context "validates length" do
   
   should "add a validation macro" do
-    WhyValidationsSuckIn96::ValidationBuilder.instance_methods
+    WhyValidationsSuckIn96::ValidationBuilder.instance_methods.map {|im| im.to_s}
   end.includes('validates_length_of')
   
   should "raise if an no options are given" do

data/test/macros/validates_numericality_test.rb

@@ -1,115 +1,115 @@
 require 'teststrap'
 
 context "validates numericality" do
-  
+
   should "add a validation macro" do
-    WhyValidationsSuckIn96::ValidationBuilder.instance_methods
+    WhyValidationsSuckIn96::ValidationBuilder.instance_methods.map {|im| im.to_s}
   end.includes('validates_numericality_of')
-  
+
   context "with some default options" do
     setup do
       WhyValidationsSuckIn96::ValidatesNumericality.new(Object.new, :attribute => :number)
     end
-  
+
     should "have a message accessor with a default message" do
       topic.message
     end.equals("is not a numerical value")
   end # with some default options
-  
+
   context "validating an object" do
-    
+
     context "with the default option of :only_integer being false" do
       validatable = OpenStruct.new(:number => 123)
-      
+
       setup do
         WhyValidationsSuckIn96::ValidatesNumericality.new(validatable, :attribute => :number)
       end
-      
+
       should "pass for an actual integer" do
         validatable.number = 30000
         topic.validates?
       end
-      
+
       should "pass for a regular old integer string" do
         validatable.number = "123"
         topic.validates?
       end
-      
+
       should "pass for a valid integer with spaces" do
         validatable.number = "123 456"
         topic.validates?
       end
-      
+
       should "pass for a valid integer with commas" do
         validatable.number = "123,456"
         topic.validates?
       end
-      
+
       should "pass for a valid integer with a positive sign" do
         validatable.number = "+1234"
         topic.validates?
       end
-      
+
       should "pass for a valid integer with a negative sign" do
-        validatable.number "-1234"
+        validatable.number = "-1234"
         topic.validates?
       end
-      
+
       should "fail for an integer with letters" do
         validatable.number = "a1234"
         topic.validates?
       end.equals(false)
-      
+
       should "fail for an integer with other punctuation" do
         validatable.number = "!1234"
         topic.validates?
       end.equals(false)
-      
+
       should "pass for an actual float" do
         validatable.number = 123.45
         topic.validates?
       end
-      
+
       should "pass for a regular old float" do
         validatable.number = "123.456"
         topic.validates?
       end
-      
+
       should "pass for a valid float with spaces" do
         validatable.number = "123 456.10"
         topic.validates?
       end
-      
+
       should "pass for a valid float with commas" do
         validatable.number = "123,456.10"
         topic.validates?
       end
-      
+
       should "pass for a valid float with a positive sign" do
         validatable.number = "+123456.10"
         topic.validates?
       end
-      
+
       should "pass for a valid float with a negative sign" do
         validatable.number = "-123456.10"
         topic.validates?
       end
-      
+
       should "fail for a float with letters other than the exponent" do
         validatable.number = "123z456.10"
         topic.validates?
       end.equals(false)
-      
+
       should "fail for a float with other punctuation" do
         validatable.number = "$123456.10"
         topic.validates?
       end.equals(false)
-      
+
     end # with the default option of :only_integer being false
-    
+
     context "with the :only_integer option being true" do
       validatable = OpenStruct.new(:number => 123)
-      
+
       setup do
         WhyValidationsSuckIn96::ValidatesNumericality.new(validatable, :attribute => :number, :only_integer => true)
       end
@@ -118,12 +118,12 @@ context "validates numericality" do
         validatable.number = 123.456
         topic.validates?
       end.equals(false)
-      
+
       should "allow integer values" do
         validatable.number = 123
         topic.validates?
       end
-      
+
     end # with the :only_integer option being true
   end   # validating an object
 end     # validates numericality

data/test/macros/validates_presence_test.rb

@@ -3,7 +3,7 @@ require 'teststrap'
 context "validates presence" do
   
   should "add a validation macro" do
-    WhyValidationsSuckIn96::ValidationBuilder.instance_methods
+    WhyValidationsSuckIn96::ValidationBuilder.instance_methods.map {|im| im.to_s}
   end.includes('validates_presence_of')
   
   context "validating an object" do

data/test/macros/validates_url_test.rb

@@ -3,7 +3,7 @@ require 'teststrap'
 context "validates url" do
   
   should "add a validation macro" do
-    WhyValidationsSuckIn96::ValidationBuilder.instance_methods
+    WhyValidationsSuckIn96::ValidationBuilder.instance_methods.map {|im| im.to_s}
   end.includes('validates_as_url')
   
   context "with some default options" do

data/test/rails/association_validation_test.rb

@@ -7,105 +7,118 @@ context "association validation" do
       validation_klass == WhyValidationsSuckIn96::ValidatesAssociated && opts[:attribute] == assoc && opts[:on] == :save
     end.nil?
   end
-  
+
+  teardown do
+    next unless topic.kind_of?(Class)
+    Object.send(:remove_const, topic.name)
+  end
+
   context "against has_many" do
     context "with :validate set to true" do
       setup do
-        Class.new(Book) do
+        class ::TestBook < Book
           has_many :chapters, :validate => true
+          self
         end
       end
-      
+
       should "set up an association validation" do
         has_association_validation[topic, :chapters]
       end
     end # with :validate set to true
-    
+
     context "with :validate set to false" do
       setup do
-        Class.new(Book) do
+        class ::TestBook < Book
           has_many :chapters, :validate => false
+          self
         end
       end
-      
+
       should "not set up an association validation" do
         has_association_validation[topic, :chapters]
       end.equals(false)
     end # with :validate set to false
   end   # against has_many
-  
+
   context "against has_and_belongs_to_many" do
     context "with :validate set to true" do
       setup do
-        Class.new(Genre) do
+        class ::TestGenre < Genre
           has_and_belongs_to_many :books, :validate => true
+          self
         end
       end
-      
+
       should "set up an association validation" do
         has_association_validation[topic, :books]
       end
     end # with :validate set to true
-    
+
     context "with :validate set to false" do
       setup do
-        Class.new(Genre) do
+        class ::TestGenre < Genre
           has_and_belongs_to_many :books, :validate => false
+          self
         end
       end
-      
+
       should "not set up an association validation" do
         has_association_validation[topic, :books]
       end.equals(false)
     end # with :validate set to false
   end   # against has_and_belongs_to_many
-  
+
   context "against has_one" do
     context "with :validate set to true" do
       setup do
-        Class.new(Book) do
+        class ::TestBook < Book
           has_one :glossary, :validate => true
+          self
         end
       end
-      
+
       should "set up an association validation" do
         has_association_validation[topic, :glossary]
       end
     end # with :validate set to true
-    
+
     context "with :validate set to false" do
       setup do
-        Class.new(Book) do
+        class ::TestBook < Book
           has_one :glossary, :validate => false
+          self
         end
       end
-      
+
       should "not set up an association validation" do
         has_association_validation[topic, :glossary]
       end.equals(false)
     end # with :validate set to false
   end   # against has_one
-  
+
   context "against belongs_to" do
     context "with :validate set to true" do
       setup do
-        Class.new(Chapter) do
+        class ::TestChapter < Chapter
           belongs_to :book, :validate => true
+          self
         end
       end
-      
+
       should "set up an association validation" do
         has_association_validation[topic, :book]
       end
     end # with :validate set to true
-    
+
     context "with :validate set to false" do
       setup do
-        Class.new(Chapter) do
+        class ::TestChapter < Chapter
           belongs_to :book, :validate => false
+          self
         end
       end
-      
+
       should "not set up an association validation" do
         has_association_validation[topic, :book]
       end.equals(false)

data/test/rails/macros/validates_uniqueness_test.rb

@@ -2,40 +2,46 @@ require 'teststrap'
 require 'rails/active_record_test_helper'
 
 context "validates uniqueness" do
-  
+
   should "add a validation macro" do
-    WhyValidationsSuckIn96::ValidationBuilder.instance_methods
+    WhyValidationsSuckIn96::ValidationBuilder.instance_methods.map {|im| im.to_s}
   end.includes('validates_uniqueness_of')
-  
+
   context "with some default options" do
     setup do
       WhyValidationsSuckIn96::ValidatesUniqueness.new(Object.new, :attribute => :username)
     end
-  
+
     should "have a message accessor with a default message" do
       topic.message
     end.equals("has already been taken")
-    
+
     should "default to being case insensitive" do
       topic.options[:case_sensitive]
     end.equals(false)
-    
+
     should "default :base_class_scope to true" do
       topic.options[:base_class_scope]
     end.equals(true)
   end # with some default options
-  
+
+  teardown do
+    next unless topic.kind_of?(Class)
+    Object.send(:remove_const, topic.name)
+  end
+
   context "validating an object" do
-    
+
     context "with default options" do
       setup do
-        Class.new(VisualWork) do
+        class ::TestVisualWork < VisualWork
           setup_validations do
             validates_uniqueness_of :name
           end
+          self
         end # VisualWork
       end   # setup do
-      
+
       should "mark the second object with the same name as invalid" do
         work = topic.new(:name => "example")
         work.save!
@@ -51,7 +57,7 @@ context "validates uniqueness" do
         other = topic.new(:name => "example two")
         other.valid?
       end
-      
+
       should "not care about case sensitivity by default" do
         work = topic.new(:name => "cAsE SeNsItiViTy")
         work.save!
@@ -60,7 +66,7 @@ context "validates uniqueness" do
           fv.kind_of?(WhyValidationsSuckIn96::ValidatesUniqueness) && fv.attribute == :name
         end
       end
-      
+
       should "allow the one object to be saved twice and not violate the constraint" do
         work = topic.new(:name => "screenshot")
         work.save
@@ -71,10 +77,11 @@ context "validates uniqueness" do
 
     context "uniqueness of integers" do
       setup do
-        Class.new(Chapter) do
+        class ::TestChapter < Chapter
           setup_validations do
             validates_uniqueness_of :number, :scope_to => :book_id
           end
+          self
         end
       end
 
@@ -89,22 +96,23 @@ context "validates uniqueness" do
         end
       end
     end
-    
+
     context "specifying case sensitivity" do
       setup do
-        Class.new(VisualWork) do
+        class ::TestVisualWork < VisualWork
           setup_validations do
             validates_uniqueness_of :name, :case_sensitive => true
           end
+          self
         end # VisualWork
       end   # setup do
-      
+
       should "allow objects with the same name and different case to be valid" do
         work = topic.create!(:name => "CASE SENSITIVE IS TRUE")
         other_work = topic.new(:name => "case sensitive is true")
         other_work.valid?
       end
-      
+
       should "mark the second object with the name in the same case as invalid" do
         work = topic.create(:name => "SO WHAT")
         other_work = topic.new(:name => "SO WHAT")
@@ -113,14 +121,14 @@ context "validates uniqueness" do
         end
       end
     end # specifying case sensitivity
-    
+
     context "specifying base class scope" do
       context "as false" do
         should "allow records to be created in different subclasses that violate the uniqueness" do
           Painting.create!(:name => "painting one", :author => "humbug")
           Photograph.new(:name => "photo one", :author => "humbug").valid?
-        end 
-        
+        end
+
         should "not allow records to be created in the same class that violate the uniqueness" do
           Photograph.create!(:name => "photo one", :author => "gus")
           photo = Photograph.new(:name => "photo two", :author => "gus")
@@ -129,7 +137,7 @@ context "validates uniqueness" do
           end
         end
       end # as false
-      
+
       context "as true" do
         should "not allow records to be created that violate a uniqueness constraint based on the base class" do
           VisualWork.create!(:name => "mspaint", :author => "dan")
@@ -138,21 +146,21 @@ context "validates uniqueness" do
             fv.kind_of?(WhyValidationsSuckIn96::ValidatesUniqueness) && fv.attribute == :author
           end
         end
-        
+
         should "allow records to be created that don't violate the uniqueness constraint" do
           VisualWork.create!(:name => "photoshop", :author => "alex")
           Painting.create!(:name => "paintshop", :author => "evan")
         end
       end # as true
     end   # specifying base class scope
-    
+
     context "specifying scope options" do
       should "pass when uniqueness is valid against the given scope column" do
         Collage.create!(:name => "wired snippets", :author => "dan")
         work = Collage.new(:name => "wired snippets", :author => "gabe")
         work.valid?
       end
-      
+
       should "fail when uniqueness is invalid against the given scope column" do
         Collage.create!(:name => "rolling stone snippets", :author => "gabe")
         work = Collage.new(:name => "rolling stone snippets", :author => "gabe")
@@ -161,7 +169,7 @@ context "validates uniqueness" do
         end
       end
     end # specifying scope options
-    
+
     context "when using with_scope" do
       should "basically just ignore with_scope" do
         Painting.create!(:author => "fred", :name => "bbzzzt")

data/test/validation_test.rb

@@ -15,7 +15,7 @@ context "validation" do
     end.equals(:validates_rockingness)
 
     should "define validate as private on the new subclass" do
-      topic.private_instance_methods
+      topic.private_instance_methods.map {|im| im.to_s}
     end.includes("validate")
   end # creating a new subclass
 

data/whyvalidationssuckin96.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{whyvalidationssuckin96}
-  s.version = "1.6.1"
+  s.version = "1.6.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["gabrielg", "douglasmeyer"]
-  s.date = %q{2010-03-09}
+  s.date = %q{2010-03-17}
   s.description = %q{A library for setting up model validations, such as in ActiveRecord.}
   s.email = %q{gabriel.gironda@gmail.com}
   s.extra_rdoc_files = [
@@ -126,7 +126,7 @@ Gem::Specification.new do |s|
   s.homepage = %q{http://github.com/thumblemonks/whyvalidationssuckin96}
   s.rdoc_options = ["--charset=UTF-8"]
   s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.3.5}
+  s.rubygems_version = %q{1.3.6}
   s.summary = %q{An alternative implementation of object validations.}
   s.test_files = [
     "test/attribute_based_validation_test.rb",

metadata

@@ -1,7 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: whyvalidationssuckin96
 version: !ruby/object:Gem::Version 
-  version: 1.6.1
+  prerelease: false
+  segments: 
+  - 1
+  - 6
+  - 2
+  version: 1.6.2
 platform: ruby
 authors: 
 - gabrielg
@@ -10,39 +15,47 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-09 00:00:00 -06:00
+date: 2010-03-17 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: riot
-  type: :development
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 0
         version: "0"
-    version: 
+  type: :development
+  version_requirements: *id001
 - !ruby/object:Gem::Dependency 
   name: yard
-  type: :development
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 0
         version: "0"
-    version: 
+  type: :development
+  version_requirements: *id002
 - !ruby/object:Gem::Dependency 
   name: activerecord
-  type: :development
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 2
+        - 3
+        - 0
         version: 2.3.0
-    version: 
+  type: :development
+  version_requirements: *id003
 description: A library for setting up model validations, such as in ActiveRecord.
 email: gabriel.gironda@gmail.com
 executables: []
@@ -171,18 +184,20 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.5
+rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
 summary: An alternative implementation of object validations.