whyvalidationssuckin96 1.6.0 → 1.6.1

data/VERSION

@@ -1 +1 @@
-1.6.0
+1.6.1

data/lib/whyvalidationssuckin96/attribute_based_validation.rb

@@ -43,9 +43,12 @@ module WhyValidationsSuckIn96
     # Performs the validation, returning true or false if the validation passes or fails,
     # or nil if the validation will not run.
     # @return [true, false, nil]
+    #
+    # @todo - this method is uuuuuuuugly
     def validates?
       if options[:array]
         return @passed = nil if skip_on_empty?
+        return @passed = false if !skip_on_empty? && Array(validatable.send(options[:attribute])).empty?
         reset
         @pos = 0
         statuses = []

data/test/attribute_based_validation_test.rb

@@ -86,6 +86,11 @@ context "attribute based validation mixin" do
         first_failed && inst.validates?
       end
 
+      should "fail if allow_empty is false and the collection is empty" do
+        inst = topic.new(OpenStruct.new(:test => []), :attribute => :test, :array => true, :allow_empty => false)
+        inst.validates?
+      end.equals(false)
+
       context "with :allow_empty" do
         should "skip validation if the array is empty" do
           inst = topic.new(OpenStruct.new(:test => []), :allow_empty => true, :attribute => :test, :array => true)

data/whyvalidationssuckin96.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{whyvalidationssuckin96}
-  s.version = "1.6.0"
+  s.version = "1.6.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["gabrielg", "douglasmeyer"]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: whyvalidationssuckin96
 version: !ruby/object:Gem::Version 
-  version: 1.6.0
+  version: 1.6.1
 platform: ruby
 authors: 
 - gabrielg