whyvalidationssuckin96 1.2.3 → 1.3.0

data/VERSION

@@ -1 +1 @@
-1.2.3
+1.3.0

data/lib/whyvalidationssuckin96/validation_collection.rb

@@ -0,0 +1,16 @@
+module WhyValidationsSuckIn96
+  class ValidationCollection < Array
+
+    def to_json(options={})
+      inject({}) do |acc,validation|
+        acc[validation.attribute] = validation.options
+        acc
+      end.to_json(options)
+    end
+
+    def select(&block)
+      self.class.new super
+    end
+
+  end
+end

data/lib/whyvalidationssuckin96/validation_support.rb

@@ -1,4 +1,5 @@
 require 'whyvalidationssuckin96/validation_builder'
+require 'whyvalidationssuckin96/validation_collection'
 
 module WhyValidationsSuckIn96
   module ValidationSupport
@@ -43,8 +44,9 @@ module WhyValidationsSuckIn96
       # An array of instances of all validations for this object
       # @return [Array]
       def all_validations
-        @all_validations ||= self.class.validation_collection.collect do |(vc,opts)|
-          vc.new(self, opts)
+        @all_validations ||= self.class.validation_collection.inject(ValidationCollection.new) do |vc, (v,opts)|
+          vc << v.new(self, opts)
+          vc
         end
       end
       
@@ -72,4 +74,4 @@ module WhyValidationsSuckIn96
       
     end # ClassMethods
   end   # ValidationSupport
-end     # WhyValidationsSuckIn96
+end     # WhyValidationsSuckIn96

data/test/validation_collection_test.rb

@@ -0,0 +1,63 @@
+require 'teststrap'
+require 'active_support'
+
+context "validation_collection" do
+  context "to_json" do
+    setup do
+      @validation_options = { :is => 3 }
+      @collection = WhyValidationsSuckIn96::ValidationCollection.new
+      @collection << WhyValidationsSuckIn96::ValidatesLength.new(Object.new, { :attribute => :thing }.merge(@validation_options))
+      ActiveSupport::JSON.decode(@collection.to_json)
+    end
+
+    should "have keys for each attribute that is validated" do
+      topic.keys
+    end.equals(['thing'])
+
+    should "not have a value that is the attribute name" do
+      !topic['thing'].keys.include? 'thing'
+    end
+
+    should "have a message value that is the validation's message" do
+      topic['thing']['message'] == @collection.first.message
+    end
+
+    should "have values of the validation options" do
+      @validation_options.all? {|option,value| topic['thing'][option.to_s] == value }
+    end
+
+    context "provided a hash of options" do
+      setup do
+        @collection << WhyValidationsSuckIn96::ValidatesNumericality.new(Object.new, { :attribute => :other_thing })
+        ActiveSupport::JSON.decode(@collection.to_json(:only => :thing))
+      end
+
+      should "respect those options when generating json" do
+        topic.keys == ['thing']
+      end
+    end
+
+    context "selecting a subset" do
+      setup do
+        @collection << WhyValidationsSuckIn96::ValidatesNumericality.new(Object.new, { :attribute => :other_thing })
+        @collection.select { |v| v.attribute == :thing }
+      end
+
+      should "return a ValidationCollection" do
+        topic.instance_of? WhyValidationsSuckIn96::ValidationCollection
+      end
+    end
+
+    context "rejecting a subset" do
+      setup do
+        @collection << WhyValidationsSuckIn96::ValidatesNumericality.new(Object.new, { :attribute => :other_thing })
+        @collection.reject { |v| v.attribute == :thing }
+      end
+
+      should "return a ValidationCollection" do
+        topic.instance_of? WhyValidationsSuckIn96::ValidationCollection
+      end
+    end
+
+  end
+end

data/test/validation_support_test.rb

@@ -34,6 +34,10 @@ context "validation_support" do
       topic.new
     end.respond_to(:all_validations)
     
+    should "have a ValidationCollection for all_validations" do
+      topic.new.all_validations.instance_of?(WhyValidationsSuckIn96::ValidationCollection)
+    end
+
     should "have an empty validation collection" do
       topic.validation_collection.size
     end.equals(0)

data/whyvalidationssuckin96.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{whyvalidationssuckin96}
-  s.version = "1.2.3"
+  s.version = "1.3.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["gabrielg", "douglasmeyer"]
-  s.date = %q{2009-12-22}
+  s.date = %q{2010-01-15}
   s.description = %q{A library for setting up model validations, such as in ActiveRecord.}
   s.email = %q{gabriel.gironda@gmail.com}
   s.extra_rdoc_files = [
@@ -91,6 +91,7 @@ Gem::Specification.new do |s|
      "lib/whyvalidationssuckin96/skippable_validation.rb",
      "lib/whyvalidationssuckin96/validation.rb",
      "lib/whyvalidationssuckin96/validation_builder.rb",
+     "lib/whyvalidationssuckin96/validation_collection.rb",
      "lib/whyvalidationssuckin96/validation_support.rb",
      "test/attribute_based_validation_test.rb",
      "test/macros/validates_acceptance_test.rb",
@@ -110,6 +111,7 @@ Gem::Specification.new do |s|
      "test/skippable_validation_test.rb",
      "test/teststrap.rb",
      "test/validation_builder_test.rb",
+     "test/validation_collection_test.rb",
      "test/validation_support_test.rb",
      "test/validation_test.rb",
      "whyvalidationssuckin96.gemspec"
@@ -138,6 +140,7 @@ Gem::Specification.new do |s|
      "test/skippable_validation_test.rb",
      "test/teststrap.rb",
      "test/validation_builder_test.rb",
+     "test/validation_collection_test.rb",
      "test/validation_support_test.rb",
      "test/validation_test.rb"
   ]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: whyvalidationssuckin96
 version: !ruby/object:Gem::Version 
-  version: 1.2.3
+  version: 1.3.0
 platform: ruby
 authors: 
 - gabrielg
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-12-22 00:00:00 -06:00
+date: 2010-01-15 00:00:00 -06:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -127,6 +127,7 @@ files:
 - lib/whyvalidationssuckin96/skippable_validation.rb
 - lib/whyvalidationssuckin96/validation.rb
 - lib/whyvalidationssuckin96/validation_builder.rb
+- lib/whyvalidationssuckin96/validation_collection.rb
 - lib/whyvalidationssuckin96/validation_support.rb
 - test/attribute_based_validation_test.rb
 - test/macros/validates_acceptance_test.rb
@@ -146,6 +147,7 @@ files:
 - test/skippable_validation_test.rb
 - test/teststrap.rb
 - test/validation_builder_test.rb
+- test/validation_collection_test.rb
 - test/validation_support_test.rb
 - test/validation_test.rb
 - whyvalidationssuckin96.gemspec
@@ -196,5 +198,6 @@ test_files:
 - test/skippable_validation_test.rb
 - test/teststrap.rb
 - test/validation_builder_test.rb
+- test/validation_collection_test.rb
 - test/validation_support_test.rb
 - test/validation_test.rb