where_exists 0.9.2 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5779b5deb8c1a1c9bcc4685a636f537a0771352a
-  data.tar.gz: 40e44d5113bd916717ac8d2e2e8aa9a8c621075d
+  metadata.gz: b7c13e66fd0af529abc8be142a7f93a19bd711f3
+  data.tar.gz: ade84d5322c10bbac3e23d09eb8db75bfacb4c45
 SHA512:
-  metadata.gz: a00a2b3f908457473c4347071d19e83c0f7e0b258ee3355ef02b3f07801a066382de7cb4b58d878eaee257a480b1589f0703041804cb61490443d135765ca35a
-  data.tar.gz: b00c7dc5fed3bef71965296ad320a81d8d12d9f161d6cd2e4b8d98ccf72bdb659e146e31da74fc0c3c70dfb15cb3dc90eb293d78b849466993272071980ebc13
+  metadata.gz: 742c790c391f2ca6ce2104c912bc3ec957f20cc60d58c7342e3075e166012ec7c88de7336d10180e4c9bd67d84e7115a828c05d419c8a2c5cc8a06bc88a34192
+  data.tar.gz: 919c4d93e016f39c49cadf80d123e3301305c186cec36cc0e6f38cf95cbe6f9e03233960a093b5d61c4b579ef8973f9e0351632eb1dcd6806522defd40e3e61d

data/lib/where_exists/version.rb

@@ -1,3 +1,3 @@
 module WhereExists
-  VERSION = "0.9.2"
+  VERSION = "1.0.0"
 end

data/test/belongs_to_polymorphic_test.rb

@@ -8,25 +8,25 @@ ActiveRecord::Migration.create_table :second_polymorphic_entities, :force => tru
   t.string :name
 end
 
-ActiveRecord::Migration.create_table :polymorphic_children, :force => true do |t|
+ActiveRecord::Migration.create_table :belongs_to_polymorphic_children, :force => true do |t|
   t.integer :polymorphic_entity_id
   t.string :polymorphic_entity_type
   t.string :name
 end
 
-class PolymorphicChild < ActiveRecord::Base
+class BelongsToPolymorphicChild < ActiveRecord::Base
   belongs_to :polymorphic_entity, polymorphic: true
 end
 
 class FirstPolymorphicEntity < ActiveRecord::Base
-  has_many :children, as: :polymorphic_entity, class_name: PolymorphicChild
+  has_many :children, as: :polymorphic_entity, class_name: BelongsToPolymorphicChild
 end
 
 class SecondPolymorphicEntity < ActiveRecord::Base
-  has_many :children, as: :polymorphic_entity, class_name: PolymorphicChild
+  has_many :children, as: :polymorphic_entity, class_name: BelongsToPolymorphicChild
 end
 
-class BelongsToPolymorphicTest < Minitest::Unit::TestCase
+class BelongsToPolymorphicTest < Minitest::Test
   def setup
     ActiveRecord::Base.descendants.each(&:delete_all)
   end
@@ -36,12 +36,12 @@ class BelongsToPolymorphicTest < Minitest::Unit::TestCase
     second_entity = SecondPolymorphicEntity.create!
     second_entity.update_column(:id, first_entity.id + 1)
 
-    first_child = PolymorphicChild.create!(polymorphic_entity: first_entity)
-    second_child = PolymorphicChild.create!(polymorphic_entity: second_entity)
-    really_orphaned_child = PolymorphicChild.create!(polymorphic_entity_type: 'FirstPolymorphicEntity', polymorphic_entity_id: second_entity.id)
-    another_really_orphaned_child = PolymorphicChild.create!(polymorphic_entity_type: 'SecondPolymorphicEntity', polymorphic_entity_id: first_entity.id)
+    first_child = BelongsToPolymorphicChild.create!(polymorphic_entity: first_entity)
+    second_child = BelongsToPolymorphicChild.create!(polymorphic_entity: second_entity)
+    _really_orphaned_child = BelongsToPolymorphicChild.create!(polymorphic_entity_type: 'FirstPolymorphicEntity', polymorphic_entity_id: second_entity.id)
+    _another_really_orphaned_child = BelongsToPolymorphicChild.create!(polymorphic_entity_type: 'SecondPolymorphicEntity', polymorphic_entity_id: first_entity.id)
 
-    result = PolymorphicChild.where_exists(:polymorphic_entity)
+    result = BelongsToPolymorphicChild.where_exists(:polymorphic_entity)
 
     assert_equal 2, result.length
     assert_equal [first_child, second_child].map(&:id).sort, result.map(&:id).sort
@@ -52,12 +52,12 @@ class BelongsToPolymorphicTest < Minitest::Unit::TestCase
     second_entity = SecondPolymorphicEntity.create!
     second_entity.update_column(:id, first_entity.id + 1)
 
-    first_child = PolymorphicChild.create!(polymorphic_entity: first_entity)
-    orphaned_child = PolymorphicChild.create!(polymorphic_entity_id: second_entity.id, polymorphic_entity_type: 'FirstPolymorphicEntity')
+    _first_child = BelongsToPolymorphicChild.create!(polymorphic_entity: first_entity)
+    orphaned_child = BelongsToPolymorphicChild.create!(polymorphic_entity_id: second_entity.id, polymorphic_entity_type: 'FirstPolymorphicEntity')
 
-    result = PolymorphicChild.where_not_exists(:polymorphic_entity)
+    result = BelongsToPolymorphicChild.where_not_exists(:polymorphic_entity)
 
     assert_equal 1, result.length
     assert_equal orphaned_child.id, result.first.id
   end
-end
+end

data/test/belongs_to_test.rb

@@ -1,49 +1,49 @@
 require 'test_helper'
 
-ActiveRecord::Migration.create_table :simple_entities, :force => true do |t|
+ActiveRecord::Migration.create_table :belongs_to_simple_entities, :force => true do |t|
   t.string :name
   t.integer :my_id
 end
 
-ActiveRecord::Migration.create_table :simple_entity_children, :force => true do |t|
+ActiveRecord::Migration.create_table :belongs_to_simple_entity_children, :force => true do |t|
   t.integer :parent_id
   t.string :name
 end
 
-class SimpleEntity < ActiveRecord::Base
-  has_many :simple_entity_children, primary_key: :my_id, foreign_key: :parent_id
+class BelongsToSimpleEntity < ActiveRecord::Base
+  has_many :simple_entity_children, primary_key: :my_id, foreign_key: :parent_id, class_name: "BelongsToSimpleEntityChild"
 end
 
-class SimpleEntityChild < ActiveRecord::Base
-  belongs_to :simple_entity, foreign_key: :parent_id, primary_key: :my_id
+class BelongsToSimpleEntityChild < ActiveRecord::Base
+  belongs_to :simple_entity, foreign_key: :parent_id, primary_key: :my_id, class_name: "BelongsToSimpleEntity"
 end
 
-class BelongsToTest < Minitest::Unit::TestCase
+class BelongsToTest < Minitest::Test
   def setup
     ActiveRecord::Base.descendants.each(&:delete_all)
   end
 
   def test_nil_foreign_key
-    entity = SimpleEntity.create!(my_id: 999)
+    _entity = BelongsToSimpleEntity.create!(my_id: 999)
 
-    child = SimpleEntityChild.create!(parent_id: 999)
-    orphaned_child = SimpleEntityChild.create!(parent_id: nil)
+    child = BelongsToSimpleEntityChild.create!(parent_id: 999)
+    _orphaned_child = BelongsToSimpleEntityChild.create!(parent_id: nil)
 
-    result = SimpleEntityChild.where_exists(:simple_entity)
+    result = BelongsToSimpleEntityChild.where_exists(:simple_entity)
 
     assert_equal 1, result.length
     assert_equal result.first.id, child.id
   end
 
   def test_not_existing_foreign_object
-    entity = SimpleEntity.create!(my_id: 999)
+    _entity = BelongsToSimpleEntity.create!(my_id: 999)
 
-    child = SimpleEntityChild.create!(parent_id: 999)
-    orphaned_child = SimpleEntityChild.create!(parent_id: 500)
+    child = BelongsToSimpleEntityChild.create!(parent_id: 999)
+    _orphaned_child = BelongsToSimpleEntityChild.create!(parent_id: 500)
 
-    result = SimpleEntityChild.where_exists(:simple_entity)
+    result = BelongsToSimpleEntityChild.where_exists(:simple_entity)
 
     assert_equal 1, result.length
     assert_equal result.first.id, child.id
   end
-end
+end

data/test/documentation_test.rb

@@ -29,7 +29,7 @@ class Connection < ActiveRecord::Base
   belongs_to :group
 end
 
-class DocumentationTest < Minitest::Unit::TestCase
+class DocumentationTest < Minitest::Test
   def setup
     ActiveRecord::Base.descendants.each(&:delete_all)
   end
@@ -37,9 +37,9 @@ class DocumentationTest < Minitest::Unit::TestCase
   def test_readme
     group1 = Group.create!(name: 'first')
     group2 = Group.create!(name: 'second')
-    group3 = Group.create!(name: 'third')
+    _group3 = Group.create!(name: 'third')
 
-    group4 = Group.create!(name: 'fourth')
+    _group4 = Group.create!(name: 'fourth')
     group5 = Group.create!(name: 'fifth')
     group6 = Group.create!(name: 'sixth')
 
@@ -67,4 +67,4 @@ class DocumentationTest < Minitest::Unit::TestCase
     assert_equal 1, result.length
     assert_equal user4.id, result.first.id
   end
-end
+end

data/test/has_many_polymorphic_test.rb

@@ -8,37 +8,37 @@ ActiveRecord::Migration.create_table :irrelevant_polymorphic_entities, :force =>
   t.string :name
 end
 
-ActiveRecord::Migration.create_table :polymorphic_children, :force => true do |t|
-  t.integer :polymorphic_entity_id
-  t.string :polymorphic_entity_type
+ActiveRecord::Migration.create_table :has_many_polymorphic_children, :force => true do |t|
+  t.integer :polymorphic_thing_id
+  t.string :polymorphic_thing_type
   t.string :name
 end
 
-class PolymorphicChild < ActiveRecord::Base
-  belongs_to :polymorphic_entity, polymorphic: true
+class HasManyPolymorphicChild < ActiveRecord::Base
+  belongs_to :polymorphic_thing, polymorphic: true
 end
 
 class RelevantPolymorphicEntity < ActiveRecord::Base
-  has_many :children, as: :polymorphic_entity, class_name: PolymorphicChild
+  has_many :children, as: :polymorphic_thing, class_name: HasManyPolymorphicChild
 end
 
 class IrrelevantPolymorphicEntity < ActiveRecord::Base
-  has_many :children, as: :polymorphic_entity, class_name: PolymorphicChild
+  has_many :children, as: :polymorphic_thing, class_name: HasManyPolymorphicChild
 end
 
-class HasManyPolymorphicTest < Minitest::Unit::TestCase
+class HasManyPolymorphicTest < Minitest::Test
   def setup
     ActiveRecord::Base.descendants.each(&:delete_all)
   end
 
   def test_polymorphic
-    child = PolymorphicChild.create!
+    child = HasManyPolymorphicChild.create!
 
     irrelevant_entity = IrrelevantPolymorphicEntity.create!(children: [child])
-    relevant_entity = RelevantPolymorphicEntity.create!(id: irrelevant_entity.id)
+    _relevant_entity = RelevantPolymorphicEntity.create!(id: irrelevant_entity.id)
 
     result = RelevantPolymorphicEntity.where_exists(:children)
 
     assert_equal 0, result.length
   end
-end
+end

data/test/has_many_test.rb

@@ -18,7 +18,7 @@ class SimpleEntityChild < ActiveRecord::Base
   belongs_to :simple_entity, foreign_key: :parent_id
 end
 
-class HasManyTest < Minitest::Unit::TestCase
+class HasManyTest < Minitest::Test
   def setup
     ActiveRecord::Base.descendants.each(&:delete_all)
   end
@@ -26,7 +26,7 @@ class HasManyTest < Minitest::Unit::TestCase
   def test_without_parameters
     child = SimpleEntityChild.create!
 
-    blank_entity = SimpleEntity.create!(my_id: 999)
+    _blank_entity = SimpleEntity.create!(my_id: 999)
     filled_entity = SimpleEntity.create!(simple_entity_children: [child], my_id: 500)
 
     result = SimpleEntity.where_exists(:simple_entity_children)
@@ -39,8 +39,8 @@ class HasManyTest < Minitest::Unit::TestCase
     wrong_child = SimpleEntityChild.create!(name: 'wrong')
     child = SimpleEntityChild.create!(name: 'right')
 
-    blank_entity = SimpleEntity.create!(my_id: 999)
-    wrong_entity = SimpleEntity.create!(simple_entity_children: [wrong_child], my_id: 500)
+    _blank_entity = SimpleEntity.create!(my_id: 999)
+    _wrong_entity = SimpleEntity.create!(simple_entity_children: [wrong_child], my_id: 500)
     entity = SimpleEntity.create!(name: 'this field is irrelevant', simple_entity_children: [child], my_id: 300)
 
     result = SimpleEntity.where_exists(:simple_entity_children, name: 'right')
@@ -63,7 +63,7 @@ class HasManyTest < Minitest::Unit::TestCase
     child = SimpleEntityChild.create!
 
     blank_entity = SimpleEntity.create!(my_id: 999)
-    filled_entity = SimpleEntity.create!(simple_entity_children: [child], my_id: 500)
+    _filled_entity = SimpleEntity.create!(simple_entity_children: [child], my_id: 500)
 
     result = SimpleEntity.where_not_exists(:simple_entity_children)
 

data/test/has_many_through_test.rb

@@ -44,7 +44,7 @@ end
 
 # Invoices ->  LineItems <- Tasks <- Project
 
-class HasManyThroughTest < Minitest::Unit::TestCase
+class HasManyThroughTest < Minitest::Test
   def setup
     ActiveRecord::Base.descendants.each(&:delete_all)
   end
@@ -56,8 +56,8 @@ class HasManyThroughTest < Minitest::Unit::TestCase
     task = Task.create!(project: project)
     irrelevant_task = Task.create!(project: irrelevant_project)
 
-    line_item = LineItem.create!(name: 'relevant', task: task)
-    irrelevant_line_item = LineItem.create!(name: 'irrelevant', task: irrelevant_task)
+    _line_item = LineItem.create!(name: 'relevant', task: task)
+    _irrelevant_line_item = LineItem.create!(name: 'irrelevant', task: irrelevant_task)
 
     result = Project.where_exists(:project_line_items, name: 'relevant')
 
@@ -79,8 +79,8 @@ class HasManyThroughTest < Minitest::Unit::TestCase
     invoice = Invoice.create!(name: 'relevant')
     irrelevant_invoice = Invoice.create!(name: 'irrelevant')
 
-    line_item = LineItem.create!(task: task, invoice: invoice)
-    irrelevant_line_item = LineItem.create!(task: irrelevant_task, invoice: irrelevant_invoice)
+    _line_item = LineItem.create!(task: task, invoice: invoice)
+    _irrelevant_line_item = LineItem.create!(task: irrelevant_task, invoice: irrelevant_invoice)
 
     result = Project.where_exists(:invoices, name: 'relevant')
 
@@ -92,4 +92,4 @@ class HasManyThroughTest < Minitest::Unit::TestCase
     assert_equal 1, result.length
     assert_equal irrelevant_project.id, result.first.id
   end
-end
+end

metadata

@@ -1,35 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: where_exists
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 1.0.0
 platform: ruby
 authors:
 - Eugene Zolotarev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-01 00:00:00.000000000 Z
+date: 2017-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
         version: 3.2.22
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
         version: 3.2.22
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '6'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -44,6 +44,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Rails way to harness the power of SQL "EXISTS" statement
 email:
 - eugzol@gmail.com
@@ -83,16 +97,16 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.4
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: "#where_exists extension of ActiveRecord"
 test_files:
-- test/belongs_to_polymorphic_test.rb
-- test/belongs_to_test.rb
 - test/db/test.db
+- test/belongs_to_test.rb
 - test/documentation_test.rb
+- test/test_helper.rb
 - test/has_many_polymorphic_test.rb
+- test/belongs_to_polymorphic_test.rb
 - test/has_many_test.rb
 - test/has_many_through_test.rb
-- test/test_helper.rb