whatsa 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7ac4a4382455cb767f687b48ee577cfbea776f34
-  data.tar.gz: ee220697878ad879a70bac12da3eb7dd84f54a2c
+  metadata.gz: aef97bd6c6bbcfbff00e5fe88ab1e6715de035cb
+  data.tar.gz: 4816a33391219a2d92081be925269db130733096
 SHA512:
-  metadata.gz: 02c69d6cc696b0e5d8b185de1b0634a335bf154660ed6d31790b03a4e891b5fe8cc3e9959743581c570d1a8206856f6c220348b921d08b5334586126ee12989f
-  data.tar.gz: 372691d81e21c453a06c37c5cc6365641cdc3922f3375c2e908cabda78d215e7a85afa9fe369877f903cbba13c79e5847a12accac1e4f09db7ac7a333febf2c4
+  metadata.gz: 9661681f7cde6a9b5b17807a2a908e18c0eab23a0b053a3a4c4f7cecfcd77ef2401bb3341af3840cc70b6ebf831f7ce5bbc89709b319cbca4514f91cc2e629f5
+  data.tar.gz: 87d9ba1a98bb9347d8aef6d369009f0303c096d3d4b31bcfcb2387c56c0f77021aad0f61ff3aaa1e89a5c0d20ae1b75da9d5e23f3f43694868e6f489cd9b6a2e

data/lib/whatsa/article.rb

@@ -6,6 +6,10 @@ class Whatsa::Article
     @title = noko_doc.css('h1').text
     @contents = noko_doc.css('#mw-content-text').children
     @sections = make_sections
+
+    # comment out the next line if you want sections with non-<p> and non-<ul>
+    # content to display as "[no displayable information]"
+    remove_empty_sections
   end
 
   def summary
@@ -50,8 +54,10 @@ class Whatsa::Article
     secs = [Whatsa::Section.new("#{self.title} - Introduction", intro_pars)]
     indices.each_cons(2) do |i, j|
       title = self.contents[i].text.gsub('[edit]', '').strip
-      par_nodes = self.contents[i...j].select { |e| e.name == 'p' && e.text != "" }
-      pars = par_nodes.map { |par| par.text }
+      par_nodes = self.contents[i...j].select do |e|
+        e.name == 'p' || e.name == 'ul' && e.text != ""
+      end
+      pars = par_nodes.map { |par| par.text.strip }
       secs << Whatsa::Section.new(title, pars).tap { |s| s.article = self }
     end
     secs
@@ -64,4 +70,8 @@ class Whatsa::Article
     end
     indices
   end
+
+  def remove_empty_sections
+    self.sections.reject! { |sec| sec.summary == "[no displayable information]" }
+  end
 end

data/lib/whatsa/section.rb

@@ -5,6 +5,7 @@ class Whatsa::Section
     @title = title
     @paragraphs = paragraphs
     remove_citations
+    bullet_list_pars
   end
 
   def summary
@@ -21,4 +22,8 @@ class Whatsa::Section
     self.paragraphs.map! { |par| par.gsub(/\[(\d+|citation needed)\]/, "") }
   end
 
+  def bullet_list_pars
+    self.paragraphs.map! { |par| par.index("\n") ? par.gsub(/^/, "- ") : par }
+  end
+
 end

data/lib/whatsa/version.rb

@@ -1,3 +1,3 @@
 module Whatsa
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

data/spec.md

@@ -0,0 +1,6 @@
+# Specifications for the CLI Assessment
+
+Specs:
+- [x] Have a CLI for interfacing with the application (You can access Whatsa by running the command `whatsa` after installing it, then follow the on-screen instructions in your terminal to interact. The rest is explained in the README.)
+- [x] Pull data from an external source (This application pulls data from articles, disambiguation pages, and search results pages on Wikipedia.org)
+- [x] Implement both list and detail views (If you make a query that is ambiguous, the app will present a list to you, from which you can select a choice by number or name. If you wish to read from a specific category/section of an article, you can type `other` and it will present a similarly-selectable list of sections. Once you get to an article or a section, it will display its summary, and if you'd like more, you can ask for that too.)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: whatsa
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Keegan Leitz
@@ -93,6 +93,7 @@ files:
 - lib/whatsa/scraper.rb
 - lib/whatsa/section.rb
 - lib/whatsa/version.rb
+- spec.md
 - whatsa.gemspec
 homepage: https://github.com/kjleitz/whatsa
 licenses: