what_weve_got_here_is_an_error_to_communicate 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f9ff0e4e8188c71874623d5b7f91c3b1628c733c
-  data.tar.gz: aa5acc32a411201dc00d52ebf551b533a36d85fc
+  metadata.gz: db03e1ff78b344563fa7bda3ae8fe71e11831f4c
+  data.tar.gz: 16e844d556f1f78ffed35268471854e369dd54b3
 SHA512:
-  metadata.gz: ad7c22761d89cce4c92264aadd62b3c1c1609d5713ed97c76d06d50cb6c7e5057b8856a3ac2240cb0f14122401cc51c10453bff5ff1f3385a1292cc1124205af
-  data.tar.gz: 67ced68e105811bb22d0a1382eced38ae2830e1c8ebcb06f62852aeb9c0bde436b654217b31c3641452b2a674eee06c2eb45b2a63741a1c8461373cdada82fae
+  metadata.gz: 0f0cf2c3e453604fe5ec06a1b1f7ac2568c19fc2aa60263f2742c3ba6b2571cb8c6acd5ff8f5f555ba0c0639116a3e63bb9f675ed3f6c4baf587e20ba63ee67d
+  data.tar.gz: d664d9467c1248586c837232c77b83c05fc987798499d60eda0aacc0823734d55fadf79b9956162a06503da9380ef9682af9097481560f05c29e53abf40d805f

data/lib/error_to_communicate/heuristic/no_method_error.rb

@@ -48,6 +48,15 @@ module ErrorToCommunicate
         tokens = Rouge::Lexers::Ruby.lex(line).to_a
         index  = tokens.index { |token, text| text == undefined_method_name }
 
+        if !index
+          return nil
+          # this happens when the tokens don't match the name, eg
+          # method name of "[]", and tokens of:
+          # [[<Token Punctuation>, "["],
+          #  [<Token Literal.Number.Integer>, "0"],
+          #  [<Token Punctuation>, "]"]]
+        end
+
         while 0 <= index
           token, text = tokens[index]
           break if token.qualname == "Name.Variable.Instance"

data/lib/error_to_communicate/heuristic/wrong_number_of_arguments.rb

@@ -19,10 +19,10 @@ module ErrorToCommunicate
       def semantic_explanation
         [ :message,
           [ [:explanation, explanation],
-            [:context, ' (expected '],
-            [:details, num_expected],
-            [:context, ', sent '],
+            [:context, ' (given '],
             [:details, num_received],
+            [:context, ', expected '],
+            [:details, num_expected],
             [:context, ')'],
           ]
         ]

data/lib/error_to_communicate/version.rb

@@ -1,3 +1,3 @@
 module ErrorToCommunicate
-  VERSION = '0.0.7'.freeze
+  VERSION = '0.0.8'.freeze
 end

data/spec/acceptance/no_methood_error_spec.rb

@@ -45,4 +45,61 @@ RSpec.describe 'NoMethodError', acceptance: true do
       expect(stderr).to match /no_method_error\.rb:7\n.*?backtrace4/
       expect(stderr).to match /no_method_error\.rb:14\n.*?Test.backtrace2/
   end
+
+
+
+  it 'doesn\'t freak out on methods with punctuation names' do
+    # https://github.com/JoshCheek/mrspec/issues/11
+    write_file 'punctuation_no_method_error.rb', <<-BODY
+      require 'error_to_communicate/at_exit'
+      class Bowling
+        def self.score(rolls)
+          new(rolls).score
+        end
+
+        def initialize(rolls)
+          @rolls = rolls
+        end
+
+        def score(total=0)
+          current = rolls.shift
+          if strike?
+            current + rolls[1] + rolls[2] + total
+          else
+            current + total
+          end
+        end
+
+        private
+
+        attr_reader :rolls
+
+        def strike?
+          self[0] == 10
+        end
+      end
+
+      Bowling.score([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0])
+    BODY
+
+    invocation = ruby 'punctuation_no_method_error.rb'
+    stderr = strip_color invocation.stderr
+
+    # sanity
+      expect(invocation.stdout).to     eq ''
+      expect(invocation.exitstatus).to eq 1
+
+    # error: It prints the exception class and message
+      expect(stderr).to include 'NoMethodError'
+      expect(stderr).to include "undefined method `[]'"
+
+    # heuristic:
+      expect(stderr).to match /self\[0\] == 10  \[\] is undefined/
+
+    # backtrace: It displays each line of the backtrace and includes the code from that line
+      expect(stderr).to match /punctuation_no_method_error\.rb:25/
+      expect(stderr).to match /punctuation_no_method_error\.rb:13/
+      expect(stderr).to match /punctuation_no_method_error\.rb:4/
+      expect(stderr).to match /punctuation_no_method_error\.rb:29/
+  end
 end

data/spec/acceptance/wrong_number_of_arguments_spec.rb

@@ -26,8 +26,8 @@ RSpec.context 'WrongNumberOfArguments', acceptance: true do
 
     # error: It prints the exception class and prints the reworded message
       expect(stderr).to include 'ArgumentError'
-      expect(stderr).to include 'Wrong number of arguments'
-      expect(stderr).to include '(expected 0, sent 1)'
+      expect(stderr).to match /wrong number of arguments/i
+      expect(stderr).to include '(given 1, expected 0)'
 
     # heuristic:
       # It displays name of the file with the line number of the error

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: what_weve_got_here_is_an_error_to_communicate
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Josh Cheek
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-24 00:00:00.000000000 Z
+date: 2016-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rouge