wegift-ruby-client 1.7.0 → 1.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7e26669ac746a053ceaff3ae76c09064e341e4fc
-  data.tar.gz: 3bfffee3e75e004ca366c25a4d662b01d9c7129b
+  metadata.gz: 8c8d33e34dab238c5e59fb84f6653548713685a2
+  data.tar.gz: bb8cd55f5134c27bdde0e978803a711693ceb5b2
 SHA512:
-  metadata.gz: b11bbfe7b91be3f83507a8ce7dd5b2b9a49d58b4042091f144e620b4df4bb69eedf33865e50390d8cdb754676e16082b13a14dfcfac01b0a80afd999be23cd0e
-  data.tar.gz: 03ff16e2c0884a7d2b8cb6bfef2cd6084337ddd6570586928d6f3497614089617e70432e2b55dc3583936ac313905447d897c539aea81617b2cd3f61c5f46fe0
+  metadata.gz: e5409f5391c0f2f5a8443bcb85bc11364c94c465be26cb7ca9bf023d85fcfc46abd268c0cbad1d9480065909087378ff624426eb2c333b15efb1978653bad1c5
+  data.tar.gz: d46762f2f027ebdb10c6f982bc350c09f769af83ae6c2debde2abb9f80910f305cae652f55996b82cf6653a9f2547b05ba0314d8e0da9ebd90bcdd5297f5c1ec

data/README.md

@@ -1,6 +1,6 @@
 # WeGift Ruby Client
 
-A simple client for [WeGift.io][wegift] B2B Synchronous API (Document Version 1.7). 
+A simple client for [WeGift.io][wegift] B2B Synchronous API (Document Version 1.7).
 
 ## Installation
 
@@ -24,7 +24,7 @@ $ gem install wegift-ruby-client
 
 Simple example for ordering a Digital Card
 ```ruby
-# a simple client 
+# a simple client
 client = Wegift::Client.new(
       :api_host => 'http://sandbox.wegift.io',
       :api_path => '/api/b2b-sync/v1',
@@ -34,7 +34,15 @@ client = Wegift::Client.new(
 )
 
 # with all available products
-products = client.products
+get_products = client.products
+
+if get_products.is_successful?
+  # it provides a list of all vouchers
+  vouchers = products.all
+else
+  # get_products.status => 403
+  # get_products.error_details => "Forbidden"
+end
 
 # or just a single one
 product = client.products('PROD-ID')
@@ -51,7 +59,7 @@ order = client.order(
         :currency_code => 'USD',
         :amount => '42.00',
         :delivery_method => 'direct', # default
-        :delivery_format => 'raw', # default        
+        :delivery_format => 'raw', # default
         :external_ref => '123' # optional
 )
 
@@ -64,7 +72,7 @@ if order.is_successful?
   order.pin
   order.expiry_date
   order.delivery_url
-  
+
 end
 ```
 
@@ -83,7 +91,7 @@ rspec
 
 It will load all tapes found in `spec/tapes`, we are using [VCR][vcr].
 
-To remaster all recordings, you will need a sandbox account. 
+To remaster all recordings, you will need a sandbox account.
 Add an `.env` file to your root:
 
 ```bash
@@ -105,4 +113,4 @@ Bug reports and pull requests are welcome on GitHub at https://github.com/kendri
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).
 
 [wegift]: http://WeGift.io
-[vcr]: https://github.com/vcr/vcr
+[vcr]: https://github.com/vcr/vcr

data/lib/wegift/client.rb

@@ -43,13 +43,8 @@ module Wegift
     # global methods
 
     def products()
-      # initialize endpoint
       products = Wegift::Products.new()
-
-      # get catalogue with context / current connection
       products.get(self)
-
-      # TODO: shared error handling
     end
 
     def product(id = nil)

data/lib/wegift/models/order.rb

@@ -36,11 +36,11 @@ class Wegift::Order < Wegift::Response
   # POST /api/b2b-sync/v1/order-digital-card
   def post(ctx)
     response = ctx.request(:post, PATH, self.payload)
-    self.parse(JSON.parse(response.body))
+    self.parse(response)
   end
 
-  def parse(data)
-    super(data)
+  def parse(response)
+    super(response)
 
     # nested status/error object
     # assuming root "status" is always "SUCCESS" if "e_code" is set
@@ -58,23 +58,23 @@ class Wegift::Order < Wegift::Response
     #}
 
     # override root "status" if set
-    if data['e_code'] && data['e_code']['status'].eql?(STATUS[:error])
-      @status = data['e_code']['status']
-      @error_code = data['e_code']['error_code'] unless data['e_code']['error_code'].blank?
-      @error_string = data['e_code']['error_string'] unless data['e_code']['error_string'].blank?
-      @error_details = data['e_code']['error_details'] unless data['e_code']['error_details'].blank?
+    if @payload['e_code'] && @payload['e_code']['status'].eql?(STATUS[:error])
+      @status = @payload['e_code']['status']
+      @error_code = @payload['e_code']['error_code'] unless @payload['e_code']['error_code'].blank?
+      @error_string = @payload['e_code']['error_string'] unless @payload['e_code']['error_string'].blank?
+      @error_details = @payload['e_code']['error_details'] unless @payload['e_code']['error_details'].blank?
     end
 
     # set valid data
-    if data['e_code'] && data['e_code']['status'].eql?(STATUS[:success])
-      @code = data['e_code']['code']
-      @expiry_date = data['e_code']['expiry_date']
-      @pin = data['e_code']['pin']
-      @cvc2 = data['e_code']['cvc2']
-      @delivery_url = data['e_code']['delivery_url']
+    if @payload['e_code'] && @payload['e_code']['status'].eql?(STATUS[:success])
+      @code = @payload['e_code']['code']
+      @expiry_date = @payload['e_code']['expiry_date']
+      @pin = @payload['e_code']['pin']
+      @cvc2 = @payload['e_code']['cvc2']
+      @delivery_url = @payload['e_code']['delivery_url']
     end
 
-    @order_id = data['order_id']
+    @order_id = @payload['order_id']
 
     self
   end

data/lib/wegift/models/product.rb

@@ -27,12 +27,12 @@ class Wegift::Product < Wegift::Response
   # GET /api/b2b-sync/v1/products/ID
   def get(ctx)
     response = ctx.request(:get, path)
-    self.parse(JSON.parse(response.body))
+    self.parse(response)
   end
 
-  def parse(data)
-    super(data)
-    Wegift::Product.new(data)
+  def parse(response)
+    super(response)
+    Wegift::Product.new(@payload)
   end
 
 end

data/lib/wegift/models/products.rb

@@ -2,20 +2,28 @@ class Wegift::Products < Wegift::Response
 
   PATH = '/products'
 
+  attr_accessor :all
+
   # Product Details List
   # GET /api/b2b-sync/v1/products/
   def get(ctx)
     response = ctx.request(:get, PATH)
-    self.parse(JSON.parse(response.body))
+    self.parse(response)
   end
 
-  def parse(data)
-    super(data)
+  def parse(response)
+    super(response)
 
-    # TODO separate?
-    if data['products']
-      data['products'].map{|p| Wegift::Product.new(p)}
+    if self.is_successful?
+      # TODO separate?
+      if @payload['products']
+        @all = @payload['products'].map{|p| Wegift::Product.new(p)}
+      end
+    else
+      @all = []
     end
+
+    self
   end
 
 end

data/lib/wegift/models/response.rb

@@ -13,19 +13,29 @@ class Wegift::Response
   # error_details - Details of the particular error, i.e. Field "delivery" missing from request
 
   # global shared body
-  attr_accessor :status, :error_code, :error_string, :error_details
+  attr_accessor :payload, :status, :error_code, :error_string, :error_details
 
   def is_successful?
     @status && @status.eql?(STATUS[:success])
   end
 
-  def parse(data = {})
-    @status = data['status']
-    @error_code = data['error_code']
-    @error_string = data['error_string']
-    @error_details = data['error_details']
+  def parse(response = {})
+    # TODO: JSON responses, when requested?
+    # let's fix that with a simpel catch all
+    if response.success? && response['content-type'].eql?('application/json')
+      @payload = JSON.parse(response.body)
+      # TODO: @payload['status'] is only returned for orders! (products etc are plain objects)
+      @status = @payload['status'] || STATUS[:success]
+      @error_code = @payload['error_code']
+      @error_string = @payload['error_string']
+      @error_details = @payload['error_details']
+    else
+      @payload = {}
+      @status = STATUS[:error]
+      @error_code = response.status
+      @error_string = response.reason_phrase
+      @error_details = response.reason_phrase
+    end
   end
 
-  # TODO
-
-end
+end

data/lib/wegift/version.rb

@@ -1,4 +1,4 @@
 module Wegift
   # api-version.lib-build
-  VERSION = '1.7.0'
+  VERSION = '1.7.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: wegift-ruby-client
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.7.1
 platform: ruby
 authors:
 - Klaas Endrikat
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-21 00:00:00.000000000 Z
+date: 2018-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -200,7 +200,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: A simple Ruby client for the WEGIFT API