webvalve 0.12.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d632e36adb6db315896d3a144d02408dfcacdb7af5196874f4839d12b187499b
-  data.tar.gz: 044a117bf8a6df2eba482f99b5234e39b393f906ef0b895b3819d76805e76e9d
+  metadata.gz: 5da39e3192b0ca68909782d930f60bbcb854b9f1d81f2f2e48ab5ce485d6758b
+  data.tar.gz: a5deb923fb76b3d4e1a084a012d671fc3689cdd61f24255f869217f2527e46a7
 SHA512:
-  metadata.gz: e7c5ca72aa5ac1ee8417a15df0848f66f019655a4870152c32ff62231b1df91eef435524f072e548e4091e509be76d2ac5fd19391ecafd861193c2ef1b92617e
-  data.tar.gz: b1a9d0d174ae5d65ca02fc62ecdb13b24f74489d13c6ab39995868cac56665015667632849a62477c087fc6fe4d0770d5945131ffd84914d61706e58e58b374e
+  metadata.gz: 406fca19f30cffb98fd401667ef41038dc1b45f7ee0ff255a9ecb01359dbbef1ac35209bd15b0202790072b8f9f09b82fa8069457d6fb777305719d797024032
+  data.tar.gz: 00e5633ca9ee5932dd0af9344e15c2e580f8d550e2ad8a6500a9a952f4f973892df349119bd36e2ebc5540f2e6445671471dd20bcefa9de18ac243bdad08c1f4

data/CHANGELOG.md

@@ -9,6 +9,11 @@ and this project aims to adhere to [Semantic Versioning](http://semver.org/spec/
 ### Added
 ### Removed
 
+## [1.0.0] - 2020-04-22
+### Changed
+- Support API_URLs that include path
+    (https://github.com/Betterment/webvalve/pull/41)
+
 ## [0.12.0] - 2020-02-22
 ### Changed
 - raise an error on setup when multiple services are registered to the
@@ -52,7 +57,8 @@ and this project aims to adhere to [Semantic Versioning](http://semver.org/spec/
 ### Changed
 - WebMock 3+ support from @messanjah (https://github.com/Betterment/webvalve/pull/22)
 
-[Unreleased]: https://github.com/Betterment/webvalve/compare/v0.12.0...HEAD
+[Unreleased]: https://github.com/Betterment/webvalve/compare/v1.0.0...HEAD
+[1.0.0]: https://github.com/Betterment/webvalve/compare/v0.12.0...v1.0.0
 [0.12.0]: https://github.com/Betterment/webvalve/compare/v0.11.0...v0.12.0
 [0.11.0]: https://github.com/Betterment/webvalve/compare/v0.10.0...v0.11.0
 [0.10.0]: https://github.com/Betterment/webvalve/compare/v0.9.10...v0.10.0

data/README.md

@@ -1,7 +1,7 @@
 WebValve
 ========
 
-[![Build Status](https://travis-ci.org/Betterment/webvalve.svg?branch=master)](https://travis-ci.org/Betterment/webvalve)
+![Build Status](https://github.com/Betterment/webvalve/workflows/CI/badge.svg)
 [![Gem Status](https://img.shields.io/gem/v/webvalve.svg)](https://rubygems.org/gems/webvalve)
 
 WebValve is a tool for defining and registering fake implementations of

data/Rakefile

@@ -7,7 +7,7 @@ end
 Bundler::GemHelper.install_tasks
 
 task(:default).clear
-if ENV['APPRAISAL_INITIALIZED'] || ENV['TRAVIS']
+if ENV['APPRAISAL_INITIALIZED'] || ENV['CI']
   require 'rspec/core'
   require 'rspec/core/rake_task'
   RSpec::Core::RakeTask.new(:spec)

data/lib/webvalve/fake_service_config.rb

@@ -23,6 +23,10 @@ module WebValve
       end
     end
 
+    def path_prefix
+      @path_prefix ||= URI::parse(service_url).path
+    end
+
     private
 
     attr_reader :custom_service_url

data/lib/webvalve/fake_service_wrapper.rb

@@ -1,18 +1,19 @@
 module WebValve
   class FakeServiceWrapper
     # lazily resolve the app constant to leverage rails class reloading
-    def initialize(app_class_name)
-      @app_class_name = app_class_name
+    def initialize(service_config)
+      @service_config = service_config
     end
 
     def call(env)
+      env['PATH_INFO'] = env['PATH_INFO'].gsub(/\A#{@service_config.path_prefix}/, '')
       app.call(env)
     end
 
     private
 
     def app
-      @app_class_name.constantize
+      @service_config.service_class_name.constantize
     end
   end
 end

data/lib/webvalve/manager.rb

@@ -70,6 +70,7 @@ module WebValve
       allowlisted_urls.clear
       fake_service_configs.clear
       stubbed_urls.clear
+      WebMock.reset!
     end
 
     # @api private
@@ -132,7 +133,7 @@ module WebValve
       WebMock.stub_request(
         :any,
         url_to_regexp(config.service_url)
-      ).to_rack(FakeServiceWrapper.new(config.service_class_name))
+      ).to_rack(FakeServiceWrapper.new(config))
     end
 
     def allowlist_service(config)

data/lib/webvalve/version.rb

@@ -1,3 +1,3 @@
 module WebValve
-  VERSION = "0.12.0"
+  VERSION = "1.0.0"
 end

data/spec/webvalve/fake_service_config_spec.rb

@@ -88,4 +88,28 @@ RSpec.describe WebValve::FakeServiceConfig do
       end
     end
   end
+
+  describe '.path_prefix' do
+    it 'raises if the url is not present' do
+      expect { subject.path_prefix }.to raise_error(/There is no URL defined for FakeDummy/)
+    end
+
+    it 'returns root when there is no path in the service URL' do
+      with_env 'DUMMY_API_URL' => 'http://bananas.test/' do
+        expect(subject.path_prefix).to eq '/'
+      end
+      with_env 'DUMMY_API_URL' => 'https://some:auth@bananas.test//' do
+        expect(subject.path_prefix).to eq '/' # Parses funkier URL
+      end
+    end
+
+    it 'returns the path when there is one in the service URL' do
+      with_env 'DUMMY_API_URL' => 'http://zombo.com/welcome' do
+        expect(subject.path_prefix).to eq '/welcome'
+      end
+      with_env 'DUMMY_API_URL' => 'http://zombo.com/welcome/' do
+        expect(subject.path_prefix).to eq '/welcome' # Ignores trailing '/'
+      end
+    end
+  end
 end

data/spec/webvalve/fake_service_spec.rb

@@ -26,21 +26,44 @@ RSpec.describe WebValve::FakeService do
       WebValve.reset
     end
 
-    it 'raise a useful error when an unmapped route is requested' do
-      with_env 'DUMMY_API_URL' => 'http://dummy.dev' do
-        WebValve.register subject.name
-        WebValve.setup
+    context 'when the service is at a root path' do
+      it 'raise a useful error when an unmapped route is requested' do
+        with_env 'DUMMY_API_URL' => 'http://dummy.dev' do
+          WebValve.register subject.name
+          WebValve.setup
 
-        expect { Net::HTTP.get(URI('http://dummy.dev/foos')) }.to raise_error(RuntimeError, /route not defined for GET/)
+          expect { Net::HTTP.get(URI('http://dummy.dev/foos')) }.to raise_error(RuntimeError, /route not defined for GET/)
+        end
+      end
+
+      it 'returns the result from the fake when a mapped route is requested' do
+        with_env 'DUMMY_API_URL' => 'http://dummy.dev' do
+          WebValve.register subject.name
+          WebValve.setup
+
+          expect(Net::HTTP.get(URI('http://dummy.dev/widgets'))).to eq({ result: 'it works!' }.to_json)
+        end
       end
     end
 
-    it 'returns the result from the fake when a mapped route is requested' do
-      with_env 'DUMMY_API_URL' => 'http://dummy.dev' do
-        WebValve.register subject.name
-        WebValve.setup
+    context 'when the service lives at a non-root path' do
+      it 'raise a useful error when the route is requested at the root' do
+        with_env 'DUMMY_API_URL' => 'http://dummy.dev/gg' do
+          WebValve.register subject.name
+          WebValve.setup
+
+          expect { Net::HTTP.get(URI('http://dummy.dev/widgets')) }
+            .to raise_error(WebMock::NetConnectNotAllowedError, /Real HTTP connections are disabled/)
+        end
+      end
+
+      it 'returns the result from the fake when a mapped route is requested' do
+        with_env 'DUMMY_API_URL' => 'http://dummy.dev/gg' do
+          WebValve.register subject.name
+          WebValve.setup
 
-        expect(Net::HTTP.get(URI('http://dummy.dev/widgets'))).to eq({ result: 'it works!' }.to_json)
+          expect(Net::HTTP.get(URI('http://dummy.dev/gg/widgets'))).to eq({ result: 'it works!' }.to_json)
+        end
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: webvalve
 version: !ruby/object:Gem::Version
-  version: 0.12.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Sam Moore
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-22 00:00:00.000000000 Z
+date: 2020-04-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport