webpacker_lite 1.0.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b8639e91747db6f8fdcc978cb2ec8e454d0a01b7
-  data.tar.gz: 1b4a93698db3a570369886138c1adb58673c2f58
+  metadata.gz: 2e6a7d776f0f2bb29a4cd64177a1ca8b447b358a
+  data.tar.gz: ade62ad9187e06fe8f3ed007641b5cbdf2b2ef28
 SHA512:
-  metadata.gz: 73409d286c0497e8086904233a8cf6301438983f890664c44c452f8114611c592ba64959e2e188ba332f17beedc28af62698e7d7ff98e8a844e98b660e805638
-  data.tar.gz: d8744e4cb8ea2626877f54e4cb49869a5185186af1a4d1f3e11717285dd17d3d7c244d9fe8dd19249e5d17f97e7915440ae0b96b38ca459a1b3d4f98212f3e5d
+  metadata.gz: 90cb984e1db2305e0504a7a5ac0030bec26726b5ba7db0541a6b206444caf3e01ac06261452e2cb0d3cc9921cb9458ac0e45c37c17cd2ed1d0bf68cf14a057f0
+  data.tar.gz: 1d1f2c2b10e55f1e78c36fab16ff7969ac1ee24129b9bde2e224e2b650c0f1aee3bfe5e3e81274704263e06573d6ecb8a57c63e13f736c1bfee7a75ee4fea16c

data/.gitignore

@@ -1,3 +1,4 @@
 /.bundle
 node_modules
 pkg
+log

data/.travis.yml

@@ -6,16 +6,9 @@ rvm:
   - 2.4.1
 cache:
   bundler: true
-  directories:
-    - node_modules
-  yarn: true
 
 install:
-  - gem install rubocop
-  - nvm install node
-  - node -v
-  - npm i -g yarn
-  - yarn
+  - bundle install
 script:
-  - yarn lint
-  - rubocop
+  - bundle exec rubocop
+  - bundle exec rake test

data/CHANGELOG.md

@@ -6,8 +6,20 @@ Contributors: please follow the recommendations outlined at [keepachangelog.com]
 ## [Unreleased]
 *Please add entries here for your pull requests.*
 
+
+## [2.0.0] - 2017-05-23
+All in [#9](https://github.com/shakacode/webpacker_lite/pull/9) by [justin808](https://github.com/justin808) with help from [conturbo](https://github.com/conturbo) on the tests.
+
+* Rewrote README.md.
+* Configuration is simplified and changed to a single file, `/config/webpacker_lite.yml`. See README.md.
+* v1 assumed that manifest.json would contain the host name for hot reloading. v2 puts in the host at the Ruby level.
+* `stylesheet_pack_tag` API changed. ENV value for `HOT_RELOADING` == "TRUE" results in the stylesheet_pack_tag not writing anything due to hot reloading requiring inlined JavaScript of styles and not extracted CSS.
+* Removed any bits of JavaScript from webpacker_lite.
+* Added tests
+
 ## [1.0.0] - 2017-05-03
 Initial release
 
-[Unreleased]: https://github.com/shakacode/webpacker_lite/compare/1.0.0...master
+[Unreleased]: https://github.com/shakacode/webpacker_lite/compare/2.0.0...master
+[2.0.0]: https://github.com/shakacode/react_on_rails/compare/1.0.0...2.0.0
 [1.0.0]: https://github.com/shakacode/react_on_rails/compare/0.0.5...1.0.0

data/Gemfile

@@ -1,3 +1,11 @@
 source "https://rubygems.org"
 
 gemspec
+
+gem "rails"
+gem "rake", ">= 11.1"
+gem "rubocop", ">= 0.47", require: false
+
+group :test do
+  gem "minitest", "~> 5.10", "!= 5.10.2"
+end

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    webpacker_lite (0.0.2)
+    webpacker_lite (1.0.0)
       activesupport (>= 4.2)
       multi_json (~> 1.2)
       railties (>= 4.2)
@@ -9,62 +9,130 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (5.0.2)
-      actionview (= 5.0.2)
-      activesupport (= 5.0.2)
+    actioncable (5.1.0)
+      actionpack (= 5.1.0)
+      nio4r (~> 2.0)
+      websocket-driver (~> 0.6.1)
+    actionmailer (5.1.0)
+      actionpack (= 5.1.0)
+      actionview (= 5.1.0)
+      activejob (= 5.1.0)
+      mail (~> 2.5, >= 2.5.4)
+      rails-dom-testing (~> 2.0)
+    actionpack (5.1.0)
+      actionview (= 5.1.0)
+      activesupport (= 5.1.0)
       rack (~> 2.0)
       rack-test (~> 0.6.3)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (5.0.2)
-      activesupport (= 5.0.2)
+    actionview (5.1.0)
+      activesupport (= 5.1.0)
       builder (~> 3.1)
-      erubis (~> 2.7.0)
+      erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.0.3)
-    activesupport (5.0.2)
+    activejob (5.1.0)
+      activesupport (= 5.1.0)
+      globalid (>= 0.3.6)
+    activemodel (5.1.0)
+      activesupport (= 5.1.0)
+    activerecord (5.1.0)
+      activemodel (= 5.1.0)
+      activesupport (= 5.1.0)
+      arel (~> 8.0)
+    activesupport (5.1.0)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (~> 0.7)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
+    arel (8.0.0)
+    ast (2.3.0)
     builder (3.2.3)
     concurrent-ruby (1.0.5)
-    erubis (2.7.0)
+    erubi (1.6.0)
+    globalid (0.4.0)
+      activesupport (>= 4.2.0)
     i18n (0.8.1)
     loofah (2.0.3)
       nokogiri (>= 1.5.9)
+    mail (2.6.5)
+      mime-types (>= 1.16, < 4)
     method_source (0.8.2)
+    mime-types (3.1)
+      mime-types-data (~> 3.2015)
+    mime-types-data (3.2016.0521)
     mini_portile2 (2.1.0)
     minitest (5.10.1)
     multi_json (1.12.1)
-    nokogiri (1.7.1)
+    nio4r (2.0.0)
+    nokogiri (1.7.2)
       mini_portile2 (~> 2.1.0)
-    rack (2.0.1)
+    parser (2.4.0.0)
+      ast (~> 2.2)
+    powerpack (0.1.1)
+    rack (2.0.2)
     rack-test (0.6.3)
       rack (>= 1.0)
-    rails-dom-testing (2.0.2)
-      activesupport (>= 4.2.0, < 6.0)
-      nokogiri (~> 1.6)
+    rails (5.1.0)
+      actioncable (= 5.1.0)
+      actionmailer (= 5.1.0)
+      actionpack (= 5.1.0)
+      actionview (= 5.1.0)
+      activejob (= 5.1.0)
+      activemodel (= 5.1.0)
+      activerecord (= 5.1.0)
+      activesupport (= 5.1.0)
+      bundler (>= 1.3.0, < 2.0)
+      railties (= 5.1.0)
+      sprockets-rails (>= 2.0.0)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
     rails-html-sanitizer (1.0.3)
       loofah (~> 2.0)
-    railties (5.0.2)
-      actionpack (= 5.0.2)
-      activesupport (= 5.0.2)
+    railties (5.1.0)
+      actionpack (= 5.1.0)
+      activesupport (= 5.1.0)
       method_source
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
+    rainbow (2.2.2)
+      rake
     rake (12.0.0)
+    rubocop (0.48.1)
+      parser (>= 2.3.3.1, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    ruby-progressbar (1.8.1)
+    sprockets (3.7.1)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-rails (3.2.0)
+      actionpack (>= 4.0)
+      activesupport (>= 4.0)
+      sprockets (>= 3.0.0)
     thor (0.19.4)
     thread_safe (0.3.6)
     tzinfo (1.2.3)
       thread_safe (~> 0.1)
+    unicode-display_width (1.2.1)
+    websocket-driver (0.6.5)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.2)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   bundler (~> 1.12)
+  minitest (~> 5.10, != 5.10.2)
+  rails
+  rake (>= 11.1)
+  rubocop (>= 0.47)
   webpacker_lite!
 
 BUNDLED WITH
-   1.14.6
+   1.15.0

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2016 David Heinemeier Hansson, Basecamp,
+Copyright (c) 2016 David Heinemeier Hansson, Basecamp, and
 2017 Justin Gordon, ShakaCode
 
 Permission is hereby granted, free of charge, to any person obtaining

data/README.md

@@ -1,38 +1,157 @@
 # Webpacker Lite
-[![Gem](https://img.shields.io/gem/v/webpacker_lite.svg)](https://github.com/shakacode/webpacker_lite)
+![Gem Version](https://badge.fury.io/rb/webpacker_lite.svg)
 
-Webpacker Lite provides the webpack enabled asset helpers from [Webpacker](https://github.com/rails/webpacker).
-[React on Rails](https://github.com/shakacode/react_on_rails) will soon support using Webpacker Lite,
-including other optimizations for [React on Rails](https://github.com/shakacode/react_on_rails)
+*A slimmer version of Webpacker*
 
-# NEWS
-* 2017-04-09: React on Rails 7.0.0 beta work to include webpacker_lite gem has begun. See [#786](https://github.com/shakacode/react_on_rails/issues/786
+Webpacker Lite provides similar webpack enabled view helpers from [Webpacker](https://github.com/rails/webpacker).
+[React on Rails](https://github.com/shakacode/react_on_rails) version 8 and greater defaults to using Webpacker Lite.
 
-## Prerequisites
+For example, these view helpers allow your application's layout to easily reference JavaScript and CSS files created by your Webpack setup, taking into account differences in the Rails environments. With these helpers, there is no reason for Webpack created assets to run through the [Asset Pipeline](http://guides.rubyonrails.org/asset_pipeline.html), as was done in React on Rails 7.x and earlier.
 
-* Ruby 2+
-* Rails 4.2+
+If you like this project, show your support by giving us a star!
 
-## Installation
+# Why Fork?
+
+> Everything should be made as simple as possible, but not simpler.
+
+[Albert Einstein on Wikiquote](https://en.wikiquote.org/wiki/Albert_Einstein)
+
+Why did [ShakaCode](http://www.shakacode.com) fork [rails/webpacker](https://github.com/rails/webpacker)? For [react_on_rails](https://github.com/shakacode/react_on_rails), we wanted a simpler configuration to get the core functionality needed. You configure 2 things:
 
-WebpackerLite is currently compatible with Rails 4.2+, but there's no guarantee it will still be
-in the future.
+1. Name of the manifest file.
+2. The directory within `/public` where Webpack will create the manifest and output file.
+
+Then you need to configure your Webpack to generate a simple manifest that maps the base output names to the possibly fingerprinted versions. Note, unlike Webpacker, Webpacker Lite wants your manifest to **NOT** contain any host information.
+
+Optionally, you can configure the name of the server and port for hot reloading, and if hot reloading is the default for a given Rails.env.
+
+For more details on how this project differs from Webpacker and why we forked, please see [Webpacker Lite: Why Did  We Fork Webpacker?](https://medium.com/@railsonmaui/webpacker-lite-why-did-we-fork-webpacker-ee3305688d66)
+
+# NEWS
+ 
+* 2017-05-03: React on Rails 8.0.0 beta defaults to using webpacker_lite.
+
+## Installation
 
-The best way to see the installation of webpacker_lite is to use the generator for React on Rails 7.1.0 or greater.
+The best way to see the installation of webpacker_lite is to use the generator for React on Rails 8.0.0 or greater. Otherwise, add the gem and create the configuration file described below.
 
 ## Overview
 
-1. Configure the location of your Webpack output in the `config/webpack/paths.yml` file.
-   `webpack_ouput: public/assets/webpack` is the default.
-2. Configure your Webpack scripts to:
-   1. Use the manifest plugin to generate a manifest
-   2. Write output to the directory that you configured in your paths.yml file.
-3. Use the asset helpers on your layouts to provide the webpack generated files:
+1. Configure the `config/webpacker_lite.yml` file, as described below. You will specify the name of the manifest file and the output directory used by step 2.
+2. Use the [webpack-manifest-plugin](https://www.npmjs.com/package/webpack-manifest-plugin) to generate a manifest
+   in the output directory (`webpack_public_output_dir`) that you configured in your `/config/webpacker_lite.yml` file. 
+3. Use the view helpers on your layouts to provide the webpack generated files. Note, these are the same names used by [rails/webpacker](https://github.com/rails/webpacker).
+   These `output` names are **NOT** the actual file names, as the file name may have a [fingerprint](http://guides.rubyonrails.org/asset_pipeline.html#what-is-fingerprinting-and-why-should-i-care-questionmark).
    ```erb
    <%# app/views/layouts/application.html.erb %>
-   <%= javascript_pack_tag 'main' %>
-   <%= stylesheet_pack_tag 'main' %>
+   <%= javascript_pack_tag('main') %>
+   <%= stylesheet_pack_tag('main') %>
    ```
+4. When hot-reloading, the extract-text-plugin (extracted CSS from being inlined in the JavaScript)is not supported. Therefore, all your hot-reloaded Webpack-compiled CSS will be inlined and we will skip the CSS file by default. If you're not worried about hot-reloading for your CSS, use the `enabled_when_hot_loading: true` option. 
+
+   ```erb
+   <%= stylesheet_pack_tag('main', enabled_when_hot_loading: true) %> <% # Default is false %>
+   ```
+   
+For more details on the helper documentation, see the Ruby comments in [lib/webpacker_lite/helper.rb](lib/webpacker_lite/helper.rb) and please submit PRs here to help us improve the docs!
+
+## Configuration
+Webpacker Lite takes one configuration file: `config/webpacker_lite.yml` used to configure two required values and a couple optional values. Note, this file is configured like `config/database.yml` in that you place the values beneath the name of the Rails.env. 
+
+### Mandatory Configuration within `config/webpacker_lite.yml` 
+
+1. `manifest`: The manifest file name 
+1. `webpack_public_output_dir`: The output directory of both the manifest and the webpack static generated files within the `/public` directory.
+
+Note, placing output files within the Rails `/public` directory is not configurable.
+
+### Optional Configuration within `config/webpacker_lite.yml` 
+1. `hot_reloading_host`: The name of the hot reloading `webpack-dev-server` including the port
+2. `hot_reloading_enabled_by_default`: If hot reloading should default to true
+
+### Hot Reloading Notes
+
+Do not put the output server in your `manifest.json` file. The rails view helpers will automatically prepend the hot_reloading_host to the asset path.
+
+### Example Configuration `/config/webpacker_lite.yml`
+
+This example config shows how we use different output directories for the webpack generated assets per the type of environment. This is extremely convenient when you want to log redux messages in development but not in your tests.
+
+```yaml
+# /config/webpacker_lite.yml
+# Note: Base output directory of /public is assumed for static files
+default: &default
+  manifest: manifest.json  
+  # Used in your webpack configuration. Must be created in the
+  # webpack_public_output_dir folder
+  
+development:
+  <<: *default
+  # generated files for development, in /public/webpack/development
+  webpack_public_output_dir: webpack/development
+  
+  # Default is localhost:3500. You can specify the protocol if needed. Defaults to http://.
+  hot_reloading_host: localhost:3500
+  
+  # Developer note: considering removing this option so it can ONLY be turned by using an ENV value.
+  # Default is false, ENV 'HOT_RELOADING' will always override 
+  hot_reloading_enabled_by_default: false 
+  
+test:
+  <<: *default
+  # generated files for tests, in /public/webpack/test   
+  webpack_public_output_dir: webpack/test
+
+production:
+  <<: *default
+  # generated files for tests, in /public/webpack/production
+  webpack_public_output_dir: webpack/production
+```
+
+## Example for Development vs Hot Reloading vs Production Mode
+
+**erb file**
+
+```erb
+  <% # app/views/layouts/application.html.erb %>
+  <%= javascript_pack_tag('main') %>
+  <%= stylesheet_pack_tag('main') %>
+```
+
+**html file**
+
+```html
+  <!-- In test mode -->
+  <script src="/webpack/test/main.js"></script>
+  <link rel="stylesheet" media="screen" href="/webpack/test/main-0bd141f6d9360cf4a7f5.js">
+  
+  <!-- In development mode -->
+  <script src="/webpack/development/main.js"></script>
+  <link rel="stylesheet" media="screen" href="/webpack/development/main-0bd141f6d9360cf4a7f5.js">
+  
+  <!-- In development mode with hot reloading, using the webpack-dev-server -->
+  <script src="http://localhost:8080/webpack/development/main.js"></script>
+  <!-- Note, there's no stylesheet tag by default, as your CSS should be inlined in your JS. -->
+  
+  <!-- In production mode -->
+  <script src="/webpack/production/main-0bd141f6d9360cf4a7f5.js"></script>
+  <link rel="stylesheet" media="screen" href="/webpack/production/main-dc02976b5f94b507e3b6.css">
+```
+
+## Other Helpers: Getting the asset path
+
+The `asset_pack_path` helper provides the path of any given asset that's been compiled by webpack.
+
+For example, if you want to create a `<link rel="prefetch">` or `<img />`
+for an asset used in your pack code you can reference them like this in your view,
+
+```erb
+<img src="<%= asset_pack_path 'calendar.png' %>" />
+<% # => <img src="/webpack/calendar.png" /> %>
+```
+
+## Webpack Helper
+You may use the [React on Rails NPM Package](https://www.npmjs.com/package/react-on-rails), [react-on-rails/webpackConfigLoader](https://github.com/shakacode/react_on_rails/blob/master/webpackConfigLoader.js) to provide your Webpack config with easy access to the YAML settings. Even if you don't use the NPM package, you can use that file to inspire your Webpack configuration.
 
 ## Rake Tasks
 
@@ -49,43 +168,22 @@ If you are using different directories for the output paths per RAILS_ENV, this
 RAILS_ENV=test rake webpacker_lite:clobber
 ```
 
+## Differences from Webpacker
 
+1. Configuration setup of an optional single file `/config/webpacker_lite.yml`
+2. Webpacker helpers expect the manifest to contain the server URL when hot reloading. Webpacker Lite expects the manifest to never contain any host information.
 
-## Hot Reloading Config   
-Similary, you can also control and configure `webpack-dev-server` settings from
-`config/webpack/development.server.yml` file
-
-```yml
-# config/webpack/development.server.yml
-enabled: true
-host: localhost
-port: 8080
-```
-
-## Getting asset path
-
-Webpacker provides `asset_pack_path` helper to get the path of any given asset that's been compiled by webpack.
+## Hot Reloading
 
-For example, if you want to create a `<link rel="prefetch">` or `<img />`
-for an asset used in your pack code you can reference them like this in your view,
+1. Tell Rails and Webpacker Lite that you're hot reloading by setting the ENV value of `HOT_RELOADING=YES` if you are not hot reloading by default by setting the `hot_reloading_enabled_by_default` key in your config file.
+1. By default, the `stylesheet_pack_tag` helper will not create a tag when hot reloading is enabled. Per the note above, when hot-reloading, the extract-text-plugin (extracted CSS from being inlined in the JavaScript)is not supported. Therefore, all your hot-reloaded Webpack-compiled CSS will be inlined and we will skip the CSS file by default.
 
-```erb
-<img src="<%= asset_pack_path 'calendar.png' %>" />
-<% # => <img src="/packs/calendar.png" /> %>
-```
+   ```erb
+   <%= stylesheet_pack_tag('main', enabled_when_hot_loading: true) %> <% # Default is false %>
+   ```
+   
 
-## Example for Development vs Hot Reloading vs Production Mode
-```html
-  <!-- In development mode with webpack-dev-server -->
-  <script src="http://localhost:8080/main.js"></script>
-  <link rel="stylesheet" media="screen" href="http://localhost:8080/main.css">
-  <!-- In development mode -->
-  <script src="/packs/main.js"></script>
-  <link rel="stylesheet" media="screen" href="/packs/main.css">
-  <!-- In production mode -->
-  <script src="/packs/main-0bd141f6d9360cf4a7f5.js"></script>
-  <link rel="stylesheet" media="screen" href="/packs/main-dc02976b5f94b507e3b6.css">
-```
 
-## License
-Webpacker is released under the [MIT License](https://opensource.org/licenses/MIT).
+## Prerequisites
+* Ruby 2+
+* Rails 4.2+

data/Rakefile

@@ -1 +1,12 @@
+# frozen_string_literal: true
 require "bundler/gem_tasks"
+require "rake/testtask"
+
+Rake::TestTask.new(:test) do |t|
+  t.libs << "test"
+  t.libs << "lib"
+  t.test_files = FileList["test/**/*_test.rb"]
+  t.verbose = true
+end
+
+task default: :test

data/lib/tasks/webpacker.rake

@@ -1,5 +1,5 @@
 tasks = {
-  "webpacker_lite:clobber"  => "Remove the webpack compiled output directory as defined in config/webpack/paths.yml",
+  "webpacker_lite:clobber" => "Remove the webpack compiled output directory as defined in config/webpack/paths.yml",
   "webpacker_lite:check_node"      => "Verifies if Node.js is installed",
   "webpacker_lite:check_yarn"      => "Verifies if yarn is installed",
   "webpacker_lite:verify_install"  => "Verifies if webpacker is installed"

data/lib/tasks/webpacker_lite/clobber.rake

@@ -3,7 +3,7 @@ require "webpacker_lite/configuration"
 namespace :webpacker_lite do
   desc "Remove the webpack compiled output directory as defined in config/webpack/paths.yml"
   task clobber: ["webpacker_lite:verify_install", :environment] do
-    output_path = WebpackerLite::Configuration.output_path
+    output_path = WebpackerLite::Configuration.webpack_public_output_dir
     FileUtils.rm_r(output_path) if File.exist?(output_path)
     puts "Removed webpack output path directory #{output_path}"
   end

data/lib/tasks/webpacker_lite/verify_install.rake

@@ -3,9 +3,9 @@ require "webpacker_lite/configuration"
 namespace :webpacker_lite do
   desc "Verifies if webpacker_lite is installed"
   task verify_install: [:check_node, :check_yarn] do
-    if File.exist?(WebpackerLite::Configuration.file_path)
+    if File.exist?(WebpackerLite::Env.file_path)
       puts "WebpackerLite is installed 🎉 🍰"
-      puts "Using #{WebpackerLite::Configuration.file_path} file for setting up webpack paths"
+      puts "Using #{WebpackerLite::Env.file_path} file for setting up webpack paths"
     else
       puts "Configuration config/webpack/paths.yml file not found. \n"\
            "Make sure webpacker_lite:install is run successfully before " \

data/lib/webpacker_lite.rb

@@ -4,6 +4,10 @@ module WebpackerLite
     WebpackerLite::Configuration.load
     WebpackerLite::Manifest.load
   end
+
+  def env
+    WebpackerLite::Env.current.inquiry
+  end
 end
 
 require "webpacker_lite/railtie" if defined?(Rails)

data/lib/webpacker_lite/configuration.rb

@@ -4,30 +4,46 @@ require "webpacker_lite/env"
 
 class WebpackerLite::Configuration < WebpackerLite::FileLoader
   class << self
-    def config_path
-      Rails.root.join(paths.fetch(:config, "config/webpack"))
+    def manifest_path
+      Rails.root.join(webpack_public_output_dir,
+                      configuration.fetch(:manifest, "manifest.json"))
     end
 
-    def file_path
-      Rails.root.join("config", "webpack", "paths.yml")
+    def webpack_public_output_dir
+      Rails.root.join(
+        File.join("public", configuration.fetch(:webpack_public_output_dir, "webpack")))
     end
 
-    def manifest_path
-      Rails.root.join(output_path, paths.fetch(:manifest, "manifest.json"))
+    def base_path
+      "/#{configuration.fetch(:webpack_public_output_dir, "webpack")}"
     end
 
-    def output_path
-      Rails.root.join(paths.fetch(:output, "public"), paths.fetch(:assets, "assets/webpack"))
+    # Uses the hot_reloading_host if appropriate
+    def base_url
+      if WebpackerLite::Env.hot_loading?
+        host = configuration[:hot_reloading_host]
+        if host.blank?
+          raise "WebpackerLite's /config/webpacker_lite.yml needs a configuration value for the "\
+            "`hot_reloading_host` for environment #{Rails.env}."
+        end
+        if host.starts_with?("http")
+          host
+        else
+          "http://#{host}"
+        end
+      else
+        base_path
+      end
     end
 
-    def paths
+    def configuration
       load if WebpackerLite::Env.development?
       raise WebpackerLite::FileLoader::FileLoaderError.new("WebpackerLite::Configuration.load must be called first") unless instance
       instance.data
     end
 
-    def source_path
-      Rails.root.join(paths.fetch(:source, "app/javascript"))
+    def file_path
+      Rails.root.join("config", "webpacker_lite.yml")
     end
   end
 

data/lib/webpacker_lite/env.rb

@@ -1,4 +1,4 @@
-# Singleton registry for determining NODE_ENV from config/webpack/paths.yml
+# Singleton registry for determining NODE_ENV from config/webpacker_lite.yml
 require "webpacker_lite/file_loader"
 
 class WebpackerLite::Env < WebpackerLite::FileLoader
@@ -13,11 +13,14 @@ class WebpackerLite::Env < WebpackerLite::FileLoader
     end
 
     def hot_loading?
-      ENV["REACT_ON_RAILS_ENV"] == "HOT"
+      (ENV["HOT_RELOADING"].present? && (
+      ENV["HOT_RELOADING"].upcase == "YES" ||
+        ENV["HOT_RELOADING"].upcase == "TRUE")) ||
+        current["hot_reloading_enabled_by_default"]
     end
 
     def file_path
-      Rails.root.join("config", "webpack", "paths.yml")
+      Rails.root.join("config", "webpacker_lite.yml")
     end
   end
 

data/lib/webpacker_lite/file_loader.rb

@@ -1,4 +1,4 @@
-# Provides a base singleton-configuration pattern for loading a file, given a path
+# Provides a base singleton-configuration pattern for loading a JSON or YAML file, given a path
 class WebpackerLite::FileLoader
   class NotFoundError < StandardError; end
   class FileLoaderError < StandardError; end
@@ -10,6 +10,10 @@ class WebpackerLite::FileLoader
     def load(path = file_path)
       self.instance = new(path)
     end
+
+    def file_path
+      raise "Subclass of WebpackerLite::FileLoader should override this method"
+    end
   end
 
   private

data/lib/webpacker_lite/helper.rb

@@ -8,27 +8,28 @@ module WebpackerLite::Helper
   # Examples:
   #
   # In development mode:
-  #   <%= asset_pack_path 'calendar.js' %> # => "/packs/calendar.js"
+  #   <%= asset_pack_path 'calendar.js' %> # => "/public/webpack/development/calendar-1016838bab065ae1e122.js"
   # In production mode:
-  #   <%= asset_pack_path 'calendar.css' %> # => "/packs/calendar-1016838bab065ae1e122.css"
+  #   <%= asset_pack_path 'calendar.css' %> # => "/public/webpack/production/calendar-1016838bab065ae1e122.css"
   def asset_pack_path(name, **options)
-    asset_path(WebpackerLite::Manifest.lookup(name), **options)
+    path = WebpackerLite::Configuration.base_path
+    file = WebpackerLite::Manifest.lookup(name)
+    asset_path("#{path}/#{file}", **options)
   end
-  # Creates a script tag that references the named pack file, as compiled by Webpack per the entries list
-  # in config/webpack/shared.js. By default, this list is auto-generated to match everything in
-  # app/javascript/packs/*.js. In production mode, the digested reference is automatically looked up.
+
+  # Creates a script tag that references the named pack file, as compiled by Webpack.
   #
   # Examples:
   #
-  #   # In development mode:
+  #   In development mode:
   #   <%= javascript_pack_tag 'calendar', 'data-turbolinks-track': 'reload' %> # =>
-  #   <script src="/packs/calendar.js" data-turbolinks-track="reload"></script>
+  #   <script src="/public/webpack/development/calendar-1016838bab065ae1e314.js" data-turbolinks-track="reload"></script>
   #
   #   # In production mode:
   #   <%= javascript_pack_tag 'calendar', 'data-turbolinks-track': 'reload' %> # =>
-  #   <script src="/packs/calendar-1016838bab065ae1e314.js" data-turbolinks-track="reload"></script>
+  #   <script src="/public/webpack/production/calendar-1016838bab065ae1e314.js" data-turbolinks-track="reload"></script>
   def javascript_pack_tag(name, **options)
-    javascript_include_tag(WebpackerLite::Manifest.lookup("#{name}#{compute_asset_extname(name, type: :javascript)}"), **options)
+    javascript_include_tag(asset_source(name, :javascript), **options)
   end
 
   # Creates a link tag that references the named pack file(s), as compiled by Webpack per the entries list
@@ -42,48 +43,25 @@ module WebpackerLite::Helper
   #
   #   # In development mode:
   #   <%= stylesheet_pack_tag 'calendar', 'data-turbolinks-track': 'reload' %> # =>
-  #   <link rel="stylesheet" media="screen" href="/public/webpack/development/calendar.css" data-turbolinks-track="reload" />
-  #
-  #   The key options are `static` and `hot` which specify what you want for static vs. hot. Both of
-  #   these params are optional, and support either a single value, or an array.
+  #   <link rel="stylesheet" media="screen" href="/public/webpack/development/calendar-1016838bab065ae1e122.css" data-turbolinks-track="reload" />
   #
-  #   static vs. hot is picked based on whether
-  #   ENV["REACT_ON_RAILS_ENV"] == "HOT"
-  #   <%= stylesheet_pack_tag(static: 'application_static',
-  #                               hot: 'application_non_webpack',
-  #                               media: 'all',
-  #                               'data-turbolinks-track' => "reload")  %>
+  #   # In development mode with hot-reloading
+  #   <%= stylesheet_pack_tag('main') %> <% # Default is false for enabled_when_hot_loading%>
+  #   # No output
   #
-  #   <!-- These do not use turbolinks, so no data-turbolinks-track -->
-  #   <!-- This is to load the hot assets. -->
-  #   <%= stylesheet_pack_tag(hot: ['app', 'vendor']) %>
+  #   # In development mode with hot-reloading and enabled_when_hot_loading
+  #   # <%= stylesheet_pack_tag('main', enabled_when_hot_loading: true) %>
+  #   <link rel="stylesheet" media="screen" href="/public/webpack/development/calendar-1016838bab065ae1e122.css" />
   #
-  #   <!-- These do use turbolinks -->
-  #   <%= stylesheet_pack_tag(static: 'application_static',
-  #                                  hot: 'application_non_webpack',
-  #                                  'data-turbolinks-track': 'reload') %>
-  #
-
-  def stylesheet_pack_tag(*args, **kwargs)
-    manifested_names = []
-    default_case = args.any?
-    if default_case
-      args.flatten!
-      manifested_names += get_manifests(args)
-    end
-    asset_type = WebpackerLite::Env.hot_loading? ? :hot : :static
-    names = Array(kwargs[asset_type])
-    manifested_names += get_manifests(names)
-
-    options = kwargs.delete_if { |key, _value| %i(hot static).include?(key) }
-    stylesheet_link_tag(*manifested_names, options)
+  def stylesheet_pack_tag(name, **options)
+    return "" if WebpackerLite::Env.hot_loading? && !options[:enabled_when_hot_loading].presence
+    stylesheet_link_tag(asset_source(name, :stylesheet), **options)
   end
 
   private
-
-  def get_manifests(names)
-    names.map do |name|
-      WebpackerLite::Manifest.lookup("#{name}#{compute_asset_extname(name, type: :stylesheet)}")
+    def asset_source(name, type)
+      url = WebpackerLite::Configuration.base_url
+      path = WebpackerLite::Manifest.lookup("#{name}#{compute_asset_extname(name, type: type)}")
+      "#{url}/#{path}"
     end
-  end
 end

data/lib/webpacker_lite/manifest.rb

@@ -1,9 +1,9 @@
-# Singleton registry for accessing the packs path using generated manifest.
+# Singleton registry for accessing the output path using generated manifest.
 # This allows javascript_pack_tag, stylesheet_pack_tag, asset_pack_path to take a reference to,
-# say, "calendar.js" or "calendar.css" and turn it into "/packs/calendar.js" or
-# "/packs/calendar.css" in development. In production mode, it returns compiles
-# files, # "/packs/calendar-1016838bab065ae1e314.js" and
-# "/packs/calendar-1016838bab065ae1e314.css" for long-term caching
+# say, "calendar.js" or "calendar.css" and turn it into "/public/webpack/calendar.js" or
+# "/public/webpack/calendar.css" in development. In production mode, it returns compiles
+# files, # "/public/webpack/calendar-1016838bab065ae1e314.js" and
+# "/webpack/calendar-1016838bab065ae1e314.css" for long-term caching
 
 require "webpacker_lite/file_loader"
 require "webpacker_lite/env"
@@ -18,7 +18,18 @@ class WebpackerLite::Manifest < WebpackerLite::FileLoader
     def lookup(name)
       load if WebpackerLite::Env.development? || instance.data.empty?
       raise WebpackerLite::FileLoader::FileLoaderError.new("WebpackerLite::Manifest.load must be called first") unless instance
-      instance.data[name.to_s] || raise(WebpackerLite::FileLoader::NotFoundError.new("Can't find #{name} in #{file_path}. Is webpack still compiling?"))
+      instance.data[name.to_s] || missing_file_error(name)
+    end
+
+    def missing_file_error(name)
+      msg = <<-MSG
+        WebpackerLite can't find #{name} in your manifest #{file_path}. Possible causes:
+          1. You are hot reloading
+          2. Webpack is not running
+          3. You have misconfigured WebpackerLite's config/webpacker_lite.yml file.
+          4. Your Webpack configuration is not creating a manifest.
+      MSG
+      raise(WebpackerLite::FileLoader::NotFoundError.new(msg))
     end
   end
 

data/lib/webpacker_lite/version.rb

@@ -1,3 +1,3 @@
 module WebpackerLite
-  VERSION = "1.0.0".freeze
+  VERSION = "2.0.0".freeze
 end

data/test/configuration_test.rb

@@ -0,0 +1,13 @@
+require "webpacker_test"
+
+class ConfigurationTest < Minitest::Test
+  def test_manifest_path
+    manifest_path = File.join(File.dirname(__FILE__), "test_app/public/webpack", "manifest.json").to_s
+    assert_equal WebpackerLite::Configuration.manifest_path.to_s, manifest_path
+  end
+
+  def test_output_path
+    output_path = File.join(File.dirname(__FILE__), "test_app/public/webpack").to_s
+    assert_equal WebpackerLite::Configuration.webpack_public_output_dir.to_s, output_path
+  end
+end

data/test/env_test.rb

@@ -0,0 +1,12 @@
+require "webpacker_test"
+
+class EnvTest < Minitest::Test
+  def test_current_env
+    assert_equal WebpackerLite::Env.current, "production"
+  end
+
+  def test_file_path
+    correct_path = File.join(File.dirname(__FILE__), "test_app/config", "webpacker_lite.yml").to_s
+    assert_equal WebpackerLite::Env.file_path.to_s, correct_path
+  end
+end

data/test/helper_test.rb

@@ -0,0 +1,23 @@
+require "webpacker_test"
+
+class HelperTest < ActionView::TestCase
+  def setup
+    @view = ActionView::Base.new
+    @view.extend WebpackerLite::Helper
+  end
+
+  def test_asset_pack_path
+    assert_equal @view.asset_pack_path("bootstrap.js"), "/webpack/bootstrap-300631c4f0e0f9c865bc.js"
+    assert_equal @view.asset_pack_path("bootstrap.css"), "/webpack/bootstrap-c38deda30895059837cf.css"
+  end
+
+  def test_javascript_pack_tag
+    script = %(<script src="/webpack/bootstrap-300631c4f0e0f9c865bc.js"></script>)
+    assert_equal @view.javascript_pack_tag("bootstrap.js"), script
+  end
+
+  def test_stylesheet_pack_tag
+    expected_style = %(<link rel="stylesheet" media="screen" href="/webpack/bootstrap-c38deda30895059837cf.css" />)
+    assert_equal @view.stylesheet_pack_tag("bootstrap.css"), expected_style
+  end
+end

data/test/manifest_test.rb

@@ -0,0 +1,31 @@
+require "webpacker_test"
+
+class ManifestTest < Minitest::Test
+  def test_file_path
+    file_path = File.join(File.dirname(__FILE__), "test_app/public/webpack", "manifest.json").to_s
+    assert_equal WebpackerLite::Manifest.file_path.to_s, file_path
+  end
+
+  def test_lookup_exception
+    manifest_path = File.join(File.dirname(__FILE__), "test_app/public/webpack", "manifest.json").to_s
+    asset_file = "calendar.js"
+    msg = <<-MSG
+        WebpackerLite can't find #{asset_file} in your manifest #{manifest_path}. Possible causes:
+          1. You are hot reloading
+          2. Webpack is not running
+          3. You have misconfigured WebpackerLite's config/webpacker_lite.yml file.
+          4. Your Webpack configuration is not creating a manifest.
+    MSG
+
+    error = assert_raises WebpackerLite::FileLoader::NotFoundError do
+      WebpackerLite::Manifest.lookup(asset_file)
+    end
+
+    assert_equal error.message, msg
+  end
+
+  def test_lookup_success
+    asset_file = "bootstrap.js"
+    assert_equal WebpackerLite::Manifest.lookup(asset_file), "bootstrap-300631c4f0e0f9c865bc.js"
+  end
+end

data/test/test_app/config/secrets.yml

@@ -0,0 +1,5 @@
+development:
+  secret_key_base: 'abcdef'
+
+test:
+  secret_key_base: 'abcdef'

data/test/test_app/public/webpack/manifest.json

@@ -0,0 +1,4 @@
+{
+  "bootstrap.css": "bootstrap-c38deda30895059837cf.css",
+  "bootstrap.js": "bootstrap-300631c4f0e0f9c865bc.js"
+}

data/test/webpacker_test.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+require "minitest/autorun"
+require "rails"
+require "rails/test_help"
+require "webpacker_lite"
+
+module TestApp
+  class Application < ::Rails::Application
+    config.root = File.join(File.dirname(__FILE__), "test_app")
+  end
+end
+
+TestApp::Application.initialize!

data/yarn.lock

@@ -0,0 +1,4 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
+# yarn lockfile v1
+
+

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: webpacker_lite
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.0
 platform: ruby
 authors:
 - David Heinemeier Hansson, Justin Gordon
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-03 00:00:00.000000000 Z
+date: 2017-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -94,7 +94,15 @@ files:
 - lib/webpacker_lite/manifest.rb
 - lib/webpacker_lite/railtie.rb
 - lib/webpacker_lite/version.rb
+- test/configuration_test.rb
+- test/env_test.rb
+- test/helper_test.rb
+- test/manifest_test.rb
+- test/test_app/config/secrets.yml
+- test/test_app/public/webpack/manifest.json
+- test/webpacker_test.rb
 - webpacker.gemspec
+- yarn.lock
 homepage: https://github.com/shakacode/webpacker_lite
 licenses:
 - MIT
@@ -119,4 +127,11 @@ rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Asset Helpers for Webpack
-test_files: []
+test_files:
+- test/configuration_test.rb
+- test/env_test.rb
+- test/helper_test.rb
+- test/manifest_test.rb
+- test/test_app/config/secrets.yml
+- test/test_app/public/webpack/manifest.json
+- test/webpacker_test.rb