webpacker 3.2.1 → 3.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5a54f5131894092cf3a3c2176cca4c3d2d99cb10
-  data.tar.gz: 82eb7c75ef0ce343c7e8bb8b66efffb92d9ba252
+SHA256:
+  metadata.gz: c15a75f6c29cc05aae6839309adee7e0db2b51ef63976992e03b1d684e703b70
+  data.tar.gz: c02f95838b9f7ca24c178053eeae3eed75523c72a17276e18a1b0b93b4be90c1
 SHA512:
-  metadata.gz: '088e85d9e4d9534b51b55ec1c69db1cbee256ac5d965c8b49ce2d9f1a1c92ccf17ef22432e58ac52ffb78629aa2708429e5ad39e0277a4917ec9412242ed64af'
-  data.tar.gz: fdeab469b4ce1d04d34f7a33a810c286c0783ff69f1c8e95d4f7664fea6f9f02e0b67c4bb0b71db76e2732c42d1ba8afa8c8ea9234dd69ea76671c706fb4600e
+  metadata.gz: 79e537a4b5ef7e67da86b59cf3a74c7182b79cd3787285fe06032b2a2d2c0a5fba8b35961caba36e125ffc65d17641eb331fe2d63baee59724efc9e4c0d849da
+  data.tar.gz: 2905386f28390de59651c450c08cad42bcaadc35e2e59ff92ee7e310c9d85aeadf2a208f4634d29896fb749e4e4a1ac3e4fd28a80905315acd6da0d43067c2d5

data/.travis.yml

@@ -1,11 +1,11 @@
 sudo: false
 language: ruby
 before_install:
-  - gem update --system 
+  - gem update --system
 rvm:
-  - 2.2.8
-  - 2.3.5
-  - 2.4.2
+  - 2.2.9
+  - 2.3.6
+  - 2.4.3
   - 2.5.0
   - ruby-head
 gemfile:

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 **Please note that Webpacker 3.1.0 and 3.1.1 has some serious bugs so please consider using either 3.0.2 or 3.2.0**
 
+## [3.2.2] - 2018-02-11
+
+### Added
+
+- Stimulus example [https://stimulusjs.org/](https://stimulusjs.org/)
+
+```bash
+bundle exec rails webpacker:install:stimulus
+```
+
+- Upgrade gems and npm packages [#1254](https://github.com/rails/webpacker/pull/1254)
+
+And, bunch of bug fixes [See changes](https://github.com/rails/webpacker/compare/v3.2.1...3.2.2)
+
 ## [3.2.1] - 2018-01-21
 
 - Disable dev server running? check if no dev server config is present in that environment [#1179](https://github.com/rails/webpacker/pull/1179)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    webpacker (3.2.1)
+    webpacker (3.2.2)
       activesupport (>= 4.2)
       rack-proxy (>= 0.6.1)
       railties (>= 4.2)
@@ -47,15 +47,15 @@ GEM
       minitest (~> 5.1)
       tzinfo (~> 1.1)
     arel (8.0.0)
-    ast (2.3.0)
+    ast (2.4.0)
     builder (3.2.3)
-    byebug (9.1.0)
+    byebug (10.0.0)
     concurrent-ruby (1.0.5)
     crass (1.0.3)
     erubi (1.7.0)
     globalid (0.4.1)
       activesupport (>= 4.2.0)
-    i18n (0.9.1)
+    i18n (0.9.3)
       concurrent-ruby (~> 1.0)
     loofah (2.1.1)
       crass (~> 1.0.2)
@@ -65,15 +65,15 @@ GEM
     method_source (0.9.0)
     mini_mime (1.0.0)
     mini_portile2 (2.3.0)
-    minitest (5.11.1)
+    minitest (5.11.3)
     nio4r (2.2.0)
-    nokogiri (1.8.1)
+    nokogiri (1.8.2)
       mini_portile2 (~> 2.3.0)
     parallel (1.12.1)
     parser (2.4.0.2)
       ast (~> 2.3)
     powerpack (0.1.1)
-    rack (2.0.3)
+    rack (2.0.4)
     rack-proxy (0.6.3)
       rack
     rack-test (0.8.2)
@@ -120,7 +120,7 @@ GEM
       sprockets (>= 3.0.0)
     thor (0.20.0)
     thread_safe (0.3.6)
-    tzinfo (1.2.4)
+    tzinfo (1.2.5)
       thread_safe (~> 0.1)
     unicode-display_width (1.3.0)
     websocket-driver (0.6.5)
@@ -141,4 +141,4 @@ DEPENDENCIES
   webpacker!
 
 BUNDLED WITH
-   1.15.4
+   1.16.1

data/README.md

@@ -30,6 +30,7 @@ in which case you may not even need the asset pipeline. This is mostly relevant
   - [Angular with TypeScript](#angular-with-typescript)
   - [Vue](#vue)
   - [Elm](#elm)
+  - [Stimulus](#stimulus)
   - [Coffeescript](#coffeescript)
   - [Erb](#erb)
 - [Paths](#paths)
@@ -79,7 +80,7 @@ Or add it to your `Gemfile`:
 
 ```ruby
 # Gemfile
-gem 'webpacker', '~> 3.0'
+gem 'webpacker', '~> 3.2'
 
 # OR if you prefer to use master
 gem 'webpacker', git: 'https://github.com/rails/webpacker.git'
@@ -306,7 +307,7 @@ configuration:
     p.script_src :self, :https
   end
 ```
-You can read more this in [Vue docs](https://vuejs.org/v2/guide/installation.html#CSP-environments).
+You can read more about this in the [Vue docs](https://vuejs.org/v2/guide/installation.html#CSP-environments).
 
 
 ### Elm
@@ -325,6 +326,20 @@ The Elm library and core packages will be added via Yarn and Elm itself.
 An example `Main.elm` app will also be added to your project in `app/javascript`
 so that you can experiment with Elm right away.
 
+### Stimulus
+
+To use Webpacker with [Stimulus](http://stimulusjs.org), create a
+new Rails 5.1+ app using `--webpack=stimulus` option:
+
+```
+# Rails 5.1+
+rails new myapp --webpack=stimulus
+```
+
+(or run `bundle exec rails webpacker:install:stimulus` on a Rails app already setup with Webpacker).
+
+Please read [The Stimulus Handbook](https://stimulusjs.org/handbook/introduction) or learn more about its source code at https://github.com/stimulusjs/stimulus
+
 ### Coffeescript
 
 To add [Coffeescript](http://coffeescript.org/) support,

data/docs/docker.md

@@ -39,7 +39,7 @@ and create an env file to load environment variables from:
 ```env
 NODE_ENV=development
 RAILS_ENV=development
-WEBPACKER_DEV_SERVER_HOST: 0.0.0.0
+WEBPACKER_DEV_SERVER_HOST=0.0.0.0
 ```
 
 Lastly, rebuild your container:

data/lib/install/angular.rb

@@ -9,4 +9,15 @@ directory "#{__dir__}/examples/angular/hello_angular", "#{Webpacker.config.sourc
 say "Installing all angular dependencies"
 run "yarn add core-js zone.js rxjs @angular/core @angular/common @angular/compiler @angular/platform-browser @angular/platform-browser-dynamic"
 
+if Rails::VERSION::MAJOR == 5 && Rails::VERSION::MINOR > 1
+  say "You need to enable unsafe-eval rule.", :yellow
+  say "This can be done in Rails 5.2+ for development environment in the CSP initializer", :yellow
+  say "config/initializers/content_security_policy.rb with a snippet like this:", :yellow
+  say "if Rails.env.development?", :yellow
+  say "  p.script_src :self, :https, :unsafe_eval", :yellow
+  say "else", :yellow
+  say "  p.script_src :self, :https", :yellow
+  say "end", :yellow
+end
+
 say "Webpacker now supports angular 🎉", :green

data/lib/install/examples/coffee/hello_coffee.coffee

@@ -1,4 +1,4 @@
-# Run this example by adding <%%= javascript_pack_tag 'hello_coffee' %> to the head of your layout file,
+# Run this example by adding <%= javascript_pack_tag 'hello_coffee' %> to the head of your layout file,
 # like app/views/layouts/application.html.erb.
 
 console.log 'Hello world from coffeescript'

data/lib/install/examples/erb/hello_erb.js.erb

@@ -1,4 +1,4 @@
-// Run this example by adding <%%= javascript_pack_tag 'hello_erb' %> to the head of your layout file,
+// Run this example by adding <%= javascript_pack_tag 'hello_erb' %> to the head of your layout file,
 // like app/views/layouts/application.html.erb.
 
 <% name = 'Erb' %>

data/lib/install/examples/stimulus/application.js

@@ -0,0 +1,6 @@
+import { Application } from "stimulus"
+import { definitionsFromContext } from "stimulus/webpack-helpers"
+
+const application = Application.start()
+const context = require.context("controllers", true, /.js$/)
+application.load(definitionsFromContext(context))

data/lib/install/examples/stimulus/controllers/hello_controller.js

@@ -0,0 +1,18 @@
+// Visit The Stimulus Handbook for more details 
+// https://stimulusjs.org/handbook/introduction
+// 
+// This example controller works with specially annotated HTML like:
+//
+// <div data-controller="hello">
+//   <h1 data-target="hello.output"></h1>
+// </div>
+
+import { Controller } from "stimulus"
+
+export default class extends Controller {
+  static targets = [ "output" ]
+
+  connect() {
+    this.outputTarget.textContent = 'Hello, Stimulus!'
+  }
+}

data/lib/install/examples/typescript/hello_typescript.ts

@@ -1,4 +1,4 @@
-// Run this example by adding <%%= javascript_pack_tag 'hello_typescript' %> to the head of your layout file,
+// Run this example by adding <%= javascript_pack_tag 'hello_typescript' %> to the head of your layout file,
 // like app/views/layouts/application.html.erb.
 
 console.log('Hello world from typescript');

data/lib/install/stimulus.rb

@@ -0,0 +1,12 @@
+say "Appending Stimulus setup code to #{Webpacker.config.source_entry_path}/application.js"
+append_to_file "#{Webpacker.config.source_entry_path}/application.js" do
+  "\n" + open("#{__dir__}/examples/stimulus/application.js").read
+end
+
+say "Creating controllers directory"
+directory "#{__dir__}/examples/stimulus/controllers", "#{Webpacker.config.source_path}/controllers"
+
+say "Installing all Stimulus dependencies"
+run "yarn add stimulus"
+
+say "Webpacker now supports Stimulus.js 🎉", :green

data/lib/install/template.rb

@@ -18,9 +18,18 @@ run "bundle binstubs webpacker"
 
 say "Adding configurations"
 
+check_yarn_integrity_config = ->(value) { <<CONFIG }
 # Verifies that versions and hashed value of the package contents in the project's package.json
-inject_into_file "config/environments/development.rb", "    config.webpacker.check_yarn_integrity = true", after: "Rails.application.configure do\n", verbose: false
-inject_into_file "config/environments/production.rb", "   config.webpacker.check_yarn_integrity = false", after: "Rails.application.configure do\n", verbose: false
+  config.webpacker.check_yarn_integrity = #{value}
+CONFIG
+
+if Rails::VERSION::MAJOR >= 5
+  environment check_yarn_integrity_config.call("true"), env: :development
+  environment check_yarn_integrity_config.call("false"), env: :production
+else
+  inject_into_file "config/environments/development.rb", "\n  #{check_yarn_integrity_config.call("true")}", after: "Rails.application.configure do", verbose: false
+  inject_into_file "config/environments/production.rb", "\n  #{check_yarn_integrity_config.call("false")}", after: "Rails.application.configure do", verbose: false
+end
 
 if File.exists?(".gitignore")
   append_to_file ".gitignore", <<-EOS
@@ -28,7 +37,6 @@ if File.exists?(".gitignore")
 /public/packs-test
 /node_modules
 yarn-debug.log*
-yarn-error.log*
 .yarn-integrity
 EOS
 end
@@ -39,4 +47,11 @@ run "yarn add @rails/webpacker"
 say "Installing dev server for live reloading"
 run "yarn add --dev webpack-dev-server"
 
+if Rails::VERSION::MAJOR == 5 && Rails::VERSION::MINOR > 1
+  say "You need to allow webpack-dev-server host as allowed origin for connect-src.", :yellow
+  say "This can be done in Rails 5.2+ for development environment in the CSP initializer", :yellow
+  say "config/initializers/content_security_policy.rb with a snippet like this:", :yellow
+  say "p.connect_src :self, :https, \"http://localhost:3035\", \"ws://localhost:3035\" if Rails.env.development?", :yellow
+end
+
 say "Webpacker successfully installed 🎉 🍰", :green

data/lib/install/vue.rb

@@ -26,4 +26,15 @@ copy_file "#{__dir__}/examples/vue/app.vue",
 say "Installing all Vue dependencies"
 run "yarn add vue vue-loader vue-template-compiler"
 
+if Rails::VERSION::MAJOR == 5 && Rails::VERSION::MINOR > 1
+  say "You need to enable unsafe-eval rule.", :yellow
+  say "This can be done in Rails 5.2+ for development environment in the CSP initializer", :yellow
+  say "config/initializers/content_security_policy.rb with a snippet like this:", :yellow
+  say "if Rails.env.development?", :yellow
+  say "  p.script_src :self, :https, :unsafe_eval", :yellow
+  say "else", :yellow
+  say "  p.script_src :self, :https", :yellow
+  say "end", :yellow
+end
+
 say "Webpacker now supports Vue.js 🎉", :green

data/lib/tasks/installers.rake

@@ -5,7 +5,8 @@ installers = {
   "Vue": :vue,
   "Erb": :erb,
   "Coffee": :coffee,
-  "Typescript": :typescript
+  "Typescript": :typescript,
+  "Stimulus": :stimulus
 }.freeze
 
 dependencies = {

data/lib/tasks/webpacker.rake

@@ -11,6 +11,7 @@ tasks = {
   "webpacker:install:vue"             => "Installs and setup example Vue component",
   "webpacker:install:angular"         => "Installs and setup example Angular component",
   "webpacker:install:elm"             => "Installs and setup example Elm component",
+  "webpacker:install:stimulus"        => "Installs and setup example Stimulus component",
   "webpacker:install:erb"             => "Installs Erb loader with an example",
   "webpacker:install:coffee"          => "Installs CoffeeScript loader with an example",
   "webpacker:install:typescript"      => "Installs Typescript loader with an example"

data/lib/webpacker/helper.rb

@@ -11,7 +11,7 @@ module Webpacker::Helper
   #   # In production mode:
   #   <%= asset_pack_path 'calendar.css' %> # => "/packs/calendar-1016838bab065ae1e122.css"
   def asset_pack_path(name, **options)
-    unless Webpacker.dev_server.running? && Webpacker.dev_server.hot_module_replacing?
+    unless stylesheet?(name) && Webpacker.dev_server.running? && Webpacker.dev_server.hot_module_replacing?
       asset_path(Webpacker.manifest.lookup!(name), **options)
     end
   end
@@ -68,6 +68,10 @@ module Webpacker::Helper
   end
 
   private
+    def stylesheet?(name)
+      File.extname(name) == ".css"
+    end
+
     def sources_from_pack_manifest(names, type:)
       names.map { |name| Webpacker.manifest.lookup!(pack_name_with_extension(name, type: type)) }
     end

data/lib/webpacker/railtie.rb

@@ -28,17 +28,17 @@ class Webpacker::Engine < ::Rails::Engine
       output = `yarn check --integrity 2>&1`
 
       unless $?.success?
-        warn "\n\n"
-        warn "========================================"
-        warn "  Your Yarn packages are out of date!"
-        warn "  Please run `yarn install` to update."
-        warn "========================================"
-        warn "\n\n"
-        warn "To disable this check, please add `config.webpacker.check_yarn_integrity = false`"
-        warn "to your Rails development config file (config/environments/development.rb)."
-        warn "\n\n"
-        warn output
-        warn "\n\n"
+        $stderr.puts "\n\n"
+        $stderr.puts "========================================"
+        $stderr.puts "  Your Yarn packages are out of date!"
+        $stderr.puts "  Please run `yarn install` to update."
+        $stderr.puts "========================================"
+        $stderr.puts "\n\n"
+        $stderr.puts "To disable this check, please add `config.webpacker.check_yarn_integrity = false`"
+        $stderr.puts "to your Rails development config file (config/environments/development.rb)."
+        $stderr.puts "\n\n"
+        $stderr.puts output
+        $stderr.puts "\n\n"
 
         exit(1)
       end

data/lib/webpacker/version.rb

@@ -1,4 +1,4 @@
 module Webpacker
   # Change the version in package.json too, please!
-  VERSION = "3.2.1".freeze
+  VERSION = "3.2.2".freeze
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rails/webpacker",
-  "version": "3.2.1",
+  "version": "3.2.2",
   "description": "Use webpack to manage app-like JavaScript modules in Rails",
   "main": "package/index.js",
   "files": [
@@ -20,30 +20,30 @@
     "babel-polyfill": "^6.26.0",
     "babel-preset-env": "^1.6.1",
     "case-sensitive-paths-webpack-plugin": "^2.1.1",
-    "compression-webpack-plugin": "^1.1.3",
-    "css-loader": "^0.28.8",
+    "compression-webpack-plugin": "^1.1.6",
+    "css-loader": "^0.28.9",
     "extract-text-webpack-plugin": "^3.0.2",
     "file-loader": "^1.1.6",
     "glob": "^7.1.2",
     "js-yaml": "^3.10.0",
     "node-sass": "^4.7.2",
     "path-complete-extname": "^0.1.0",
-    "postcss-cssnext": "^3.0.2",
+    "postcss-cssnext": "^3.1.0",
     "postcss-import": "^11.0.0",
-    "postcss-loader": "^2.0.10",
+    "postcss-loader": "^2.1.0",
     "sass-loader": "^6.0.6",
-    "style-loader": "^0.19.1",
-    "uglifyjs-webpack-plugin": "^1.1.6",
+    "style-loader": "^0.20.1",
+    "uglifyjs-webpack-plugin": "^1.1.8",
     "webpack": "^3.10.0",
     "webpack-manifest-plugin": "^1.3.2"
   },
   "devDependencies": {
-    "eslint": "^4.15.0",
+    "eslint": "^4.17.0",
     "eslint-config-airbnb": "^16.1.0",
     "eslint-plugin-import": "^2.8.0",
     "eslint-plugin-jsx-a11y": "^6.0.3",
-    "eslint-plugin-react": "^7.5.1",
-    "jest": "^22.0.6"
+    "eslint-plugin-react": "^7.6.1",
+    "jest": "^22.2.1"
   },
   "jest": {
     "testRegex": "(/__tests__/.*|(\\.|/))\\.jsx?$",

data/package/__tests__/config.js

@@ -0,0 +1,25 @@
+/* global test expect, describe */
+
+const chdirApp = () => process.chdir('test/test_app')
+const chdirCwd = () => process.chdir(process.cwd())
+chdirApp()
+
+const config = require('../config')
+
+describe('Webpacker.yml config', () => {
+  afterAll(chdirCwd)
+
+  test('should return extensions as listed in app config', () => {
+    expect(config.extensions).toEqual([
+      '.js',
+      '.sass',
+      '.scss',
+      '.css',
+      '.png',
+      '.svg',
+      '.gif',
+      '.jpeg',
+      '.jpg'
+    ])
+  })
+})