webpacker 1.1 → 1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: afb4934952e44753c407df428b480d135304df59
-  data.tar.gz: f124edb9f58ce86a53dbea607abaea20899c8ab4
+  metadata.gz: 3ccfe0b6654653e31fa2f154132007bbde99b751
+  data.tar.gz: 14f29f16a493bc35b35162feaea491027dd736fa
 SHA512:
-  metadata.gz: 3d446150ede6cbec18cd3117b85ff8afa66223b8d68f33db1530206279b3226f6938382fd37d2bee8c5bca31f8136161596541d9c2e6e69e0163e4d6ce85ee05
-  data.tar.gz: 9e8c65dd9322341a790f073c55146c6305aab8210260320d4e6834581fccef83ca0312bc2bffb59e9764f5693a6acef4d099a0c97fe928d7f5bb4532c99d4373
+  metadata.gz: 40170698d19c5b726d2a6407ea14c385d57c4e90feb44b72e42b1bb05f478cb2e8467ec9b727a32be423b74efe3e1aa97c6bd2f667205354b82ab3f66dc32488
+  data.tar.gz: fa16cf6e69c87157b4f0eb310d1a2c3d978dc71469ec42cab00926e55db77aa7706dacf749c4871c21e71baaf49d1fada7c4626d2560699bb8e3e7c49b7621fe

data/.travis.yml

@@ -1,11 +1,9 @@
-sudo: required
+sudo: false
 language: ruby
 rvm:
   - 2.2.6
-
-services:
-  - docker
-
+  - 2.3.3
+  - 2.4.1
 cache:
   bundler: true
   directories:
@@ -13,12 +11,12 @@ cache:
   yarn: true
 
 install:
-  - gem install rubocop
+  - bundle install
   - nvm install node
   - node -v
   - npm i -g yarn
   - yarn
-
 script:
   - yarn lint
-  - rubocop
+  - bundle exec rubocop
+  - bundle exec rake test

data/CHANGELOG.md

@@ -0,0 +1,64 @@
+## [1.2] - 2017-04-27
+Some of the changes made requires you to run below commands to install new changes.
+
+```bash
+bundle update webpacker
+bundle exec rails webpacker:install
+```
+
+### Fixed
+- Support Spring - [#205](https://github.com/rails/webpacker/issues/205)
+
+  ```ruby
+    Spring.after_fork {  Webpacker.bootstrap } if defined?(Spring)
+  ```
+- Check node version and yarn before installing webpacker - [#217](https://github.com/rails/webpacker/issues/217)
+
+- Include webpacker helper to views - [#172](https://github.com/rails/webpacker/issues/172)
+
+- Webpacker installer on windows - [#245](https://github.com/rails/webpacker/issues/245)
+
+- Yarn duplication - [#278](https://github.com/rails/webpacker/issues/278)
+
+- Add back Spring for `rails-erb-loader` - [#216](https://github.com/rails/webpacker/issues/216)
+
+- Move babel presets and plugins to .babelrc - [#202](https://github.com/rails/webpacker/issues/202)
+
+### Added
+- A changelog - [#211](https://github.com/rails/webpacker/issues/211)
+- Minimize CSS assets - [#218](https://github.com/rails/webpacker/issues/218)
+- Pack namespacing support - [#201](https://github.com/rails/webpacker/pull/201)
+
+```
+app/javascript/packs/admin/hello_vue.js
+app/javascript/packs/admin/hello.vue
+app/javascript/packs/hello_vue.js
+app/javascript/packs/hello.vue
+```
+- Add tree-shaking support - [#250](https://github.com/rails/webpacker/pull/250)
+- Add initial test case by @kimquy [#259](https://github.com/rails/webpacker/pull/259)
+- Compile assets before test:controllers and test:system
+
+### Removed
+- Webpack watcher - [#295](https://github.com/rails/webpacker/pull/295)
+
+## [1.1] - 2017-03-24
+
+This release requires you to run below commands to install new features.
+
+```bash
+bundle update webpacker
+bundle exec rails webpacker:install
+# if installed react, vue or angular
+bundle exec rails webpacker:install:[react, angular, vue]
+```
+
+### Added (breaking changes)
+- Static assets support - [#153](https://github.com/rails/webpacker/pull/153)
+- Advanced webpack configuration - [#153](https://github.com/rails/webpacker/pull/153)
+
+### Removed
+
+```rb
+config.x.webpacker[:digesting] = true
+```

data/Gemfile

@@ -1,3 +1,11 @@
 source "https://rubygems.org"
 
 gemspec
+
+gem "rails"
+gem "rake", ">= 11.1"
+gem "rubocop", ">= 0.47", require: false
+
+group :test do
+  gem "minitest", "~> 5.0"
+end

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    webpacker (1.0)
+    webpacker (1.1)
       activesupport (>= 4.2)
       multi_json (~> 1.2)
       railties (>= 4.2)
@@ -9,6 +9,16 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
+    actioncable (5.0.1)
+      actionpack (= 5.0.1)
+      nio4r (~> 1.2)
+      websocket-driver (~> 0.6.1)
+    actionmailer (5.0.1)
+      actionpack (= 5.0.1)
+      actionview (= 5.0.1)
+      activejob (= 5.0.1)
+      mail (~> 2.5, >= 2.5.4)
+      rails-dom-testing (~> 2.0)
     actionpack (5.0.1)
       actionview (= 5.0.1)
       activesupport (= 5.0.1)
@@ -22,26 +32,60 @@ GEM
       erubis (~> 2.7.0)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.0.2)
+    activejob (5.0.1)
+      activesupport (= 5.0.1)
+      globalid (>= 0.3.6)
+    activemodel (5.0.1)
+      activesupport (= 5.0.1)
+    activerecord (5.0.1)
+      activemodel (= 5.0.1)
+      activesupport (= 5.0.1)
+      arel (~> 7.0)
     activesupport (5.0.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (~> 0.7)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
+    arel (7.1.4)
+    ast (2.3.0)
     builder (3.2.3)
     concurrent-ruby (1.0.5)
     erubis (2.7.0)
+    globalid (0.3.7)
+      activesupport (>= 4.1.0)
     i18n (0.8.1)
     loofah (2.0.3)
       nokogiri (>= 1.5.9)
+    mail (2.6.4)
+      mime-types (>= 1.16, < 4)
     method_source (0.8.2)
+    mime-types (3.1)
+      mime-types-data (~> 3.2015)
+    mime-types-data (3.2016.0521)
     mini_portile2 (2.1.0)
     minitest (5.10.1)
     multi_json (1.12.1)
+    nio4r (1.2.1)
     nokogiri (1.7.0.1)
       mini_portile2 (~> 2.1.0)
+    parser (2.4.0.0)
+      ast (~> 2.2)
+    powerpack (0.1.1)
     rack (2.0.1)
     rack-test (0.6.3)
       rack (>= 1.0)
+    rails (5.0.1)
+      actioncable (= 5.0.1)
+      actionmailer (= 5.0.1)
+      actionpack (= 5.0.1)
+      actionview (= 5.0.1)
+      activejob (= 5.0.1)
+      activemodel (= 5.0.1)
+      activerecord (= 5.0.1)
+      activesupport (= 5.0.1)
+      bundler (>= 1.3.0, < 2.0)
+      railties (= 5.0.1)
+      sprockets-rails (>= 2.0.0)
     rails-dom-testing (2.0.2)
       activesupport (>= 4.2.0, < 6.0)
       nokogiri (~> 1.6)
@@ -53,17 +97,40 @@ GEM
       method_source
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
+    rainbow (2.2.1)
     rake (12.0.0)
+    rubocop (0.47.1)
+      parser (>= 2.3.3.1, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    ruby-progressbar (1.8.1)
+    sprockets (3.7.1)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-rails (3.2.0)
+      actionpack (>= 4.0)
+      activesupport (>= 4.0)
+      sprockets (>= 3.0.0)
     thor (0.19.4)
     thread_safe (0.3.6)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
+    unicode-display_width (1.1.3)
+    websocket-driver (0.6.5)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.2)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   bundler (~> 1.12)
+  minitest (~> 5.0)
+  rails
+  rake (>= 11.1)
+  rubocop (>= 0.47)
   webpacker!
 
 BUNDLED WITH

data/README.md

@@ -1,14 +1,26 @@
 # Webpacker
 ![travis-ci status](https://api.travis-ci.org/rails/webpacker.svg?branch=master)
+[![node.js](https://img.shields.io/badge/node-%3E%3D%206.4.0-brightgreen.svg)](https://nodejs.org/en/)
+[![Gem](https://img.shields.io/gem/v/webpacker.svg)](https://github.com/rails/webpacker)
 
-Webpacker makes it easy to use the JavaScript preprocessor and bundler [Webpack](https://webpack.github.io)
+Webpacker makes it easy to use the JavaScript preprocessor and bundler [Webpack 2.x.x+](https://webpack.js.org/)
 to manage application-like JavaScript in Rails. It coexists with the asset pipeline,
-as the purpose is only to use Webpack for app-like JavaScript, not images, css, or
-even JavaScript Sprinkles (that all continues to live in app/assets).
+as the primary purpose for Webpack is app-like JavaScript, not images, css, or
+even JavaScript Sprinkles (that all continues to live in app/assets). It is, however,
+possible to use Webpacker for CSS and images assets as well, in which case you may not
+even need the asset pipeline. This is mostly relevant when exclusively using component-based
+JavaScript frameworks.
 
 It's designed to work with Rails 5.1+ and makes use of the [Yarn](https://yarnpkg.com) dependency management
 that's been made default from that version forward.
 
+## Prerequisites
+
+* Ruby 2.2+
+* Rails 4.2+
+* Node.js 6.4.0+
+* Yarn
+
 ## Installation
 
 Webpacker is currently compatible with Rails 4.2+, but there's no guarantee it will still be
@@ -27,24 +39,13 @@ You can also see a list of available commands by running `./bin/rails webpacker`
 
 ## Binstubs
 
-Webpacker ships with three binstubs: `./bin/webpack`, `./bin/webpack-watcher` and `./bin/webpack-dev-server`.
-They're thin wrappers around the standard webpack.js executable, just to ensure that the right configuration
-file is loaded.
-
+Webpacker ships with two binstubs: `./bin/webpack` and `./bin/webpack-dev-server`.
+They're thin wrappers around the standard webpack.js executable, just to ensure that the right configuration file is loaded depending on your environment.
 
 A binstub is also created to install your npm dependencies,
 and can be called via `./bin/yarn`.
 
-In development, you'll need to run `./bin/webpack-watcher` in a separate terminal from
-`./bin/rails server` to have your `app/javascript/packs/*.js` files compiled as you make changes.
-If you'd rather not have to run the two processes separately by hand, you can use
-[Foreman](https://ddollar.github.io/foreman).
-
-Alternatively, you can run `./bin/webpack-dev-server`. This will launch a
-[Webpack Dev Server](https://webpack.github.io/docs/webpack-dev-server.html) listening on http://localhost:8080/
-serving your pack files. This setup allows you to leverage advanced Webpack features, such
-as [Hot Module Replacement](https://webpack.github.io/docs/hot-module-replacement-with-webpack.html).
-
+In development, you'll need to run `./bin/webpack-dev-server` in a separate terminal from `./bin/rails server` to have your `app/javascript/packs/*.js` files compiled as you make changes. If you'd rather not have to run the two processes separately by hand, you can use [Foreman](https://ddollar.github.io/foreman). `./bin/webpack-dev-server` launches the [Webpack Dev Server](https://webpack.js.org/configuration/dev-server/), which serves your pack files on http://localhost:8080/, and provides advanced Webpack features, such as [Hot Module Replacement](https://webpack.js.org/guides/hmr-react/).
 
 ## Configuration
 
@@ -72,13 +73,34 @@ app/javascript/calendar/models/month.js
 ```
 
 ```erb
-<%# app/views/layout/application.html.erb %>
+<%# app/views/layouts/application.html.erb %>
 <%= javascript_pack_tag 'calendar' %>
 <%= stylesheet_pack_tag 'calendar' %>
 ```
 
 But it could also look a million other ways.
 
+**Note:** You can also namespace your packs using directories, similar to a Rails app.
+
+```
+app/javascript/packs/admin/orders.js
+app/javascript/packs/shop/orders.js
+```
+
+and reference them in your views like this:
+
+```erb
+<%# app/views/admin/orders/index.html.erb %>
+<%= javascript_pack_tag 'admin/orders' %>
+```
+
+and
+
+```erb
+<%# app/views/shop/orders/index.html.erb %>
+<%= javascript_pack_tag 'shop/orders' %>
+```
+
 ## Advanced Configuration
 
 By default, webpacker offers simple conventions for where the webpack configs, javascript app files and compiled webpack bundles will go in your rails app,
@@ -109,11 +131,6 @@ port: 8080
 By default, `webpack-dev-server` uses `output` option specified in
 `paths.yml` as `contentBase`.
 
-**Note:** Don't forget to disable `webpack-dev-server` incase you are using
-`./bin/webpack-watcher` to serve assets in development mode otherwise
-you will get 404 for assets because the helper tag will use webpack-dev-server url
-to serve assets instead of public directory.
-
 ## Linking to static assets
 
 Static assets like images, fonts and stylesheets support is enabled out-of-box so, you can link them into your javascript app code and have them compiled automatically.
@@ -124,7 +141,7 @@ Static assets like images, fonts and stylesheets support is enabled out-of-box s
 import React from 'react'
 import ReactDOM from 'react-dom'
 import helloIcon from '../hello_react/images/icon.png'
-import './hello-react.sass'
+import '../hello_react/styles/hello-react.sass'
 
 const Hello = props => (
   <div className="hello-react">
@@ -214,7 +231,7 @@ Webpacker uses a `manifest.json` file to keep track of packs in all environments
 however since this file is generated after packs are compiled by webpack. So,
 if you load a view in browser whilst webpack is compiling you will get this error.
 Therefore, make sure webpack
-(i.e `./bin/webpack-watcher` or `./bin/webpack-dev-server`) is running and has
+(i.e `./bin/webpack-dev-server`) is running and has
 completed the compilation successfully before loading a view.
 
 ## Wishlist

data/Rakefile

@@ -1 +1,12 @@
+# frozen_string_literal: true
 require "bundler/gem_tasks"
+require "rake/testtask"
+
+Rake::TestTask.new(:test) do |t|
+  t.libs << "test"
+  t.libs << "lib"
+  t.test_files = FileList["test/**/*_test.rb"]
+  t.verbose = true
+end
+
+task default: :test

data/lib/install/angular.rb

@@ -15,4 +15,4 @@ copy_file "#{__dir__}/examples/angular/tsconfig.json", "tsconfig.json"
 puts "Installing all angular dependencies"
 run "./bin/yarn add typescript ts-loader core-js zone.js rxjs @angular/core @angular/common @angular/compiler @angular/platform-browser @angular/platform-browser-dynamic"
 
-puts "Webpacker now supports angular.js and typescript 🎉"
+puts "Webpacker now supports angular and typescript 🎉"

data/lib/install/bin/webpack-dev-server.tt

@@ -14,7 +14,7 @@ APP_PATH    = File.expand_path("../", __dir__)
 CONFIG_PATH = File.join(APP_PATH, "config/webpack/paths.yml")
 
 begin
-  paths = YAML.load(File.read(CONFIG_PATH))
+  paths = YAML.load(File.read(CONFIG_PATH))[NODE_ENV]
 
   NODE_MODULES_PATH   = File.join(APP_PATH.shellescape, paths["node_modules"])
   WEBPACK_CONFIG_PATH = File.join(APP_PATH.shellescape, paths["config"])
@@ -29,5 +29,5 @@ end
 
 Dir.chdir(APP_PATH) do
   exec "NODE_PATH=#{NODE_MODULES_PATH} #{WEBPACK_BIN} --progress --color " \
-    "--config #{DEV_SERVER_CONFIG}"
+    "--config #{DEV_SERVER_CONFIG} #{ARGV.join(" ")}"
 end

data/lib/install/bin/webpack.tt

@@ -12,21 +12,14 @@ NODE_ENV    = ENV["NODE_ENV"]
 
 APP_PATH               = File.expand_path("../", __dir__)
 CONFIG_PATH            = File.join(APP_PATH, "config/webpack/paths.yml")
-DEV_SERVER_CONFIG_PATH = File.join(APP_PATH, "config/webpack/development.server.yml")
 
 begin
-  paths            = YAML.load(File.read(CONFIG_PATH))
-  dev_server = YAML.load(File.read(DEV_SERVER_CONFIG_PATH))
+  paths            = YAML.load(File.read(CONFIG_PATH))[NODE_ENV]
 
   NODE_MODULES_PATH   = File.join(APP_PATH.shellescape, paths["node_modules"])
   WEBPACK_CONFIG_PATH = File.join(APP_PATH.shellescape, paths["config"])
-
-  if NODE_ENV == "development" && dev_server["enabled"]
-    puts "Warning: webpack-dev-server is currently enabled in #{DEV_SERVER_CONFIG_PATH}. " \
-      "Disable to serve assets directly from public/packs directory"
-  end
 rescue Errno::ENOENT, NoMethodError
-  puts "Configuration not found in config/webpack/paths.yml or config/webpack/development.server.yml."
+  puts "Configuration not found in config/webpack/paths.yml"
   puts "Please run bundle exec rails webpacker:install to install webpacker"
   exit!
 end

data/lib/install/bin/yarn.tt

@@ -4,7 +4,8 @@ Dir.chdir(VENDOR_PATH) do
   begin
     exec "yarnpkg #{ARGV.join(" ")}"
   rescue Errno::ENOENT
-    puts "Yarn executable was not detected in the system."
-    puts "Download Yarn at https://yarnpkg.com/en/docs/install"
+    $stderr.puts "Yarn executable was not detected in the system."
+    $stderr.puts "Download Yarn at https://yarnpkg.com/en/docs/install"
+    exit 1
   end
 end

data/lib/install/config/.babelrc

@@ -0,0 +1,5 @@
+{
+  "presets": [
+    ["env", { "modules": false } ]
+  ]
+}