webpacker-pnpm 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9e0c39889bfdad4a14a2fc35250e7eaa33fd49bf48ecc082c44d1985884fbe89
-  data.tar.gz: 8f27fae2d742a2b4c27e0fa675480dda85771bfd120e283fa706c80ce7414fa5
+  metadata.gz: 9ccdea9b9cf8d7a874d90f5bb13f6f20f9229bfcc232085f8d48ec4fb657168e
+  data.tar.gz: bc53eb621ea514efaf2da1891a0e6dcc4c9dad43f217b923ddb479de705b3104
 SHA512:
-  metadata.gz: 8715f49514245b10d8ed85169c5edadcb2ab8905880f9afdd273121835336c175dec087f05b639179024eeea4fc1745ca24c73d00c24fc92d06bbb85ab591d02
-  data.tar.gz: fd7a0f6cc602c9a7d4ba0a2689fc87feae4d7f93c470c9c5fc8b7f62cfd364fd3152839448150a58c523a0e516aa229eed3d9d07cc1083ed0b4ecaeb9938a5b8
+  metadata.gz: c2091d6c417fcaf65e24bb54f8402001f049b7efa5e4d1bde7594a80f0f87fc5d1a97ea6272012042b3ee1f7980244b728c13b5bdc5ead9b1e69af7a3f4de3b4
+  data.tar.gz: 9932710c5d083577ad15eac9f9086da2355e810e58e84a5d5a4dbda7db9925f14da97c6d6f8c6070f8b33428ede8433ed3a30ddcd2bfd934034b6a32d6d0faff

data/.gitignore

@@ -1,3 +1,6 @@
 /tmp/
-/**/*.log
-Gemfile.lock
+**/log
+Gemfile.lock
+**/*.gem
+gemfiles/vendor
+.bundle

data/.rubocop.yml

@@ -1,91 +1,25 @@
-require: rubocop-rails
-AllCops:
-  Exclude:
-    - "node_modules/**/*"
-
-# disable length length checking, as it tends to make things worse in the majority
-# of cases. however, it is good practice keep lines <= 85 columns so they remain
-# readable.
-Layout/LineLength:
-  Enabled: false
-
-# disable documentation checking. many classes do not require top-level comments,
-# and their inclusion can actually obscure their function.
-Style/Documentation:
-  Enabled: false
-
-# functionalization is important, but the Rails' idiom for returning key-value
-# maps can raise a false alarm with the max line number (10). increase the value
-# to something more reasonable given the circumstances.
-Metrics/MethodLength:
-  Max: 20
-  ExcludedMethods:
-    - test_rake_tasks
-
-# if you're specifying access modifiers, it is likely intentional. force RuboCop
-# to trust your decision making.
-Lint/UselessAccessModifier:
-  Enabled: false
-
-# flag potential memory leaks, like when opening a file.
-Style/AutoResourceCleanup:
-  Enabled: true
-
-# single quotes are meant for single characters. double quotes are meant for
-# strings, which are arrays of multiple characters. there are a whole host of
-# other differences and functions; if you're creating a string, you nearly always
-# should use double quotes.
-#
-# https://en.wikipedia.org/wiki/Delimiter#Bracket_delimiters
-# Schwartz, Randal (2005). Learning Perl. ISBN 978-0-596-10105-3.
-Style/StringLiterals:
-  Enabled: true
-  EnforcedStyle: double_quotes
-
-# flags methods that violate the default ABC magnitude (15). The ABC metric
-# quantizes the size of a method, and is calculated based on the number of
-# assignment operations, possible execution branches, and number of conditionals.
-#
-# https://en.wikipedia.org/wiki/ABC_Software_Metric
-Metrics/AbcSize:
-  Enabled: true
-  IgnoredMethods:
-    - test_rake_tasks
-    - chdir_concurrent
-
-# this simply doesn't work in a cross-platform development environment. Bit
-# flags across UNIX and Windows platforms are volatile, and thus there is no
-# way to ensure this passes besides explicitly granting execute permissions
-# in CI config (which would defeat the purpose).
-Lint/ScriptPermission:
-  Enabled: false
-
-Layout/SpaceAroundMethodCallOperator:
-  Enabled: true
-
-Lint/RaiseException:
-  Enabled: true
-
-Lint/StructNewOverride:
-  Enabled: true
-
-Style/ExponentialNotation:
-  Enabled: true
-
-Style/HashEachMethods:
-  Enabled: true
-
-Style/HashTransformKeys:
-  Enabled: true
-
-Style/HashTransformValues:
-  Enabled: true
-
-Layout/EmptyLinesAroundAttributeAccessor:
-  Enabled: true
-
-Style/SlicingWithRange:
-  Enabled: true
-
-Style/RescueModifier:
-  Enabled: false
+#
+# RuboCop is a Ruby static code analyzer and code formatter that tries to enforce many of
+# the guidelines outlined in the community Ruby and Rails
+# style guides.
+#
+# https://docs.rubocop.org/en/latest/
+# https://rubystyle.guide/
+# https://rails.rubystyle.guide/
+inherit_gem:
+  practical-pig: rubocop-base.yaml
+inherit_mode:
+  merge:
+    - Include
+    - Exclude
+    - IgnoredMethods
+    - AllowedMethods
+
+# cop-specific excludes are not inherited for some reason (likely a bug in RuboCop) so we
+# need to manually re-omit the intended files and directories.
+Layout/LineLength:
+  Exclude:
+    - "**/config/initializers/**/*"
+Style/MethodCallWithArgsParentheses:
+  Exclude:
+    - "**/Gemfile"

data/.travis.yml

@@ -1,11 +1,16 @@
 language: ruby
-os: linux
 dist: bionic
-before_install:
-  - gem install rubygems-update && update_rubygems
-  - yes | rvm @global do gem install bundler -v 2.1.4 || true
+os:
+  - linux
+  - osx
+
+cache:
+  bundler: true
+  npm: true
+  directories:
+    - "~/.pnpm-store"
 rvm:
-  - 2.4.9
+  - 2.4.10
   - 2.5.5
   - 2.6.5
   - 2.7.0
@@ -13,33 +18,25 @@ rvm:
 gemfile:
   - gemfiles/Gemfile-rails.5.2.x
   - gemfiles/Gemfile-rails.6.0.x
-  - gemfiles/Gemfile-rails-edge
-cache:
-  bundler: true
-  npm: false
-  yarn: false
-  directories:
-    - node_modules
-    - "~/.pnpm-store"
 
-install:
-  - bundle install --jobs 3 --retry 3
-  - nvm install 12
-  - node -v
+before_install:
+  - gem install rubygems-update && update_rubygems
+  - yes | rvm @global do gem install bundler -v 2.1.4 || true
+  - nvm install --lts
   - curl -L https://raw.githubusercontent.com/pnpm/self-installer/master/install.js | node
   - pnpm config set store-dir ~/.pnpm-store
+  - bundle config set path 'vendor/bundle'
+install:
+  - bundle install --jobs 3 --retry 3
   - pnpm install --frozen-lockfile
 script:
   - bundle exec rubocop
   - bundle exec rake test
+
 jobs:
+  fast_finish: true
   allow_failures:
-    - gemfile: gemfiles/Gemfile-rails-edge
     - rvm: ruby-head
   exclude:
-    - rvm: 2.4.9
-      gemfile: gemfiles/Gemfile-rails-edge
-    - rvm: 2.5.5
-      gemfile: gemfiles/Gemfile-rails-edge
-    - rvm: 2.4.9
+    - rvm: 2.4.10
       gemfile: gemfiles/Gemfile-rails.6.0.x

data/CHANGELOG.md

@@ -4,6 +4,24 @@ All notable changes to this project will be documented in this file.
 
 The format is based on Keep a Changelog (<https://keepachangelog.com/en/1.0.0/>). This project adheres to Semantic Versioning (<https://semver.org/spec/v2.0.0.html>).
 
+## [v1.2.1] - 2020-05-16
+
+### Added
+
+- Informative error messages when pnpm is not installed.
+- Pessimistic gem dependency version specifications to avoid installation conflicts.
+- Full-length gem description.
+- Forced shameful hoisting of installed pnpm dependencies via `webpacker:pnpm_install`.
+- Practical Pig development dependency for external RuboCop linting.
+
+### Changed
+
+- Commented and adjusted RuboCop formatting rules to clarify design decisions.
+
+### Removed
+
+- Testing configs for bleeding-edge Rails.
+
 ## [v1.2.0] - 2020-05-14
 
 ### Added

data/Gemfile

@@ -3,15 +3,6 @@
 source "https://rubygems.org"
 gemspec
 
-gem "rack-proxy", require: false
-gem "rails", ">= 5.2"
-gem "rake", ">= 12.3.3"
-gem "semantic_range", require: false
-
 install_if -> { Gem.win_platform? } do
   gem "tzinfo-data"
 end
-
-group :test do
-  gem "minitest", ">= 5"
-end

data/README.md

@@ -1,11 +1,13 @@
 # webpacker-pnpm
 
-![version](https://img.shields.io/gem/v/webpacker-pnpm?label=version&style=flat-square)
+[![version](https://img.shields.io/gem/v/webpacker-pnpm?label=version&style=flat-square)](https://rubygems.org/gems/webpacker-pnpm)
 [![status](https://img.shields.io/travis/thearchitector/webpacker-pnpm?style=flat-square)](https://travis-ci.org/github/thearchitector/webpacker-pnpm)
-![downloads](https://img.shields.io/gem/dt/webpacker-pnpm?style=flat-square)
+[![downloads](https://img.shields.io/gem/dt/webpacker-pnpm?style=flat-square)](https://rubygems.org/gems/webpacker-pnpm)
 [![license](https://img.shields.io/badge/license-CC--BY--NC--SA--4.0-green?style=flat-square)](https://creativecommons.org/licenses/by-nc-sa/4.0/)
 
-`webpacker-pnpm` replaces Rails' Yarn environment with [pnpm](https://pnpm.js.org/), which is a much smarter, efficient, and faster alternative Node.js package manager. You can read about the philosophy and technology behind `pnpm` in [this convincing blog post](https://www.kochan.io/nodejs/why-should-we-use-pnpm.html) by Zoltan Kochan, but in essence it reduces dependency resolution times and `node_modules` folder sizes to within reasonable ranges (not 30 seconds and 10 GiB).
+`webpacker-pnpm` replaces Rails' Yarn environment with [pnpm](https://pnpm.js.org/), a better, smarter, and more efficient Node.js package manager. As a result, applications become less prone to dependency hell, more functional, more stable, and more flexible. And as an added bonus, dependency resolution times and `node_modules` folder sizes reduce to within reasonable ranges (not 45 seconds and 10 GiB).
+
+You can read about the philosophy and technology behind `pnpm` in [this convincing blog post](https://www.kochan.io/nodejs/why-should-we-use-pnpm) by Zoltan Kochan (<https://www.kochan.io/nodejs/why-should-we-use-pnpm>).
 
 ## Features
 

data/Rakefile

@@ -8,4 +8,4 @@ Rake::TestTask.new do |t|
   t.test_files = FileList["test/**/*_test.rb"]
 end
 
-task default: :test
+task(default: :test)

data/lib/webpacker/pnpm/railtie.rb

@@ -5,8 +5,6 @@ require "rails/railtie"
 module Webpacker
   module PNPM
     class Railtie < Rails::Railtie
-      private
-
       rake_tasks do
         # load all the rake tasks within the `tasks` directory
         Dir[File.join(File.dirname(__FILE__), "../tasks/**/*.rake")].each do |task|
@@ -14,10 +12,21 @@ module Webpacker
         end
       end
 
-      # manually specify bin path to skip Yarn execution during Webpack runner
-      # initialization
+      # manually specify node_modules bin path to skip Yarn execution during
+      # Webpack runner initialization
       config.before_configuration do
-        ENV["WEBPACKER_NODE_MODULES_BIN_PATH"] ||= File.join(`pnpm root`.chomp, ".bin")
+        begin
+          ENV["WEBPACKER_NODE_MODULES_BIN_PATH"] ||= File.join(`pnpm root`.chomp, ".bin")
+        rescue Errno::ENOENT
+          # use abort instead of Rails' logger because it doesn't show up when
+          # run within Rake tasks
+          abort(
+            <<~HEREDOC.squish
+              \e[31m[FATAL] pnpm is not installed or not present in $PATH.
+              Install pnpm and try again.\e[0m
+            HEREDOC
+          )
+        end
       end
     end
   end

data/lib/webpacker/pnpm/version.rb

@@ -2,6 +2,8 @@
 
 module Webpacker
   module PNPM
-    VERSION = "1.2.0"
+    VERSION = "1.2.1"
+
+    public_constant :VERSION
   end
 end

data/lib/webpacker/tasks/check_pnpm.rake

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "semantic_range"
+
 namespace :webpacker do
   desc "Verifies if pnpm is installed"
   task check_pnpm: [:environment] do
@@ -10,17 +11,31 @@ namespace :webpacker do
       pnpm_version = `pnpm --version`.chomp
       raise Errno::ENOENT if pnpm_version.blank?
 
-      pnpm_range = ">=3.0.0"
-      is_unsupported = SemanticRange.satisfies?(pnpm_version, pnpm_range) rescue false
+      begin
+        pnpm_range = ">= 3.0.0"
+        is_unsupported = SemanticRange.satisfies?(pnpm_version, pnpm_range)
+      rescue StandardError
+        is_unsupported = false
+      end
 
       unless is_unsupported
-        warn "Webpacker requires pnpm \"#{pnpm_range}\" and you are using #{pnpm_version}. Please upgrade pnpm https://pnpm.js.org/en/installation/"
-        warn "Exiting!"
+        warn(
+          <<~HEREDOC.squish
+            Webpacker requires pnpm \"#{pnpm_range}\" and you are using #{pnpm_version}.
+            Please upgrade pnpm https://pnpm.js.org/en/installation/.
+          HEREDOC
+        )
+        warn("Exiting!")
         exit!
       end
     rescue Errno::ENOENT
-      warn "pnpm is not installed. Please download and install pnpm from https://pnpm.js.org/en/installation/"
-      warn "Exiting!"
+      warn(
+        <<~HEREDOC.squish
+          pnpm is not installed. Please download and install pnpm from
+          https://pnpm.js.org/en/installation/.
+        HEREDOC
+      )
+      warn("Exiting!")
       exit!
     end
   end

data/lib/webpacker/tasks/env.rake

@@ -3,7 +3,7 @@
 require "webpacker/version"
 
 namespace :webpacker do
-  desc "Provide information on Webpacker's environment"
+  desc "Provide information on Webpacker's current environment"
   task env: [:environment] do
     $stdout.puts "Ruby: #{`ruby --version`}"
     $stdout.puts "Rails: #{Rails.version}"
@@ -14,7 +14,9 @@ namespace :webpacker do
     $stdout.puts "\n"
     $stdout.puts "@rails/webpacker: \n#{`npm list @rails/webpacker version`}"
 
-    $stdout.puts "Is bin/webpack present?: #{File.exist? 'bin/webpack'}"
-    $stdout.puts "Is bin/webpack-dev-server present?: #{File.exist? 'bin/webpack-dev-server'}"
+    $stdout.puts "Is bin/webpack present?: #{File.exist?("bin/webpack")}"
+    $stdout.puts <<~HEREDOC.squish
+      Is bin/webpack-dev-server present?: #{File.exist?("bin/webpack-dev-server")}
+    HEREDOC
   end
 end

data/lib/webpacker/tasks/pnpm_install.rake

@@ -1,14 +1,14 @@
 # frozen_string_literal: true
 
 namespace :webpacker do
-  desc "Support for older Rails versions. Install all JavaScript dependencies as specified via pnpm"
+  desc "Install all JavaScript dependencies as specified via pnpm."
   task pnpm_install: [:environment] do
-    valid_node_envs = %w[test development production]
+    valid_node_envs = ["test", "development", "production"]
 
     node_env = ENV.fetch("NODE_ENV") do
       valid_node_envs.include?(Rails.env) ? Rails.env : "production"
     end
 
-    system({ "NODE_ENV" => node_env }, "pnpm i --frozen-lockfile")
+    system({ "NODE_ENV" => node_env }, "pnpm i --frozen-lockfile --shamefully-hoist")
   end
 end

data/test/rake_tasks_test.rb

@@ -7,82 +7,73 @@ module Webpacker
     class RakeTasksTest < Test
       def test_rake_tasks
         output = chdir_concurrent(test_path, "bundle exec rake --tasks")
-        assert_includes output, "webpacker"
-        assert_includes output, "webpacker:binstubs"
-        assert_includes output, "webpacker:check_binstubs"
-        assert_includes output, "webpacker:check_node"
-        assert_includes output, "webpacker:check_pnpm"
-        assert_includes output, "webpacker:clean"
-        assert_includes output, "webpacker:clobber"
-        assert_includes output, "webpacker:compile"
-        assert_includes output, "webpacker:env"
-        assert_includes output, "webpacker:install"
-        assert_includes output, "webpacker:install:angular"
-        assert_includes output, "webpacker:install:coffee"
-        assert_includes output, "webpacker:install:elm"
-        assert_includes output, "webpacker:install:erb"
-        assert_includes output, "webpacker:install:react"
-        assert_includes output, "webpacker:install:svelte"
-        assert_includes output, "webpacker:install:stimulus"
-        assert_includes output, "webpacker:install:typescript"
-        assert_includes output, "webpacker:install:vue"
-        assert_includes output, "webpacker:pnpm_install"
-        assert_includes output, "webpacker:verify_install"
-
-        assert_not_includes output, "webpacker:check_yarn"
-        assert_not_includes output, "webpacker:yarn_install"
-        assert_not_includes output, "yarn:install"
+        assert_includes(output, "webpacker:check_pnpm")
+        assert_includes(output, "webpacker:pnpm_install")
+        assert_includes(output, "webpacker:env")
+
+        assert_not_includes(output, "webpacker:check_yarn")
+        assert_not_includes(output, "webpacker:yarn_install")
+        assert_not_includes(output, "yarn:install")
+        assert_not_includes(output, "webpacker:info")
       end
 
       def test_check_pnpm_version
-        output = chdir_concurrent(test_path, "rake webpacker:check_pnpm 2>&1")
-        assert_not_includes output, "pnpm is not installed"
-        assert_not_includes output, "Webpacker requires pnpm"
+        output = chdir_concurrent(test_path, "rake webpacker:check_pnpm")
+        assert_not_includes(output, "pnpm is not installed")
+        assert_not_includes(output, "Webpacker requires pnpm")
 
-        assert_includes output, "Verifying pnpm version..."
+        assert_includes(output, "Verifying pnpm version...")
       end
 
       def test_override_check_yarn_version
-        output = chdir_concurrent(test_path, "rake webpacker:check_yarn 2>&1")
-        assert_not_includes output, "pnpm is not installed"
-        assert_not_includes output, "Webpacker requires pnpm"
+        output = chdir_concurrent(test_path, "rake webpacker:check_yarn")
+        assert_not_includes(output, "pnpm is not installed")
+        assert_not_includes(output, "Webpacker requires pnpm")
 
-        assert_includes output, "Verifying pnpm version..."
+        assert_includes(output, "Verifying pnpm version...")
       end
 
       def test_pnpm_install_in_production_env
         cmd = "bundle exec rake webpacker:pnpm_install"
-
-        chdir_concurrent(test_path, cmd, { NODE_ENV: :production }, { isolated: true }) do |_, temp|
-          assert_not_includes installed_node_modules(temp), "right-pad", "Expected only production dependencies to be installed"
+        chdir_concurrent(test_path, cmd, { "NODE_ENV": "production" },
+                         { isolated: true }) do |temp|
+          assert_not_includes installed_node_modules(temp), "right-pad", <<~HEREDOC
+            Expected only production dependencies to be installed
+          HEREDOC
         end
       end
 
       def test_pnpm_install_in_test_env
-        assert_includes test_app_dev_dependencies, "right-pad"
+        assert_includes(test_app_dev_dependencies, "right-pad")
 
         cmd = "bundle exec rake webpacker:pnpm_install"
-
-        chdir_concurrent(test_path, cmd, { NODE_ENV: :test }, { isolated: true }) do |_, temp|
-          assert_includes installed_node_modules(temp), "right-pad", "Expected dev dependencies to be installed"
+        chdir_concurrent(test_path, cmd, { "NODE_ENV": "test" },
+                         { isolated: true }) do |temp|
+          assert_includes installed_node_modules(temp), "right-pad", <<~HEREDOC
+            Expected dev dependencies to be installed
+          HEREDOC
         end
       end
 
       def test_yarn_install_alias_in_production_env
         cmd = "bundle exec rake webpacker:yarn_install"
-
-        chdir_concurrent(test_path, cmd, { NODE_ENV: :production }, { isolated: true }) do |_, temp|
-          assert_not_includes installed_node_modules(temp), "right-pad", "Expected only production dependencies to be installed"
+        chdir_concurrent(test_path, cmd, { "NODE_ENV": "production" },
+                         { isolated: true }) do |temp|
+          assert_not_includes installed_node_modules(temp), "right-pad", <<~HEREDOC
+            Expected only production dependencies to be installed
+          HEREDOC
         end
       end
 
       def test_yarn_install_alias_in_test_env
-        assert_includes test_app_dev_dependencies, "right-pad"
+        assert_includes(test_app_dev_dependencies, "right-pad")
 
         cmd = "bundle exec rake webpacker:yarn_install"
-
-        chdir_concurrent(test_path, cmd, { NODE_ENV: :test }, { isolated: true }) do |_, temp|
-          assert_includes installed_node_modules(temp), "right-pad", "Expected dev dependencies to be installed"
+        chdir_concurrent(test_path, cmd, { "NODE_ENV": "test" },
+                         { isolated: true }) do |temp|
+          assert_includes installed_node_modules(temp), "right-pad", <<~HEREDOC
+            Expected dev dependencies to be installed
+          HEREDOC
         end
       end
 

data/test/test_app/bin/rails

@@ -1,6 +1,4 @@
-#!/usr/bin/env ruby.exe
-# frozen_string_literal: true
-
-APP_PATH = File.expand_path("../config/application", __dir__)
-require_relative "../config/boot"
-require "rails/commands"
+#!/usr/bin/env ruby.exe
+APP_PATH = File.expand_path('../config/application', __dir__)
+require_relative '../config/boot'
+require 'rails/commands'

data/test/test_app/bin/rake

@@ -1,6 +1,4 @@
-#!/usr/bin/env ruby.exe
-# frozen_string_literal: true
-
-require_relative "../config/boot"
-require "rake"
-Rake.application.run
+#!/usr/bin/env ruby.exe
+require_relative '../config/boot'
+require 'rake'
+Rake.application.run

data/test/test_app/bin/setup

@@ -1,27 +1,25 @@
-#!/usr/bin/env ruby.exe
-# frozen_string_literal: true
-
-require "fileutils"
-
-# path to your application root.
-APP_ROOT = File.expand_path("..", __dir__)
-
-def system!(*args)
-  system(*args) || abort("\n== Command #{args} failed ==")
-end
-
-FileUtils.chdir APP_ROOT do
-  # This script is a way to setup or update your development environment automatically.
-  # This script is idempotent, so that you can run it at anytime and get an expectable outcome.
-  # Add necessary setup steps to this file.
-
-  puts "== Installing dependencies =="
-  system! "gem install bundler --conservative"
-  system("bundle check") || system!("bundle install")
-
-  puts "\n== Removing old logs and tempfiles =="
-  system! "bin/rails log:clear tmp:clear"
-
-  puts "\n== Restarting application server =="
-  system! "bin/rails restart"
-end
+#!/usr/bin/env ruby.exe
+require 'fileutils'
+
+# path to your application root.
+APP_ROOT = File.expand_path('..', __dir__)
+
+def system!(*args)
+  system(*args) || abort("\n== Command #{args} failed ==")
+end
+
+FileUtils.chdir APP_ROOT do
+  # This script is a way to setup or update your development environment automatically.
+  # This script is idempotent, so that you can run it at anytime and get an expectable outcome.
+  # Add necessary setup steps to this file.
+
+  puts '== Installing dependencies =='
+  system! 'gem install bundler --conservative'
+  system('bundle check') || system!('bundle install')
+
+  puts "\n== Removing old logs and tempfiles =="
+  system! 'bin/rails log:clear tmp:clear'
+
+  puts "\n== Restarting application server =="
+  system! 'bin/rails restart'
+end

data/test/test_app/bin/webpack

@@ -5,7 +5,8 @@ ENV["RAILS_ENV"] ||= ENV["RACK_ENV"] || "development"
 ENV["NODE_ENV"] ||= ENV["RAILS_ENV"]
 
 require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile", Pathname.new(__FILE__).realpath)
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+                                           Pathname.new(__FILE__).realpath)
 
 require "bundler/setup"
 

data/test/test_app/bin/webpack-dev-server

@@ -5,7 +5,8 @@ ENV["RAILS_ENV"] ||= ENV["RACK_ENV"] || "development"
 ENV["NODE_ENV"] ||= ENV["RAILS_ENV"]
 
 require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile", Pathname.new(__FILE__).realpath)
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+                                           Pathname.new(__FILE__).realpath)
 
 require "bundler/setup"
 

data/test/test_app/config.ru

@@ -4,4 +4,4 @@
 
 require_relative "config/environment"
 
-run Rails.application
+run(Rails.application)

data/test/test_app/config/boot.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+
+require "bundler/setup" # Set up gems listed in the Gemfile.

data/test/test_helper.rb

@@ -42,16 +42,13 @@ module Webpacker
           # if we're want an isolated environment, copy the directory contents to
           # a new temporary directory and change the working directory to it
           if isolated
-            files = Dir[File.join(dir, "*")].reject do |f|
-              f.include?("node_modules")
-            end
-
+            files = Dir[File.join(dir, "*")].reject { |f| f.include?("node_modules") }
             dir = Dir.mktmpdir
             FileUtils.cp_r(files, dir)
           end
 
           output, = Open3.capture2e(env, "cd #{dir} && #{cmd}", opts)
-          yield(output, dir) if block_given?
+          yield(dir) if block_given?
         ensure
           # make sure we remove the generated temp directory
           FileUtils.remove_entry_secure(dir) if isolated

data/webpacker-pnpm.gemspec

@@ -7,29 +7,37 @@ require "webpacker/pnpm/version"
 Gem::Specification.new do |spec|
   spec.name        = "webpacker-pnpm"
   spec.version     = Webpacker::PNPM::VERSION
-  spec.authors     = ["Elias Gabriel"]
-  spec.email       = ["me@eliasfgabriel.com"]
-  spec.summary     = "Replaces Webpacker's Yarn environment with pnpm"
+  spec.author      = "Elias Gabriel"
+  spec.email       = "me@eliasfgabriel.com"
   spec.homepage    = "https://github.com/thearchitector/webpacker-pnpm"
   spec.license     = "CC-BY-NC-SA-4.0"
 
+  spec.summary     = "Replaces Webpacker's Yarn environment with pnpm."
+  spec.description = <<~HEREDOC.gsub(/[[:space:]]+/, " ").strip
+    webpacker-pnpm minimizes dependency hell, improves code quality stability, and
+    reduces node_modules folder sizes by replacing Webpacker's Yarn environment with pnpm.
+  HEREDOC
+
   spec.metadata    = {
     "homepage_uri" => spec.homepage,
-    "source_code_uri" => "https://github.com/thearchitector/webpacker-pnpm/tree/v#{Webpacker::PNPM::VERSION}",
-    "changelog_uri" => "https://github.com/thearchitector/webpacker-pnpm/blob/v#{Webpacker::PNPM::VERSION}/CHANGELOG.md"
+    "source_code_uri" => "#{spec.homepage}/tree/v#{spec.version}",
+    "changelog_uri" => "#{spec.homepage}/blob/v#{spec.version}/CHANGELOG.md",
+    "bug_tracker_uri" => "#{spec.homepage}/issues"
   }
 
   spec.required_ruby_version = ">= 2.4.0"
 
-  spec.add_dependency "activesupport", ">= 5.2"
-  spec.add_dependency "rack-proxy", ">= 0.6.1"
-  spec.add_dependency "railties", ">= 5.2"
-  spec.add_dependency "semantic_range", ">= 2.3.0"
-  spec.add_dependency "webpacker", "~> 5.x"
+  spec.add_dependency "rails", ">= 5.2"
+  spec.add_dependency "rake", ">= 12.3.3"
+  spec.add_dependency "semantic_range", "~> 2.3"
+  spec.add_dependency "webpacker", "~> 5.0"
 
-  spec.add_development_dependency "bundler", "~> 2.0"
-  spec.add_development_dependency "rubocop"
-  spec.add_development_dependency "rubocop-rails"
+  spec.add_development_dependency "minitest", "~> 5.0"
+  spec.add_development_dependency "practical-pig", "~> 1.0"
+  spec.add_development_dependency "rubocop", "~> 0.83.0"
+  spec.add_development_dependency "rubocop-minitest", "~> 0.9"
+  spec.add_development_dependency "rubocop-performance", "~> 1.3"
+  spec.add_development_dependency "rubocop-rails", "~> 2.5"
 
   spec.files       = `git ls-files`.split("\n")
   spec.test_files  = `git ls-files -- test/*`.split("\n")

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: webpacker-pnpm
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Elias Gabriel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-14 00:00:00.000000000 Z
+date: 2020-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -25,106 +25,135 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '5.2'
 - !ruby/object:Gem::Dependency
-  name: rack-proxy
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.6.1
+        version: 12.3.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.6.1
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
-  name: railties
+  name: semantic_range
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '2.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '2.3'
 - !ruby/object:Gem::Dependency
-  name: semantic_range
+  name: webpacker
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: '5.0'
 - !ruby/object:Gem::Dependency
-  name: webpacker
+  name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.x
-  type: :runtime
+        version: '5.0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.x
+        version: '5.0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: practical-pig
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.83.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.83.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.9'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-description: 
-email:
-- me@eliasfgabriel.com
+        version: '2.5'
+description: webpacker-pnpm minimizes dependency hell, improves code quality stability,
+  and reduces node_modules folder sizes by replacing Webpacker's Yarn environment
+  with pnpm.
+email: me@eliasfgabriel.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -139,7 +168,6 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
-- gemfiles/Gemfile-rails-edge
 - gemfiles/Gemfile-rails.5.2.x
 - gemfiles/Gemfile-rails.6.0.x
 - lib/webpacker/pnpm.rb
@@ -178,8 +206,9 @@ licenses:
 - CC-BY-NC-SA-4.0
 metadata:
   homepage_uri: https://github.com/thearchitector/webpacker-pnpm
-  source_code_uri: https://github.com/thearchitector/webpacker-pnpm/tree/v1.2.0
-  changelog_uri: https://github.com/thearchitector/webpacker-pnpm/blob/v1.2.0/CHANGELOG.md
+  source_code_uri: https://github.com/thearchitector/webpacker-pnpm/tree/v1.2.1
+  changelog_uri: https://github.com/thearchitector/webpacker-pnpm/blob/v1.2.1/CHANGELOG.md
+  bug_tracker_uri: https://github.com/thearchitector/webpacker-pnpm/issues
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -195,11 +224,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6.2
+rubygems_version: 3.1.3
 signing_key: 
 specification_version: 4
-summary: Replaces Webpacker's Yarn environment with pnpm
+summary: Replaces Webpacker's Yarn environment with pnpm.
 test_files:
 - test/rake_tasks_test.rb
 - test/test_app/.gitignore

data/gemfiles/Gemfile-rails-edge

@@ -1,12 +0,0 @@
-source "https://rubygems.org"
-
-git_source(:github) { |repo| "https://github.com/#{repo}.git" }
-
-gemspec path: "../"
-
-gem "rails", github: "rails/rails"
-gem "arel", github: "rails/arel"
-gem "rake", ">= 11.1"
-gem "rack-proxy", require: false
-gem "minitest", "~> 5.0"
-gem "byebug"