webpack-rails-react 1.0.7 → 1.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ab15cc237b848592e2bf33e98d8dae38da3982e3
-  data.tar.gz: 733ed1de054c198512de0fa2def7580c5352cdaa
+  metadata.gz: 0da8cf4f7d6b95ba1a7cb9da36e7404392bb7bd9
+  data.tar.gz: 805c1c43baab1db2c655ed4b059b8788df501f5a
 SHA512:
-  metadata.gz: 19dbe43e1f8f6368fd5e55c8f3c6191a6ec39d485a495afbd2e36a98525ac8a867febb0f71f0c6b0d2c878d9d7ec6de10a0de4bc7fbb4472149165419c1e6068
-  data.tar.gz: 10ccac5d9498461ccab3061b4cb27644846408ca0905c46a7b14da5a87d44ec6e39d07bc92c3d1f582543be5edbc39198fe507924e0c8480aaed4a86ee7d545a
+  metadata.gz: b23afced5ca978ba91d38bb3914ee2ad591d4ae33616b052381082410f1043cfe8cf3510968f8a055d60600258bf891c9b4d12077e3179f22e852ef7cc103de8
+  data.tar.gz: f221bbbe50ce4d88c8f8991d1c29eb52d8a7c73c959ef678c79d0f3f079d69888387723a4f0e80acc854c2d5c2bd812c0f89577b7fc260bd981e5affcb7822fe

data/README.md

@@ -65,7 +65,28 @@ In CI, we manually run `webpack` to compile the assets to public and set `config
 
 ### Production Deployment
 
-Add `rake webpack:compile` to your deployment. It serves a similar purpose as Sprockets' `assets:precompile` task. If you're using Webpack and Sprockets (as we are at Marketplacer) you'll need to run both tasks - but it doesn't matter which order they're run in.
+If deploying to heroku, you will need to set your buildpacks before pushing. After adding the heroku git remote, run the below three commands:
+
+```
+  heroku buildpacks:clear
+  heroku buildpacks:set heroku/nodejs
+  heroku buildpacks:add heroku/ruby --index 2
+```
+
+This will set the Node.js buildpack to run first, followed by the Ruby buildpack. To confirm that your buildpacks are set correctly, run `heroku buildpacks`. You should see Node.js listed first and Ruby second.
+
+Next you will need to set up a post build hook to bundle Webpack. Include the below scripts in `package.json`. For the Webpack deployment script, ensure that the route for your `webpack.config.js` file is correct.
+
+``` javascript
+  "scripts": {
+    "webpack:deploy": "webpack --config=config/webpack.config.js -p",
+    "heroku-postbuild": "npm run webpack:deploy"
+  }
+```
+
+Lastly, ensure that all Babel related modules are listed as dependencies and not dev dependencies in `package.json`. At this point, you should be able to push to Heroku.
+
+An alternative to adding the post build hook to `package.json` is to add `rake webpack:compile` to your deployment. It serves a similar purpose as Sprockets' `assets:precompile` task. If you're using Webpack and Sprockets (as we are at Marketplacer) you'll need to run both tasks - but it doesn't matter which order they're run in.
 
 If you're using `[chunkhash]` in your build asset filenames (which you should be, if you want to cache them in production), you'll need to persist built assets between deployments. Consider in-flight requests at the time of deployment: they'll receive paths based on the old `manifest.json`, not the new one.
 

data/lib/generators/webpack_rails_react/install_generator.rb

@@ -89,7 +89,9 @@ module WebpackRailsReact
       end
       insert_into_file 'app/views/layouts/application.html.erb', before: /<\/head>/ do
           <<-'RUBY'
-    <script src="http://localhost:3808/webpack-dev-server.js"></script>
+    <% if Rails.env.development? %>
+      <script src="http://localhost:3808/webpack-dev-server.js"></script>
+    <% end %>
           RUBY
       end
     end

data/lib/webpack/rails/react/version.rb

@@ -2,7 +2,7 @@ module Webpack
   # :nodoc:
   module Rails
     module React
-      VERSION = "1.0.7"
+      VERSION = "1.0.8"
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webpack-rails-react
 version: !ruby/object:Gem::Version
-  version: 1.0.7
+  version: 1.0.8
 platform: ruby
 authors:
 - Dave Jungst
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-10 00:00:00.000000000 Z
+date: 2016-07-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -81,7 +81,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Webpack / Rails / React