webkit_remote 0.4.0 → 0.4.1

data/README.md

@@ -30,6 +30,12 @@ have been implemented:
 * Page
 * Remote
 
+This gem will only support officially released remote debugging protocol
+features. If you need to use an unsupported feature, such as CSS debugging,
+take a look at the
+[webkit_remote_unstable](https:://github.com/pwnall/webkit_remote_unstable)
+gem.
+
 
 ## Requirements
 
@@ -218,6 +224,11 @@ closes the debugging connection and shuts down the Google Chrome instance.
 
 ## Contributing
 
+Please contribute support for stable features to
+[webkit_remote](https:://github.com/pwnall/webkit_remote) and support for
+unstable features at
+[webkit_remote_unstable](https:://github.com/pwnall/webkit_remote_unstable).
+
 * Check out the latest master to make sure the feature hasn't been implemented or the bug hasn't been fixed yet.
 * Check out the issue tracker to make sure someone already hasn't requested it and/or contributed it.
 * Fork the project.

data/VERSION

@@ -1 +1 @@
-0.4.0
+0.4.1

data/lib/webkit_remote/client/dom.rb

@@ -222,6 +222,27 @@ class DomNode
     @system_id = nil
     @value = nil
     @xml_version = nil
+
+    initialize_modules
+  end
+
+  def initialize_modules
+  end
+  private :initialize_modules
+
+  # Registers a module initializer.
+  def self.initializer(name)
+    before_name = :"initialize_modules_before_#{name}"
+    alias_method before_name, :initialize_modules
+    private before_name
+    remove_method :initialize_modules
+    eval <<END_METHOD
+      def initialize_modules
+        #{name}
+        #{before_name.to_s}
+      end
+END_METHOD
+    private :initialize_modules
   end
 
   # Updates node state to reflect new data from the Webkit debugging server.
@@ -270,27 +291,6 @@ class DomNode
   }.freeze
 end   # class WebkitRemote::Client::DomNode
 
-class JsObject
-  # @return [WebkitRemote::Client::DomNode] the DOM node wrapped by this
-  #     JavaScript object
-  def dom_node
-    @dom_node ||= dom_node!
-  end
-
-  # Fetches the wrapped DOM node, bypassing the object's cache.
-  #
-  # @return [WebkitRemote::Client::DomNode] the DOM domain object wrapped by
-  #     this JavaScript object
-  def dom_node!
-    result = @client.rpc.call 'DOM.requestNode', objectId: @remote_id
-    @dom_node = if result['nodeId']
-      @client.dom_node result['nodeId']
-    else
-      nil
-    end
-  end
-end  # class WebkitRemote::Client::JsObject
-
 end  # namespace WebkitRemote::Client
 
 end  # namespace WebkitRemote

data/lib/webkit_remote/client/dom_runtime.rb

@@ -0,0 +1,34 @@
+module WebkitRemote
+
+class Client
+
+class JsObject
+  # @return [WebkitRemote::Client::DomNode] the DOM node wrapped by this
+  #     JavaScript object
+  def dom_node
+    @dom_node ||= dom_node!
+  end
+
+  # Fetches the wrapped DOM node, bypassing the object's cache.
+  #
+  # @return [WebkitRemote::Client::DomNode] the DOM domain object wrapped by
+  #     this JavaScript object
+  def dom_node!
+    result = @client.rpc.call 'DOM.requestNode', objectId: @remote_id
+    @dom_node = if result['nodeId']
+      @client.dom_node result['nodeId']
+    else
+      nil
+    end
+  end
+
+  # @private Called by the JsObject constructor.
+  def initialize_dom
+    @dom_node = nil
+  end
+  initializer :initialize_dom
+end  # class WebkitRemote::Client::JsObject
+
+end  # namespace WebkitRemote::Client
+
+end  # namespace WebkitRemote

data/lib/webkit_remote/client/runtime.rb

@@ -299,9 +299,29 @@ class JsObject
       @js_subtype = nil
     end
     @value = raw_object['value']
-    @dom_node = nil
 
     group.add self
+
+    initialize_modules
+  end
+
+  def initialize_modules
+  end
+  private :initialize_modules
+
+  # Registers a module initializer.
+  def self.initializer(name)
+    before_name = :"initialize_modules_before_#{name}"
+    alias_method before_name, :initialize_modules
+    private before_name
+    remove_method :initialize_modules
+    eval <<END_METHOD
+      def initialize_modules
+        #{name}
+        #{before_name.to_s}
+      end
+END_METHOD
+    private :initialize_modules
   end
 
   # Informs this object that it was released as part of a group release.

data/lib/webkit_remote/client.rb

@@ -111,6 +111,7 @@ class Client
   def self.initializer(name)
     before_name = :"initialize_modules_before_#{name}"
     alias_method before_name, :initialize_modules
+    private before_name
     remove_method :initialize_modules
     eval <<END_METHOD
       def initialize_modules
@@ -118,12 +119,14 @@ class Client
         #{before_name.to_s}
       end
 END_METHOD
+    private :initialize_modules
   end
 
   # Registers a module clearer.
   def self.clearer(name)
     before_name = :"clear_modules_before_#{name}"
     alias_method before_name, :clear_modules
+    private before_name
     remove_method :clear_modules
     eval <<END_METHOD
       def clear_modules
@@ -131,6 +134,7 @@ END_METHOD
         #{before_name.to_s}
       end
 END_METHOD
+    private :clear_modules
   end
 
   # Called by the constructor. Aliased by the module initializers.
@@ -139,6 +143,7 @@ END_METHOD
   def initialize_modules
     # NOTE: this gets called after all the module initializers complete
   end
+  private :initialize_modules
 
   # Called by clear_all.
   #
@@ -146,6 +151,7 @@ END_METHOD
   def clear_modules
     # NOTE: this gets called after all the module cleaners complete
   end
+  private :clear_modules
 
   # Debugging output.
   def inspect

data/lib/webkit_remote.rb

@@ -16,3 +16,4 @@ require 'webkit_remote/client/network_events.rb'
 require 'webkit_remote/client/page.rb'
 require 'webkit_remote/client/page_events.rb'
 require 'webkit_remote/client/runtime.rb'
+require 'webkit_remote/client/dom_runtime.rb'

data/test/webkit_remote/client/network_test.rb

@@ -10,6 +10,18 @@ describe WebkitRemote::Client::Network do
     @client.close
   end
 
+  describe 'can_clear_cookies?' do
+    it 'returns true in Chrome' do
+      @client.can_clear_cookies?.must_equal true
+    end
+  end
+
+  describe 'can_clear_network_cache?' do
+    it 'returns true in Chrome' do
+      @client.can_clear_network_cache?.must_equal true
+    end
+  end
+
   describe 'without network events enabled' do
     before :all do
       @client.network_events = false

data/webkit_remote.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = "webkit_remote"
-  s.version = "0.4.0"
+  s.version = "0.4.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Victor Costan"]
@@ -32,6 +32,7 @@ Gem::Specification.new do |s|
     "lib/webkit_remote/client/console_events.rb",
     "lib/webkit_remote/client/dom.rb",
     "lib/webkit_remote/client/dom_events.rb",
+    "lib/webkit_remote/client/dom_runtime.rb",
     "lib/webkit_remote/client/network.rb",
     "lib/webkit_remote/client/network_events.rb",
     "lib/webkit_remote/client/page.rb",

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webkit_remote
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
   prerelease: 
 platform: ruby
 authors:
@@ -259,6 +259,7 @@ files:
 - lib/webkit_remote/client/console_events.rb
 - lib/webkit_remote/client/dom.rb
 - lib/webkit_remote/client/dom_events.rb
+- lib/webkit_remote/client/dom_runtime.rb
 - lib/webkit_remote/client/network.rb
 - lib/webkit_remote/client/network_events.rb
 - lib/webkit_remote/client/page.rb
@@ -306,7 +307,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 4292049841560848513
+      hash: 3710674464370196221
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: