webhookr 0.0.2 → 0.1.0

data/.coveralls.yml

@@ -0,0 +1 @@
+service_name: travis-ci

data/.travis.yml

@@ -0,0 +1,13 @@
+language: ruby
+rvm:
+  - "1.9.3"
+  - "2.0.0"
+  - jruby-19mode # JRuby in 1.9 mode
+  - ruby-head
+env:
+  - RAILS_VERSION=4.0.0
+  - RAILS_VERSION=3.2.13
+  - RAILS_VERSION=3.1.12
+matrix:
+  allow_failures:
+    - rvm: ruby-head

data/Gemfile

@@ -2,15 +2,18 @@ source "http://rubygems.org"
 
 gemspec
 
-gem "rake", "~> 10.0"
-gem "minitest"
-gem "minitest-reporters"
-gem "em-websocket"
-gem "guard"
-gem "guard-minitest"
-gem "guard-markdown"
-gem "guard-livereload"
-gem "simplecov", :require => false
+group :development, :test do
+  gem "rake", "~> 10.0"
+  gem "minitest"
+  gem "minitest-reporters"
+  gem "em-websocket"
+  gem "guard"
+  gem "guard-minitest"
+  gem "guard-markdown"
+  gem "guard-livereload"
+  gem "simplecov", :require => false
+  gem 'coveralls', :require => false
+end
 
 if File.exists?('Gemfile.local')
   instance_eval File.read('Gemfile.local')

data/Guardfile

@@ -18,7 +18,7 @@ guard 'minitest', :test_folders => 'test', :test_file_patterns => '*_test.rb' do
 end
 
 guard 'livereload' do
-  watch('README.md')
+  watch('README.html')
 end
 
 guard 'markdown', :convert_on_start => true do

data/README.md

@@ -1,5 +1,8 @@
 # webhookr: Rails Webhooks Made Easy
-[![Code Climate](https://codeclimate.com/badge.png)](https://codeclimate.com/github/zoocasa/webhookr)
+[![Build Status](https://travis-ci.org/zoocasa/webhookr.png?branch=master)](https://travis-ci.org/zoocasa/webhookr)
+[![Dependency Status](https://gemnasium.com/zoocasa/webhookr.png)](https://gemnasium.com/zoocasa/webhookr)
+[![Code Climate](https://codeclimate.com/github/zoocasa/webhookr.png)](https://codeclimate.com/github/zoocasa/webhookr)
+[![Coverage Status](https://coveralls.io/repos/zoocasa/webhookr/badge.png?branch=master)](https://coveralls.io/r/zoocasa/webhookr?branch=master)
 
 ## <a name="introduction"></a>Introduction
 
@@ -120,33 +123,40 @@ If you are sending sensitive data via webhooks, it is recommended you use HTTPS.
 
 ### <a name="supported_services"></a>Supported Services
 
-* MailChimp - webhookr-mail_chimp
-* Mandrill - webhookr-mandrill
+* MailChimp - [webhookr-mail_chimp](https://github.com/zoocasa/webhookr-mailchimp)
+* Mandrill - [webhookr-mandrill](https://github.com/gerrypower/webhookr-mandrill)
+* Stripe - [webhookr-stripe](https://github.com/gerrypower/webhookr-stripe)
 * Github - coming soon
-* Stripe - coming soon
 
 ## <a name="works_with"></a>Works with:
 
-webhookr works with Rails 3.1 and 3.2, and has been tested on the following Ruby
+webhookr works with Rails 4.0 and 3.1, and has been tested on the following Ruby
 implementations:
 
-* JRuby 1.7.1
-* MRI 1.8.7
-* MRI 1.9.2
+* JRuby 1.7.4
 * MRI 1.9.3
-* Rubinius 1.2.4
-* Ruby EE 1.8.7
-
-Pending:
-
-* MRI 2.0
+* MRI 2.0.0
 
 ### TODO
 * Implement get/post strategies and responses so the controller can return variable text to the service.
 This allows support for advanced Webhook responses for services that require it.
 * Enhance testing of Rake tasks
 * Clean up the stubs with FactoryGirl
-* Test with MRI 2.0
+
+### Versioning
+This library aims to adhere to [Semantic Versioning 2.0.0](http://semver.org/). Violations of this scheme should be reported as
+bugs. Specifically, if a minor or patch version is released that breaks backward compatibility, that
+version should be immediately yanked and/or a new version should be immediately released that restores
+compatibility. Breaking changes to the public API will only be introduced with new major versions. As a
+result of this policy, once this gem reaches a 1.0 release, you can (and should) specify a dependency on
+this gem using the [Pessimistic Version Constraint](http://docs.rubygems.org/read/chapter/16#page74) with
+two digits of precision. For example:
+
+    spec.add_dependency 'webhookr', '~> 1.0'
+
+While this gem is currently a 0.x release, suggestion is to require the exact version that works for your code:
+
+    spec.add_dependency 'webhookr', '0.0.2'
 
 ### License
 

data/app/controllers/webhookr/events_controller.rb

@@ -20,6 +20,9 @@ module Webhookr
 
     def create_service
       begin
+        # Rails 4.0.0 fix: https://github.com/rails/rails/pull/11353
+        request.body.rewind
+
         @service = Webhookr::Service.new(
           params[:service_id], :payload => request.body.read, :security_token => params[:security_token]
         )

data/config/routes.rb

@@ -1,4 +1,10 @@
 Webhookr::Engine.routes.draw do
-  get "/events/:service_id(/:security_token)" => "events#show", :as => "events"
-  post "/events/:service_id(/:security_token)" => "events#create", :as => "events"
+  get "/events/:service_id(/:security_token)" => "events#show",
+      :as => "events",
+      :defaults => { :format => 'json' },
+      :constraints => { :format => 'json' }
+  post "/events/:service_id(/:security_token)" => "events#create",
+       :as => "new_event",
+       :defaults => { :format => 'json' },
+       :constraints => { :format => 'json' }
 end

data/lib/webhookr/version.rb

@@ -1,3 +1,3 @@
 module Webhookr
-  VERSION = "0.0.2"
+  VERSION = "0.1.0"
 end

data/test/dummy/config/application.rb

@@ -3,7 +3,6 @@ require File.expand_path('../boot', __FILE__)
 # Pick the frameworks you want:
 # require "active_record/railtie"
 require "action_controller/railtie"
-require "active_resource/railtie"
 require "sprockets/railtie"
 require "rails/test_unit/railtie"
 

data/test/dummy/config/environments/development.rb

@@ -6,9 +6,6 @@ Dummy::Application.configure do
   # since you don't have to restart the web server when you make code changes.
   config.cache_classes = false
 
-  # Log error messages when you accidentally call methods on nil.
-  config.whiny_nils = true
-
   # Show full error reports and disable caching
   config.consider_all_requests_local       = true
   config.action_controller.perform_caching = false

data/test/dummy/config/environments/test.rb

@@ -11,8 +11,8 @@ Dummy::Application.configure do
   config.serve_static_assets = true
   config.static_cache_control = "public, max-age=3600"
 
-  # Log error messages when you accidentally call methods on nil
-  config.whiny_nils = true
+  # Rails 4.0
+  config.eager_load = false
 
   # Show full error reports and disable caching
   config.consider_all_requests_local       = true

data/test/dummy/config/initializers/secret_token.rb

@@ -4,4 +4,4 @@
 # If you change this key, all old signed cookies will become invalid!
 # Make sure the secret is at least 30 characters and all random,
 # no regular words or you'll be exposed to dictionary attacks.
-Dummy::Application.config.secret_token = '37ef70b5f837f7a433cdd2a24cfac821c9e6624bccad494de69557a4d95e70d6400afb6c291fed109e417492c84c39d4325f35716fdc6c57cc376aacc72ad512'
+Dummy::Application.config.secret_key_base = '37ef70b5f837f7a433cdd2a24cfac821c9e6624bccad494de69557a4d95e70d6400afb6c291fed109e417492c84c39d4325f35716fdc6c57cc376aacc72ad512'

data/test/functional/webhookr/events_controller_test.rb

@@ -5,7 +5,7 @@ require 'stubs/service_under_test_stubs'
 
 module Webhookr
   class EventsControllerTest < ActionController::TestCase
-    
+
     include Webhookr::ServiceUnderTest
 
     def setup
@@ -17,16 +17,16 @@ module Webhookr
 
     test ":get with no service id should return a ActionController::RoutingError" do
       assert_raise(ActionController::RoutingError) {
-        get(:show)
+        get(:show, {:service_id => ""})
       }
     end
-    
-    test ":get with an unknown service id should return a ActionController::RoutingError" do     
+
+    test ":get with an unknown service id should return a ActionController::RoutingError" do
       assert_raise(ActionController::RoutingError) {
         get(:show, {:service_id => "blort"})
       }
     end
-    
+
     test ":get with known service id should return success and an empty body" do
       get(:show, {:service_id => stub.service_name})
       assert_response :success

data/test/functional/webhookr/events_routes_test.rb

@@ -5,9 +5,9 @@ module Webhookr
 
     def setup
       @routes = Webhookr::Engine.routes
-      @show_controller = { :controller => "webhookr/events", :action => "show", :service_id => "service_id" }
+      @show_controller = { :format => "json", :controller => "webhookr/events", :action => "show", :service_id => "service_id" }
       @show_controller_with_token = @show_controller.merge({ :security_token => "secure" })
-      @create_controller = { :controller => "webhookr/events", :action => "create", :service_id => "service_id" }
+      @create_controller = { :format => "json", :controller => "webhookr/events", :action => "create", :service_id => "service_id" }
       @create_controller_with_token = @create_controller.merge({ :security_token => "secure" })
       @path = "/events/service_id"
       @path_with_token = "/events/service_id/secure"

data/test/test_helper.rb

@@ -1,4 +1,11 @@
 require 'simplecov'
+require 'coveralls'
+
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+  SimpleCov::Formatter::HTMLFormatter,
+  Coveralls::SimpleCov::Formatter
+]
+SimpleCov.command_name("Webhookr Tests")
 SimpleCov.start
 
 # Configure Rails Environment
@@ -16,3 +23,7 @@ Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
 MiniTest::Reporters.use!(MiniTest::Reporters::SpecReporter.new)
 
+puts "Webhookr #{Webhookr::VERSION}"
+puts "Rails #{Rails::VERSION::STRING}"
+puts "Ruby #{RUBY_VERSION}-p#{RUBY_PATCHLEVEL} - #{RbConfig::CONFIG['RUBY_INSTALL_NAME']}"
+

data/webhookr.gemspec

@@ -18,5 +18,5 @@ Gem::Specification.new do |s|
   s.homepage = "http://github.com/zoocasa/webhookr"
   s.require_paths = ["lib"]
 
-  s.add_dependency "rails", ["~> 3.1"]
+  s.add_dependency "rails", [">= 3.1"]
 end

metadata

@@ -1,30 +1,30 @@
 --- !ruby/object:Gem::Specification
 name: webhookr
 version: !ruby/object:Gem::Version
-  version: 0.0.2
   prerelease: 
+  version: 0.1.0
 platform: ruby
 authors:
 - Gerry Power
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-11 00:00:00.000000000 Z
+date: 2013-07-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
+  type: :runtime
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.1'
-  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.1'
 description: Webhookr - easily and securely add webhooks to your Rails app.
@@ -34,7 +34,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- .coveralls.yml
 - .gitignore
+- .travis.yml
 - Gemfile
 - Guardfile
 - MIT-LICENSE