webhook_system 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c8cf0345d592bd7eddd4df0589e308f442300f2e
-  data.tar.gz: e45bc8b040f4e262dcc29ebff36283975cdf658b
+  metadata.gz: 845cc8863c319a2a78ff235cbb41256a9bdbe850
+  data.tar.gz: afa19be64345c961c0989c09d09fc80341200ab4
 SHA512:
-  metadata.gz: 2f73f386866cb8dacc605cebc14cd9bf2fa667b451a502eabf72cdef52cf7dfaa4b0e4c28787f5f1f9dc7a584046feb29a95baeb39c60eb343e4a0a99fc88a7a
-  data.tar.gz: bebab60ba8f6780a73aa93c8090acdd3e67ce7b416ab2c2634c249d61d0080010629b7b936a83d0a01e7390e400ba0166ab8a134030f033befbf532b39a13076
+  metadata.gz: 0285d5a6e08624c92cdddf4eceed759c55f2839c139d922c09c8d82302114b0dcfba8416dae5ea5cb965ca8bdcc971c323087397ddae26b309217c9c1fb11820
+  data.tar.gz: de888a90628e3987dc5f4b0416d7eef83e8afc6f1972135c6545ecd8839f4cacb570ef4f1d73900cadc3cd808a10329c6b43c0adb60bd805278942d858b0e3a6

data/.rubocop.yml

@@ -45,6 +45,8 @@ Style/CollectionMethods:
 Metrics/LineLength:
   Max: 120
   AllowURI: true
+  Exclude:
+    - spec/**/*
 
 # Align with the style guide, we don't prefer anything
 Style/CollectionMethods:

data/CHANGELOG.md

@@ -0,0 +1,13 @@
+# Change Log
+
+## [v0.1.0](https://github.com/payrollhero/webhook_system/tree/v0.1.0) (2016-02-05)
+[Full Changelog](https://github.com/payrollhero/webhook_system/compare/v0.0.1...v0.1.0)
+
+- Add easy topic mass assignment and url validation [\#2](https://github.com/payrollhero/webhook_system/pull/2) ([piotrb](https://github.com/piotrb))
+
+## [v0.0.1](https://github.com/payrollhero/webhook_system/tree/v0.0.1) (2016-02-05)
+- Initial implementation of the webhook system [\#1](https://github.com/payrollhero/webhook_system/pull/1) ([piotrb](https://github.com/piotrb))
+
+
+
+\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*

data/Rakefile

@@ -42,5 +42,5 @@ end
 
 desc "Updates the changelog"
 task :changelog do
-  sh "github_changelog_generator payrollhero/ph_utility --simple-list"
+  sh "github_changelog_generator payrollhero/webhook_system --simple-list"
 end

data/lib/webhook_system/base_event.rb

@@ -17,21 +17,33 @@ module WebhookSystem
     def as_json
       result = { 'event' => event_name }
       each_attribute do |attribute_name, attribute_method|
+        validate_attribute_name attribute_name
         result[attribute_name.to_s] = public_send(attribute_method).as_json
       end
-      result
+      result.deep_stringify_keys
+    end
+
+    def self.key_is_reserved?(key)
+      key.to_s.in? %w(event)
     end
 
     private
 
-    def each_attribute
+    def validate_attribute_name(key)
+      if self.class.key_is_reserved?(key)
+        message = "#{self.class.name} should not be defining an attribute named #{key} since its reserved"
+        raise ArgumentError, message
+      end
+    end
+
+    def each_attribute(&block)
       case payload_attributes
       when Array
         payload_attributes.each do |attribute_name|
           yield(attribute_name, attribute_name)
         end
       when Hash
-        payload_attributes.each
+        payload_attributes.each(&block)
       else
         raise ArgumetError, "don't know how to deal with payload_attributes: #{payload_attributes.inspect}"
       end

data/lib/webhook_system/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module WebhookSystem
-  VERSION = '0.1.0'.freeze
+  VERSION = '0.1.1'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webhook_system
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Piotr Banasik