webflow-ruby 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2df995b45bc57f7941d8fae264b58e29593d69d3
-  data.tar.gz: 25abadb527e7ae8360da648bf5f55ed174f67b9d
+  metadata.gz: 5335df9034568611d6cbf005de8171ac5a3812cb
+  data.tar.gz: 181c5a8e4bff8a0ca6e84c40c572ab5b4083b092
 SHA512:
-  metadata.gz: a72d46c3803b36dc9484a15b2bad0a6b2304d036c74ccc00a90e5b680a7306afe21ca9fc7da4f7adeb2fe293501763ba349c0fd436b572d6f6592fce3a70539b
-  data.tar.gz: 8193ed9ec0fba4bd6ca28f67e9d5860b7ed73ec9c982ef5b155da0929b96fa901fa1d0d4c6382c0b4aa2a3887db4531c56759147b71860b031d4b8e61906ac81
+  metadata.gz: 34f29de017d55f7bdf779993280998c4b3f98d14647ac4bb34fb52e6a5ecad4c108ea23bcf73655f620eb5a5fc4f0eb8293bc58ef4f2d2ca5e2aa8feef64961e
+  data.tar.gz: 3200e5ce2ab1025fa3fdafbb643b19201112b5d9797d3ebcb057a311eb3f53ef4192875b20ba46217808ad3d24ea11d2bda8e0e991e5b00af8d7f3dcced91916

data/README.md

@@ -18,13 +18,13 @@ Or install it yourself as:
 
 ## Usage
 
-Have a look at the tests!
+Have a look at the tests, seriously!
 
-## Development
+## Todo
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
-
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+* Error handling, it's all JSON for now
+* Resource mapping, it's plain hashes for now
+* Proper docs
 
 ## Contributing
 

data/lib/webflow/client.rb

@@ -1,5 +1,4 @@
 require 'typhoeus'
-require 'nokogiri'
 require 'oj'
 
 module Webflow
@@ -71,25 +70,29 @@ module Webflow
     end
 
     def post(path, data)
-      request(path, method: :post, body: data)
+      request(path, method: :post, data: data)
     end
 
     def put(path, data)
-      request(path, method: :put, body: data)
+      request(path, method: :put, data: data)
     end
 
     def delete(path)
       request(path, method: :delete)
     end
 
-    def request(path, method: :get, params: nil, body: nil)
-      body = Oj.dump(body, OJ_OPTIONS) if body
-      json = http(path, method: method, params: params, headers: request_headers, body: body)
-      Oj.load(json, OJ_OPTIONS)
+    def request(path, method: :get, params: nil, data: nil)
+      json = Oj.dump(data, OJ_OPTIONS) if data
+
+      response = http(path, method: method, params: params, headers: request_headers, body: json)
+      track_rate_limit(response.headers)
+
+      Oj.load(response.body, OJ_OPTIONS)
     end
 
     def http(path, method: :get, params: nil, headers: nil, body: nil)
       url = File.join(HOST, path)
+
       request = Typhoeus::Request.new(
         url,
         method: method,
@@ -97,17 +100,12 @@ module Webflow
         headers: headers,
         body: body,
       )
-      response = request.run
-
-      track_rate_limit(response.headers)
-
-      response.body
+      request.run
     end
 
     def track_rate_limit(headers)
       rate_limit = headers.select { |key, value| key =~ /X-Ratelimit/ }
       @rate_limit = rate_limit unless rate_limit.empty?
-      # byebug
     end
 
     def request_headers
@@ -118,14 +116,14 @@ module Webflow
       }
     end
 
-    def error_codes
-      # https://developers.webflow.com/#errors
+    # https://developers.webflow.com/#errors
+    def self.error_codes
       {
         [400,	SyntaxError] =>	'Request body was incorrectly formatted. Likely invalid JSON being sent up.',
         [400,	InvalidAPIVersion] =>	'Requested an invalid API version',
         [400,	UnsupportedVersion] =>	'Requested an API version that in unsupported by the requested route',
         [400,	NotImplemented] =>	'This feature is not currently implemented',
-        [400,	ValidationError] =>	'Validation failure (see problems field in the response)',
+        [400,	ValidationError] =>	'Validation failure (see err field in the response)',
         [400,	Conflict] =>	'Request has a conflict with existing data.',
         [401,	Unauthorized] =>	'Provided access token is invalid or does not have access to requested resource',
         [404,	NotFound] =>	'Requested resource not found',

data/lib/webflow/version.rb

@@ -1,3 +1,3 @@
 module Webflow
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

data/webflow.gemspec

@@ -22,7 +22,6 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "typhoeus"
-  spec.add_dependency "nokogiri"
   spec.add_dependency "oj"
 
   spec.add_development_dependency "bundler", "~> 1.13"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webflow-ruby
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - phoet
@@ -24,20 +24,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: nokogiri
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: oj
   requirement: !ruby/object:Gem::Requirement