webdrivers 4.1.2 → 4.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7cd7ebf2f29727575042cf40f562078368874a966f32185894fccc870846eae4
-  data.tar.gz: b11fabe9de1ba71cf72eac2cd3144a2564aa898a730a44a75195b380ee87d2d5
+  metadata.gz: ecc36e5f9d3969cfc74f760b76c503aee82245ef3d38e4abf185927b9c4a4de4
+  data.tar.gz: 0d20abe48637e92ae714e24d50ea7ef51feaeb1dc018fb69ae145f766e799344
 SHA512:
-  metadata.gz: edd6426c60e37b35655b9170321bd7c66d5fb1992ce1f2e9038a7fb75793b4d2270792c876b7a165ce7411330ddc35b63c33e274a9a836e1e4d073c4bf80887d
-  data.tar.gz: 356ec146930fcd79c1ad9a8b6fe9c0d0f78552a5ad90d07809723e4c9c3ce1b3328824e8583e8cae732b3a1c47c3e08697a72af707ab09fbb0f88ed926f669d1
+  metadata.gz: 69ee84671cb4ea6c45cfc4f12260c43da13827558f7c91653081bdc01f51ca750145bfe9e42908e5a907a60bd75d92698cd8f1cee3a81cd80094946d7841a680
+  data.tar.gz: 2a047608c7d39f7790fadcb5aa1deb91abe8daf6c1132059f9f61c03bcffe39d8983e9aa8c65b7bad6abe2af71e3f4031317ae92331497e807c44c294356eae5

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+### 4.1.3 (2019-10-07)
+* Require rubyzip version 1.3.0 or higher to fix [rubyzip#403](https://github.com/rubyzip/rubyzip/pull/403). Thanks rhymes! ([#153](https://github.com/titusfortner/webdrivers/pull/153))
+* Fix a bug where the file deletion confirmation was printed even when there were no files to delete.
+
 ### 4.1.2 (2019-07-29)
 * Fix a bug related to raising `BrowserNotFound`.
 

data/lib/webdrivers/common.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'rubygems/package'
-require 'zip'
 require 'webdrivers/logger'
 require 'webdrivers/network'
 require 'webdrivers/system'

data/lib/webdrivers/system.rb

@@ -4,6 +4,12 @@ require 'rubygems/package'
 require 'zip'
 require 'English'
 
+# validate zip entry sizes to avoid zip bombs
+# see https://github.com/rubyzip/rubyzip#size-validation
+# and https://github.com/rubyzip/rubyzip/pull/403 for further details
+# this will be the default in rubyzip 2.0+
+Zip.validate_entry_sizes = true
+
 module Webdrivers
   #
   # @api private
@@ -14,11 +20,13 @@ module Webdrivers
         max_attempts = 3
         attempts_made = 0
         delay = 0.5
-        Webdrivers.logger.debug "Deleting #{file}"
 
         begin
           attempts_made += 1
-          File.delete file if File.exist? file
+          if File.exist? file
+            Webdrivers.logger.debug "Deleting #{file}"
+            File.delete file
+          end
         rescue Errno::EACCES # Solves an intermittent file locking issue on Windows
           sleep(delay)
           retry if File.exist?(file) && attempts_made <= max_attempts

data/lib/webdrivers/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Webdrivers
-  VERSION = '4.1.2'
+  VERSION = '4.1.3'
 end

data/webdrivers.gemspec

@@ -29,6 +29,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'simplecov', '~>0.16'
 
   s.add_runtime_dependency 'nokogiri', '~> 1.6'
-  s.add_runtime_dependency 'rubyzip', '~> 1.0'
+  s.add_runtime_dependency 'rubyzip', '>= 1.3.0'
   s.add_runtime_dependency 'selenium-webdriver', '>= 3.0', '< 4.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webdrivers
 version: !ruby/object:Gem::Version
-  version: 4.1.2
+  version: 4.1.3
 platform: ruby
 authors:
 - Titus Fortner
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-29 00:00:00.000000000 Z
+date: 2019-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ffi
@@ -142,16 +142,16 @@ dependencies:
   name: rubyzip
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.3.0
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver
   requirement: !ruby/object:Gem::Requirement
@@ -241,7 +241,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.4
 signing_key: 
 specification_version: 4
 summary: Easy download and use of browser drivers.