webdrivers 4.0.0.rc1 → 4.0.0.rc2

Sign up to get free protection for your applications and to get access to all the features.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
- SHA1:
3
- metadata.gz: 35e2346c87541df0f3aade8f330ef3f9df6376cd
4
- data.tar.gz: fd9c3d144960b435ff139b1d6b7073ef9ebd5a87
2
+ SHA256:
3
+ metadata.gz: c15a5f991a655dcb0ab30ccfa3daac4facd4f051e02147d48c140ee1f272c9b5
4
+ data.tar.gz: 035b0fd8214ba3d26a8789f349bef233e31a86b4cf7d6852f564a7681feffd3c
5
5
  SHA512:
6
- metadata.gz: 0dd52833bcd3c354c45ec026c6d041d845018274fe27164a0fa0ec31f002b917221463659d9aa51e09824805444158775e63ba3b7c94c66e833b7f0dca09e2ab
7
- data.tar.gz: 00e2e731f00ee020511d62fab5084eeaff766ffef19d7f11cba06e9a13dcd73ed31d2fd043811e5160de4dc920a515d9d74ee8244de7b7dd7484054fe7bed7d3
6
+ metadata.gz: ea32e06957c4b7b4fb4146ac21f1cabad8e712fd47f612c61e21dbd5eae0effe841874f4c5e8e9587d00a44ea85eb90c8fbbad600e05c3b713cb9748d93d697d
7
+ data.tar.gz: 6a8c82ee41b75e06028c01f20a15491f3f30e5ba6b4bfb5cc13b9e05390718199b4b4a36f27b261536cbabf5fc3e3bf4217c8229f87c65798b35070833e0cab3
@@ -1,14 +1,14 @@
1
- #### Summary
2
- Short summary of the bug or feature request.
3
-
4
- #### Debug Info
5
- Please provide the following information for bug reports:
6
-
7
- * Operating system / CI Environment:
8
- * Browser and version:
9
-
10
- #### Expected Behavior
11
- What you expect to happen.
12
-
13
- #### Actual Behavior
1
+ #### Summary
2
+ Short summary of the bug or feature request.
3
+
4
+ #### Debug Info
5
+ Please provide the following information for bug reports:
6
+
7
+ * Operating system / CI Environment:
8
+ * Browser and version:
9
+
10
+ #### Expected Behavior
11
+ What you expect to happen.
12
+
13
+ #### Actual Behavior
14
14
  What is actually happening: Error message, stack trace, DEBUG log if applicable (set `Webdrivers.logger.level = :DEBUG` after you require webdrivers)
data/.gitignore CHANGED
@@ -1,7 +1,7 @@
1
- *.gem
2
- .bundle
3
- Gemfile.lock
4
- pkg/*
5
- chromedriver.log
6
- /.idea/
7
- coverage/
1
+ *.gem
2
+ .bundle
3
+ Gemfile.lock
4
+ pkg/*
5
+ chromedriver.log
6
+ /.idea/
7
+ coverage/
data/CHANGELOG.md CHANGED
@@ -1,11 +1,17 @@
1
+ ### 4.0.0.rc2 (2019-05-21)
2
+ * Fix a bug with `WD_CACHE_TIME` when using the rake tasks (issue [#123](https://github.com/titusfortner/webdrivers/pull/123))
3
+
1
4
  ### 4.0.0.rc1 (2019-05-20)
2
- * locate Chrome binary the same way as chromedriver to ensure the correct browser version is obtained by default
3
- * add rake tasts for update, remove and version
4
- * removed all deprecated code
5
+ * Locate Chrome binary the same way as chromedriver to ensure the correct browser version is
6
+ obtained by default (issue [#45](https://github.com/titusfortner/webdrivers/issues/45))
7
+ * Add rake tasks for update, remove and version
8
+ (issues [#28](https://github.com/titusfortner/webdrivers/issues/28)
9
+ [#77](https://github.com/titusfortner/webdrivers/issues/77))
10
+ * Removed all deprecated code
5
11
 
6
12
  ### 3.9.4 (2019-05-20)
7
- * Fix bug from bug fix that warned users about setting cache time when it was already set (issue #118)
8
- * make #base_url public for easier mocking (issue #109)
13
+ * Fix bug from bug fix that warned users about setting cache time when it was already set (issue [#118](https://github.com/titusfortner/webdrivers/pull/118))
14
+ * Make #base_url public for easier mocking (issue [#109](https://github.com/titusfortner/webdrivers/issues/109))
9
15
 
10
16
  ### 3.9.3 (2019-05-17)
11
17
  * Fix the bug that warned users about setting cache time when it was already set
data/README.md CHANGED
@@ -192,7 +192,11 @@ To use Microsoft Edge, please visit the
192
192
 
193
193
  ## Wiki
194
194
 
195
- Please see the [wiki](https://github.com/titusfortner/webdrivers/wiki) for solutions to commonly reported issues.
195
+ Please see the [wiki](https://github.com/titusfortner/webdrivers/wiki)
196
+ for solutions to commonly reported issues.
197
+
198
+ Join us in the `#webdrivers-gem` channel on [Slack](https://seleniumhq.herokuapp.com/)
199
+ if you prefer a live discussion instead.
196
200
 
197
201
  ## License
198
202
 
@@ -26,7 +26,7 @@ module Webdrivers
26
26
  # Returns the amount of time (Seconds) the gem waits between two update checks.
27
27
  #
28
28
  def cache_time
29
- @cache_time || ENV['WD_CACHE_TIME'].to_i
29
+ (@cache_time || ENV['WD_CACHE_TIME']).to_i
30
30
  end
31
31
 
32
32
  #
@@ -1,5 +1,5 @@
1
1
  # frozen_string_literal: true
2
2
 
3
3
  module Webdrivers
4
- VERSION = '4.0.0.rc1'
4
+ VERSION = '4.0.0.rc2'
5
5
  end
@@ -134,13 +134,6 @@ describe Webdrivers::Chromedriver do
134
134
  expect(chromedriver.current_version.version).to eq('72.0.3626.7')
135
135
  end
136
136
  end
137
-
138
- context 'when ENV variable WD_CACHE_TIME is set' do
139
- it 'uses cache time value from ENV variable' do
140
- allow(ENV).to receive(:[]).with('WD_CACHE_TIME').and_return('999')
141
- expect(Webdrivers.cache_time).to be(999)
142
- end
143
- end
144
137
  end
145
138
 
146
139
  describe '#current_version' do
@@ -257,30 +250,6 @@ describe Webdrivers::Chromedriver do
257
250
  end
258
251
  end
259
252
 
260
- describe '#install_dir' do
261
- it 'uses ~/.webdrivers as default value' do
262
- expect(Webdrivers.install_dir).to include('.webdriver')
263
- end
264
-
265
- it 'uses provided value' do
266
- begin
267
- install_dir = File.expand_path(File.join(ENV['HOME'], '.webdrivers2'))
268
- Webdrivers.install_dir = install_dir
269
-
270
- expect(Webdrivers.install_dir).to eq install_dir
271
- ensure
272
- Webdrivers.install_dir = nil
273
- end
274
- end
275
-
276
- context 'when ENV variable WD_INSTALL_DIR is set' do
277
- it 'uses path from the ENV variable' do
278
- allow(ENV).to receive(:[]).with('WD_INSTALL_DIR').and_return('custom_dir')
279
- expect(Webdrivers.install_dir).to be('custom_dir')
280
- end
281
- end
282
- end
283
-
284
253
  describe '#driver_path' do
285
254
  it 'returns full location of binary' do
286
255
  expect(chromedriver.driver_path).to match("#{File.join(ENV['HOME'])}/.webdrivers/chromedriver")
@@ -14,5 +14,55 @@ describe Webdrivers do
14
14
  msg = /Webdrivers Driver caching is turned off in this version, but will be enabled by default in 4\.x/
15
15
  expect { Webdrivers::Chromedriver.update }.not_to output(msg).to_stdout_from_any_process
16
16
  end
17
+
18
+ context 'when ENV variable WD_CACHE_TIME is set and Webdrivers.cache_time is not' do
19
+ before { described_class.cache_time = nil }
20
+
21
+ it 'uses cache time value from ENV variable' do
22
+ allow(ENV).to receive(:[]).with('WD_CACHE_TIME').and_return('999')
23
+ expect(described_class.cache_time).to be(999)
24
+ end
25
+
26
+ it 'returns cache time as an Integer' do
27
+ allow(ENV).to receive(:[]).with('WD_CACHE_TIME').and_return('999')
28
+ expect(described_class.cache_time).to be_an_instance_of(Integer)
29
+ end
30
+ end
31
+
32
+ context 'when Webdrivers.cache_time is set' do
33
+ it 'returns cache time as an Integer' do
34
+ described_class.cache_time = '999'
35
+ expect(described_class.cache_time).to be_an_instance_of(Integer)
36
+ end
37
+ end
38
+ end
39
+
40
+ describe '#install_dir' do
41
+ it 'uses ~/.webdrivers as default value' do
42
+ expect(described_class.install_dir).to include('.webdriver')
43
+ end
44
+
45
+ it 'uses provided value' do
46
+ begin
47
+ install_dir = File.expand_path(File.join(ENV['HOME'], '.webdrivers2'))
48
+ described_class.install_dir = install_dir
49
+
50
+ expect(described_class.install_dir).to eq install_dir
51
+ ensure
52
+ described_class.install_dir = nil
53
+ end
54
+ end
55
+
56
+ context 'when ENV variable WD_INSTALL_DIR is set and Webdrivers.install_dir is not' do
57
+ it 'uses path from the ENV variable' do
58
+ begin
59
+ described_class.install_dir = nil
60
+ allow(ENV).to receive(:[]).with('WD_INSTALL_DIR').and_return('custom_dir')
61
+ expect(described_class.install_dir).to be('custom_dir')
62
+ ensure
63
+ described_class.install_dir = nil
64
+ end
65
+ end
66
+ end
17
67
  end
18
68
  end
data/webdrivers.gemspec CHANGED
@@ -1,8 +1,8 @@
1
1
  # frozen_string_literal: true
2
2
 
3
3
  lib = File.expand_path('lib', __dir__)
4
- $:.unshift lib unless $:.include?(lib)
5
- require "webdrivers/version"
4
+ $LOAD_PATH.unshift lib unless $LOAD_PATH.include?(lib)
5
+ require 'webdrivers/version'
6
6
 
7
7
  Gem::Specification.new do |s|
8
8
  s.name = 'webdrivers'
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: webdrivers
3
3
  version: !ruby/object:Gem::Version
4
- version: 4.0.0.rc1
4
+ version: 4.0.0.rc2
5
5
  platform: ruby
6
6
  authors:
7
7
  - Titus Fortner
@@ -212,15 +212,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
212
212
  - !ruby/object:Gem::Version
213
213
  version: 1.3.1
214
214
  requirements: []
215
- rubyforge_project:
216
- rubygems_version: 2.6.14.4
215
+ rubygems_version: 3.0.3
217
216
  signing_key:
218
217
  specification_version: 4
219
218
  summary: Easy download and use of browser drivers.
220
- test_files:
221
- - spec/spec_helper.rb
222
- - spec/webdrivers/chromedriver_spec.rb
223
- - spec/webdrivers/geckodriver_spec.rb
224
- - spec/webdrivers/i_edriver_spec.rb
225
- - spec/webdrivers/webdrivers_spec.rb
226
- - spec/webdrivers_proxy_support_spec.rb
219
+ test_files: []