webdrivers 3.9.3 → 3.9.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f5f04db40cd34e87279887ac59110e05f38ef250
-  data.tar.gz: c2a768ed1f2a05ab0fce06f1a6ce9142d9f116a7
+  metadata.gz: a4e0c2a5c2fd095d45921dd927a01a0a181e27ab
+  data.tar.gz: 0d9be64a36320745d3d3eb17771c79ed53e6136a
 SHA512:
-  metadata.gz: 6908de99e739390d34fb816b4e7ca908961123933576f890436ff6f699903389e64af8b733fa835893bc4391ed66dc0e752a46164d799980566543f124ca50f5
-  data.tar.gz: 8add787cbc29d4f3bb3ca09cca8320c8e34f4ea5a19bdbde42e7aaa544bdce320628daf5d7eba0308c624a440a5151c13ac2f03fa24dc831bae3c122f323a800
+  metadata.gz: ddea9e942925176d9239e06fd414e432e8a114fdd83279760001c0bc6080f8a4e6aaef8ca2bccefaac49e7d5988905f569ac2c3409e902c57e54dc6fd17bf911
+  data.tar.gz: '0997d4066700cdefe6aea6acb59d96eac15475c0e9eaf5f3d053bda153d0b49d92ed512bba5c40e5a6bedb1aa2cce23ae6c586aa725ab9dd6d994c36736d2498'

data/CHANGELOG.md

@@ -1,6 +1,15 @@
+### 3.9.4 (2019-05-20)
+* Fix bug from bug fix that warned users about setting cache time when it was already set (issue #118) 
+* make #base_url public for easier mocking (issue #113)
+
+### 3.9.3 (2019-05-17)
+* Fix the bug that warned users about setting cache time when it was already set 
+([#118](https://github.com/titusfortner/webdrivers/pull/118), thanks Eduardo Gutierrez)
+
 ### 3.9.2 (2019-05-14)
 * Allow webdrivers to handle network mocking ([#116](https://github.com/titusfortner/webdrivers/pull/116))
-* Fix a Windows specific bug when decompressing the driver packages ([#114](https://github.com/titusfortner/webdrivers/pull/114))
+* Fix a Windows specific bug when decompressing the driver packages 
+([#114](https://github.com/titusfortner/webdrivers/pull/114))
 
 ### 3.9.1 (2019-05-09)
 * Fix bug throwing nil warnings (issue #107)
@@ -24,20 +33,27 @@
 
 ### 3.8.0 (2019-04-17)
 * Add support for `selenium-webdriver` v4. See [#69](https://github.com/titusfortner/webdrivers/pull/69).
-* Remove dependency on `net_http_ssl_fix` gem. `Webdrivers.net_http_ssl_fix` now raises an exception and points to other solutions. See [#60](https://github.com/titusfortner/webdrivers/pull/60) and [#68](https://github.com/titusfortner/webdrivers/pull/68).
+* Remove dependency on `net_http_ssl_fix` gem. `Webdrivers.net_http_ssl_fix` now raises an exception and 
+points to other solutions. See [#60](https://github.com/titusfortner/webdrivers/pull/60) and 
+[#68](https://github.com/titusfortner/webdrivers/pull/68) (thanks Samuel Williams & Maik Arnold).
 
 ### 3.7.2 (2019-04-01)
-* Fix bugs in methods that retrieve Chrome/Chromium version. See [#43](https://github.com/titusfortner/webdrivers/pull/43) and [#52](https://github.com/titusfortner/webdrivers/issues/52).
-* Add workaround for a Jruby bug when retrieving Chrome version on Windows. See [#41](https://github.com/titusfortner/webdrivers/issues/41).
+* Fix bugs in methods that retrieve Chrome/Chromium version. 
+See [#43](https://github.com/titusfortner/webdrivers/pull/43) 
+and [#52](https://github.com/titusfortner/webdrivers/issues/52) (Thanks Ochko). 
+* Add workaround for a Jruby bug when retrieving Chrome version on Windows. 
+See [#41](https://github.com/titusfortner/webdrivers/issues/41).
 * Update README with more information.
 
 ### 3.7.1 (2019-03-25)
-* Use `Selenium::WebDriver::Chrome#path` to check for a user given browser executable before defaulting to Google Chrome. Addresses [#38](https://github.com/titusfortner/webdrivers/issues/38).
+* Use `Selenium::WebDriver::Chrome#path` to check for a user given browser executable 
+before defaulting to Google Chrome. Addresses [#38](https://github.com/titusfortner/webdrivers/issues/38).
 * Download `chromedriver` v2.46 if Chrome/Chromium version is less than 70.
 
 ### 3.7.0 (2019-03-19)
 
-* `chromedriver` version now matches the installed Chrome version. See [#32](https://github.com/titusfortner/webdrivers/pull/32).
+* `chromedriver` version now matches the installed Chrome version. 
+See [#32](https://github.com/titusfortner/webdrivers/pull/32).
 
 ### 3.6.0 (2018-12-30)
 

data/lib/webdrivers/chromedriver.rb

@@ -50,6 +50,14 @@ module Webdrivers
         normalize_version ver[/\d+\.\d+\.\d+\.\d+/] # Google Chrome 73.0.3683.75 -> 73.0.3683.75
       end
 
+      #
+      # Returns url with domain for calls to get this driver.
+      #
+      # @return [String]
+      def base_url
+        'https://chromedriver.storage.googleapis.com'
+      end
+
       private
 
       def latest_point_release(version)
@@ -78,10 +86,6 @@ module Webdrivers
         System.platform == 'win' ? 'chromedriver.exe' : 'chromedriver'
       end
 
-      def base_url
-        'https://chromedriver.storage.googleapis.com'
-      end
-
       def download_url
         return @download_url if @download_url
 

data/lib/webdrivers/common.rb

@@ -181,10 +181,10 @@ end
         if System.valid_cache?(file_name)
           normalize_version System.cached_version(file_name)
         else
-          unless cache_warning
+          unless Common.cache_warning
             Webdrivers.logger.warn 'Driver caching is turned off in this version, but will be '\
                                   'enabled by default in 4.x. Set the value with `Webdrivers#cache_time=` in seconds'
-            @cache_warning = true
+            Common.cache_warning = true
           end
           version = yield
           System.cache_version(file_name, version)

data/lib/webdrivers/geckodriver.rb

@@ -28,16 +28,20 @@ module Webdrivers
         @latest_version ||= with_cache(file_name) { normalize_version(Network.get_url("#{base_url}/latest")[/[^v]*$/]) }
       end
 
+      #
+      # Returns url with domain for calls to get this driver.
+      #
+      # @return [String]
+      def base_url
+        'https://github.com/mozilla/geckodriver/releases'
+      end
+
       private
 
       def file_name
         System.platform == 'win' ? 'geckodriver.exe' : 'geckodriver'
       end
 
-      def base_url
-        'https://github.com/mozilla/geckodriver/releases'
-      end
-
       def download_url
         @download_url ||= if required_version == EMPTY_VERSION
                             direct_url(latest_version)

data/lib/webdrivers/iedriver.rb

@@ -29,16 +29,20 @@ module Webdrivers
         @latest_version ||= with_cache(file_name) { downloads.keys.max }
       end
 
+      #
+      # Returns url with domain for calls to get this driver.
+      #
+      # @return [String]
+      def base_url
+        'https://selenium-release.storage.googleapis.com/'
+      end
+
       private
 
       def file_name
         'IEDriverServer.exe'
       end
 
-      def base_url
-        'https://selenium-release.storage.googleapis.com/'
-      end
-
       def downloads
         doc = Nokogiri::XML.parse(Network.get(base_url))
         items = doc.css('Key').collect(&:text)

data/spec/webdrivers/webdrivers_spec.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Webdrivers do
+  describe '#cache_time' do
+    before { Webdrivers::Chromedriver.remove }
+
+    after { described_class.cache_time = 0 }
+
+    it 'does not warn if cache time is set' do
+      described_class.cache_time = 50
+
+      msg = /Webdrivers Driver caching is turned off in this version, but will be enabled by default in 4\.x/
+      expect { Webdrivers::Chromedriver.update }.not_to output(msg).to_stdout_from_any_process
+    end
+  end
+end

data/webdrivers.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.push File.expand_path('../lib', __dir__)
 
 Gem::Specification.new do |s|
   s.name        = 'webdrivers'
-  s.version     = '3.9.3'
+  s.version     = '3.9.4'
   s.authors     = ['Titus Fortner', 'Lakshya Kapoor']
   s.email       = %w[titusfortner@gmail.com kapoorlakshya@gmail.com]
   s.homepage    = 'https://github.com/titusfortner/webdrivers'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webdrivers
 version: !ruby/object:Gem::Version
-  version: 3.9.3
+  version: 3.9.4
 platform: ruby
 authors:
 - Titus Fortner
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-17 00:00:00.000000000 Z
+date: 2019-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ffi
@@ -184,6 +184,7 @@ files:
 - spec/webdrivers/geckodriver_spec.rb
 - spec/webdrivers/i_edriver_spec.rb
 - spec/webdrivers/ms_webdriver_spec.rb
+- spec/webdrivers/webdrivers_spec.rb
 - spec/webdrivers_proxy_support_spec.rb
 - webdrivers.gemspec
 homepage: https://github.com/titusfortner/webdrivers
@@ -216,4 +217,5 @@ test_files:
 - spec/webdrivers/geckodriver_spec.rb
 - spec/webdrivers/i_edriver_spec.rb
 - spec/webdrivers/ms_webdriver_spec.rb
+- spec/webdrivers/webdrivers_spec.rb
 - spec/webdrivers_proxy_support_spec.rb