webdrivers 3.9.0 → 3.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bee44be9b5854e4de983328db68fd8735a0a7587
-  data.tar.gz: 8dede2a2bd5446c2cd58df1485fd5db8dffeedea
+  metadata.gz: 6403a589e0c784d0b04a94c3b108c7d44fe062c2
+  data.tar.gz: 7956cc9a314eba3ec964e14a531d1aa97ac15aaa
 SHA512:
-  metadata.gz: bbbc24fb35b58c3b161f7b09d5a662f73f004f88e28bc6222ea80fa8ffb6df3cda648376462491e9e39835420ea4e057d958028701aa2529dd2bae2cd2c587ca
-  data.tar.gz: 8f1bd1cbcbddb25e27ffc73e35c6da979fe1fa7805254782a00d70c35da3daa0a41ef42e266f8322d129634ae64aee8987e54b0dfdcee995c30514121f876e4f
+  metadata.gz: ce9aa170e3e2d314c0f72d0eec6067df137575979276025ab7148c73b6d9242abb2f33815e330907ee7ca00e278f07cbc4af6a3fb1bfb8331bb7d2feeacc3d8c
+  data.tar.gz: 5d10f4f1194ede57d231b1c0c2be18f8370d1d08a2f5a812066236ef12e8e6e77654bf361fd9d5d3ab3d19bb8b475455d40ef34389b4a75e3b02b02f6e07a055

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+### 3.9.1 (2019-05-09)
+* Fix bug throwing nil warnings (issue #107)
+* Fix bug preventing running on older versions of Selenium
+
 ### 3.9.0 (2019-05-07)
 * Make public methods more obvious and deprecate unnecessary methods (issue #36)
 * Allow geckodriver binaries to be downloaded directly (issue #30)

data/README.md

@@ -29,6 +29,8 @@ require 'webdrivers'
 The drivers will now be automatically downloaded or updated when you launch a browser
 through Selenium. 
 
+### Specific Drivers
+
 If you want webdrivers to only manage specific drivers you can specify as follows:
 ```ruby
 require 'webdrivers/chromedriver'
@@ -68,6 +70,15 @@ You can explicitly trigger the update in your code, but this will happen automat
 Webdrivers::Chromedriver.update
 ```
 
+### Caching Drivers
+
+You can set Webdrivers to only look for updates if the previous check was longer ago than a specified number of seconds.
+```ruby
+Webdrivers.cache_time = 86_400
+```
+
+The default in 3.9 is zero, and the default for 4.x will be 24 hours (86,400 seconds)
+
 ### Proxy
 
 If there is a proxy between you and the Internet then you will need to configure

data/lib/webdrivers/chromedriver.rb

@@ -67,7 +67,7 @@ module Webdrivers
       def download_url
         return @download_url if @download_url
 
-        version = if required_version.version.empty?
+        version = if required_version == EMPTY_VERSION
                     latest_version
                   else
                     normalize_version(required_version)

data/lib/webdrivers/common.rb

@@ -71,7 +71,7 @@ end
         new = "#{self.class}#required_version or #{self.class}#latest_version"
         Webdrivers.logger.deprecate(old, new)
 
-        desired_version.version.empty? ? latest_version : normalize_version(desired_version)
+        desired_version == EMPTY_VERSION ? latest_version : normalize_version(desired_version)
       end
 
       def remove
@@ -98,7 +98,7 @@ end
       private
 
       def download_url
-        @download_url ||= if required_version.version.empty?
+        @download_url ||= if required_version == EMPTY_VERSION
                             downloads[downloads.keys.max]
                           else
                             downloads[normalize_version(required_version)]
@@ -110,7 +110,7 @@ end
       end
 
       def correct_binary?
-        current_version == if required_version.version.empty?
+        current_version == if required_version == EMPTY_VERSION
                              latest_version
                            else
                              normalize_version(required_version)
@@ -124,7 +124,7 @@ end
       end
 
       def normalize_version(version)
-        Gem::Version.new(version&.to_s)
+        Gem::Version.new(version.to_s)
       end
 
       def binary_version
@@ -150,6 +150,8 @@ end
           normalize_version version
         end
       end
+
+      EMPTY_VERSION = Gem::Version.new('')
     end
   end
 end

data/lib/webdrivers/geckodriver.rb

@@ -31,7 +31,11 @@ module Webdrivers
       end
 
       def download_url
-        @download_url ||= required_version.version.empty? ? direct_url(latest_version) : direct_url(required_version)
+        @download_url ||= if required_version == EMPTY_VERSION
+                            direct_url(latest_version)
+                          else
+                            direct_url(required_version)
+                          end
       end
 
       def direct_url(version)

data/lib/webdrivers/mswebdriver.rb

@@ -13,7 +13,7 @@ end
 module Selenium
   module WebDriver
     module Edge
-      if Selenium::WebDriver::VERSION > '3.141.0'
+      if defined?(Selenium::WebDriver::VERSION) && Selenium::WebDriver::VERSION > '3.141.0'
         class Service < WebDriver::Service
           class << self
             alias se_driver_path driver_path

data/spec/webdrivers/ms_webdriver_spec.rb

@@ -8,7 +8,7 @@ describe Webdrivers::MSWebdriver do
   it 'gives deprecation for using it' do
     msg = /WARN Webdrivers Microsoft WebDriver for the Edge browser is no longer supported by Webdrivers gem/
 
-    if Selenium::WebDriver::VERSION > '3.141.0'
+    if defined?(Selenium::WebDriver::VERSION) && Selenium::WebDriver::VERSION > '3.141.0'
       expect { Selenium::WebDriver::Edge::Service.driver_path }.to output(msg).to_stdout_from_any_process
     else
       expect { Selenium::WebDriver::Edge.driver_path }.to output(msg).to_stdout_from_any_process

data/webdrivers.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.push File.expand_path('../lib', __dir__)
 
 Gem::Specification.new do |s|
   s.name        = 'webdrivers'
-  s.version     = '3.9.0'
+  s.version     = '3.9.1'
   s.authors     = ['Titus Fortner', 'Lakshya Kapoor']
   s.email       = %w[titusfortner@gmail.com kapoorlakshya@gmail.com]
   s.homepage    = 'https://github.com/titusfortner/webdrivers'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webdrivers
 version: !ruby/object:Gem::Version
-  version: 3.9.0
+  version: 3.9.1
 platform: ruby
 authors:
 - Titus Fortner
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-08 00:00:00.000000000 Z
+date: 2019-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ffi