webdrivers 3.2.3 → 3.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f81f6522ad358e18e2cf683e41223f33700eb62b
-  data.tar.gz: 3164add137b3f3a154a7ab954238ad16c8e91c47
+  metadata.gz: ca1ac3aeef06a8be8d433cde3199d6fe8609b88d
+  data.tar.gz: c51bbd846ff0fbb6e21213be144a1f9c72538616
 SHA512:
-  metadata.gz: c979cb462555fcf4e3c50730c01ca293a0f78c8b5ef70a21407cc31084631e211e8c5eef272346cba6fd254dd1fed8596150e3b18683cfaf60bd789f668b12f0
-  data.tar.gz: 5185f0ee4ef76cae82b73f0c3feffe54cd80f24e5505a99eacbf8de75e1579c6b32a3b4368459c4a9734e36f10fdb4b7059d7aafb6340a813d71bcedc1b0e7e2
+  metadata.gz: c9fc8f2e6c6e1268fc69fc7c76f197234da084b11f3298f8742449f4e44ee5d4b2605369c03ac0efcb5895814dcb4207c1514a3419486f2c5603c49576b4c48f
+  data.tar.gz: 81ffe1608b1d783df44a7e75075ed601e4fb6553e244733153f4098803ff05e0ba4acaa604398c7cf232ffe05ec6211a6731d5ced87e337078b27299f6e92c45

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+### 3.2.3 (2017-01-04)
+
+* Improve error message when unable to find the latest driver
+
 ### 3.2.3 (2017-12-12)
 
 * Fixed bug with finding geckodriver on updated Github release pages

data/lib/webdrivers/common.rb

@@ -9,7 +9,17 @@ module Webdrivers
         unless site_available?
           return current.nil? ? nil : binary
         end
-        return binary if current == latest
+        released = latest()
+        location = binary()
+
+        return location if released.nil? && File.exist?(location)
+
+        if released.nil?
+          msg = "Unable to find the latest version of #{file_name}; try downloading manually from #{base_url} and place in #{install_dir}"
+          raise StandardError, msg
+        end
+
+        return location if current == released
         remove && download
       end
 

data/spec/geckodriver_spec.rb

@@ -4,6 +4,19 @@ describe Webdrivers::Geckodriver do
 
   let(:geckodriver) { Webdrivers::Geckodriver }
 
+  it 'raises exception if unable to get latest geckodriver and no geckodriver present' do
+    geckodriver.remove
+    allow(geckodriver).to receive(:latest).and_return(nil)
+    msg = /^Unable to find the latest version of geckodriver; try downloading manually from (.*)?and place in (.*)?\.webdrivers$/
+    expect { geckodriver.update }.to raise_exception StandardError, msg
+  end
+
+  it 'uses found version of geckodriver if latest release unable to be found' do
+    geckodriver.download
+    allow(geckodriver).to receive(:latest).and_return(nil)
+    expect(geckodriver.update).to match(/\.webdrivers\/geckodriver/)
+  end
+
   it 'finds latest version' do
     expect(geckodriver.latest).to be > 0.17
     expect(geckodriver.latest).to be < 0.2

data/webdrivers.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "webdrivers"
-  s.version     = "3.2.3"
+  s.version     = "3.2.4"
   s.authors     = ["Titus Fortner"]
   s.email       = ["titusfortner@gmail.com"]
   s.homepage    = "https://github.com/titusfortner/webdrivers"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: webdrivers
 version: !ruby/object:Gem::Version
-  version: 3.2.3
+  version: 3.2.4
 platform: ruby
 authors:
 - Titus Fortner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-12 00:00:00.000000000 Z
+date: 2018-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec