webdrivers 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 46f1acf45fd7372da5ea9c5af77f903c4a9758bf
-  data.tar.gz: c6f35b74fba542c6eacdbccad28b1001edd6ecdb
+  metadata.gz: a3906bdc8bd136289c358406431dc861ca4a9743
+  data.tar.gz: 21f04b5c852414cd9b7c49458f93bab02527b470
 SHA512:
-  metadata.gz: e1703697fe5b2f87077b2b24d92c7806b941f3444676c0a84a85437a206ecb30d82e20e7700bc11e27164212e54d61068c6a3802dbdffdb8d46d9710cd64ab1c
-  data.tar.gz: 607a53cd50642d97e888e068ee669cc04b4490d683375f00e9e312d14f930b43a11dcb14e7f306438a0cac2b6ac6e6990705786990dd28aa1e1a04f01e7c5035
+  metadata.gz: 60679288c0b3baa467980eff5cf63bb1df5d7d99caa5d8a2eb812e7993498375181892af515af985094ebc3bff162b26876eb18f0b2838f8034383bb83666255
+  data.tar.gz: 7e5ebd24567114a7abb43542c810478c498eb89f4d318c7bd0f78f50ac460b36d601d06057f6b9b5db3b138753efc8346d541237208afbd63dc1bbca355a3385

data/CHANGELOG.md

@@ -1,6 +1,12 @@
 Changelog
 ==========
 
+2.1.1 - 2016-11-26
+----------
+
+* Improve Decompression Approach
+
+
 2.1.0 - 2016-11-25
 ----------
 

data/lib/webdrivers/chromedriver.rb

@@ -31,10 +31,6 @@ module Webdrivers
         end
       end
 
-      def decompress_file(filename)
-        Archive::Zip.extract(filename, '.', :overwrite => :all)
-      end
-
       def base_url
         'http://chromedriver.storage.googleapis.com'
       end

data/lib/webdrivers/common.rb

@@ -30,6 +30,28 @@ module Webdrivers
         FileUtils.chmod "ugo+rx", binary_path
       end
 
+      def decompress_file(filename)
+        case filename
+        when /tar\.gz$/
+          untargz_file(filename)
+        else
+          unzip_file(filename)
+        end
+      end
+
+      def untargz_file(filename)
+        tar_extract = Gem::Package::TarReader.new(Zlib::GzipReader.open(filename))
+        tar_extract.rewind
+
+        ucf = File.open(file_name, "w+")
+        tar_extract.each { |entry| ucf << entry.read }
+        ucf.close
+      end
+
+      def unzip_file(filename)
+        Archive::Zip.extract(filename, '.', :overwrite => :all)
+      end
+
       def download_url(version = nil)
         downloads[version || newest_version]
       end

data/lib/webdrivers/geckodriver.rb

@@ -32,15 +32,6 @@ module Webdrivers
         end
       end
 
-      def decompress_file(filename)
-        tar_extract = Gem::Package::TarReader.new(Zlib::GzipReader.open(filename))
-        tar_extract.rewind
-
-        ucf = File.open(file_name, "w+")
-        tar_extract.each { |entry| ucf << entry.read }
-        ucf.close
-      end
-
       def base_url
         'https://github.com/mozilla/geckodriver/releases'
       end

data/spec/chromedriver_spec.rb

@@ -4,6 +4,12 @@ describe Webdrivers::Chromedriver do
 
   let(:chromedriver) { Webdrivers::Chromedriver }
 
+  it 'downloads' do
+    chromedriver.download
+    file = "#{ENV['GEM_HOME']}/bin/chromedriver"
+    expect(File.exist?(file)).to eq true
+  end
+
   it { expect(chromedriver.newest_version.to_f).to be >= 2.25 }
 
   it { expect(chromedriver.downloads.size).to be >= 26 }

data/spec/geckodriver_spec.rb

@@ -4,6 +4,12 @@ describe Webdrivers::Geckodriver do
 
   let(:geckodriver) { Webdrivers::Geckodriver }
 
+  it 'downloads' do
+    geckodriver.download
+    file = "#{ENV['GEM_HOME']}/bin/geckodriver"
+    expect(File.exist?(file)).to eq true
+  end
+
   it { expect(geckodriver.newest_version.to_f).to be >= 0.11 }
 
   it { expect(geckodriver.downloads.size).to be >= 4 }

data/webdrivers.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "webdrivers"
-  s.version     = "2.1.0"
+  s.version     = "2.1.1"
   s.authors     = ["Titus Fortner"]
   s.email       = ["titusfortner@gmail.com"]
   s.homepage    = "https://github.com/titusfortner/webdrivers"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webdrivers
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Titus Fortner