weatherzone 0.8.2 → 0.8.3

data/lib/weatherzone.rb

@@ -22,5 +22,5 @@ require 'weatherzone/helpers/date_parser'
 require 'weatherzone/helpers/units'
 
 module Weatherzone
-  VERSION = '0.8.2'
+  VERSION = '0.8.3'
 end

data/lib/weatherzone/helpers/date_parser.rb

@@ -19,11 +19,15 @@ module Weatherzone
               has_attribute :tz, :on_elements => methods
               define_method "#{method_name}_utc" do
                 tz = TZInfo::Timezone.get("Australia/#{send("#{method_name}_tz")}")
-                tz.local_to_utc(Time.parse(instance_variable_get("@#{method_name}")))
+                if value = instance_variable_get("@#{method_name}")
+                  tz.local_to_utc(Time.parse(value))
+                end
               end
               define_method method_name do
-                tz = TZInfo::Timezone.get("Australia/#{send("#{method_name}_tz")}")
-                tz.utc_to_local send("#{method_name}_utc")
+                if value = send("#{method_name}_utc")
+                  tz = TZInfo::Timezone.get("Australia/#{send("#{method_name}_tz")}")
+                  tz.utc_to_local value
+                end
               end
             end
           end

data/test/test_date_parser.rb

@@ -2,10 +2,15 @@ require File.dirname(__FILE__) + '/test_helper.rb'
 
 class TestDateParser < Test::Unit::TestCase
 
-  class SomeResource
+  class SomeResource < Weatherzone::Resource
     include Weatherzone::Helpers::DateParser
-    attr_writer :created_at
+    attr_writer :created_at, :issue_time_local
     interpret_as_date :created_at
+    interpret_as_time :issue_time_local
+    
+    def issue_time_local_tz
+      "EST"
+    end
   end
   
   def test_parses_date
@@ -14,10 +19,30 @@ class TestDateParser < Test::Unit::TestCase
     assert_equal Date.parse("12/04/1972"), resource.created_at
   end
   
-  def test_doesnt_bork_on_nils
+  def test_doesnt_raise_on_nil_dates
     resource = SomeResource.new
     resource.created_at = nil
     assert_equal nil, resource.created_at
   end
+  
+  def test_parses_time
+    time = "2009-08-12T09:17:00"
+    
+    tz = TZInfo::Timezone.get("Australia/EST")
+    expected_utc = tz.local_to_utc(Time.parse(time))
+    
+    resource = SomeResource.new
+    resource.issue_time_local = time
+
+    assert_equal expected_utc, resource.issue_time_local_utc
+    assert_equal tz.utc_to_local(expected_utc), resource.issue_time_local    
+  end
+  
+  def test_doesnt_raise_on_nil_times
+    resource = SomeResource.new
+    resource.issue_time_local = nil
+    assert_equal nil, resource.issue_time_local_utc
+    assert_equal nil, resource.issue_time_local
+  end
 
 end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 8
-  - 2
-  version: 0.8.2
+  - 3
+  version: 0.8.3
 platform: ruby
 authors: 
 - Ben Askins