weather_hacker 0.1.3 → 0.1.4

data/lib/weather_hacker/client.rb

@@ -21,6 +21,8 @@ class WeatherHacker
           "min" => hash["lwws"]["temperature"]["min"]["celsius"],
         },
       }
+    rescue ParseError
+      nil
     end
 
     private
@@ -59,6 +61,8 @@ class WeatherHacker
       response = get ZIPCODE_URL, :query => { :zn => zipcode }
       values   = response["ZIP_result"]["ADDRESS_value"]["value"]
       Hash[values.map { |v| v.to_a.flatten }]
+    rescue NoMethodError
+      raise ParseError, "The zipcode is not supported by API"
     end
 
     # canonical prefecture name

data/lib/weather_hacker/version.rb

@@ -1,3 +1,3 @@
 class WeatherHacker
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

data/lib/weather_hacker.rb

@@ -24,10 +24,10 @@ class WeatherHacker
   # if the date is not supported, return nil
   def on(date)
     now = Date.today
-    {
-      now     => today,
-      now + 1 => tomorrow,
-      now + 2 => day_after_tomorrow,
-    }[date]
+    case date
+    when now + 0; today
+    when now + 1; tomorrow
+    when now + 2; day_after_tomorrow
+    end
   end
 end

data/spec/weather_hacker/client_spec.rb

@@ -9,33 +9,43 @@ describe "WeatherHacker::Client" do
   end
 
   describe "#get_weather" do
-    before do
-      @result = @client.get_weather(@zipcode)
-    end
+    let(:result) { @client.get_weather(@zipcode) }
 
-    it "get parsed weather data in Hash" do
-      [Hash, NilClass].should be_include @result.class
-    end
+    context "when server returns expected response" do
+      it "should get parsed weather data in Hash" do
+        [Hash, NilClass].should be_include result.class
+      end
+
+      it "should have weather" do
+        result["weather"].should =~ /[晴曇雨]/
+      end
 
-    it "has weather" do
-      @result["weather"].should =~ /[晴曇雨]/
+      it "should have max and min temperature" do
+        result["temperature"].has_key?("max").should be_true
+        result["temperature"].has_key?("min").should be_true
+      end
     end
 
-    it "has max and min temperature" do
-      @result["temperature"].has_key?("max").should be_true
-      @result["temperature"].has_key?("min").should be_true
+    context "when server returns unexpeced response" do
+      before do
+        @zipcode = "999-9999"
+      end
+
+      it do
+        result.should be_nil
+      end
     end
   end
 
   shared_examples_for "having area table" do
-    it "has area table" do
+    it "should have area table" do
       @client.send(:id_by_city).keys.size.should_not == 0
       @client.send(:pref_by_city).keys.size.should_not == 0
     end
   end
 
   shared_examples_for "not having area table" do
-    it "has not area table" do
+    it "should have not area table" do
       @client.instance_variable_get(:@id_by_city).should be_nil
       @client.instance_variable_get(:@pref_by_city).should be_nil
     end
@@ -64,14 +74,14 @@ describe "WeatherHacker::Client" do
   end
 
   describe "#city_id_by_zipcode" do
-    it "return city_id" do
+    it "should return city_id" do
       city_id = @client.send(:city_id_by_zipcode, @zipcode)
       city_id.should be_kind_of Integer
     end
   end
 
   describe "#id_by_pref" do
-    it "is cached in instance variable" do
+    it "should be cached in instance variable" do
       @client.instance_variable_get(:@id_by_pref).should be_nil
       @client.send(:id_by_pref)
       @client.instance_variable_get(:@id_by_pref).should be_kind_of Hash
@@ -80,7 +90,7 @@ describe "WeatherHacker::Client" do
       @client.send(:id_by_pref)
     end
 
-    it "return table of id by pref" do
+    it "should return table of id by pref" do
       @client.send(:id_by_pref).should be_kind_of Hash
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: weather_hacker
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70285964279140 !ruby/object:Gem::Requirement
+  requirement: &70362866214980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 0.9.2
   type: :runtime
   prerelease: false
-  version_requirements: *70285964279140
+  version_requirements: *70362866214980
 - !ruby/object:Gem::Dependency
   name: httparty
-  requirement: &70285964278720 !ruby/object:Gem::Requirement
+  requirement: &70362866214560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70285964278720
+  version_requirements: *70362866214560
 - !ruby/object:Gem::Dependency
   name: awesome_print
-  requirement: &70285964278260 !ruby/object:Gem::Requirement
+  requirement: &70362866214100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70285964278260
+  version_requirements: *70362866214100
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70285964277840 !ruby/object:Gem::Requirement
+  requirement: &70362866213660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70285964277840
+  version_requirements: *70362866213660
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &70285964277420 !ruby/object:Gem::Requirement
+  requirement: &70362866213240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70285964277420
+  version_requirements: *70362866213240
 - !ruby/object:Gem::Dependency
   name: simplecov-vim
-  requirement: &70285964277000 !ruby/object:Gem::Requirement
+  requirement: &70362866212780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,7 +76,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70285964277000
+  version_requirements: *70362866212780
 description: Library for Livedoor Weather Web Service
 email:
 - r7kamura@gmail.com
@@ -117,7 +117,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1882350461741233661
+      hash: -3473716244803351994
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -126,7 +126,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1882350461741233661
+      hash: -3473716244803351994
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.15