weasel_diesel 1.2.0 → 1.2.1

data/CHANGELOG.md

@@ -3,6 +3,16 @@
 All changes can be seen on GitHub and git tags are used to isolate each
 release.
 
+*1.2.1*:
+
+* Modified the way an empty string param is cast/verified. If a param is
+passed as an empty string but the param isn't specified as a string, the
+param is nullified. So if you pass `{'id' => ''}`, and `id` is set to be
+an integer param, the cast params will look like that: `{'id' => nil}`,
+however if `name` is a string param and `{'name' => ''}` is passed, the
+value won't be nullified.
+
+
 **1.2.0**: 
 
 * All service urls are now stored with a prepended slash (if not defined

data/lib/params_verification.rb

@@ -165,7 +165,7 @@ module ParamsVerification
   #
   # @param [Object] param_value The value to validate and cast.
   # @param [String] param_name The name of the param we are validating.
-  # @param [Symbol] type The expected object type.
+  # @param [Symbol] rule_type The expected object type.
   # @param [Hash] params The params that might need to be updated.
   # @param [String, Symbol] namespace The optional namespace used to access the `param_value`
   #
@@ -175,6 +175,8 @@ module ParamsVerification
   def self.validate_and_cast_type(param_value, param_name, rule_type, params, namespace=nil)
     # checks type & modifies params if needed
     if rule_type && param_value
+      # nullify empty strings for any types other than string
+      param_value = nil if param_value == '' && rule_type != :string
       verify_cast(param_name, param_value, rule_type)
       param_value = type_cast_value(rule_type, param_value)
       # update the params hash with the type cast value

data/lib/weasel_diesel/version.rb

@@ -1,3 +1,3 @@
 class WeaselDiesel
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

data/spec/params_verification_spec.rb

@@ -187,4 +187,14 @@ describe ParamsVerification do
     lambda{ ParamsVerification.validate!(params, @service.defined_params) }.should raise_exception(ParamsVerification::InvalidParamValue)
   end
   
+  it "should allow optional null integer params" do
+    service = WeaselDiesel.new("spec")
+    service.params do |p|
+      p.integer :id, :optional => true, :null => true
+    end
+    params = {"id" => ""}
+    lambda{ ParamsVerification.validate!(params, service.defined_params) }.should_not raise_exception
+    params = {"id" => nil}
+    lambda{ ParamsVerification.validate!(params, service.defined_params) }.should_not raise_exception
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: weasel_diesel
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-26 00:00:00.000000000 Z
+date: 2013-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -146,7 +146,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2531016401630925863
+      hash: 1325572656893606813
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -155,7 +155,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2531016401630925863
+      hash: 1325572656893606813
 requirements: []
 rubyforge_project: wsdsl
 rubygems_version: 1.8.24