we-call 0.6.0 → 0.6.1.pre.alpha1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3d78d029728e8e0fa159897a40a4e618127f8baa
-  data.tar.gz: 7d19119651d934580795b9ae0f94a758048406cd
+  metadata.gz: cf7b5c54d9eb24a040dc0ecb5bb9aca3b7c8ca97
+  data.tar.gz: 72addcf3bc92a8bf5770134a079185d7fef7f9b3
 SHA512:
-  metadata.gz: f5f90f915b325d61ccdfc43c896e4b4354d83a1ba47deade642411ab89316159c56ceda5aeda2813e223d3f5eb769e5e298155bbf632430d870a72110c683451
-  data.tar.gz: a1952d2146232bb7f6a78d78394bed9b48d8b82f1bbfbba681dcd17b1495b3d54001456e30ba32608bb311bd953f4321773e50978e945c8818176a6b2fe93ae9
+  metadata.gz: a8098c9c5f614d736a19ff0abf170c5b5d8000dcec7585220f66687a73051a3fbf23053262e604890a69af7a2b17cba1cf0bd5bf2d698f47d0d2da3e681f77a3
+  data.tar.gz: e666fd9db47bee7413cb9a9b161c8b03d46671698e0ed10de2d4fd9b4329e15d24f88523332b9ba48dd4a7efc7a724cd1001bc598b6b602ac8716d1e14f2d26f

data/README.md

@@ -37,10 +37,10 @@ end
 As this is a Faraday wrapper, the only thing that will change from normal Faraday usage is initialization.
 
 ```ruby
-connection = We::Call::Connection.new(host: 'https://some-service.example.com/', timeout: 5)
+connection = We::Call::Connection.new(host: 'https://some-service.example.com/', timeout: 2)
 
 # or with a Faraday connection block
-connection = We::Call::Connection.new(host: 'https://some-service.example.com/', timeout: 5) do |conn|
+connection = We::Call::Connection.new(host: 'https://some-service.example.com/', timeout: 2) do |conn|
   conn.token_auth('abc123token')
   conn.headers['Foo'] = 'bar'
 end
@@ -61,7 +61,7 @@ connection = We::Call.configure do |config|
 end
 
 # Provided at initialization
-connection = We::Call::Connection.new(host: 'https://service-b.example.com/', app: 'Service A', timeout: 5)
+connection = We::Call::Connection.new(host: 'https://service-b.example.com/', app: 'Service A', timeout: 2)
 ```
 
 _Ofc services could lie about this, so do not use App Name for any sort of security. For that you need to use tokens assigned to applications. This is essentially just forcing a user agent._
@@ -75,7 +75,7 @@ connection = We::Call.configure do |config|
 end
 
 # Provided at initialization
-connection = We::Call::Connection.new(host: 'https://service-b.example.com/', env: 'staging', timeout: 5)
+connection = We::Call::Connection.new(host: 'https://service-b.example.com/', env: 'staging', timeout: 2)
 ```
 
 Not only is knowing the app name important, but knowing the env is necessary too. Sometimes people configure stuff wrong, and Service A (staging) will hit Service B (production) 😨.
@@ -90,12 +90,12 @@ The lower this number can be the better, as it reduces time web threads spend wa
 
 ```ruby
 # Provided at initialization
-connection = We::Call::Connection.new(host: 'https://service-b.example.com/', timeout: 5)
+connection = We::Call::Connection.new(host: 'https://service-b.example.com/', timeout: 2)
 ```
 
 Timeouts can only be provided at initialization of a connection, as they should be different for each service. This is down to the sad reality that some internal services are more performant than others, and various third-parties will have different SLAs.
 
-As well as `timeout: num_seconds` which can set the entire open/read (essentially the total response time of the server), another optional argument exists for `open_timeout: numseconds`. This is how long We::Call should spend waiting for a vague sign of life from the server, which by default is 2.
+As well as `timeout: num_seconds` which can set the entire open/read (essentially the total response time of the server), another optional argument exists for `open_timeout: numseconds`. This is how long We::Call should spend waiting for a vague sign of life from the server, which by default is 1.
 
 ### Deprecations
 

data/lib/we/call/connection.rb

@@ -1,6 +1,3 @@
-require 'faraday'
-require 'faraday-sunset'
-require 'typhoeus'
 require 'typhoeus/adapters/faraday'
 
 module We
@@ -8,7 +5,9 @@ module We
     module Connection
       extend self
 
-      OPEN_TIMEOUT = 2
+      # If your network isn't stable enough to get a sign of life in 1s then you should look into that
+      # Or override this default on creating the connection.
+      OPEN_TIMEOUT = 1
 
       # We use typhoeus instead of default NetHTTP so we can control how many retries are made
       # https://github.com/lostisland/faraday/issues/612

data/lib/we/call/version.rb

@@ -1,5 +1,5 @@
 module We
   module Call
-    VERSION = "0.6.0"
+    VERSION = "0.6.1-alpha1"
   end
 end

data/lib/we/call.rb

@@ -1,3 +1,7 @@
+require 'faraday'
+require 'faraday-sunset'
+require 'typhoeus'
+
 module We
   module Call
     autoload :Annotations,   "we/call/annotations"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: we-call
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1.pre.alpha1
 platform: ruby
 authors:
 - WeWork Engineering
@@ -259,9 +259,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.6.8