wcc-contentful 1.4.0.rc1 → 1.4.0.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 40c4c53ea7b5054745f8cd28841d59934a2e83ea65e4658e64124533412500bb
-  data.tar.gz: 53150802f51676dafc356812578159c23670335b8066c0536ad0d0b89fb094fd
+  metadata.gz: 0b1a0aa21bc1bc749fdfc169eecf55d5bf829e0d4ac4272e90649c2d46abf622
+  data.tar.gz: 12812d6728c4992ea3763cdbe0dc8f204267a75c3f35a052a663ec8c4f380115
 SHA512:
-  metadata.gz: cd9ad6f0e34c388c12bc55fb7a62e5a55463f83fa0b09c0964e9f990d373ef142c890d54b8d77d6cd5e4e8e53a3c199919163268b2fddba7ec79e6f39e040a18
-  data.tar.gz: 1102e99319ded82fdef9293b06f68dae7d06b978696f6c12afe094f467d8f8cfff7242ada67e2adebed4b2903e279bd637ac468569dbf79a786e3ed07244337d
+  metadata.gz: 9226778b6abf97db358f836ed0659e202f13266fbf946acd793cbeed23f69cb3cab475e9750ca64761ba6ceecd38cdaaad7f919ea2a2d04f00fa4d8e940d9653
+  data.tar.gz: c4f0bb1b6e44fa8b0a4aa647e246ff7dd6726d62e2905d026f2bb201867fb09af640b266ab95c22e04dab6b23f4c162ec6d88cf3bd45ca41c9a5853eb4842d80

data/README.md

@@ -374,7 +374,6 @@ WCC::Contentful::SimpleClient::Cdn.new(
   space: '1234',
   # optional
   environment: 'staging', # omit to use master
-  default_locale: '*',
   rate_limit_wait_timeout: 10,
   instrumentation: ActiveSupport::Notifications,
   connection: Faraday.new { |builder| ... },

data/app/jobs/wcc/contentful/webhook_enable_job.rb

@@ -51,7 +51,6 @@ module WCC::Contentful
         management_token: config.management_token,
         space: config.space,
         environment: config.environment,
-        default_locale: config.default_locale,
         connection: config.connection,
         webhook_username: config.webhook_username,
         webhook_password: config.webhook_password,

data/lib/wcc/contentful/active_record_shim.rb

@@ -33,7 +33,7 @@ module WCC::Contentful::ActiveRecordShim
 
   class_methods do
     def model_name
-      WCC::Contentful::Helpers.constant_from_content_type(content_type)
+      ActiveModel::Name.new(self, nil, WCC::Contentful::Helpers.constant_from_content_type(content_type))
     end
 
     def const_get(name)
@@ -46,7 +46,7 @@ module WCC::Contentful::ActiveRecordShim
     end
 
     def table_name
-      model_name.tableize
+      model_name.plural.tableize
     end
 
     def unscoped

data/lib/wcc/contentful/middleware/store/caching_middleware.rb

@@ -34,7 +34,8 @@ module WCC::Contentful::Middleware::Store
       # Now that the one locale is in the cache, when we index next time we'll index the
       # all-locales version and we'll be fine.
       locale = options[:locale]&.to_s || default_locale
-      if found.dig('sys', 'locale') != locale
+      found_locale = found.dig('sys', 'locale')&.to_s
+      if found_locale && (found_locale != locale)
         event = 'miss'
         return store.find(key, **options)
       end
@@ -90,15 +91,21 @@ module WCC::Contentful::Middleware::Store
       id = json.dig('sys', 'id')
       type = json.dig('sys', 'type')
       prev = @cache.read(id)
-      return if prev.nil? && LAZILY_CACHEABLE_TYPES.include?(type)
+      if prev.nil? && LAZILY_CACHEABLE_TYPES.include?(type)
+        _instrument('miss.index', key: id, type: type, prev: nil, next: nil)
+        return
+      end
 
       if (prev_rev = prev&.dig('sys', 'revision')) && (next_rev = json.dig('sys', 'revision')) && (next_rev < prev_rev)
+        _instrument('miss.index', key: id, type: type, prev: prev_rev, next: next_rev)
         return prev
       end
 
       # we also set DeletedEntry objects in the cache - no need to go hit the API when we know
       # this is a nil object
-      @cache.write(id, json, expires_in: expires_in)
+      _instrument('write.index', key: id, type: type, prev: prev_rev, next: next_rev) do
+        @cache.write(id, json, expires_in: expires_in)
+      end
 
       case type
       when 'DeletedEntry', 'DeletedAsset'

data/lib/wcc/contentful/model_builder.rb

@@ -59,11 +59,11 @@ module WCC::Contentful
 
           define_method(:initialize) do |raw, context = nil|
             ct = content_type_from_raw(raw)
-            if ct != typedef.content_type
+            if ct.present? && ct != typedef.content_type
               raise ArgumentError, 'Wrong Content Type - ' \
                                    "'#{raw.dig('sys', 'id')}' is a #{ct}, expected #{typedef.content_type}"
             end
-            if raw.dig('sys', 'locale').blank?
+            if raw.dig('sys', 'locale').blank? && %w[Entry Asset].include?(raw.dig('sys', 'type'))
               raise ArgumentError, 'Model layer cannot represent "locale=*" entries. ' \
                                    "Please use a specific locale in your query.  \n" \
                                    "(Error occurred with entry id: #{raw.dig('sys', 'id')})"

data/lib/wcc/contentful/simple_client.rb

@@ -36,7 +36,6 @@ module WCC::Contentful
     # @param [Hash] options The remaining optional parameters, defined below
     # @option options [Symbol, Object] connection The Faraday connection to use to make requests.
     #   Auto-discovered based on what gems are installed if this is not provided.
-    # @option options [String] default_locale The locale query param to set by default.
     # @option options [String] environment The contentful environment to access. Defaults to 'master'.
     # @option options [Boolean] no_follow_redirects If true, do not follow 300 level redirects.
     # @option options [Number] rate_limit_wait_timeout The maximum time to block the thread waiting
@@ -51,7 +50,6 @@ module WCC::Contentful
       @options = options
       @_instrumentation = @options[:instrumentation]
       @query_defaults = {}
-      @query_defaults[:locale] = @options[:default_locale] if @options[:default_locale]
       # default 1.5 so that we retry one time then fail if still rate limited
       # https://www.contentful.com/developers/docs/references/content-preview-api/#/introduction/api-rate-limits
       @rate_limit_wait_timeout = @options[:rate_limit_wait_timeout] || 1.5

data/lib/wcc/contentful/version.rb

@@ -2,6 +2,6 @@
 
 module WCC
   module Contentful
-    VERSION = '1.4.0.rc1'
+    VERSION = '1.4.0.rc2'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: wcc-contentful
 version: !ruby/object:Gem::Version
-  version: 1.4.0.rc1
+  version: 1.4.0.rc2
 platform: ruby
 authors:
 - Watermark Dev
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-02-28 00:00:00.000000000 Z
+date: 2023-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: byebug
@@ -698,8 +698,8 @@ summary: '[![Gem Version](https://badge.fury.io/rb/wcc-contentful.svg)](https://
   credentials, or to connect without setting up all the rest of WCC::Contentful, is
   easy:  ```ruby WCC::Contentful::SimpleClient::Cdn.new( # required access_token:
   ''xxxx'', space: ''1234'', # optional environment: ''staging'', # omit to use master
-  default_locale: ''*'', rate_limit_wait_timeout: 10, instrumentation: ActiveSupport::Notifications,
-  connection: Faraday.new { |builder| ... }, ) ```  You can also create a {WCC::Contentful::SimpleClient::Preview}
+  rate_limit_wait_timeout: 10, instrumentation: ActiveSupport::Notifications, connection:
+  Faraday.new { |builder| ... }, ) ```  You can also create a {WCC::Contentful::SimpleClient::Preview}
   to talk to the Preview API, or a {WCC::Contentful::SimpleClient::Management} to
   talk to the Management API.  ### Store Layer  The Store Layer represents the data
   store where Contentful entries are kept for querying.  By default, `WCC::Contentful.init!`