wavefront-cli 4.2.1 → 4.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 36ce95b63a82df8446956332caa6b6765a3eca92d921974a954f640698bcd63d
-  data.tar.gz: 2c1a531e527d4be0e0dae2747aba4f75dce6c3da48012e15516ab9b63f6dc249
+  metadata.gz: 79bb78ee1f6515f3a168acdedfa89680be010f429a33520e23a6caae252fc42f
+  data.tar.gz: 1e86e9eeb5ea1242443b0cf17eb1fea5c5f3a207c6895ab4102a1f705bf1a5a4
 SHA512:
-  metadata.gz: af0e40f1c76fdbe8ade39b6db403a4b58b70ed154bf5ae5a3c810d18ec4ebacc5b84a604a42c56cb8750df3891f335188de6a4f7a65eb2a7be6e85efe4a7794b
-  data.tar.gz: c859fd699041b147fd7fa1b7d30e62d71922420d6460614c137e47be9dfb63cb0350184594ed5c03e6010e1348ed8020d765ca6e0b8cf6bd769d57c1b44bfeef
+  metadata.gz: 01a3a13dbca2192dfb50c375d833ec73115a6c76e31e5fbb0ee42cab3a3f95ea89264e35ebabcb2f34caee642e8e91b74c664d1669d546504cd30f16d364725c
+  data.tar.gz: 1d076d96e1972ceb5d9de355ef1e88e6ea3e68961a911a5a2b691570a337fd8ac3d1cf7fe1d6b4b3c7bacf92ab8741becfb6cbfe4ccb223d363a037d5f219c28

data/.codeclimate.yml

@@ -12,6 +12,7 @@ engines:
     enabled: true
   rubocop:
     enabled: true
+    channel: channel/rubocop-0-74
 ratings:
   paths:
   - "**.rb"

data/.rubocop.yml

@@ -1,20 +1,7 @@
 ---
 
 AllCops:
-  DisplayStyleGuide: true
   TargetRubyVersion: 2.3
 
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
-Style/FormatStringToken:
-  Enabled: false
-
 Metrics/ClassLength:
-  Enabled: false
-
-Metrics/MethodLength:
-  Max: 13
-
-Style/NumericLiterals:
-  Enabled: false
+  Max: 400

data/.travis.yml

@@ -2,9 +2,9 @@ language: ruby
 cache: bundler
 rvm:
   - 2.3.8
-  - 2.4.5
-  - 2.5.5
-  - 2.6.2
+  - 2.4.7
+  - 2.5.6
+  - 2.6.4
 before_install: gem install bundler --no-document
 deploy:
   provider: rubygems
@@ -14,7 +14,7 @@ deploy:
   on:
     tags: true
     repo: snltd/wavefront-cli
-    ruby: 2.6.2
+    ruby: 2.6.4
 notifications:
   email: false
   slack:

data/Gemfile

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 gemspec

data/HISTORY.md

@@ -1,17 +1,40 @@
 # Changelog
 
-## 4.2.1 (26/07/2019)
-* Remove tagging subcommands from `apitoken` command's usage info,
-  because you can't tag API tokens.
-
-## 4.2.0 (01/07/2019)
+## 4.3.0 (2019-09-30)
+* Add `serviceaccount` command.
+* Add `user privileges` command.
+* Refactor of all tests, which exposed the following:
+* Fix noops on `proxy versions`, `window ongoing` and `window
+  pending`.
+* Fix partially broken `source list` command.
+* Make `source search --cursor <source>` work properly.
+* Remove duplicate `manifests` subcommand from `integrations`
+  command.
+* Fix broken noop on `acl clear`.
+* Fix `derivedmetric` and `notificant` `set` commands.
+* Fix various `alert` commands when using `--noop`.
+* Better handling of bad `search` input.
+* Fix bug when trying to read non-existent messages.
+* Fix missing quote in `usergroup delete` output.
+* Fix broken `--all` in usergroup listings and searches.
+* Fix `user dump`.
+* Removed `user set` command, because it didn't do anything.
+* Improve output of `user` and `usergroup` commands.
+* Refactor of `event` command handling.
+* Require 3.5.x of [the SDK](https://github.com/snltd/wavefront-sdk).
+
+## 4.2.1 (2019-07-26)
+* Remove tagging subcommands from `apitoken` command's usage info, because you
+  can't tag API tokens.
+
+## 4.2.0 (2019-07-01)
 * Add `-M` (`--items-only`) option to all commands. For
   machine-parseable formats, this filters the API response, giving only
   the `items` array, which should usually be suitable for batch
   importing. This is a more sophisticated and flexible implementation of
   4.1.0's `dump` subcommand.
 
-## 4.1.0 (27/06/2019)
+## 4.1.0 (2019-06-27)
 * Add `dump` subcommand for all importable object types. Produces
   JSON or YAML output.
 * Allow batch importing of objects. Works with files produced by
@@ -19,21 +42,20 @@
   objects. Batch imports are automatically detected by the `import`
   subcommand.
 
-## 4.0.2 (20/06/2019)
+## 4.0.2 (2019-06-20)
 * Allow importing of dashboards which have a URL but not an ID.
 
-## 4.0.1 (18/06/2019)
+## 4.0.1 (2019-06-18)
 * `update` subcommand has been changed to `set`. (Breaking change.)
 * `import` subcommand now accepts `--update` (`-u`) option, which
   lets you overwrite an existing object with a JSON or YAML
   description.
 * Fix `tag searchpath` bug.
 
-## 4.0.0 (18/06/2019)
-
+## 4.0.0 (2019-06-18)
 * Failed push to Gemfury. Does not exist.
 
-## 3.3.0 (10/06/2019)
+## 3.3.0 (2019-06-10)
 * Support negation searches. Search for alerts with targets *not*
   containing `str` with `wf alert search target!~str`.
 * Add `tag pathsearch` command. Searches for tags whose hierarchical
@@ -45,48 +67,48 @@
   match the search along with the matching keys. (Not values!)
   Adding `-l` presents all matching objects in full.
 
-## 3.2.3 (24/05/2019)
+## 3.2.3 (2019-05-24)
 * Don't print erroneous pagination message when using `list --all`.
 * Require 3.3.2 of [the SDK](https://github.com/snltd/wavefront-sdk).
 
-## 3.2.2 (16/05/2019)
+## 3.2.2 (2019-05-16)
 * Smarter error messages.
 * Require 3.3.1 of [the SDK](https://github.com/snltd/wavefront-sdk).
 
-## 3.2.1 (09/05/2019)
+## 3.2.1 (2019-05-09)
 * Fix for new API ACL format.
 * Require 3.3.0 of [the SDK](https://github.com/snltd/wavefront-sdk).
 
-## 3.2.0 (30/04/2019)
+## 3.2.0 (2019-04-30)
 * New `apitoken` command lets you manage your own API tokens.
 * Support for alert ACLs.
 * Require 3.2.0 of [the SDK](https://github.com/snltd/wavefront-sdk).
 
-## 3.1.4 (02/05/2019)
+## 3.1.4 (2019-05-02)
 * Fix `alert import` missing tags bug.
 * Allow importing of notificants.
 
-## 3.1.3 (24/04/2019)
+## 3.1.3 (2019-04-24)
 * Fix `write distribution` bug. Points would be sent, but results
   could not be displayed, causing a crash unless you used `-q`.
 
-## 3.1.2 (06/04/2019)
+## 3.1.2 (2019-04-06)
 * Bugfix on handling of invalid config files.
 * Explicitly specifying a missing config file now causes an error
   whether or not credentials available from other mechanisms.
 * Require 3.0.2 of [the SDK](https://github.com/snltd/wavefront-sdk).
 
-## 3.1.1 (05/04/2019)
+## 3.1.1 (2019-04-05)
 * Usernames do not have to be e-mail addresses.
 * Require 3.0.1 of [the SDK](https://github.com/snltd/wavefront-sdk).
 
-## 3.1.0 (02/04/2019)
+## 3.1.0 (2019-04-02)
 * Add `message read` command.
 
-## 3.0.1 (23/03/2019)
+## 3.0.1 (2019-03-23)
 * Fix `config about` bug.
 
-## 3.0.0 (23/03/2019)
+## 3.0.0 (2019-03-23)
 * Drop support for Ruby 2.2. (Potentially breaking change.)
 * Remove the (deprecated) `report` command. Send points directly to
   Wavefront with `write --use api`. (Potentially breaking change.)
@@ -106,20 +128,20 @@
 * New `config about` subcommand gives diagnostic info.
 * Require 3.0.0 of [the SDK](https://github.com/snltd/wavefront-sdk).
 
-## 2.18.0 (22/02/2019)
+## 2.18.0 (2019-02-22)
 * Add `usergroup` command, and extend `user` command to cover new
   RBAC features.
 * Require 2.5.0 of [the SDK](https://github.com/snltd/wavefront-sdk).
 
-## 2.17.0 (19/02/2019)
+## 2.17.0 (2019-02-19)
 * Add `-O field,field` to all `list` commands. This lets you select
   the fields displayed in the output.
 
-## 2.16.2 (29/12/2018)
+## 2.16.2 (2018-12-29)
 * Fix typo in `query` help. CSV headers are produced with `-F
   headers`, not `-F header`.
 
-## 2.16.1 (29/12/2018)
+## 2.16.1 (2018-12-29)
 * Fix regression which broke query time ranges.
 * Fix regression which made `--noop` silent unless `--verbose` was
   also specified.
@@ -129,18 +151,18 @@
 * Add much more comprehensive `--noop` tests.
 * Better handling of `--noop` on commands which cannot support it.
 
-## 2.16.0 (23/12/2018)
+## 2.16.0 (2018-12-23)
 * Add `config` command to quickly set up and manage profiles.
 
-## 2.15.2 (21/12/2018)
+## 2.15.2 (2018-12-21)
 * Fix bug which caused an unhandled exception if CSV or Wavefront
   query outputs tried to process an empty data set.
 
-## 2.15.1 (20/12/2018)
+## 2.15.1 (2018-12-20)
 * Fix bug where `alert snoozed` and `alert firing` did the same
   thing.
 
-## 2.15.0 (18/12/2018)
+## 2.15.0 (2018-12-18)
 * Gracefully handle ctrl-c.
 * Add `install` and `uninstall` subcommands to `wf alert`.
 * Add `enable` and `disable` subcommands to `wf cloudintegration`.
@@ -149,12 +171,12 @@
   `manifest` commands to `wf integration`.
 * Require 2.2.0 of [wavefront-sdk](https://github.com/snltd/wavefront-sdk).
 
-## 2.14.0 (15/12/2018)
+## 2.14.0 (2018-12-15)
 * Add `-n` to `dashboard`'s `list` and `queries` commands to omit
   system-owned dashboards.
 * Let `queries` subcommand accept an optional ID.
 
-## 2.13.0 (11/12/2018)
+## 2.13.0 (2018-12-11)
 * Add CSV output for `query` command.
 * Add multiple format outputs for all applicable `alert`
   subcommands.
@@ -162,19 +184,19 @@
   to quickly see which queries (and therefore timeseries) are being
   used.
 
-## 2.12.0 (26/11/2018)
+## 2.12.0 (2018-11-26)
 * Support SDK's new `unix` writer, which lets you write points to a
   local Unix datagram socket. This requires `-u unix` and `-S
   filename`.
 
-## 2.11.0 (24/10/2018)
+## 2.11.0 (2018-10-24)
 * Add `proxy versions` subcommand. Lists proxies and their versions,
   newest to oldest.
 
-## 2.10.1 (22/10/2018)
+## 2.10.1 (2018-10-22)
 * Fix bug seen when listing events with `-s` AND `-L`.
 
-## 2.10.0 (22/10/2018)
+## 2.10.0 (2018-10-22)
 * Most `list` subcommands accept `-a / --all`, and will show all
   objects of the given type, with no pagination. (Exceptions are
   `user`, which never paginated because the API doesn't, and
@@ -205,18 +227,18 @@
 * Use a single connection when streaming data to a proxy from STDIN.
 * Don't list hidden sources unless specifically asked.
 
-## 2.9.3 (03/09/2018)
+## 2.9.3 (2018-09-03)
 * Fix a bug where indefinitely snoozed alerts broke `wf alert
   snoozed`.
 
-## 2.9.2 (22/08/2018)
+## 2.9.2 (2018-08-22)
 * Fix regression which broke the `wf` command when it ran without a
   tty.
 
-## 2.9.1 (22/08/2018)
+## 2.9.1 (2018-08-22)
 * Use 1.6.2 of [wavefront-sdk](https://github.com/snltd/wavefront-sdk).
 
-## 2.9.0 (22/08/2018)
+## 2.9.0 (2018-08-22)
 * Create external links with new `link create` sub-command.
 * Fix bug which stopped you writing points without a `.wavefront`
   configuration file.
@@ -225,7 +247,7 @@
 * Modify external link filters.
 * Use 1.6.1 of [wavefront-sdk](https://github.com/snltd/wavefront-sdk).
 
-## 2.8.0 (08/08/2018)
+## 2.8.0 (2018-08-08)
 * Add `wavefront` format to the `query` command. This outputs the
   result of a raw or timeseries query in a format which can be fed
   back into Wavefront via a proxy.
@@ -233,15 +255,15 @@
 * Restructure the way different output formats are handled in a
   better, more flexible way.
 
-## 2.7.0 (04/07/2018)
+## 2.7.0 (2018-07-04)
 * Add a `-i` option to the `report` command, to send delta metrics.
 * Fix delta metrics on the `write` command.
 
-## 2.6.0 (27/06/2018)
+## 2.6.0 (2018-06-27)
 * Anything which can be imported can be imported from STDIN. The CLI
   will do its best to work out if the format is YAML or JSON.
 
-## 2.5.0 (25/06/2018)
+## 2.5.0 (2018-06-25)
 * Support [derived
   metrics](https://docs.wavefront.com/derived_metrics.html).
 * Remove options which were not actually supported.
@@ -251,7 +273,7 @@
 * Better formatting of `query` output.
 * Remove obsolete code and test files.
 
-## 2.4.0 (10/04/2017)
+## 2.4.0 (2017-04-10)
 * Support direct data ingestion via `report` command.
 * Support writing delta metrics.
 * Add `-q` to silenty write data points.
@@ -260,56 +282,56 @@
   Terraform
   provider](https://github.com/spaceapegames/terraform-provider-wavefront).
 
-## 2.3.1 (24/03/2017)
+## 2.3.1 (2017-03-24)
 * Fix broken handling of negative values in `write` command.
 
-## 2.3.0 (23/02/2017)
+## 2.3.0 (2017-02-23)
 * Add query aliases.
 
-## 2.2.0 (18/02/2017)
+## 2.2.0 (2017-02-18)
 * Add `alert firing` and `alert snoozed` subcommands.
 
-## 2.1.6 (11/01/2017)
+## 2.1.6 (2017-01-11)
 * Correctly handle `=` characters in `update` subcommands.
 
-## 2.1.5 (05/12/2017)
+## 2.1.5 (2017-12-05)
 * Allow the user to tag events when they are created.
 
-## 2.1.4 (15/11/2017)
+## 2.1.4 (2017-11-15)
 * `event create` bugfix.
 
-## 2.1.3 (31/10/2017)
+## 2.1.3 (2017-10-31)
 * Use credential mechanism from SDK instead of rolling our own.
 * Fix bug which ignored supposedly supported environment variables,
   and add support for more.
 * Cut dead wood out of codebase.
 * Eradicate build warnings.
 
-## 2.1.2 (31/10/2017)
+## 2.1.2 (2017-10-31)
 * Fix no-op bug.
 * Add BSD license.
 
-## 2.1.1 (12/10/2017)
+## 2.1.1 (2017-10-12)
 * Fix bug in relative time specifications.
 
-## 2.1.0 (12/10/2017)
+## 2.1.0 (2017-10-12)
 * Allow users to specify relative times, like `-10m`.
 
-## 2.0.0 (09/10/2017)
+## 2.0.0 (2017-10-09)
 * Support viewing and managing of integrations.
 * Support notificants. (AKA alert targets).
 * Support new source descriptions.
 * Breaking change in `source` command.
 
-## 1.0.3 (25/08/2017)
+## 1.0.3 (2017-08-25)
 * Fix nil tag bug in terse source listing.
 
-## 1.0.2 (04/08/2017)
+## 1.0.2 (2017-08-04)
 * Greatly improve support for maintenance windows. They can now be
   extended, shrunk, and closed and created on the fly.
 
-## 1.0.1 (31/07/2017)
+## 1.0.1 (2017-07-31)
 * Report `no data` if a query returns no data.
 
-## 1.0.0 (28/07/2017)
+## 1.0.0 (2017-07-28)
 * First official release.

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yard'
 require 'bundler/gem_tasks'
 require 'rake/testtask'

data/bin/wf

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'pathname'
 require 'io/console'

data/lib/wavefront-cli/alert.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'base'
 require_relative 'command_mixins/tag'
 require_relative 'command_mixins/acl'
@@ -53,7 +55,7 @@ module WavefrontCli
       if wf.respond_to?(state)
         in_state(state)
       else
-        abort format("'%s' is not a valid alert state.", state)
+        abort format("'%<state>s' is not a valid alert state.", state: state)
       end
     end
 
@@ -89,8 +91,12 @@ module WavefrontCli
     def in_state(status)
       options[:all] = true
       ret = find_in_state(status)
-      ok_exit(format('No alerts are currently %s.', status)) if ret.empty?
-      ret
+
+      exit if options[:noop]
+
+      return ret unless ret.is_a?(Wavefront::Response) && ret.empty?
+
+      ok_exit(format('No alerts are currently %<status>s.', status: status))
     end
 
     # Does the work for #in_state
@@ -99,7 +105,9 @@ module WavefrontCli
     # @return Wavefront::Response
     #
     def find_in_state(status)
-      search = do_search([format('status=%s', status)])
+      search = do_search([format('status=%<status>s', status: status)])
+
+      return if options[:noop]
 
       items = search.response.items.map do |i|
         { name: i.name, id: i.id, time: state_time(i) }
@@ -116,6 +124,7 @@ module WavefrontCli
     def state_time(item)
       return item[:event][:startTime] if item.key?(:event)
       return item[:snoozed] if item.key?(:snoozed)
+
       nil
     end
 
@@ -127,7 +136,6 @@ module WavefrontCli
     def import_to_create(raw)
       import_fields.each_with_object({}) { |k, a| a[k.to_sym] = raw[k] }
                    .tap do |ret|
-
         if raw.key?(:resolveAfterMinutes)
           ret[:resolveMinutes] = raw[:resolveAfterMinutes]
         end