watson-ruby 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b11a43edd74df47a900897873268d38b056c10f4
-  data.tar.gz: 95bccd69492466cbf64102bc946d957520781c5b
+  metadata.gz: 010d18c7699c27eecd4b22d22c47561ea9d06165
+  data.tar.gz: 5a74c7c250c89de84952b769a118d62629b614c8
 SHA512:
-  metadata.gz: 3ca841a102298b44102bc684d6e161df044c42233f28d8c7f1a39378a8e0850aa7a926b40d4f125f76ea1525c0897c2cc439f607ab5f2c9f169d14d516170b2a
-  data.tar.gz: e978dac203b6b8f4c9e7bb75011f5cc0ac824efcf9b1a34613b6f90815b6bc40a278129ab154cf260bbd0761a58c5fee895633477bd94b99556186cbfb888d13
+  metadata.gz: 4cd17d98b5f73e7d417900a50f1dcaabbbb5b6b433328237d233540eaed3dacf97a1006cdc9c0bf1aefc5f681f059e176dbfcf701e28e4862df98e8ebb5354d0
+  data.tar.gz: b8ae589570ee13514d4932fb5346eee2f77503e3db64da2ad1e0991fb36f2ba555ad23c92ef7d8ac651d498ea8c63162c26d69b2c8734d07d97b89d614d508b4

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    watson-ruby (1.4.0)
+    watson-ruby (1.4.1)
       json
 
 GEM

data/lib/watson/parser.rb

@@ -212,16 +212,16 @@ module Watson
         _comment_type = '#'
       end
 
+      # [review] - It is possible to embed the valid tags in the regexp,
+      # with a ~5% performance gain, but this would loose the warning about
+      # unrecognized tags.
+      _comment_regex = /^[#{ _comment_type }+?\s+?]+\[(\w+)\]\s+-\s+(.+)/
+
 
       # Open file and read in entire thing into an array
       # Use an array so we can look ahead when creating issues later
-      # [review] - Not sure if explicit file close is required here
       # [review] - Better var name than data for read in file?
-      _data = Array.new()
-      File.open(_absolute_path, 'r').read.each_line do |_line|
-        _data.push(_line)
-        _line.encode('UTF-8', :invalid => :replace)
-      end
+      _data = File.read(_absolute_path).encode('UTF-8', :invalid => :replace).lines
 
       # Initialize issue list hash
       _issue_list = Hash.new()
@@ -241,13 +241,13 @@ module Watson
         # Using if match to stay consistent (with config.rb) see there for
         # explanation of why I do this (not a good good one persay...)
         begin
-          _mtch = _line.match(/^[#{ _comment_type }+?\s+?]+\[(\w+)\]\s+-\s+(.+)/)
+          _mtch = _line.match(_comment_regex)
         rescue ArgumentError
           debug_print "Could not encode to UTF-8, non-text\n"
         end
 
         unless _mtch
-          debug_print "No valid tag found in line, skipping\n"
+          # debug_print "No valid tag found in line, skipping\n"
           next
         end
 

data/lib/watson/version.rb

@@ -1,3 +1,3 @@
 module Watson
-  VERSION = "1.4.0"
+  VERSION = "1.4.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: watson-ruby
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - nhmood