watirsplash 2.4.0 → 2.4.1

data/History.rdoc

@@ -1,9 +1,13 @@
+=== Version 2.4.1 / 2011-10-07
+
+  * JavaScript error checker doesn't raise an error for "undefined"
+  * Page::Base#modify method uses now define_method instead of instance_eval
+
 === Version 2.4.0 / 2011-09-25
 
  * add WatirSplash::Browser.exist? method
  * redirect all method invocations on WatirSplash::Browser.current when method doesn't exist in WatirSplash::Browser class itself
 
-
 === Version 2.3.2 / 2011-09-25
 
  * add support for spork-local_process

data/lib/watirsplash/browser.rb

@@ -6,7 +6,7 @@ module WatirSplash
     JAVASCRIPT_ERRORS_CHECKER = lambda do |browser| 
       error_message = browser.execute_script "#{browser.respond_to?(:driver) ? "return ": nil}window.__browserErrorMessage"
 
-      if error_message && !error_message.empty?
+      if error_message && !error_message.empty? && error_message != "undefined"
         browser.execute_script "window.__browserErrorMessage = undefined"
         raise JavaScriptError, "JavaScript error: #{error_message}"
       end

data/lib/watirsplash/page/base.rb

@@ -28,15 +28,13 @@ module WatirSplash
       def modify element, methodz
         methodz.each_pair do |meth, return_value|
           element.instance_eval do 
-            instance_variable_set("@_#{meth}_return_value_proc", return_value)
-            instance_eval %Q[
-              self.class.send(:alias_method, :__#{meth}, :#{meth}) if respond_to? :#{meth}
+            singleton = class << self; self end
 
-              def #{meth}(*args)
-                self.send(:__#{meth}, *args) if respond_to? :__#{meth}
-                instance_variable_get("@_#{meth}_return_value_proc").call(*args)
-              end
-            ]
+            singleton.send :alias_method, "__#{meth}", meth if respond_to? meth
+            singleton.send :define_method, meth do |*args|
+              self.send("__#{meth}", *args) if respond_to? "__#{meth}"
+              return_value.call(*args)
+            end
           end
         end
         element

data/lib/watirsplash/version.rb

@@ -1,10 +1,10 @@
 module WatirSplash
   module Version
-    WATIRSPLASH = "2.4.0"
+    WATIRSPLASH = "2.4.1"
 
     # possible runtime dependencies
     WATIR = "2.0.2"
     WIN32SCREENSHOT = "~>1.0.5"
-    WATIR_WEBDRIVER = "~>0.3.4"
+    WATIR_WEBDRIVER = "~>0.3.5"
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: watirsplash
 version: !ruby/object:Gem::Version 
-  hash: 31
+  hash: 29
   prerelease: 
   segments: 
   - 2
   - 4
-  - 0
-  version: 2.4.0
+  - 1
+  version: 2.4.1
 platform: ruby
 authors: 
 - Jarmo Pertman
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-09-25 00:00:00 Z
+date: 2011-10-07 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rake
@@ -173,7 +173,7 @@ rubyforge_project:
 rubygems_version: 1.8.4
 signing_key: 
 specification_version: 3
-summary: watirsplash 2.4.0
+summary: watirsplash 2.4.1
 test_files: 
 - spec/browser_spec.rb
 - spec/page_spec.rb