watir-webdriver 0.6.10 → 0.6.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 89a38c59a99607faba5d3d114200e4a61fa1219b
-  data.tar.gz: 2e1564d5123f22ddadb7f9e74246e7dc64b5cfa1
+  metadata.gz: f701ec966d5fba22ef3505c0df91d8db1581b04e
+  data.tar.gz: c5002bc487ed49c06385469e0b531b23ecd6b11b
 SHA512:
-  metadata.gz: b3aa6a03d9ae4412ff5038902c599c07f89050bdc8e7b4baf9270cdcb0e13bb205ed2be7d03de268a5defcaf9fd148f0fc37641d9e862873e3c87a2d9e295ea7
-  data.tar.gz: 17432f8a591e0a2d78a76a53e40d090e1f45f2cb7008f58e0d8fabb569bffed648f31ada6abdf7d0e3f343e304d04fa43d44807b02a2800d0f5e202842510477
+  metadata.gz: ad1194e189f237e24d3ff125332b038ca9361ed427d5dd51c15c61da29c9d7da24cd5a3df8303434d1eeea4f0d622e82a7d8932dd1510966a4763e2878a19047
+  data.tar.gz: 79f65f913cc04a54ed1a5f25a4717bbed04ba1a3529679c9647a40d752491f17cdb96b24254584def0a78b6af1b6ece720e602b5111317fe4fb71ede41540e06

data/CHANGES.md

@@ -1,3 +1,8 @@
+### 0.6.11 (2014-09-23)
+
+* Fix namespacing issue (#265, thanks @titusfortner)
+* Fix handling of elements that go stale during lookup (#271, thanks @titusfortner)
+
 ### 0.6.10 (2014-06-10)
 
 * Changed the way attributes are generated and documented (see #28 and #215)

data/README.md

@@ -2,7 +2,7 @@ watir-webdriver
 ===============
 
 Watir implementation built on WebDriver's Ruby bindings.
-See http://rubyforge.org/pipermail/wtr-development/2009-October/001313.html.
+See https://web.archive.org/web/20140518221755/http://rubyforge.org/pipermail/wtr-development/2009-October/001313.html
 
 [![Gem Version](https://badge.fury.io/rb/watir-webdriver.png)](http://badge.fury.io/rb/watir-webdriver)
 [![Build Status](https://travis-ci.org/watir/watir-webdriver.png?branch=master)](https://travis-ci.org/watir/watir-webdriver)

data/lib/watir-webdriver/elements/button.rb

@@ -49,11 +49,9 @@ module Watir
 
     private
 
-    def locate
-      @parent.assert_exists
-      ButtonLocator.new(@parent.wd, @selector, self.class.attribute_list).locate
+    def locator_class
+      ButtonLocator
     end
-
   end # Button
 
   class ButtonCollection < ElementCollection

data/lib/watir-webdriver/elements/element.rb

@@ -502,10 +502,16 @@ module Watir
         return
       end
 
-      @element = (@selector[:element] || locate)
+      @element = @selector[:element]
 
-      unless @element
-        raise UnknownObjectException, "unable to locate element, using #{selector_string}"
+      if @element
+        assert_not_stale
+      else
+        @element = locate
+
+        unless @element
+          raise UnknownObjectException, "unable to locate element, using #{selector_string}"
+        end
       end
     end
 

data/lib/watir-webdriver/elements/iframe.rb

@@ -139,7 +139,7 @@ module Watir
     def switch!
       @driver.switch_to.frame @element
     rescue Selenium::WebDriver::Error::NoSuchFrameError => e
-      raise UnknownFrameException, e.message
+      raise Exception::UnknownFrameException, e.message
     end
 
   end # FramedDriver

data/lib/watir-webdriver/locators/element_locator.rb

@@ -39,7 +39,7 @@ module Watir
       # It is also used to alter behavior of methods locating more than one type of element
       # (e.g. text_field locates both input and textarea)
       validate_element(element) if element
-    rescue Selenium::WebDriver::Error::NoSuchElementError
+    rescue Selenium::WebDriver::Error::NoSuchElementError, Selenium::WebDriver::Error::ObsoleteElementError
       nil
     end
 

data/lib/watir-webdriver/version.rb

@@ -1,3 +1,3 @@
 module Watir
-  VERSION = "0.6.10"
+  VERSION = "0.6.11"
 end

data/spec/element_spec.rb

@@ -31,9 +31,11 @@ describe Watir::Element do
   end
 
   describe "#exists?" do
-    it "should not propagate ObsoleteElementErrors" do
+    before do
       browser.goto WatirSpec.url_for('removed_element.html', :needs_server => true)
+    end
 
+    it "should not propagate ObsoleteElementErrors" do
       button  = browser.button(:id => "remove-button")
       element = browser.div(:id => "text")
 
@@ -41,6 +43,26 @@ describe Watir::Element do
       button.click
       expect(element).to_not exist
     end
+
+    it "should determine if element constructed with WebDriver element is stale" do
+      button = browser.button(:id => "remove-button")
+      text   = browser.element(:element, browser.div(:id => "text").wd)
+
+      expect(text).to exist
+      button.click
+      expect(text).to_not exist
+    end
+
+    it "should handle element that becomes stale during lookup" do
+      wd_element = browser.div(:id => "text").wd
+
+      # simulate element going stale during lookup
+      allow(browser.driver).to receive(:find_element).with(:id, 'text') { wd_element }
+      browser.refresh
+
+      expect(browser.div(:id, 'text')).to_not exist
+    end
+
   end
 
   describe "#hover" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: watir-webdriver
 version: !ruby/object:Gem::Version
-  version: 0.6.10
+  version: 0.6.11
 platform: ruby
 authors:
 - Jari Bakken
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-10 00:00:00.000000000 Z
+date: 2014-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver