waterpig 0.9.2 → 0.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5ba1801656f48cbb9745fda0ca698f00774e4559
-  data.tar.gz: 7cbb8eb199b0a1e82e78b644d197e64974b2011d
+  metadata.gz: 3a9c11834b4217885829979fea038543cd198083
+  data.tar.gz: eef4f7e90c5db5a7e14539f463b33054522b955a
 SHA512:
-  metadata.gz: eb0977b22a40cc474c5758fa5f2d4f4bd0841cf5a7ad30f35c7773247937b907d0de010da789c2b07d527b51168b687ae71057809880ac849b9305417c9ca858
-  data.tar.gz: 36eaf853983c69b02deaee21a19220e9cf29f30254a355b7a06a5262897d1a6ec98a5d7923b2ab0556d33cee3846b9f0d6ce2405dc3826280b7f3d3d6dd3d3ff
+  metadata.gz: e34939aa6c2b4764947689c71305af995f344352db8034e0b9f646ddd7d53682bacfa073fe55dff0c8679c820f609579d269cdef11330885a1cdb5587454c18e
+  data.tar.gz: 2706da25526fb916a4da589761954d58a39243fbac818583b65971e0a4cefd75e17a81d5ea776ca3af64fdf778e79ef8eeb47e9545bb94bd6a95018920354276

data/lib/waterpig/at_exit_duck_punch.rb

@@ -0,0 +1,33 @@
+# This file is present to use in difficult RSpec cases.
+#
+# Essentially, an at_exit block will fail for some reason. The symptom is that
+# RSpec doesn't exit, or exits with the wrong status code. To determine where
+# the issue might be, run
+#
+# rspec -r waterpig/at_exit_duck_punch spec
+#
+# which will then report all the at_exit blocks as they're declared and when
+# they're run
+module Kernel
+  alias original_at_exit at_exit
+
+  def at_exit(&block)
+    installing_pid = Process.pid
+    install_point = caller[0]
+    $stderr.puts "at_exit installed at #{install_point}"
+
+    original_at_exit do
+      $stderr.puts "START: at_exit block by pid: #{installing_pid} run in #{Process.pid} from #{install_point}"
+      if $!
+        $stderr.puts "current $!: #{$!.inspect}"
+      end
+
+      block.call
+
+      $stderr.puts "FINISH: at_exit block from #{install_point}"
+      if $!
+        $stderr.puts "current $!: #{$!.inspect}"
+      end
+    end
+  end
+end

data/lib/waterpig/browser-size.rb

@@ -7,8 +7,29 @@ module Waterpig
       end
     end
 
+    #empirically determined - there's an issue on Chrome somewhere, but I can't
+    #find it at the moment. The upshot is: if you resize Chrome on Linux below
+    #this width, the content area collapses to 0 height. Tests pass anyway, is
+    #the worst part.
+    MIN_WIDTH = 348
+
+    @@warned_about_size = false
+
     def self.resize_browser_window(size)
-      Capybara.current_session.driver.browser.manage.window.resize_to(size[:width], size[:height])
+      driver = Capybara.current_session.driver
+      window = driver.current_window_handle
+      width = size.fetch(:width)
+      if width < MIN_WIDTH
+        unless @@warned_about_size
+          warn "Requested browser size #{size.inspect} - but minimum width is #{MIN_WIDTH}. Adjusting."
+          warn "You might consider setting up mobile browser emulation. (details forthcoming)"
+          @@warned_about_size = true
+        end
+        width = MIN_WIDTH
+      end
+
+      req_size = [width, size.fetch(:height)]
+      driver.resize_window_to(window, *req_size)
     end
 
     def self.current_size(example)

data/spec/embarrassing.rb

@@ -3,6 +3,7 @@ Sequel.sqlite
 
 require 'waterpig'
 require 'waterpig/deadbeat-connections'
+require 'waterpig/at_exit_duck_punch'
 module ActiveRecord
   class Base
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: waterpig
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.9.3
 platform: ruby
 authors:
 - Judson Lester
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-13 00:00:00.000000000 Z
+date: 2015-07-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -92,6 +92,7 @@ files:
 - lib/waterpig/snap-step.rb
 - lib/waterpig/browser-tools.rb
 - lib/waterpig/browser-size.rb
+- lib/waterpig/at_exit_duck_punch.rb
 - spec/embarrassing.rb
 - spec_help/spec_helper.rb
 - spec_help/gem_test_suite.rb
@@ -105,7 +106,7 @@ rdoc_options:
 - --main
 - doc/README
 - --title
-- waterpig-0.9.2 Documentation
+- waterpig-0.9.3 Documentation
 require_paths:
 - lib/
 required_ruby_version: !ruby/object:Gem::Requirement