waterdrop 2.8.0 → 2.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 96435533f730edae9dcf7bed5426641a33715e87b55c804168fa6a02465f1431
-  data.tar.gz: 3737e88ec3ffaa407b1cdaa523cf1d24a25aa85c4d90989a249381dbfb7a80c2
+  metadata.gz: 7d2fa38e1362c3069581533bd8da5ee508f00b9fea08c9a4c56ae16780c38c68
+  data.tar.gz: 0c861f372aeae735d0033b35bc9224e45025c03b2084d796108660b976e74eb3
 SHA512:
-  metadata.gz: 1b83e8505ca1aa9be5c137c06af1b98e10bb8f39af93e77aefa42302bf8dc2bd95f1442eb2569d5f032e80ac0374b8013e774d1f36494d23e20af0766094e2b3
-  data.tar.gz: 198ea59a4f7ca6a63f9816e7026c97152aaed5e6154142c47e6e96c16696a2a3d4c60cd56bf72b407b092682e9d15c08f1adfa552eb5bdc17a308f77f7424dfc
+  metadata.gz: 80ae3a51e3aeaa19e875eddfefb16e415b61f7ef44861d97043b060604fc9ea06d774b9e308f198d89eb813fa405f7f650e0516c8ce5688933ffce5b1b6533d8
+  data.tar.gz: 2da33c249c8f4e761876a18d7d95745490ed05d296a736fdf39a4ec0b84ba84f3239b8528cb91e6e08cdfe729acabda530cb464a5f8eba779373d113b5b3be94

data/.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,43 @@
+---
+name: Bug Report
+about: Report an issue within the Karafka ecosystem you've discovered.
+---
+
+To make this process smoother for everyone involved, please read the following information before filling out the template.
+
+Scope of the OSS Support
+===========
+
+We do not provide OSS support for outdated versions of Karafka and its components.
+
+Please ensure that you are using a version that is still actively supported. We cannot assist with any no longer maintained versions unless you support us with our Pro offering (https://karafka.io/docs/Pro-Support/).
+
+We acknowledge that understanding the specifics of your application and its configuration can be essential for resolving certain issues. However, due to the extensive time and resources such analysis can require, this may fall beyond our Open Source Support scope.
+
+If Karafka or its components are critical to your infrastructure, we encourage you to consider our Pro Offering.
+
+By backing us up, you can gain direct assistance and ensure your use case receives the dedicated attention it deserves.
+
+
+Important Links to Read
+===========
+
+Please take a moment to review the following resources before submitting your report:
+
+- Issue Reporting Guide: https://karafka.io/docs/Support/#issue-reporting-guide
+- Support Policy: https://karafka.io/docs/Support/
+- Versions, Lifecycle, and EOL: https://karafka.io/docs/Versions-Lifecycle-and-EOL/
+
+
+Bug Report Details
+===========
+
+Please provide all the details per our Issue Reporting Guide: https://karafka.io/docs/Support/#issue-reporting-guide
+
+Failing to provide the required details may result in the issue being closed. Please include all necessary information to help us understand and resolve your issue effectively.
+
+
+Additional Context
+===========
+
+Add any other context about the problem here.

data/.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,20 @@
+---
+name: Feature Request
+about: Suggest new WaterDrop features or improvements to existing features.
+---
+
+## Is your feature request related to a problem? Please describe.
+
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+## Describe the solution you'd like
+
+A clear and concise description of what you want to happen.
+
+## Describe alternatives you've considered
+
+A clear and concise description of any alternative solutions or features you've considered.
+
+## Additional context
+
+Add any other context or screenshots about the feature request here.

data/.github/workflows/ci.yml

@@ -18,12 +18,12 @@ jobs:
       fail-fast: false
       matrix:
         ruby:
-          - '3.4.0-preview1'
+          - '3.4'
           - '3.3'
           - '3.2'
           - '3.1'
         include:
-          - ruby: '3.3'
+          - ruby: '3.4'
             coverage: 'true'
     steps:
       - uses: actions/checkout@v4
@@ -74,7 +74,7 @@ jobs:
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 3.3
+          ruby-version: 3.4
       - name: Install latest bundler
         run: gem install bundler --no-document
       - name: Install Diffend plugin

data/.ruby-version

@@ -1 +1 @@
-3.3.5
+3.4.1

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # WaterDrop changelog
 
+## 2.8.1 (2024-12-26)
+- [Enhancement] Raise `WaterDrop::ProducerNotTransactionalError` when attempting to use transactions on a non-transactional producer.
+- [Fix] Disallow closing a producer from within a transaction.
+- [Fix] WaterDrop should prevent opening a transaction using a closed producer.
+
 ## 2.8.0 (2024-09-16)
 
 This release contains **BREAKING** changes. Make sure to read and apply upgrade notes.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    waterdrop (2.8.0)
+    waterdrop (2.8.1)
       karafka-core (>= 2.4.3, < 3.0.0)
       karafka-rdkafka (>= 0.17.5)
       zeitwerk (~> 2.3)
@@ -42,7 +42,7 @@ GEM
     logger (1.6.1)
     mini_portile2 (2.8.7)
     minitest (5.25.1)
-    ostruct (0.6.0)
+    ostruct (0.6.1)
     rake (13.2.1)
     rspec (3.13.0)
       rspec-core (~> 3.13.0)

data/docker-compose.yml

@@ -1,9 +1,7 @@
-version: '2'
-
 services:
   kafka:
     container_name: kafka
-    image: confluentinc/cp-kafka:7.7.1
+    image: confluentinc/cp-kafka:7.8.0
 
     ports:
       - 9092:9092

data/lib/waterdrop/errors.rb

@@ -25,12 +25,18 @@ module WaterDrop
     # Raised when there was an attempt to use a closed producer
     ProducerClosedError = Class.new(BaseError)
 
+    # Raised if you attempt to close the producer from within a transaction. This is not allowed.
+    ProducerTransactionalCloseAttemptError = Class.new(BaseError)
+
     # Raised when we want to send a message that is invalid (impossible topic, etc)
     MessageInvalidError = Class.new(BaseError)
 
     # Raised when we want to commit transactional offset and the input is invalid
     TransactionalOffsetInvalidError = Class.new(BaseError)
 
+    # Raised when transaction attempt happens on a non-transactional producer
+    ProducerNotTransactionalError = Class.new(BaseError)
+
     # Raised when we've got an unexpected status. This should never happen. If it does, please
     # contact us as it is an error.
     StatusInvalidError = Class.new(BaseError)

data/lib/waterdrop/producer/transactions.rb

@@ -55,11 +55,20 @@ module WaterDrop
       #
       #   handler.wait
       def transaction
+        unless transactional?
+          raise(
+            Errors::ProducerNotTransactionalError,
+            "#{id} is not transactional"
+          )
+        end
+
         # This will safely allow us to support one operation transactions so a transactional
         # producer can work without the transactional block if needed
         return yield if @transaction_mutex.owned?
 
         @transaction_mutex.synchronize do
+          ensure_active!
+
           transactional_instrument(:finished) do
             with_transactional_error_handling(:begin) do
               transactional_instrument(:started) { client.begin_transaction }

data/lib/waterdrop/producer.rb

@@ -85,6 +85,7 @@ module WaterDrop
 
       # Don't allow to obtain a client reference for a producer that was not configured
       raise Errors::ProducerNotConfiguredError, id if @status.initial?
+      raise Errors::ProducerClosedError, id if @status.closed?
 
       @connecting_mutex.synchronize do
         return @client if @client && @pid == Process.pid
@@ -180,65 +181,75 @@ module WaterDrop
     # @param force [Boolean] should we force closing even with outstanding messages after the
     #   max wait timeout
     def close(force: false)
-      @operating_mutex.synchronize do
-        return unless @status.active?
-
-        @monitor.instrument(
-          'producer.closed',
-          producer_id: id
-        ) do
-          @status.closing!
-          @monitor.instrument('producer.closing', producer_id: id)
-
-          # No need for auto-gc if everything got closed by us
-          # This should be used only in case a producer was not closed properly and forgotten
-          ObjectSpace.undefine_finalizer(id)
-
-          # We save this thread id because we need to bypass the activity verification on the
-          # producer for final flush of buffers.
-          @closing_thread_id = Thread.current.object_id
-
-          # Wait until all the outgoing operations are done. Only when no one is using the
-          # underlying client running operations we can close
-          sleep(0.001) until @operations_in_progress.value.zero?
-
-          # Flush has its own buffer mutex but even if it is blocked, flushing can still happen
-          # as we close the client after the flushing (even if blocked by the mutex)
-          flush(true)
-
-          # We should not close the client in several threads the same time
-          # It is safe to run it several times but not exactly the same moment
-          # We also mark it as closed only if it was connected, if not, it would trigger a new
-          # connection that anyhow would be immediately closed
-          if @client
-            # Why do we trigger it early instead of just having `#close` do it?
-            # The linger.ms time will be ignored for the duration of the call,
-            # queued messages will be sent to the broker as soon as possible.
-            begin
-              @client.flush(current_variant.max_wait_timeout) unless @client.closed?
-            # We can safely ignore timeouts here because any left outstanding requests
-            # will anyhow force wait on close if not forced.
-            # If forced, we will purge the queue and just close
-            rescue ::Rdkafka::RdkafkaError, Rdkafka::AbstractHandle::WaitTimeoutError
-              nil
-            ensure
-              # Purge fully the local queue in case of a forceful shutdown just to be sure, that
-              # there are no dangling messages. In case flush was successful, there should be
-              # none but we do it just in case it timed out
-              purge if force
-            end
+      # If we already own the transactional mutex, it means we are inside of a transaction and
+      # it should not we allowed to close the producer in such a case.
+      if @transaction_mutex.locked? && @transaction_mutex.owned?
+        raise Errors::ProducerTransactionalCloseAttemptError, id
+      end
 
-            @client.close
+      # The transactional mutex here can be used even when no transactions are in use
+      # It prevents us from closing a mutex during transactions and is irrelevant in other cases
+      @transaction_mutex.synchronize do
+        @operating_mutex.synchronize do
+          return unless @status.active?
 
-            @client = nil
-          end
+          @monitor.instrument(
+            'producer.closed',
+            producer_id: id
+          ) do
+            @status.closing!
+            @monitor.instrument('producer.closing', producer_id: id)
+
+            # No need for auto-gc if everything got closed by us
+            # This should be used only in case a producer was not closed properly and forgotten
+            ObjectSpace.undefine_finalizer(id)
+
+            # We save this thread id because we need to bypass the activity verification on the
+            # producer for final flush of buffers.
+            @closing_thread_id = Thread.current.object_id
+
+            # Wait until all the outgoing operations are done. Only when no one is using the
+            # underlying client running operations we can close
+            sleep(0.001) until @operations_in_progress.value.zero?
+
+            # Flush has its own buffer mutex but even if it is blocked, flushing can still happen
+            # as we close the client after the flushing (even if blocked by the mutex)
+            flush(true)
+
+            # We should not close the client in several threads the same time
+            # It is safe to run it several times but not exactly the same moment
+            # We also mark it as closed only if it was connected, if not, it would trigger a new
+            # connection that anyhow would be immediately closed
+            if @client
+              # Why do we trigger it early instead of just having `#close` do it?
+              # The linger.ms time will be ignored for the duration of the call,
+              # queued messages will be sent to the broker as soon as possible.
+              begin
+                @client.flush(current_variant.max_wait_timeout) unless @client.closed?
+              # We can safely ignore timeouts here because any left outstanding requests
+              # will anyhow force wait on close if not forced.
+              # If forced, we will purge the queue and just close
+              rescue ::Rdkafka::RdkafkaError, Rdkafka::AbstractHandle::WaitTimeoutError
+                nil
+              ensure
+                # Purge fully the local queue in case of a forceful shutdown just to be sure, that
+                # there are no dangling messages. In case flush was successful, there should be
+                # none but we do it just in case it timed out
+                purge if force
+              end
+
+              @client.close
+
+              @client = nil
+            end
 
-          # Remove callbacks runners that were registered
-          ::Karafka::Core::Instrumentation.statistics_callbacks.delete(@id)
-          ::Karafka::Core::Instrumentation.error_callbacks.delete(@id)
-          ::Karafka::Core::Instrumentation.oauthbearer_token_refresh_callbacks.delete(@id)
+            # Remove callbacks runners that were registered
+            ::Karafka::Core::Instrumentation.statistics_callbacks.delete(@id)
+            ::Karafka::Core::Instrumentation.error_callbacks.delete(@id)
+            ::Karafka::Core::Instrumentation.oauthbearer_token_refresh_callbacks.delete(@id)
 
-          @status.closed!
+            @status.closed!
+          end
         end
       end
     end

data/lib/waterdrop/version.rb

@@ -3,5 +3,5 @@
 # WaterDrop library
 module WaterDrop
   # Current WaterDrop version
-  VERSION = '2.8.0'
+  VERSION = '2.8.1'
 end

metadata

@@ -1,11 +1,10 @@
 --- !ruby/object:Gem::Specification
 name: waterdrop
 version: !ruby/object:Gem::Version
-  version: 2.8.0
+  version: 2.8.1
 platform: ruby
 authors:
 - Maciej Mensfeld
-autorequire: 
 bindir: bin
 cert_chain:
 - |
@@ -35,7 +34,7 @@ cert_chain:
   i9zWxov0mr44TWegTVeypcWGd/0nxu1+QHVNHJrpqlPBRvwQsUm7fwmRInGpcaB8
   ap8wNYvryYzrzvzUxIVFBVM5PacgkFqRmolCa8I7tdKQN+R1
   -----END CERTIFICATE-----
-date: 2024-09-16 00:00:00.000000000 Z
+date: 2024-12-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: karafka-core
@@ -95,6 +94,8 @@ files:
 - ".coditsu/ci.yml"
 - ".diffend.yml"
 - ".github/FUNDING.yml"
+- ".github/ISSUE_TEMPLATE/bug_report.md"
+- ".github/ISSUE_TEMPLATE/feature_request.md"
 - ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
@@ -154,7 +155,6 @@ metadata:
   source_code_uri: https://github.com/karafka/waterdrop
   documentation_uri: https://karafka.io/docs/#waterdrop
   rubygems_mfa_required: 'true'
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -169,8 +169,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.16
-signing_key: 
+rubygems_version: 3.6.2
 specification_version: 4
 summary: Kafka messaging made easy!
 test_files: []