waterdrop 0.3.2.3 → 0.3.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2239b15837b73734eb25eece381156ee30de0829
-  data.tar.gz: a5bd3c2d2d17b53ed907b91bb2cf2ea71a5a390f
+  metadata.gz: b8146a30bc7d849c7e9bd8d5ab6a3e65697467a4
+  data.tar.gz: b6b606e0194c98093293fd42fb891d821a2937a7
 SHA512:
-  metadata.gz: d3ee394cb790de25cdfa9a4705ed34f9d1d07610f251504674eaf40a446f7919acf4c878d1a3b13a6ca448227781bcdb1044f2add959bc7d913cb09ad180cc06
-  data.tar.gz: c32e727f2ef67fa515fe67fde2f023d2ded5edef0a4e59532fcb5552c8a27a0d10dec4dc5eef14a159e162954fbde5e7b6d87161a5b645bd7ccd38b53e4b6b9e
+  metadata.gz: 5e49033efc2f820a6c61591f475f9ff2c9782b8867a10b95ff31d4a375f0979913aa96315ac93ade25befbad558309ebc95c1015de98b21933c19b7b745a8c7c
+  data.tar.gz: 54a112efc2652be8e0315b183f7fb3e7c16322d3cd67ef145d3f49c6ba172baf9cffdd374b2651bfe07c9500b150cb5d78d6c6ae4da73e31368121dd58d8faa6

data/.rspec

@@ -1 +1,4 @@
+--color
+--format documentation
 --require spec_helper
+--tty

data/.travis.yml

@@ -1,6 +1,5 @@
 language: ruby
 rvm:
-  - 2.2.3
   - 2.3.0
   - 2.3.1
   - 2.3.2

data/CHANGELOG.md

@@ -7,6 +7,8 @@
 - Gem dump x2
 - Dry configurable config (#20)
 - added .rspec for default spec helper require
+- Added SSL capabilities
+- Coditsu instead of PG dev tools for quality control
 
 ## 0.3.1
 - Dev tools update

data/Gemfile

@@ -1,7 +1,4 @@
-source 'https://rubygems.org'
+# frozen_string_literal: true
 
+source 'https://rubygems.org'
 gemspec
-
-group :development, :test do
-  gem 'polishgeeks-dev-tools'
-end

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    waterdrop (0.3.2.3)
+    waterdrop (0.3.2.4)
       bundler
       connection_pool
       dry-configurable (~> 0.6)
@@ -12,158 +12,41 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (5.0.1)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (~> 0.7)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-    addressable (2.4.0)
-    ast (2.3.0)
-    axiom-types (0.1.1)
-      descendants_tracker (~> 0.0.4)
-      ice_nine (~> 0.11.0)
-      thread_safe (~> 0.3, >= 0.3.1)
-    brakeman (3.3.3)
-    bundler-audit (0.5.0)
-      bundler (~> 1.2)
-      thor (~> 0.18)
-    codeclimate-engine-rb (0.3.1)
-      virtus (~> 1.0)
-    coderay (1.1.1)
-    coercible (1.0.0)
-      descendants_tracker (~> 0.0.1)
-    colorize (0.8.1)
-    concurrent-ruby (1.0.4)
+    concurrent-ruby (1.0.5)
     connection_pool (2.2.1)
-    descendants_tracker (0.0.4)
-      thread_safe (~> 0.3, >= 0.3.1)
-    diff-lcs (1.2.5)
+    diff-lcs (1.3)
     docile (1.1.5)
-    dry-configurable (0.6.2)
+    dry-configurable (0.7.0)
       concurrent-ruby (~> 1.0)
-    equalizer (0.0.11)
-    erubis (2.7.0)
-    faker (1.6.6)
-      i18n (~> 0.5)
-    flay (2.8.0)
-      erubis (~> 2.7.0)
-      path_expander (~> 1.0)
-      ruby_parser (~> 3.0)
-      sexp_processor (~> 4.0)
-    flog (4.4.0)
-      path_expander (~> 1.0)
-      ruby_parser (~> 3.1, > 3.1.0)
-      sexp_processor (~> 4.4)
-    haml (4.0.7)
-      tilt
-    haml_lint (0.18.1)
-      haml (~> 4.0)
-      rake (>= 10, < 12)
-      rubocop (>= 0.36.0)
-      sysexits (~> 1.1)
-    i18n (0.7.0)
-    ice_nine (0.11.2)
-    json (2.0.2)
-    launchy (2.4.3)
-      addressable (~> 2.3)
-    method_source (0.8.2)
-    minitest (5.10.1)
-    null-logger (0.1.3)
-    parser (2.3.1.2)
-      ast (~> 2.2)
-    path_expander (1.0.0)
-    polishgeeks-dev-tools (1.3.2)
-      brakeman
-      bundler-audit
-      faker
-      haml_lint
-      pry
-      rspec
-      rubocop
-      rubocop-rspec
-      rubycritic
-      shoulda
-      simplecov
-      timecop
-      yard
-    powerpack (0.1.1)
-    pry (0.10.4)
-      coderay (~> 1.1.0)
-      method_source (~> 0.8.1)
-      slop (~> 3.4)
-    rainbow (2.1.0)
-    rake (11.3.0)
-    reek (4.1.0)
-      codeclimate-engine-rb (~> 0.3.1)
-      parser (~> 2.3.1, >= 2.3.1.2)
-      rainbow (~> 2.0)
-    rspec (3.5.0)
-      rspec-core (~> 3.5.0)
-      rspec-expectations (~> 3.5.0)
-      rspec-mocks (~> 3.5.0)
-    rspec-core (3.5.1)
-      rspec-support (~> 3.5.0)
-    rspec-expectations (3.5.0)
+    json (2.1.0)
+    null-logger (0.1.4)
+    rake (12.0.0)
+    rspec (3.6.0)
+      rspec-core (~> 3.6.0)
+      rspec-expectations (~> 3.6.0)
+      rspec-mocks (~> 3.6.0)
+    rspec-core (3.6.0)
+      rspec-support (~> 3.6.0)
+    rspec-expectations (3.6.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-mocks (3.5.0)
+      rspec-support (~> 3.6.0)
+    rspec-mocks (3.6.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-support (3.5.0)
-    rubocop (0.42.0)
-      parser (>= 2.3.1.1, < 3.0)
-      powerpack (~> 0.1)
-      rainbow (>= 1.99.1, < 3.0)
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.0, >= 1.0.1)
-    rubocop-rspec (1.5.1)
-      rubocop (>= 0.41.2)
-    ruby-kafka (0.3.16)
-    ruby-progressbar (1.8.1)
-    ruby_parser (3.8.2)
-      sexp_processor (~> 4.1)
-    rubycritic (2.9.2)
-      colorize
-      flay (= 2.8.0)
-      flog (= 4.4.0)
-      launchy (= 2.4.3)
-      parser (= 2.3.1.2)
-      reek (= 4.1.0)
-      ruby_parser (~> 3.8)
-      virtus (~> 1.0)
-    sexp_processor (4.7.0)
-    shoulda (3.5.0)
-      shoulda-context (~> 1.0, >= 1.0.1)
-      shoulda-matchers (>= 1.4.1, < 3.0)
-    shoulda-context (1.2.1)
-    shoulda-matchers (2.8.0)
-      activesupport (>= 3.0.0)
-    simplecov (0.12.0)
+      rspec-support (~> 3.6.0)
+    rspec-support (3.6.0)
+    ruby-kafka (0.3.17)
+    simplecov (0.14.1)
       docile (~> 1.1.0)
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.0)
-    slop (3.6.0)
-    sysexits (1.2.0)
-    thor (0.19.1)
-    thread_safe (0.3.5)
-    tilt (2.0.5)
-    timecop (0.8.1)
-    tzinfo (1.2.2)
-      thread_safe (~> 0.1)
-    unicode-display_width (1.1.0)
-    virtus (1.0.5)
-      axiom-types (~> 0.1)
-      coercible (~> 1.0)
-      descendants_tracker (~> 0.0, >= 0.0.3)
-      equalizer (~> 0.0, >= 0.0.9)
-    yard (0.9.5)
+    simplecov-html (0.10.1)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  polishgeeks-dev-tools
+  rspec (~> 3.6.0)
+  simplecov (~> 0.14.1)
   waterdrop!
 
 BUNDLED WITH

data/README.md

@@ -29,13 +29,16 @@ bundle install
 
 WaterDrop has following configuration options:
 
-| Option                  | Value type    | Description                      |
-|-------------------------|---------------|----------------------------------|
-| send_messages           | Boolean       | Should we send messages to Kafka |
-| kafka.hosts             | Array<String> | Kafka servers hosts with ports   |
-| connection_pool_size    | Integer       | Kafka connection pool size       |
-| connection_pool_timeout | Integer       | Kafka connection pool timeout    |
-| raise_on_failure        | Boolean       | Should we raise an exception when we cannot send message to Kafka - if false will silently ignore failures (will just ignore them) |
+| Option                    | Required   | Value type    | Description                      |
+|---------------------------|------------|---------------|----------------------------------|
+| send_messages             | true       | Boolean       | Should we send messages to Kafka |
+| kafka.hosts               | true       | Array<String> | Kafka servers hosts with ports   |
+| connection_pool_size      | true       | Integer       | Kafka connection pool size       |
+| connection_pool_timeout   | true       | Integer       | Kafka connection pool timeout    |
+| raise_on_failure          | true       | Boolean       | Should we raise an exception when we cannot send message to Kafka - if false will silently ignore failures (will just ignore them) |
+| kafka.ssl.ca_cert         | false      | String        | SSL CA certificate               |
+| kafka.ssl.client_cert     | false      | String        | SSL client certificate           |
+| kafka.ssl.client_cert_key | false      | String        | SSL client certificate password  |
 
 To apply this configuration, you need to use a *setup* method:
 
@@ -99,7 +102,11 @@ Make your feature addition or bug fix.
 Add tests for it. This is important so I don't break it in a future version unintentionally.
 Commit, do not mess with Rakefile, version, or history. (if you want to have your own version, that is fine but bump version in a commit by itself I can ignore when I pull). Send me a pull request. Bonus points for topic branches.
 
-Each pull request must pass our quality requirements. To check if everything is as it should be, we use [PolishGeeks Dev Tools](https://github.com/polishgeeks/polishgeeks-dev-tools) that combine multiple linters and code analyzers. Please run:
+[![coditsu](https://coditsu.io/assets/quality_bar.svg)](https://coditsu.io)
+
+Each pull request must pass our quality requirements. To check if everything is as it should be, we use [Coditsu](https://coditsu.io) that combinse multiple linters and code analyzers. Unfortunately, for now it is invite-only based, so just ping us and we will give you access to the quality results.
+
+Please run:
 
 ```bash
 bundle exec rake

data/Rakefile

@@ -1,17 +1,7 @@
+# frozen_string_literal: true
 require 'bundler'
 require 'rake'
-require 'polishgeeks-dev-tools'
+require 'rspec/core/rake_task'
 
-PolishGeeks::DevTools.setup do |config|
-  config.brakeman = false
-  config.haml_lint = false
-end
-
-desc 'Self check using polishgeeks-dev-tools'
-task :check do
-  PolishGeeks::DevTools::Runner.new.execute(
-    PolishGeeks::DevTools::Logger.new
-  )
-end
-
-task default: :check
+RSpec::Core::RakeTask.new(:spec)
+task default: :spec

data/lib/water_drop/config.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module WaterDrop
   # Configurator for setting up all options required by WaterDrop
   class Config
@@ -17,6 +19,15 @@ module WaterDrop
     setting :kafka do
       # @option hosts [Array<String>] Array that contains Kafka hosts with ports
       setting :hosts
+      # SSL authentication related settings
+      setting :ssl do
+        # option ca_cert [String] SSL CA certificate
+        setting :ca_cert, nil
+        # option client_cert [String] SSL client certificate
+        setting :client_cert, nil
+        # option client_cert_key [String] SSL client certificate password
+        setting :client_cert_key, nil
+      end
     end
 
     class << self

data/lib/water_drop/message.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module WaterDrop
   # Message class which encapsulate single Kafka message logic and its delivery
   class Message
@@ -6,7 +8,7 @@ module WaterDrop
     # @param topic [String, Symbol] a topic to which we want to send a message
     # @param message [Object] any object that can be serialized to a JSON string or
     #   that can be casted to a string
-    # @param options [Hash] (optional) additonal options to pass to the Kafka producer
+    # @param options [Hash] (optional) additional options to pass to the Kafka producer
     # @return [WaterDrop::Message] WaterDrop message instance
     # @example Creating a new message
     #   WaterDrop::Message.new(topic, message)

data/lib/water_drop/pool.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module WaterDrop
   # Raw Kafka producers connection pool for WaterDrop messages delivery
   module Pool

data/lib/water_drop/producer_proxy.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module WaterDrop
   # Proxy object for a producer (sender) objects that are inside pool
   # We use it to provide additional timeout monitoring layer
   # There used to be an issue with Poseidon (previous engine for this lib)
   # usage of sockets that are old and not used - that's why we just
   # reinitialize connection if the connection layer is not being used for too long
-  # We keep this logic to avoid problems just in case. If those problems won't occure
+  # We keep this logic to avoid problems just in case. If those problems won't occur
   # with Ruby-Kafka, we will drop it
   class ProducerProxy
     # How long should be object considered alive if nothing is being
@@ -54,7 +56,12 @@ module WaterDrop
     # @return [Kafka::Producer] producer instance to which we can forward method requests
     def producer
       reload! if dead?
-      @producer ||= Kafka.new(seed_brokers: ::WaterDrop.config.kafka.hosts).producer
+      @producer ||= Kafka.new(
+        seed_brokers: ::WaterDrop.config.kafka.hosts,
+        ssl_ca_cert: ::WaterDrop.config.kafka.ssl.ca_cert,
+        ssl_client_cert: ::WaterDrop.config.kafka.ssl.client_cert,
+        ssl_client_cert_key: ::WaterDrop.config.kafka.ssl.client_cert_key
+      ).producer
     end
 
     # @return [Boolean] true if we cannot use producer anymore because it was not used for a
@@ -65,7 +72,7 @@ module WaterDrop
 
     # Resets a producer so a new one will be created once requested
     def reload!
-      @producer.shutdown if @producer
+      @producer&.shutdown
       @producer = nil
     end
   end

data/lib/water_drop/version.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
+
 # WaterDrop library
 module WaterDrop
   # Current WaterDrop version
-  VERSION = '0.3.2.3'
+  VERSION = '0.3.2.4'
 end

data/lib/water_drop.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 # External components
-%w(
+%w[
   rake
   rubygems
   bundler
@@ -11,18 +13,18 @@
   connection_pool
   null_logger
   dry-configurable
-).each { |lib| require lib }
+].each { |lib| require lib }
 
 # Internal components
 base_path = File.dirname(__FILE__) + '/water_drop'
 
-%w(
+%w[
   version
   producer_proxy
   pool
   config
   message
-).each { |lib| require "#{base_path}/#{lib}" }
+].each { |lib| require "#{base_path}/#{lib}" }
 
 # WaterDrop library
 module WaterDrop

data/lib/waterdrop.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 # This file is used as a compatibility step
 require 'water_drop'

data/waterdrop.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
@@ -8,9 +10,9 @@ Gem::Specification.new do |spec|
   spec.version       = ::WaterDrop::VERSION
   spec.platform      = Gem::Platform::RUBY
   spec.authors       = ['Maciej Mensfeld', 'Pavlo Vavruk']
-  spec.email         = %w( maciej@mensfeld.pl pavlo.vavruk@gmail.com )
+  spec.email         = %w[maciej@mensfeld.pl pavlo.vavruk@gmail.com]
   spec.homepage      = 'https://github.com/karafka/waterdrop'
-  spec.summary       = %q{ Kafka messaging made easy! }
+  spec.summary       = ' Kafka messaging made easy! '
   spec.description   = spec.summary
   spec.license       = 'MIT'
 
@@ -20,9 +22,12 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'connection_pool', '>= 0'
   spec.add_dependency 'null-logger'
   spec.add_dependency 'dry-configurable', '~> 0.6'
+
+  spec.add_development_dependency 'rspec', '~> 3.6.0'
+  spec.add_development_dependency 'simplecov', '~> 0.14.1'
   spec.required_ruby_version = '>= 2.2.0'
 
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(spec)/}) }
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.require_paths = %w( lib )
+  spec.require_paths = %w[lib]
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: waterdrop
 version: !ruby/object:Gem::Version
-  version: 0.3.2.3
+  version: 0.3.2.4
 platform: ruby
 authors:
 - Maciej Mensfeld
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-30 00:00:00.000000000 Z
+date: 2017-05-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -95,6 +95,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.6'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.6.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.6.0
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.14.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.14.1
 description: Kafka messaging made easy!
 email:
 - maciej@mensfeld.pl