waterdrop 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e75b417b4e1702a407c03a3b09b414c778d22192
-  data.tar.gz: 960675222c4c7e002e3cbfab0803c70d007b7145
+  metadata.gz: 0ba074f881bf7dae566b0f1c084d328913209b1e
+  data.tar.gz: da63b01f8a1ceeaf044fa1009e1ee4ba8db3c4bd
 SHA512:
-  metadata.gz: d1b90f0160aa014f312117a5d275fa3b1630b442693da25ccd807fe3f0f06e37a19ebb91f69ad0ee963370d6c08dca081de56f854f63880b3a9a8bd428cb690c
-  data.tar.gz: c0a933015c71f03b774243a16936dab5f0820578f5e00b1923b10c44dc294bc2e9413bc16b9c92d1cdd08b5e68d83aaf34ed7109315ff7bbfaf6302ecfa04bea
+  metadata.gz: 7bda18594a2321c809a2ffd0463a0dfcc3ee714ed60e36cb59ca15a94e007cca319e178baf03962b31cab56ecea603af7bebac9f2968320bb309bbb843fe8ce7
+  data.tar.gz: 6475608c7646f70561c74209961159621ba8c252aaecf552297564b9c2798ef9ddd41160e8eb60c3f526ed6d0bcc707c66947c9b95b25680450cd1f6db99e36f

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # WaterDrop changelog
 
+## 0.1.6
+- Added null-logger gem
+
 ## 0.1.5
 - raise_on_failure flag to ignore (if false) that message was not sent
 

data/Gemfile.lock

@@ -1,10 +1,11 @@
 PATH
   remote: .
   specs:
-    waterdrop (0.1.5)
+    waterdrop (0.1.6)
       aspector
       bundler
       connection_pool
+      null-logger
       poseidon
       rake
 
@@ -12,10 +13,10 @@ GEM
   remote: https://rubygems.org/
   specs:
     abstract_type (0.0.7)
-    activemodel (4.2.3)
-      activesupport (= 4.2.3)
+    activemodel (4.2.4)
+      activesupport (= 4.2.4)
       builder (~> 3.1)
-    activesupport (4.2.3)
+    activesupport (4.2.4)
       i18n (~> 0.7)
       json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
@@ -32,17 +33,18 @@ GEM
       descendants_tracker (~> 0.0.4)
       ice_nine (~> 0.11.0)
       thread_safe (~> 0.3, >= 0.3.1)
-    brakeman (3.0.5)
+    brakeman (3.1.0)
       erubis (~> 2.6)
       fastercsv (~> 1.5)
       haml (>= 3.0, < 5.0)
-      highline (~> 1.6.20)
+      highline (~> 1.6)
       multi_json (~> 1.2)
-      ruby2ruby (~> 2.1.1)
+      ruby2ruby (>= 2.1.1, < 2.3.0)
       ruby_parser (~> 3.7.0)
       sass (~> 3.0)
-      terminal-table (~> 1.4)
-    bson (3.2.1)
+      slim (>= 1.3.6, < 4.0)
+      terminal-table (~> 1.4.5)
+    bson (3.2.4)
     builder (3.2.2)
     coderay (1.1.0)
     coercible (1.0.0)
@@ -72,7 +74,7 @@ GEM
       haml (~> 4.0)
       rubocop (>= 0.25.0)
       sysexits (~> 1.1)
-    highline (1.6.21)
+    highline (1.7.3)
     i18n (0.7.0)
     ice_nine (0.11.1)
     json (1.8.3)
@@ -94,11 +96,12 @@ GEM
       connection_pool (~> 2.0)
       optionable (~> 0.2.0)
     multi_json (1.11.2)
+    null-logger (0.1.0)
     optionable (0.2.0)
     origin (2.1.1)
     parser (2.2.2.6)
       ast (>= 1.1, < 3.0)
-    polishgeeks-dev-tools (1.1.0)
+    polishgeeks-dev-tools (1.2.0)
       brakeman
       faker
       haml-lint
@@ -137,14 +140,14 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.3.0)
     rspec-support (3.3.0)
-    rubocop (0.33.0)
+    rubocop (0.34.0)
       astrolabe (~> 1.3)
       parser (>= 2.2.2.5, < 3.0)
       powerpack (~> 0.1)
       rainbow (>= 1.99.1, < 3.0)
       ruby-progressbar (~> 1.4)
     ruby-progressbar (1.7.5)
-    ruby2ruby (2.1.4)
+    ruby2ruby (2.2.0)
       ruby_parser (~> 3.1)
       sexp_processor (~> 4.0)
     ruby_parser (3.7.1)
@@ -156,7 +159,7 @@ GEM
       reek (= 1.6.3)
       ruby2ruby (>= 2.1.1, < 3.0)
       virtus (~> 1.0)
-    sass (3.4.17)
+    sass (3.4.18)
     sexp_processor (4.6.0)
     shoulda (3.5.0)
       shoulda-context (~> 1.0, >= 1.0.1)
@@ -169,9 +172,13 @@ GEM
       json (~> 1.8)
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.0)
+    slim (3.0.6)
+      temple (~> 0.7.3)
+      tilt (>= 1.3.3, < 2.1)
     slop (3.6.0)
     sysexits (1.2.0)
-    terminal-table (1.5.2)
+    temple (0.7.6)
+    terminal-table (1.4.5)
     thread_safe (0.3.5)
     tilt (2.0.1)
     timecop (0.8.0)

data/README.md

@@ -149,6 +149,25 @@ ClassName.new.run
 
 a message with the given message will be send before and after the method execution.
 
+## References
+
+* [Karafka framework](https://github.com/karafka/karafka)
+* [Waterdrop](https://github.com/karafka/waterdrop)
+* [Sidekiq Glass](https://github.com/karafka/sidekiq-glass)
+* [Envlogic](https://github.com/karafka/envlogic)
+* [Null Logger](https://github.com/karafka/null-logger)
+
 ## Note on Patches/Pull Requests
 
-Fork the project. Make your feature addition or bug fix. Add tests for it. This is important so I don't break it in a future version unintentionally. Commit, do not mess with Rakefile, version, or history. (if you want to have your own version, that is fine but bump version in a commit by itself I can ignore when I pull) Send me a pull request. Bonus points for topic branches.
+Fork the project.
+Make your feature addition or bug fix.
+Add tests for it. This is important so I don't break it in a future version unintentionally.
+Commit, do not mess with Rakefile, version, or history. (if you want to have your own version, that is fine but bump version in a commit by itself I can ignore when I pull). Send me a pull request. Bonus points for topic branches.
+
+Each pull request must pass our quality requirements. To check if everything is as it should be, we use [PolishGeeks Dev Tools](https://github.com/polishgeeks/polishgeeks-dev-tools) that combine multiple linters and code analyzers. Please run:
+
+```bash
+bundle exec rake
+```
+
+to check if everything is in order. After that you can submit a pull request.

data/lib/water_drop/message.rb

@@ -32,10 +32,13 @@ module WaterDrop
           Poseidon::MessageToSend.new(topic, message)
         ])
       end
+      ::WaterDrop.logger.info("Message #{message} was sent to topic '#{topic}'")
     rescue *CATCHED_ERRORS => e
       # Reraise if we want to raise on failure
       # Ignore if we dont want to know that something went wrong
-      raise(e) if ::WaterDrop.config.raise_on_failure?
+      return unless ::WaterDrop.config.raise_on_failure?
+      ::WaterDrop.logger.fatal(e)
+      raise(e)
     end
   end
 end

data/lib/water_drop/version.rb

@@ -1,5 +1,5 @@
 # WaterDrop library
 module WaterDrop
   # Current WaterDrop version
-  VERSION = '0.1.5'
+  VERSION = '0.1.6'
 end

data/lib/waterdrop.rb

@@ -10,6 +10,7 @@
   aspector
   forwardable
   connection_pool
+  null_logger
 ).each { |lib| require lib }
 
 # Internal components
@@ -19,7 +20,6 @@ base_path = File.dirname(__FILE__) + '/water_drop'
   version
   pool
   config
-  logger
   message
   aspects/base_aspect
   aspects/formatter
@@ -35,7 +35,7 @@ module WaterDrop
 
     # @return [Logger] logger that we want to use
     def logger
-      @logger ||= Logger.new
+      @logger ||= NullLogger.new
     end
 
     # Sets up the whole configuration

data/waterdrop.gemspec

@@ -19,6 +19,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'aspector', '>= 0'
   spec.add_dependency 'poseidon', '>= 0'
   spec.add_dependency 'connection_pool', '>= 0'
+  spec.add_dependency 'null-logger'
 
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(spec)/}) }
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: waterdrop
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Maciej Mensfeld
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-27 00:00:00.000000000 Z
+date: 2015-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -81,6 +81,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: null-logger
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Kafka messages with aspects made easy!
 email:
 - maciej@mensfeld.pl
@@ -105,7 +119,6 @@ files:
 - lib/water_drop/aspects/before_aspect.rb
 - lib/water_drop/aspects/formatter.rb
 - lib/water_drop/config.rb
-- lib/water_drop/logger.rb
 - lib/water_drop/message.rb
 - lib/water_drop/pool.rb
 - lib/water_drop/version.rb

data/lib/water_drop/logger.rb

@@ -1,10 +0,0 @@
-module WaterDrop
-  # Null logger for karafka
-  # Is used when logger is not defined
-  class Logger
-    # Returns nil for any method call
-    def method_missing(*_args, &_block)
-      nil
-    end
-  end
-end